[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f84f1b2e92: [CodeGen] Track DeferredDecls that have been emitted (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire created this revision. junaire added a reviewer: aaron.ballman. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the declaration of an identifier has block scope, and the identifier has externa

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 457171. junaire added a comment. Simpify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 457485. junaire added a comment. Update the existing diagnostic and its tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 457855. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSem

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 459287. junaire added a comment. Try to address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 459394. junaire added a comment. Rebase, adjust commit message and release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new field called EmittedDeferredDecls in CodeGenModule that keeps

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

junaire updated this revision to Diff 441667. junaire added a comment. - Rebase - turn clang-format off in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128782/new/ https://reviews.llvm.org/D128782 Files: clang/lib/CodeGen/CodeGenModule.cp

[PATCH] D128991: [NFC] Add a missing test for for clang-repl

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a missing test for 0ecbedc0986bd4b7b90a60a5f31d32337160d4c4

[PATCH] D128991: [NFC] Add a missing test for for clang-repl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2750985a5ccb: [NFC] Add a missing test for for clang-repl (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128991: [NFC] Add a missing test for for clang-repl

junaire added a comment. In D128991#3625194 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/61429/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for the heads up, I'll revert

[PATCH] D129042: Reland "[NFC] Add a missing test for for clang-repl"

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts 3668d1264e2d246f7e222338b8a5cab18ce1bdab

[PATCH] D129042: Reland "[NFC] Add a missing test for for clang-repl"

This revision was automatically updated to reflect the committed changes. Closed by commit rG8679cbc29fb7: Reland "[NFC] Add a missing test for for clang-repl" (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129042/new/ https://

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Windows has some issues when we try to use `__attribute__((weak))` in JIT, so we dis

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire updated this revision to Diff 442879. junaire added a comment. Correct copy paster error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250 Files: clang/test/Interpreter/execute-weak.cpp clang/te

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire updated this revision to Diff 442902. junaire added a comment. extern printf so we can use, another copy paster mistake... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250 Files: clang/test/Inter

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeee6a12227a6: [clang-repl][NFC] Split weak symbol test to a new test (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

junaire added a comment. gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128782/new/ https://reviews.llvm.org/D128782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D122657: [NFC] Use range based loop.

junaire created this revision. junaire added reviewers: v.g.vassilev, rsmith. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://re

[PATCH] D122657: [NFC] Use range based loop.

junaire updated this revision to Diff 418877. junaire added a comment. use const when possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122657/new/ https://reviews.llvm.org/D122657 Files: clang/lib/AST/ASTDiagnostic.cpp Index: clang/lib/

[PATCH] D122657: [NFC] Use range based loop.

junaire updated this revision to Diff 418882. junaire added a comment. Simplify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122657/new/ https://reviews.llvm.org/D122657 Files: clang/lib/AST/ASTDiagnostic.cpp Index: clang/l

[PATCH] D122657: [NFC] Use range based loop.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b38292d5d77: [NFC] Use range based loop. (authored by junaire).

[PATCH] D122871: Clang-Formatting

junaire added a comment. You are not supposed to format the test, because the comment is actually something we called regression tests. If you reformat it (put it in the wrong place), the test will fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire updated this revision to Diff 419965. junaire added a comment. - Rebase. - Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 Files: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire added a comment. Hi @aaron.ballman, do you think it's time to consider reviewing this? I don't why there's no response or progress in GCC, but I think I can submit a patch for them if they think this issue is low prior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire added inline comments. Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:10 + + void fn(int i, int j = ({{}, {}, {,}}), int k = ""); // expected-error {{expression statement not permitted in default argument}} expected-error {{cannot initialize a parameter o

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire updated this revision to Diff 420178. junaire retitled this revision from " [Clang][Sema] Prohibit expr statement in the default argument" to "[Clang][Sema] Prohibit expr statement in the default argument". junaire edited the summary of this revision. junaire added a comment. Add tests f

[PATCH] D119609: [Clang][Sema] Prohibit expr statement in the default argument

junaire updated this revision to Diff 420384. junaire added a comment. Wording issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D119609: [Clang][Sema] Prohibit statement expression in the default argument

junaire updated this revision to Diff 420664. junaire edited the summary of this revision. junaire added a comment. - Add release note. - re-wrap line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 File

[PATCH] D119609: [Clang][Sema] Prohibit statement expression in the default argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a4d388c7fa4: [Clang][Sema] Prohibit statement expression in the default argument (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609

[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we run into a first usage or definition of a mangled name, and there's a Deferred

[PATCH] D130827: [clang] Fixed a number of typos

junaire added a comment. Hi, I think the main issue is that your patch contains another patch unintentionally, please fix that :) Comment at: clang/CMakeLists.txt:513 -endif() - option(CLANG_ENABLE_ARCMT "Build ARCMT." ON) Why delete these lines? ==

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added a comment. In D130422#3689392 , @v.g.vassilev wrote: > Thanks for working on this. This is one of the problems where is hard to find > the right behavior. For example, if a repl running in interactive issues an > error and then successful

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 448844. junaire added a comment. Rebase and add a FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp clang/tools/clang-r

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 448846. junaire added a comment. Fix some typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp clang/tools/clang-repl/Clan

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added a comment. @v.g.vassilev if you can take another look at the wording of the FIXME, and make sure you're happy about it, that will be awesome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:138 - return checkDiagErrors(Interp->getCompilerInstance()); + llvm::llvm_shutdown(); + v.g.vassilev wrote: > This seems not needed. We have already `llvm::llvm_shutdown_obj Y;` >

[PATCH] D130827: [clang] Fixed a number of typos

junaire added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult &SrcExpr, bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining = QualType

[PATCH] D130422: [clang-repl] Fix incorrect return code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9caee577ef0f: [clang-repl] Fix incorrect return code (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D130422?vs=448846&id

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the downstream projects (ROOT and Cling), we want to do header files lookups but no `OpenFile` behavior as we only need t

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rG786b503f66b1: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior. (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

junaire added a comment. I wonder what's the difference between this patch and https://reviews.llvm.org/D124434 ? Also add some reviewers that get involved in the previous discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ http

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

junaire added inline comments. Comment at: clang/test/AST/ast-dump-openmp-begin-declare-variant_11.c:2 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -verify=c_mode -ast-dump %s | FileCheck %s --check-prefix=C -// RUN: %clang_cc1 -triple x86_64-unknown-unkno

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire updated this revision to Diff 413997. junaire added a comment. - Make sure Parser can diagnostic remaining error after the expr statement. - Prohibit expression statement in template argument - Add more tests - Better diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. I just realized that something is not very clear here. Should we prohibit expression statements in all default arguments or just in lambda and templates? I wonder how gcc folks think about it as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. In D119609#3369816 , @erichkeane wrote: > The commit message isn't quite accurate, we're prohibiting it in ALL default > arguments. Yeah, I just realize this issue after changing the message. >>> I just realized that something

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. Hi @aaron.ballman @erichkeane, I have already left a comment in GCC's Bugzilla, but unfortunately there's been no response for almost a week. I'm even not sure there's really a bug fix for GCC or not. Can you guys decide how to deal with this issue? Repository: rG L

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. In D119609#3385671 , @aaron.ballman wrote: > In D119609#3384568 , @junaire wrote: > >> Hi @aaron.ballman @erichkeane, I have already left a comment in GCC's >> Bugzilla, but unfortunatel

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire created this revision. junaire added reviewers: aaron.ballman, RKSimon, dblaikie. Herald added a subscriber: arphaman. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. BitstreamCursors are heavy-w

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire created this revision. junaire added reviewers: aaron.ballman, rsmith, erichkeane. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't warn on unknown type attributes in Parser::ProhibitCXX11At

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 421695. junaire added a comment. Add a missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/Par

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 421696. junaire added a comment. Update the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseD

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire added inline comments. Comment at: clang/lib/Serialization/GlobalModuleIndex.cpp:130 std::unique_ptr IndexBuffer, -llvm::BitstreamCursor Cursor) +llvm::BitstreamCursor &Cursor) : Buffer(std::move(IndexBuffer)), IdentifierIndex(), NumIdentifierLookups(),

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 421719. junaire added a comment. Rename an argument for consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h cla

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 422094. junaire added a comment. Run test in C2x mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/P

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 422096. junaire added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Pa

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire added a comment. In D123447#3442780 , @aaron.ballman wrote: > Thank you for the fix! Can you add a release note for it as well? > > LGTM aside from a minor nit with some comment wording and a testing > suggestion. Hey Aaron, thanks for your rev

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c2f821d71b: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling (authored by junaire). Changed prior to commit: https://revie

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire created this revision. junaire added reviewers: aaron.ballman, rsmith, erichkeane, dblaikie, rjmccall. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because lambda will create its own scope, so

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. Hi @erichkeane , thanks for accepting this! But do you think we need to add a release note about it? (I'm a totally beginner so sometimes I'm confused about when we should do it.) Also, Do you have any concerns about the wording? In fact, I am pretty embarrassed by the

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423079. junaire added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/IdentifierR

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. In D123840#3453903 , @erichkeane wrote: > Ah, right, we SHOULD have a release note, please add one and I'll help review > the wording. Commit message is fine for a commit message, particularly with > a good release note. Than

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. I also find the code below really awkward: S->getParent()->getFlags() & Scope::ControlScope I find that we have helpers like `Scope::isBlockScope()` `Scope::isisTryScope()` and etc, but no `Scope::isControlScope` and `Scope::isFnTryCatchScope` I will add these helpe

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423085. junaire added a comment. Fix bad wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/IdentifierReso

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/docs/ReleaseNotes.rst:122 This fixes Issue `Issue 54817 `_. +- No longer produce a wrong redefinition error if variables are defined i

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423086. junaire marked an inline comment as done. junaire added a comment. Update release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/Re

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe0905a333d6: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement (authored by junaire). Repository: rG LLVM Github Monorepo

[PATCH] D119103: [NFC][Analyzer] Use range based for loop.

junaire created this revision. junaire added reviewers: zaks.anna, dcoughlin. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. junaire requested review of this revision. Herald adde

[PATCH] D119103: [NFC][Analyzer] Use range based for loop.

junaire added a comment. In D119103#3300037 , @steakhal wrote: > Hmm, I guess you must take it by mutable reference since you push it to > `LocalTUDecls`. > Thanks for the patch. Do you have push permissions? Otherwise, send me your > `name ` to let me

[PATCH] D119103: [NFC][Analyzer] Use range based for loop.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65adf7c2117a: [NFC][Analyzer] Use range based for loop. (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119103/new/ https://reviews.llv

[PATCH] D119405: [Clang][Sema] Use C++ standard terminology in clang diagnostics.

junaire created this revision. junaire added reviewers: Quuxplusone, aaron.ballman. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang diagnostics should say "floating-point literal" instead of "floating-point constant" accordin

[PATCH] D119405: [Clang][Sema] Use C++ standard terminology in clang diagnostics.

junaire added a comment. In D119405#3310695 , @aaron.ballman wrote: > Thank you for the patch! > > I don't think this is an improvement; the diagnostic text goes from being > correct in C but odd in C++ to being correct in C++ but odd in C (the two > s

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire created this revision. junaire added a reviewer: aaron.ballman. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a missing test, covering the different kinds of floating-point literals, like hexadecimal floats

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire created this revision. junaire added reviewers: aaron.ballman, rsmith. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang will try to act on ReturnStmt when parsing the lambda declarator, which is not desirable. LambdaSco

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408129. junaire added a comment. Add tests for long double. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c Index: cla

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. > I think we should probably have test coverage for `long double` as well, but > I also wonder whether it makes sense to add coverage for the small > floating-point types (like `_Float16`) as well, or whether we already have > coverage for those elsewhere. Test long do

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408133. junaire added a comment. long double should use `L` as literal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408134. junaire added a comment. Add missing blank. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c Index: clang/test/

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408407. junaire added a comment. Add triple info to avoid tests failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. In D119528#3318913 , @aaron.ballman wrote: > In D119528#3316311 , @junaire wrote: > >>> I think we should probably have test coverage for `long double` as well, >>> but I also wonder whe

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

This revision was automatically updated to reflect the committed changes. Closed by commit rGeffd6dd63a65: [Clang][Sema] Add a missing regression test about Wliteral-range (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/ne

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. In D119528#3319955 , @aaron.ballman wrote: > LGTM, thank you for the additional test coverage! Do you need me to commit on > your behalf? If so, what name and email address would you like me to use for > patch attribution? Tha

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire created this revision. junaire added reviewers: aaron.ballman, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. junaire requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The ElaboratedType can have no qualifiers

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire added a comment. In D119949#3328254 , @cloudhan wrote: > As the original bug reporter, I don't think this is a proper fix for it. > There seems to be some kind of bug deep in the frontend. This just hide it > anyway. Yeah, maybe there's a deepe

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409510. junaire added a comment. - Only suppress canonical types when it's a TypedefNameType. - Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 Files:

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409511. junaire added a comment. Simplify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 Files: clang-tools-extra/clang-tidy/readability/Static

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire created this revision. junaire added reviewers: dblaikie, nikic, tstellar. Herald added a subscriber: mstorsjo. Herald added a project: All. junaire requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire updated this revision to Diff 425134. junaire added a comment. use std::move(). I'm not sure this will be better but hope it will make others happy :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D1234

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG218dcdad8a0c: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

junaire added a comment. In D123436#3475002 , @dblaikie wrote: > In D123436#3462567 , @dblaikie > wrote: > >> Perhaps GlobalModuleIndex should create the cursor itself - it's being >> handed the buffer anyway? >

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire planned changes to this revision. junaire added a comment. > In general, my concern with the this patch is that it loses test coverage by > specifying an explicit language mode. We typically prefer to fix the tests so > that they can work in any language mode (and perhaps add additional

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8082a0028638: [CodeGen] Keep track of decls that were deferred and have been emitted. (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D128782?vs=441667&id=444228#toc Repository

[PATCH] D130420: [CodeGen] Consider MangleCtx when move lazy emission States

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also move MangleCtx when moving some lazy emission states in CodeGenModule. Without

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch, clang-repl incorrectly pass some tests when there's error occure

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 447103. junaire added a comment. Use `not` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp clang/tools/clang-repl/ClangRepl

[PATCH] D130420: [CodeGen] Consider MangleCtx when move lazy emission States

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58c94808450d: [CodeGen] Consider MangleCtx when move lazy emission States (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire created this revision. junaire added reviewers: fhahn, aaron.ballman, scanon, craig.topper. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements one of the missing builtin functions specified in https://rev

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 390912. junaire added a comment. Reuse existing code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td cl

  1   2   3   4   >