r352003 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

2019-01-23 Thread Julian Lettner via cfe-commits
Author: yln Date: Wed Jan 23 17:06:19 2019 New Revision: 352003 URL: http://llvm.org/viewvc/llvm-project?rev=352003&view=rev Log: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls Summary: UBSan wants to detect when unreachable code is actually reached, so

r352069 - Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls"

2019-01-24 Thread Julian Lettner via cfe-commits
Author: yln Date: Thu Jan 24 10:04:21 2019 New Revision: 352069 URL: http://llvm.org/viewvc/llvm-project?rev=352069&view=rev Log: Revert "[Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls" This reverts commit cea84ab93aeb079a358ab1c8aeba6d9140ef8b47. Modi

r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

2019-01-30 Thread Julian Lettner via cfe-commits
Author: yln Date: Wed Jan 30 15:42:13 2019 New Revision: 352690 URL: http://llvm.org/viewvc/llvm-project?rev=352690&view=rev Log: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls Summary: UBSan wants to detect when unreachable code is actually reached, so

Re: r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

2019-01-31 Thread Julian Lettner via cfe-commits
via an assert in SCCP. I'll see what I can do about a testcase (or Eric will), however, would you mind reverting in the meantime?Thanks!-ericOn Wed, Jan 30, 2019 at 4:41 PM Julian Lettner via cfe-commits <cfe-commits@lists.llvm.org> wrote:Author: yln Date: Wed Jan 30 15:42:13 2019 N

r352829 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

2019-01-31 Thread Julian Lettner via cfe-commits
Author: yln Date: Thu Jan 31 18:51:00 2019 New Revision: 352829 URL: http://llvm.org/viewvc/llvm-project?rev=352829&view=rev Log: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls Summary: UBSan wants to detect when unreachable code is actually reached, so

r352948 - [ASan] Do not instrument other runtime functions with `__asan_handle_no_return`

2019-02-01 Thread Julian Lettner via cfe-commits
Author: yln Date: Fri Feb 1 18:05:16 2019 New Revision: 352948 URL: http://llvm.org/viewvc/llvm-project?rev=352948&view=rev Log: [ASan] Do not instrument other runtime functions with `__asan_handle_no_return` Summary: Currently, ASan inserts a call to `__asan_handle_no_return` before every `nore

r353120 - [Sanitizers] UBSan unreachable incompatible with Kernel ASan

2019-02-04 Thread Julian Lettner via cfe-commits
Author: yln Date: Mon Feb 4 15:37:50 2019 New Revision: 353120 URL: http://llvm.org/viewvc/llvm-project?rev=353120&view=rev Log: [Sanitizers] UBSan unreachable incompatible with Kernel ASan Summary: This is a follow up for https://reviews.llvm.org/D57278. The previous revision should have also i

[clang] 99d6e05 - [lit] Improve naming of test result categories

2020-06-05 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2020-06-05T08:14:42-07:00 New Revision: 99d6e05e7144a2638c4e85ea75099e9dc6432cde URL: https://github.com/llvm/llvm-project/commit/99d6e05e7144a2638c4e85ea75099e9dc6432cde DIFF: https://github.com/llvm/llvm-project/commit/99d6e05e7144a2638c4e85ea75099e9dc6432cde.diff

[clang] 2d66571 - [Driver] Fix & re-enable DriverKit test

2022-08-29 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-08-29T10:27:04-07:00 New Revision: 2d66571729a2ffcd88398a77508b0d6432ed7ba0 URL: https://github.com/llvm/llvm-project/commit/2d66571729a2ffcd88398a77508b0d6432ed7ba0 DIFF: https://github.com/llvm/llvm-project/commit/2d66571729a2ffcd88398a77508b0d6432ed7ba0.diff

[clang] ce6989f - Revert "[Driver] Fix & re-enable DriverKit test"

2022-08-29 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-08-29T11:59:01-07:00 New Revision: ce6989fd8a9fb2608f670de023fdd4611f47b811 URL: https://github.com/llvm/llvm-project/commit/ce6989fd8a9fb2608f670de023fdd4611f47b811 DIFF: https://github.com/llvm/llvm-project/commit/ce6989fd8a9fb2608f670de023fdd4611f47b811.diff

[clang] 79fe9aa - [Driver] Fix & re-enable DriverKit test

2022-08-29 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-08-29T15:05:22-07:00 New Revision: 79fe9aaf6a7b13e23492e900c7ff5b9659df5544 URL: https://github.com/llvm/llvm-project/commit/79fe9aaf6a7b13e23492e900c7ff5b9659df5544 DIFF: https://github.com/llvm/llvm-project/commit/79fe9aaf6a7b13e23492e900c7ff5b9659df5544.diff

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Julian Lettner via cfe-commits
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA, } } - // Add non-standard, platform-specific search paths, e.g., for DriverKit: - // -L/System/DriverKit/usr/lib - // -F/System/DriverKit/System/Library/Framework + // Add

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Julian Lettner via cfe-commits
https://github.com/yln edited https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Julian Lettner via cfe-commits
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA, } } - // Add non-standard, platform-specific search paths, e.g., for DriverKit: - // -L/System/DriverKit/usr/lib - // -F/System/DriverKit/System/Library/Framework + // Add

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2023-12-18 Thread Julian Lettner via cfe-commits
https://github.com/yln approved this pull request. https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 64902d3 - Reland "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO"

2022-03-23 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-03-23T18:36:55-07:00 New Revision: 64902d335c2126e24a9d84b7410924148959e4a9 URL: https://github.com/llvm/llvm-project/commit/64902d335c2126e24a9d84b7410924148959e4a9 DIFF: https://github.com/llvm/llvm-project/commit/64902d335c2126e24a9d84b7410924148959e4a9.diff

[clang] 46626bc - [NFC] Improve comment and rename test file

2022-03-11 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-03-11T14:47:54-08:00 New Revision: 46626bc87382cad7a0c5ba497b3454337c45faa8 URL: https://github.com/llvm/llvm-project/commit/46626bc87382cad7a0c5ba497b3454337c45faa8 DIFF: https://github.com/llvm/llvm-project/commit/46626bc87382cad7a0c5ba497b3454337c45faa8.diff

[clang] 9c542a5 - Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

2022-03-14 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-03-14T17:51:18-07:00 New Revision: 9c542a5a4e1ba36c24e48185712779df52b7f7a6 URL: https://github.com/llvm/llvm-project/commit/9c542a5a4e1ba36c24e48185712779df52b7f7a6 DIFF: https://github.com/llvm/llvm-project/commit/9c542a5a4e1ba36c24e48185712779df52b7f7a6.diff

[clang] 22570ba - Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

2022-03-17 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-03-17T10:47:13-07:00 New Revision: 22570bac694396514fff18dec926558951643fa6 URL: https://github.com/llvm/llvm-project/commit/22570bac694396514fff18dec926558951643fa6 DIFF: https://github.com/llvm/llvm-project/commit/22570bac694396514fff18dec926558951643fa6.diff

[clang] [compiler-rt] [llvm] Get the linker version and pass the it to compiler-rt tests on Darwin. (PR #86220)

2024-03-22 Thread Julian Lettner via cfe-commits
https://github.com/yln edited https://github.com/llvm/llvm-project/pull/86220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Get the linker version and pass the it to compiler-rt tests on Darwin. (PR #86220)

2024-03-22 Thread Julian Lettner via cfe-commits
@@ -346,20 +347,7 @@ endif () # Determine HOST_LINK_VERSION on Darwin. set(HOST_LINK_VERSION) if (APPLE AND NOT CMAKE_LINKER MATCHES ".*lld.*") - set(LD_V_OUTPUT) - execute_process( -COMMAND sh -c "${CMAKE_LINKER} -v 2>&1 | head -1" -RESULT_VARIABLE HAD_ERROR -OUT

[clang] [compiler-rt] [llvm] Get the linker version and pass the it to compiler-rt tests on Darwin. (PR #86220)

2024-03-22 Thread Julian Lettner via cfe-commits
@@ -444,6 +445,15 @@ else() set(SANITIZER_USE_SYMBOLS FALSE) endif() +# Get the linker version while configuring compiler-rt and explicitly pass it +# in cflags during testing. This fixes the compiler/linker version mismatch +# issue when running a clang built with a newer X

[clang] [compiler-rt] [llvm] Get the linker version and pass the it to compiler-rt tests on Darwin. (PR #86220)

2024-03-22 Thread Julian Lettner via cfe-commits
@@ -51,6 +51,7 @@ set_default("expensive_checks", @LLVM_ENABLE_EXPENSIVE_CHECKS_PYBOOL@) set_default("test_standalone_build_libs", @COMPILER_RT_TEST_STANDALONE_BUILD_LIBS_PYBOOL@) set_default("has_compiler_rt_libatomic", @COMPILER_RT_BUILD_STANDALONE_LIBATOMIC_PYBOOL@) set_d

[clang] [compiler-rt] [llvm] Get the linker version and pass the it to compiler-rt tests on Darwin. (PR #86220)

2024-03-22 Thread Julian Lettner via cfe-commits
@@ -15,6 +15,7 @@ endif() # Must go below project(..) include(GNUInstallDirs) +include(GetDarwinLinkerVersion) yln wrote: Thanks for extracting this into a separate file! 👍 https://github.com/llvm/llvm-project/pull/86220

[clang] [compiler-rt] [llvm] Get the linker version and pass the it to compiler-rt tests on Darwin. (PR #86220)

2024-03-22 Thread Julian Lettner via cfe-commits
https://github.com/yln approved this pull request. Thanks, approved with a few nits! https://github.com/llvm/llvm-project/pull/86220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 478eb98 - [Docs] Remove outdated OS limitation

2020-09-01 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2020-09-01T14:44:17-07:00 New Revision: 478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3 URL: https://github.com/llvm/llvm-project/commit/478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3 DIFF: https://github.com/llvm/llvm-project/commit/478eb98cd25cb0ebc01fc2c3889ae94d3f1797d3.diff

[clang] dc32ed8 - [Clang][Driver] Refine/refactor DriverKit support

2022-08-26 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-08-26T16:06:24-07:00 New Revision: dc32ed8a8e226db3677abb19eda62cfe80572aed URL: https://github.com/llvm/llvm-project/commit/dc32ed8a8e226db3677abb19eda62cfe80572aed DIFF: https://github.com/llvm/llvm-project/commit/dc32ed8a8e226db3677abb19eda62cfe80572aed.diff

[clang] 5284cf0 - [Clang][Driver] Temporarily disable failing DriverKit test

2022-08-26 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2022-08-26T18:32:51-07:00 New Revision: 5284cf0098c150137983d9e6326fc1ac014428a6 URL: https://github.com/llvm/llvm-project/commit/5284cf0098c150137983d9e6326fc1ac014428a6 DIFF: https://github.com/llvm/llvm-project/commit/5284cf0098c150137983d9e6326fc1ac014428a6.diff

[clang] e6a789e - Remove -lower-global-dtors-via-cxa-atexit flag

2023-03-14 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2023-03-14T14:18:11-07:00 New Revision: e6a789ef9bb28222c91816a2cf00cfd6f706efd4 URL: https://github.com/llvm/llvm-project/commit/e6a789ef9bb28222c91816a2cf00cfd6f706efd4 DIFF: https://github.com/llvm/llvm-project/commit/e6a789ef9bb28222c91816a2cf00cfd6f706efd4.diff

[clang] c3f0153 - [MachO] Disable atexit()-based lowering when LTO'ing kernel/kext code

2023-04-25 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2023-04-25T12:13:40-07:00 New Revision: c3f0153ec27a5e2cff97179d319ab99651c4c539 URL: https://github.com/llvm/llvm-project/commit/c3f0153ec27a5e2cff97179d319ab99651c4c539 DIFF: https://github.com/llvm/llvm-project/commit/c3f0153ec27a5e2cff97179d319ab99651c4c539.diff

[clang] [llvm] [SanitizerCoverage] Add an option to gate the invocation of the tracing callbacks (PR #108328)

2024-10-07 Thread Julian Lettner via cfe-commits
https://github.com/yln approved this pull request. LGTM, looks harmless enough. Please ping again for review and wait a few more days before merging to give other reviewers another chance to chime in. In the follow-up PR that expands support for this to trace-cmp, does it make sense to docume