jbangert updated this revision to Diff 84001.
jbangert updated the summary for this revision.
jbangert added a comment.
- Add header to unit test fixture.
https://reviews.llvm.org/D26015
Files:
clang-tidy/utils/IncludeSorter.cpp
unittests/clang-tidy/IncludeInserterTest.cpp
Index: unittests
jbangert updated this revision to Diff 94282.
jbangert added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into replace_template
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/Ref
jbangert accepted this revision.
jbangert marked 2 inline comments as done.
jbangert added inline comments.
Comment at: unittests/Tooling/RefactoringCallbacksTest.cpp:101
+ std::string Expected = "void f() { FOO }";
+ ReplaceNodeWithTemplate Callback("id", "FOO");
+ expectRewr
jbangert updated this revision to Diff 94297.
jbangert added a comment.
Fix command line tool.
https://reviews.llvm.org/D29622
Files:
clang-query/CMakeLists.txt
clang-query/QueryReplace.cpp
clang-query/QueryReplace.h
clang-query/replace-tool/CMakeLists.txt
clang-query/replace-tool/Cla
jbangert created this revision.
Herald added a subscriber: mgorny.
This requires https://reviews.llvm.org/D29613. It adds a new tool,
clang-query-replace that replaces and AST node with the result of evaluating a
simple template language.
https://reviews.llvm.org/D29622
Files:
clang-query/C
jbangert created this revision.
This is the first change as part of developing a clang-query based search and
replace tool.
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.
jbangert updated this revision to Diff 87574.
jbangert added a comment.
Address code feedback & Reformat with clang-format --style llvm.
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCa
jbangert updated this revision to Diff 87575.
jbangert added a comment.
- change to push_back
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.cpp
Index: unittests/Tooling/R
jbangert marked 2 inline comments as done.
jbangert added a comment.
(marking other comments as done).
https://reviews.llvm.org/D29621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbangert marked 5 inline comments as done.
jbangert added a comment.
Thank you for the initial feedback!
Comment at: include/clang/Tooling/RefactoringCallbacks.h:61
+MatchFinder.addMatcher(Matcher, Callback);
+Callbacks.emplace_back(Callback);
+ }
sben
jbangert updated this revision to Diff 87579.
jbangert added a comment.
- use iter
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.cpp
Index: unittests/Tooling/RefactoringC
jbangert updated this revision to Diff 87580.
jbangert marked 7 inline comments as done.
jbangert added a comment.
Response to initial code review.
https://reviews.llvm.org/D29622
Files:
clang-query/CMakeLists.txt
clang-query/QueryReplace.cpp
clang-query/QueryReplace.h
clang-query/repla
jbangert added a comment.
Thank you for the feedback, addressed and reformatted using llvm style.
Comment at: clang-query/QueryReplace.h:35-36
+
+ /// \brief Replacement text. %"identifier" will be substituted by the text of
+ /// an identifier.
+ std::string ToTemplate;
---
jbangert marked 2 inline comments as done.
jbangert added a comment.
Fixed the test -- I am still getting used to the different ninja test targets.
Comment at: lib/Tooling/RefactoringCallbacks.cpp:160
+llvm::Expected>
+ReplaceNodeWithTemplate::create(StringRef FromId, StringRef
jbangert updated this revision to Diff 87879.
jbangert added a comment.
- fix test
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.cpp
Index: unittests/Tooling/RefactoringC
jbangert updated this revision to Diff 89420.
jbangert marked an inline comment as done.
jbangert added a comment.
- additional tests
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallb
jbangert accepted this revision.
jbangert added a comment.
Thanks, added tests for parser failures.
https://reviews.llvm.org/D29621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbangert updated this revision to Diff 89730.
jbangert marked an inline comment as done.
jbangert added a comment.
use llvm::report_fatal_error instead of unreachable.
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
jbangert added inline comments.
Comment at: lib/Tooling/RefactoringCallbacks.cpp:213
+llvm::errs() << "Node " << Element.Value
+ << " used in replacement template not bound in Matcher
\n";
+llvm_unreachable("Unbound node in replacement templat
jbangert updated this revision to Diff 98203.
jbangert added a comment.
Ran check-clang
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.cpp
Index: unittests/Tooling/Refacto
20 matches
Mail list logo
