https://github.com/ributzka approved this pull request.
https://github.com/llvm/llvm-project/pull/78353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ributzka wrote:
@jansvoboda11 gentle ping
https://github.com/llvm/llvm-project/pull/75530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ributzka created
https://github.com/llvm/llvm-project/pull/78816
`OptimizationLevel` and `OptimizeSize` can affect the generated AST. They
indirectly affect the `Optimize` and `OptimizeSize` frontend options, which in
turn set predefined macro definitions.
This fixes rdar://1
https://github.com/ributzka updated
https://github.com/llvm/llvm-project/pull/78816
>From ba6eac97038a8fbd24d288ffa88a4dcf508e66b8 Mon Sep 17 00:00:00 2001
From: Juergen Ributzka
Date: Fri, 19 Jan 2024 16:10:03 -0800
Subject: [PATCH 1/2] [clang][modules] Fix CodeGen options that can affect the
ributzka wrote:
> LGTM, although are we sure none of the other options should be affecting? I
> just did a quick search and it seems like this is it.
>
> I don't think it matters here, but the actual option that controls the macro
> is on `LangOptions` and where it's set has a "FIXME: Eliminat
https://github.com/ributzka updated
https://github.com/llvm/llvm-project/pull/78816
>From 968941561e08424ecb4fb15615ee46fe8356405e Mon Sep 17 00:00:00 2001
From: Juergen Ributzka
Date: Fri, 19 Jan 2024 16:10:03 -0800
Subject: [PATCH 1/2] [clang][modules] Fix CodeGen options that can affect the
https://github.com/ributzka updated
https://github.com/llvm/llvm-project/pull/69262
>From d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 Mon Sep 17 00:00:00 2001
From: Juergen Ributzka
Date: Mon, 28 Aug 2023 15:25:48 -0700
Subject: [PATCH 1/3] [llvm] Use XMACROS for MachO platforms.
This change adds
ributzka wrote:
Unrelated build issue on windows:
C:\ws\src\mlir\include\mlir/IR/BuiltinTypeInterfaces.h(14): fatal error C1083:
Cannot open include file: 'mlir/IR/BuiltinTypeInterfaces.h.inc': No such file
or directory
https://github.com/llvm/llvm-project/pull/69262
__
https://github.com/ributzka updated
https://github.com/llvm/llvm-project/pull/69262
>From ceaf58ba2f752b8a5353568013ff18603b0e615b Mon Sep 17 00:00:00 2001
From: Juergen Ributzka
Date: Mon, 28 Aug 2023 15:25:48 -0700
Subject: [PATCH] [llvm] Use XMACROS for MachO platforms.
This change adds the
ributzka wrote:
Thanks for the reviews. Checks are good now too after rebase.
https://github.com/llvm/llvm-project/pull/69262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ributzka closed
https://github.com/llvm/llvm-project/pull/69262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This seems to cause UBSAN issues:
runtime error: load of value 4294967295, which is not a valid value for
type 'clang::LVComputationKind'
See ASAN+UBSAN bot on Green Dragon:
http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/4065/console
On Tue, Aug 8, 2017 at 9:02 PM, George Burg
https://github.com/ributzka created
https://github.com/llvm/llvm-project/pull/69262
This change adds the PLATFORM XMACRO to simplify the addition of new MachO
platforms and reduce the number of required changes. Many of the changes needed
for adding a new platform are mechanical, such as adding
https://github.com/ributzka updated
https://github.com/llvm/llvm-project/pull/69262
>From d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 Mon Sep 17 00:00:00 2001
From: Juergen Ributzka
Date: Mon, 28 Aug 2023 15:25:48 -0700
Subject: [PATCH 1/2] [llvm] Use XMACROS for MachO platforms.
This change adds
Author: Juergen Ributzka
Date: 2023-03-16T15:31:17-07:00
New Revision: 29e2a4eff8f62d12754f31f90d70e9a346bc2075
URL:
https://github.com/llvm/llvm-project/commit/29e2a4eff8f62d12754f31f90d70e9a346bc2075
DIFF:
https://github.com/llvm/llvm-project/commit/29e2a4eff8f62d12754f31f90d70e9a346bc2075.di
Author: ributzka
Date: Tue Mar 14 12:46:26 2017
New Revision: 297759
URL: http://llvm.org/viewvc/llvm-project?rev=297759&view=rev
Log:
Add more debugging code for the SystemZ bot.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/Basic/VirtualFileSys
Author: ributzka
Date: Tue Mar 28 19:24:32 2017
New Revision: 298965
URL: http://llvm.org/viewvc/llvm-project?rev=298965&view=rev
Log:
Revert "clangToolingRefactor: Add libdeps upon clangFormat in r298913."
Modified:
cfe/trunk/lib/Tooling/Refactoring/CMakeLists.txt
Modified: cfe/trunk/lib/To
Author: ributzka
Date: Tue Mar 28 19:24:34 2017
New Revision: 298966
URL: http://llvm.org/viewvc/llvm-project?rev=298966&view=rev
Log:
Revert "Try to unbreak buildbots after r298913."
Modified:
cfe/trunk/unittests/Tooling/RefactoringTest.cpp
Modified: cfe/trunk/unittests/Tooling/RefactoringT
Author: ributzka
Date: Tue Mar 28 19:24:36 2017
New Revision: 298967
URL: http://llvm.org/viewvc/llvm-project?rev=298967&view=rev
Log:
Revert "Added `applyAtomicChanges` function."
This broke GreenDragon:
http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA_build/4776/
Reverting this
I reverted the commit in r298967. Please fix the cyclic dependency issue
found here:
http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA_build/4776/
Cheers,
Juergen
On Tue, Mar 28, 2017 at 6:05 AM, Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date
[+ Adrian]
Adrian knows more about the bot setup.
On Wed, Mar 29, 2017 at 8:04 AM, Eric Liu wrote:
> Hi Juergen, thanks for taking care of this, but I'm wondering if this
> build bot is using a different set of build rules? The error message says
> "Clang_Tooling
> -> Clang_Format -> Clang_Too
Author: ributzka
Date: Fri Mar 10 15:23:29 2017
New Revision: 297511
URL: http://llvm.org/viewvc/llvm-project?rev=297511&view=rev
Log:
[VFS] Remove the Path variable from RealFSDirIter. NFC.
This variable is set, but never used.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified:
Author: ributzka
Date: Fri Mar 10 15:23:27 2017
New Revision: 297510
URL: http://llvm.org/viewvc/llvm-project?rev=297510&view=rev
Log:
[VFS] Ignore broken symlinks in the directory iterator.
The VFS directory iterator and recursive directory iterator behave differently
from the LLVM counterparts.
Author: ributzka
Date: Fri Mar 10 15:46:51 2017
New Revision: 297517
URL: http://llvm.org/viewvc/llvm-project?rev=297517&view=rev
Log:
Revert r297510 "[VFS] Ignore broken symlinks in the directory iterator."
The tests are failing on one of the bots.
Modified:
cfe/trunk/include/clang/Basic/Vi
Author: ributzka
Date: Fri Mar 10 16:49:04 2017
New Revision: 297528
URL: http://llvm.org/viewvc/llvm-project?rev=297528&view=rev
Log:
Reapply [VFS] Ignore broken symlinks in the directory iterator.
Modified the tests to accept any iteration order.
The VFS directory iterator and recursive direct
Author: ributzka
Date: Fri Mar 10 18:01:24 2017
New Revision: 297531
URL: http://llvm.org/viewvc/llvm-project?rev=297531&view=rev
Log:
Adding debug output to investigate systemz bot issue.
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/Basic/Virtu
Author: ributzka
Date: Fri Mar 10 18:14:50 2017
New Revision: 297533
URL: http://llvm.org/viewvc/llvm-project?rev=297533&view=rev
Log:
Revert "Reapply [VFS] Ignore broken symlinks in the directory iterator."
Still broken on Windows and SystemZ bot ... sorry for the noise.
Modified:
cfe/trunk
Author: ributzka
Date: Mon Mar 13 19:14:40 2017
New Revision: 297693
URL: http://llvm.org/viewvc/llvm-project?rev=297693&view=rev
Log:
Reapply [VFS] Ignore broken symlinks in the directory iterator.
Modified the tests to accept any iteration order, to run only on Unix, and added
additional error
Hi Richard,
I think this broke modules.
If I try to compile a simple test program (@import Foundation;) I get the
following error:
./bin/clang test.m -fmodules -c -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk
While building module 'F
Author: ributzka
Date: Fri Nov 13 13:08:07 2015
New Revision: 253060
URL: http://llvm.org/viewvc/llvm-project?rev=253060&view=rev
Log:
Fix auto-link for text-based dynamic library SDKs.
When linking against text-based dynamic library SDKs the library name of a
framework has now more than one poss
@@ -0,0 +1,53 @@
+//===- InstallAPI/FileList.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,53 @@
+//===- InstallAPI/FileList.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ributzka approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/81701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -57,6 +58,57 @@ class AvailabilitySpec {
bool isOtherPlatformSpec() const { return Version.empty(); }
};
+class Decl;
+
+/// Storage of availability attributes for a declaration.
+struct AvailabilityInfo {
+ /// The domain is the platform for which this availability info
https://github.com/ributzka approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/81897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -35,19 +36,19 @@ struct InstallAPIContext {
/// Active target triple to parse.
llvm::Triple TargetTriple{};
- /// Output stream to write TextAPI file to.
- std::unique_ptr OS = nullptr;
-
- /// DiagnosticsEngine to report errors.
- llvm::IntrusiveRefCntPtr Diags = n
@@ -0,0 +1,125 @@
+#include "Options.h"
ributzka wrote:
The license header is missing.
https://github.com/llvm/llvm-project/pull/82293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -0,0 +1,106 @@
+#include "Options.h"
ributzka wrote:
Please add the license/file header.
https://github.com/llvm/llvm-project/pull/82293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/ributzka approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/82293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -24,8 +27,23 @@ struct InstallAPIContext {
/// Library attributes that are typically passed as linker inputs.
llvm::MachO::RecordsSlice::BinaryAttrs BA;
- /// Active target triple to parse.
- llvm::Triple TargetTriple{};
+ /// All headers that represent library.
@@ -24,8 +27,23 @@ struct InstallAPIContext {
/// Library attributes that are typically passed as linker inputs.
llvm::MachO::RecordsSlice::BinaryAttrs BA;
- /// Active target triple to parse.
- llvm::Triple TargetTriple{};
+ /// All headers that represent library.
+ H
@@ -588,13 +622,58 @@ void DylibVerifier::visitSymbolInDylib(const Record &R,
SymbolContext &SymCtx) {
}
}
+ const bool IsLinkerSymbol = SymbolName.starts_with("$ld$");
+
+ if (R.isVerified()) {
+// Check for unavailable symbols.
+// This should only occur in
@@ -588,13 +622,58 @@ void DylibVerifier::visitSymbolInDylib(const Record &R,
SymbolContext &SymCtx) {
}
}
+ const bool IsLinkerSymbol = SymbolName.starts_with("$ld$");
+
+ if (R.isVerified()) {
+// Check for unavailable symbols.
+// This should only occur in
https://github.com/ributzka approved this pull request.
https://github.com/llvm/llvm-project/pull/88205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ributzka approved this pull request.
https://github.com/llvm/llvm-project/pull/88432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -97,6 +97,14 @@ class HeaderFile {
Other.Excluded, Other.Extra,
Other.Umbrella);
}
+
+ bool operator<(const HeaderFile &Other) const {
ributzka wrote:
Including the umbre
@@ -973,5 +978,24 @@ bool DylibVerifier::verifyBinaryAttrs(const
ArrayRef ProvidedTargets,
return true;
}
+std::unique_ptr DylibVerifier::getExports() {
+ for (const auto &[Alias, Base] : Aliases) {
ributzka wrote:
This loop runs every time someone calls
@@ -107,6 +107,9 @@ struct LinkerOptions {
/// \brief Additional library search paths.
PathSeq LibPaths;
+ /// \brief List of aliased symbol exports.
ributzka wrote:
```suggestion
/// \brief List of alias symbol files.
```
https://github.com/llvm/llvm
@@ -973,5 +978,24 @@ bool DylibVerifier::verifyBinaryAttrs(const
ArrayRef ProvidedTargets,
return true;
}
+std::unique_ptr DylibVerifier::getExports() {
+ for (const auto &[Alias, Base] : Aliases) {
ributzka wrote:
In that case I would update the function
@@ -255,16 +255,21 @@ static void stubifyDirectory(const StringRef InputPath,
Context &Ctx) {
if (EC)
reportError(IT->path() + ": " + EC.message());
-// Skip header directories (include/Headers/PrivateHeaders) and module
ributzka wrote:
How is
@@ -347,6 +347,7 @@ void InitHeaderSearch::AddDefaultIncludePaths(
} else {
AddPath("/System/Library/Frameworks", System, true);
AddPath("/Library/Frameworks", System, true);
+AddPath("/System/Library/SubFrameworks", System, true);
@@ -347,6 +347,7 @@ void InitHeaderSearch::AddDefaultIncludePaths(
} else {
AddPath("/System/Library/Frameworks", System, true);
AddPath("/Library/Frameworks", System, true);
+AddPath("/System/Library/SubFrameworks", System, true);
https://github.com/ributzka approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/115048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 153 of 153 matches
Mail list logo
