[clang] [libc] [libc] Remove atomic alignment diagnostics globally (PR #96803)

2024-06-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96803 >From 66b82f970e8914a920259dd12decd65fbb325356 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 26 Jun 2024 12:58:22 -0500 Subject: [PATCH] [libc] Remove atomic alignment diagnostics globally Summary: Thes

[clang] [libc] [libc] Remove atomic alignment diagnostics globally (PR #96803)

2024-06-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU][OpenMP] Do not attach -fcuda-is-device flag for AMDGPU OpenMP (PR #96909)

2024-06-27 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. We don't even pass this in the NVPTX offloading case, so there's no reason to do it for AMDGPU. https://github.com/llvm/llvm-project/pull/96909 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink' (PR #96561)

2024-06-27 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96561 >From 849c8dab14c9332081a8c6331c9ca0c234793393 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Jun 2024 15:14:52 -0500 Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink'

[clang] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink' (PR #96561)

2024-06-27 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Re-did it and tested it against `libc` in https://github.com/llvm/llvm-project/pull/96972 so it will have a CI running it one that lands. it works for other cases I've tested, but let me know if something else should be added. https://github.com/llvm/llvm-project/pull/96561 __

[clang] [CUDA][NFC] CudaArch to OffloadArch rename (PR #97028)

2024-06-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. This is definitely overdue, thanks. https://github.com/llvm/llvm-project/pull/97028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] [openmp] [OpenMP][offload] Fix dynamic schedule tracking (PR #97065)

2024-06-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: Could you provide a more descriptive summary? I thought we discussed that the dynamic support would just use the static scheduler, but this seems to implement it? I personally don't want to see more things in the OpenMP runtime relying on `malloc` if we ca

[clang] [llvm] [openmp] [OpenMP][offload] Fix dynamic schedule tracking (PR #97065)

2024-06-28 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Malloc cannot be helped here if we want to have correctness. Currently it is > just broken and not even runnable. I figured that all this code would go away if we just made all schedules static. https://github.com/llvm/llvm-project/pull/97065 __

[clang-tools-extra] Revert: [clangd] Replace an include with a forward declaration (PR #97082)

2024-06-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Seems reasonable as I believe there were extra uses that needed the size. https://github.com/llvm/llvm-project/pull/97082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 0f723eb - [Clang] Add locale variants to libc offload wrappers

2024-09-16 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-09-16T09:57:47-05:00 New Revision: 0f723eb67197421caf6504a7e4594751040b1924 URL: https://github.com/llvm/llvm-project/commit/0f723eb67197421caf6504a7e4594751040b1924 DIFF: https://github.com/llvm/llvm-project/commit/0f723eb67197421caf6504a7e4594751040b1924.diff

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-13 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > @petrhosek Can someone explain why the clang executable in these tests is > > called `llvm` on the Fuchsia bots? > > We enable the > [`LLVM_TOOL_LLVM_DRIVER_BUILD`](https://github.com/llvm/llvm-project/blob/48deb3568eb2452ff385b04b8f71c34121f47387/clang/cmake/caches/Fuchsia-

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-12 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/112041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6a6af02 - [Clang] Remove unused TC variable

2024-10-12 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-10-12T07:09:03-05:00 New Revision: 6a6af0246bd2d68291582e9aefc0543e5c6102fe URL: https://github.com/llvm/llvm-project/commit/6a6af0246bd2d68291582e9aefc0543e5c6102fe DIFF: https://github.com/llvm/llvm-project/commit/6a6af0246bd2d68291582e9aefc0543e5c6102fe.diff

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-12 Thread Joseph Huber via cfe-commits
jhuber6 wrote: @petrhosek Can someone explain why the clang executable in these tests is called `llvm` on the Fuchsia bots? https://github.com/llvm/llvm-project/pull/112041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: First pass, I like the approach overall. https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -95,7 +95,19 @@ void SPIRV::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("-o"); CmdArgs.push_back(Output.getFilename()); + // Use of --sycl-link will call the clang-sycl-link-wrapper instead of + // the default linker (spirv-link). + i

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -466,7 +467,7 @@ void HIP::constructGenerateObjFileFromHIPFatBinary( "-o", Output.getFilename(), "-x", "assembler", ObjinFile, "-c"}; - const char *Clang = Args.MakeArgString(C.getDriver().ClangE

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/112249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Suport LLVM Driver (PR #112249)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Thanks for fixing this, didn't even know the `getPrependArg` was something we supported. Sorry for the extra work. https://github.com/llvm/llvm-project/pull/112249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -6728,7 +6728,10 @@ def fsycl : Flag<["-"], "fsycl">, def fno_sycl : Flag<["-"], "fno-sycl">, Visibility<[ClangOption, CLOption]>, Group, HelpText<"Disables SYCL kernels compilation for device">; - +def sycl_link : Flag<["--"], "sycl-link">, Flags<[HelpHidden]>,

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,528 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Why do we need these? We can create empty bitcode files inside the tests using `clang`. (Also I'm wondering if there's an existing empty bitcode file). https://github.com/llvm/llvm-project/pull/112245

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -95,7 +95,19 @@ void SPIRV::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("-o"); CmdArgs.push_back(Output.getFilename()); + // Use of --sycl-link will call the clang-sycl-link-wrapper instead of + // the default linker (spirv-link). + i

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,528 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,530 @@ +//=-- clang-sycl-link-wrapper/ClangSYCLLinkWrapper.cpp - SYCL linker util --=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
@@ -721,7 +721,9 @@ class Qualifiers { // to implicitly cast into the default address space. (A == LangAS::Default && (B == LangAS::cuda_constant || B == LangAS::cuda_device || - B == LangAS::cuda_shared)); + B == LangAS

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > So overall I'm leaning against doing it as is; guarding it under some flavour > of `allow-relaxed-address-space-handling` or something that sounds better but > is still noisy enough to make it clear there's danger seems preferable, at > least to me. A language option is reaso

[clang] [LinkerWrapper] Extract device archives if symbol is used on the host (PR #111921)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/112248 Summary: Currently, we want to use the OpenCL attributes to indicate the address space. Languages like SYCL, OpenMP, HIP, and CUDA allow their address space qualifiers to be implicitly converted to generic, as do

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I think the default AS is expected to be losslessly converted to other AS but > not the other way around, though I understand it is not clearly stated in > LangRef or other places and a lot of code just assumes it can. All the other language address spaces (cuda, OpenMP, sycl)

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Testing like that is fine, it's just that you can do `clang_cc1 -emit-llvm %s -o %t.bc` or something. https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-15 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > They should not "just work" if you're compiling for vanilla C/C++ (so not > > CUDA C++, or SYCL, or OpenCL C/C++ etc.) because neither of those defines > > such a notion. > > [a6a237f](https://github.com/llvm/llvm-project/commit/a6a237f2046ad8993db30481c8b61aeb2f73a5ad) > a

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Running into an observable situation where this is a concern means that > either you've messed around with (non C/C++) attributes, or are linking in > something exciting. Neither of which constitutes valid C/C++, and I'm leaning > towards saying shouldn't be allowed to silentl

[clang] [Clang][SYCL] Introduce clang-sycl-link-wrapper to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-15 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,82 @@ +=== +Clang SYCL Linker +=== + +.. contents:: + :local: + +.. _clang-sycl-linker: + +Introduction + + +This tool works as a wrapper around the SYCL device code linking process. +The purpose of this tool is to p

[clang] [Cuda] Handle -fcuda-short-ptr even with -nocudalib (PR #111682)

2024-10-09 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I'm not sure why we would ever want the current default if this is an option. > I'm trying to see it, but I can't work out a case where a 64bit pointer would > make sense, since the even tens-of-thousands of money supercomputer cards > have less than 256KiB of addressable shar

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/111712 Summary: We don't need a custom flag for this, LLVM had a way to get the features which are forwarded via `plugin-opt`. >From 6135a70a45801783a770252e765773905f18313d Mon Sep 17 00:00:00 2001 From: Joseph Huber

[clang] [Clang][OpenMP] Do not use feature option during packaging (PR #111702)

2024-10-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/111702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cuda] Handle -fcuda-short-ptr even with -nocudalib (PR #111682)

2024-10-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/111682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cuda] Handle -fcuda-short-ptr even with -nocudalib (PR #111682)

2024-10-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Seems reasonable, which architectures require this? https://github.com/llvm/llvm-project/pull/111682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [Cuda] Handle -fcuda-short-ptr even with -nocudalib (PR #111682)

2024-10-09 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Seems reasonable, which architectures require this? I know that NVIDIA > > deprecated the 32-bit `nvptx` target in CUDA 12 or something. > > I'm not an expert on CUDA but, AFAICT, even in 64-bit CUDA, certain pointers > such as those pointing to shared memory are 32 bit, bec

[clang] [llvm] [Clang] Put offloading globals in the `.llvm.rodata.offloading` section (PR #111890)

2024-10-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/111890 >From db58755323a6538c7a65bbdc323c5718dbc89dcb Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 10 Oct 2024 13:42:22 -0500 Subject: [PATCH] [Clang] Put offloading globals in the `.llvm.rodata.offloading`

[clang] [Cuda] Handle -fcuda-short-ptr even with -nocudalib (PR #111682)

2024-10-10 Thread Joseph Huber via cfe-commits
jhuber6 wrote: We don't need marshalling because this isn't a cc1 option. This is just handled by the driver which forwards it as `-mllvm` to the backend. You'd need to update the LLVM option to take multiple options and then make the clang driver option pick between them. https://github.com/

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/112025 Summary: The C library for GPUs provides the ability to target regular C/C++ programs by providing the C library and a file containing kernels that call the `main` function. This is mostly used for unit tests, th

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/112041 Summary: We currently use `llvm-mc` which is intended for internal testing and not expected to be present in every installation. This patch changes that to just use clang instead to get the `.o` from the HIP regi

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112041 >From 9de8a92c3bcda9d1fa414b9b355cb8ac77ae0812 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 14:53:17 -0500 Subject: [PATCH] [HIP] Replace use of `llvm-mc` with `clang` Summary: We currentl

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From a014a06d5b06bb8c94b4d86636fb57f342e184db Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/3] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/112025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From a014a06d5b06bb8c94b4d86636fb57f342e184db Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/2] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { jhuber6 wrote: Done. https://gi

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { jhuber6 wrote: Unfortunately not

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { jhuber6 wrote: What I meant, but

[clang] clang: Add llvm-mc to CLANG_TEST_DEPS (PR #112032)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/112032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Automatically enable `-fconvergent-functions` on GPU targets (PR #111076)

2024-10-04 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > -fno-convergent-functions to opt-out if you want to test broken behavior. > > You may legitimately know there are no convergent functions in the TU. We > also have the noconvergent source attribute now for this Think it would be useful to put that on functions in the wrapper

[clang] [Clang] Automatically enable `-fconvergent-functions` on GPU targets (PR #111076)

2024-10-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Extract device archives if symbol is used on the host (PR #111921)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 reopened https://github.com/llvm/llvm-project/pull/111921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Extract device archives if symbol is used on the host (PR #111921)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Accidentally deleted this branch and forgot to reopen this. Tests will fail until https://github.com/llvm/llvm-project/pull/111890 lands. https://github.com/llvm/llvm-project/pull/111921 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [llvm] [Clang] Put offloading globals in the `.llvm.rodata.offloading` section (PR #111890)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Would there be any reason to put entries for different offloading languages > into distinctly named “sub entries”? Not really, this is just a list of all the device-side symbols the host might want, that would make it more difficult to later extract. Also ping. https://githu

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From a02a27171801ad3f5618099b5035ef8185c2f835 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/3] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: ping https://github.com/llvm/llvm-project/pull/112025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f7b6dc8 - [Clang] Fix missing `-` in argument to nvlinker

2024-10-18 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-10-18T19:16:42-05:00 New Revision: f7b6dc821ad2aa02e027db76f193b85a87443e0b URL: https://github.com/llvm/llvm-project/commit/f7b6dc821ad2aa02e027db76f193b85a87443e0b DIFF: https://github.com/llvm/llvm-project/commit/f7b6dc821ad2aa02e027db76f193b85a87443e0b.diff

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 reopened https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Can you explain again why the compiler isn't providing the C library and the > start files implicitly by default, just like it does for non-GPU code? Because the GPU is not a target that wants to provide a C library and start files by default. This is an edge case where I make

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

2024-10-21 Thread Joseph Huber via cfe-commits
@@ -337,9 +337,12 @@ void AMDGPUTargetInfo::getTargetDefines(const LangOptions &Opts, if (hasFastFMA()) Builder.defineMacro("FP_FAST_FMA"); - Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize)); - // ToDo: deprecate this macro for naming consistency

[clang] [flang] [libclc] [llvm] [AMDGPU] Add a new target for gfx1153 (PR #113138)

2024-10-21 Thread Joseph Huber via cfe-commits
@@ -46,7 +46,7 @@ set(all_amdgpu_architectures "gfx700;gfx701;gfx801;gfx803;gfx900;gfx902;gfx906" "gfx908;gfx90a;gfx90c;gfx940;gfx941;gfx942;gfx1010" "gfx1030;gfx1031;gfx1032;gfx1033;gfx1034;gfx1035"

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

2024-10-21 Thread Joseph Huber via cfe-commits
jhuber6 wrote: I made https://github.com/llvm/llvm-project/pull/113156 to hopefully address the OpenMP issue. We use it in the runtime itself for a lot of stuff so removing it would definitely break that. The function call here matches what NVIDIA provides via PTX. I think we should have an op

[clang] [Clang] Automatically enable `-fconvergent-functions` on GPU targets (PR #111076)

2024-10-04 Thread Joseph Huber via cfe-commits
@@ -4106,9 +4106,10 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts, ArgList &Args, Opts.Blocks = Args.hasArg(OPT_fblocks) || (Opts.OpenCL && Opts.OpenCLVersion == 200); - Opts.ConvergentFunctions = Args.hasArg(OPT_fconvergent_functions) || -

[clang] [libc] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-04 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > IIRC, you discussed once to have GPU-agnostic intrinsics in LLVM-IR. The > backends then have to handle the details. There's three approaches basically, wrapper header, builtins, and intrinsics. We could make some generic intrinsics but it would be a lot more work and duplica

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/110179 >From 4a3348e56950583fb28211879f5ab157c34cbc66 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 26 Sep 2024 16:47:14 -0500 Subject: [PATCH 1/2] [Clang] Implement resource directory headers for common GPU

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/110179 >From 4a3348e56950583fb28211879f5ab157c34cbc66 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 26 Sep 2024 16:47:14 -0500 Subject: [PATCH 1/3] [Clang] Implement resource directory headers for common GPU

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 ready_for_review https://github.com/llvm/llvm-project/pull/110179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,187 @@ +//===-- amdgpuintrin.h - AMDPGU intrinsic functions ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,184 @@ +//===-- nvptxintrin.h - NVPTX intrinsic functions -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [libc] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/110179 >From 4a3348e56950583fb28211879f5ab157c34cbc66 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 26 Sep 2024 16:47:14 -0500 Subject: [PATCH 1/4] [Clang] Implement resource directory headers for common GPU

[clang] [libc] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,153 @@ +//===-- amdgpuintrin.h - AMDPGU intrinsic functions ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [libc] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-10-03 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,153 @@ +//===-- amdgpuintrin.h - AMDPGU intrinsic functions ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From a02a27171801ad3f5618099b5035ef8185c2f835 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/3] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -463,10 +463,11 @@ void HIP::constructGenerateObjFileFromHIPFatBinary( Objf << ObjBuffer; - ArgStringList McArgs{"-triple", Args.MakeArgString(HostTriple.normalize()), + ArgStringList McArgs{"-target", Args.MakeArgString(HostTriple.normalize()),

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -463,10 +463,11 @@ void HIP::constructGenerateObjFileFromHIPFatBinary( Objf << ObjBuffer; - ArgStringList McArgs{"-triple", Args.MakeArgString(HostTriple.normalize()), + ArgStringList McArgs{"-target", Args.MakeArgString(HostTriple.normalize()),

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112041 >From 9de8a92c3bcda9d1fa414b9b355cb8ac77ae0812 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 14:53:17 -0500 Subject: [PATCH 1/2] [HIP] Replace use of `llvm-mc` with `clang` Summary: We curr

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112041 >From 9de8a92c3bcda9d1fa414b9b355cb8ac77ae0812 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 14:53:17 -0500 Subject: [PATCH 1/3] [HIP] Replace use of `llvm-mc` with `clang` Summary: We curr

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112041 >From 9de8a92c3bcda9d1fa414b9b355cb8ac77ae0812 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 14:53:17 -0500 Subject: [PATCH 1/4] [HIP] Replace use of `llvm-mc` with `clang` Summary: We curr

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -463,10 +463,11 @@ void HIP::constructGenerateObjFileFromHIPFatBinary( Objf << ObjBuffer; - ArgStringList McArgs{"-triple", Args.MakeArgString(HostTriple.normalize()), + ArgStringList McArgs{"-target", Args.MakeArgString(HostTriple.normalize()),

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From f0682b7155dfef21833c5135e9edc9e4da80d15c Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/3] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > It should be `llvm clang`. I'm looking into this right now because this > change broke all our builders. I think that > `clang/lib/Driver/ToolChains/HIPUtility.cpp` doesn't correctly support > `LLVM_TOOL_LLVM_DRIVER_BUILD`. The variable used here is initialized via `argv[0]`

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > This seems to be failing all of the precommit CI pipelines in Clang: > > https://buildkite.com/llvm-project/github-pull-requests/builds/109413#01928af0-a546-4bf9-bd4c-a229b8ebc005 > > Can this be fixed or reverted? I'm confused, that test was modified in this patch and no long

[clang] [llvm] [CUDA] Add support for CUDA-12.6 and sm_100 (PR #112028)

2024-10-14 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. I swear there's got to be a way to automate this. https://github.com/llvm/llvm-project/pull/112028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [HIP] Replace use of `llvm-mc` with `clang` (PR #112041)

2024-10-14 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I fixed an apparent missing test dependency in > [1ac6ef5](https://github.com/llvm/llvm-project/commit/1ac6ef5af28b72e534496a9833a2b75a2aba66cc) > and this commit removed the llvm-mc dependency I probably should've remembered to include removing that in this patch. https://gi

[clang] [clang][OpenCL][CodeGen][AMDGPU] Do not use `private` as the default AS for when `generic` is available (PR #112442)

2024-10-22 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > LLVM Buildbot has detected a new failure on builder > > `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building > > `clang` at step 7 "Add check check-offload". > > Full details are available at: > > https://lab.llvm.org/buildbot/#/builders/30/builds/8694 >

[clang] [LinkerWrapper] Remove in-house handling of LTO (PR #113715)

2024-10-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/113715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NvlinkWrapper] Add support for `--undefined` (PR #113934)

2024-10-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/113934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-29 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \ +// RUN: | FileCheck %s --check-prefix=SIMPLE +// SI

[clang] need to pass executable name as arg[0] (PR #114067)

2024-10-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/114067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,500 @@ +//= clang-sycl-linker/ClangSYCLLinker.cpp - SYCL Linker util ---=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,55 @@ +include "llvm/Option/OptParser.td" + +def WrapperOnlyOption : OptionFlag; + +def help : Flag<["-", "--"], "help">, + HelpText<"Display available options (--help-hidden for more)">; + +def help_hidden : Flag<["-", "--"], "help-hidden">, + HelpText<"Display all a

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \ +// RUN: | FileCheck %s --check-prefix=SIMPLE +// SI

[clang] [llvm] [llvm][AMDGPU] Fold `llvm.amdgcn.wavefrontsize` early (PR #114481)

2024-11-04 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/114481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    12   13   14   15   16   17   18   19   20   21   >