https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/102521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/102521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
Also, just be aware that if you set this, it will apply to everything. So if
you had a particularly long link job, probably would be a good idea to make it
wait forever.
https://github.com/llvm/llvm-project/pull/102521
___
cfe-commits
jhuber6 wrote:
> > Also, just be aware that if you set this, it will apply to everything. So
> > if you had a particularly long link job, probably would be a good idea to
> > make it wait forever.
>
> Not sure I understand. grep found 2 uses of executeToolChainProgram: calling
> amdgpu-arch a
Author: Joseph Huber
Date: 2022-01-18T12:53:17-05:00
New Revision: dcb83b236421d5a4d6e767ee43ae1cdab5fce0f2
URL:
https://github.com/llvm/llvm-project/commit/dcb83b236421d5a4d6e767ee43ae1cdab5fce0f2
DIFF:
https://github.com/llvm/llvm-project/commit/dcb83b236421d5a4d6e767ee43ae1cdab5fce0f2.diff
Author: Joseph Huber
Date: 2022-01-18T12:53:20-05:00
New Revision: d081bfcd17c1c704776a0964d239f19f6acde93d
URL:
https://github.com/llvm/llvm-project/commit/d081bfcd17c1c704776a0964d239f19f6acde93d
DIFF:
https://github.com/llvm/llvm-project/commit/d081bfcd17c1c704776a0964d239f19f6acde93d.diff
Author: Joseph Huber
Date: 2022-01-18T14:44:11-05:00
New Revision: 8fc24de93f9def64c3ffa72f5235f23e9d761847
URL:
https://github.com/llvm/llvm-project/commit/8fc24de93f9def64c3ffa72f5235f23e9d761847
DIFF:
https://github.com/llvm/llvm-project/commit/8fc24de93f9def64c3ffa72f5235f23e9d761847.diff
Author: Joseph Huber
Date: 2022-01-18T18:19:57-05:00
New Revision: ca6c9e43ea9ca6b752d4302d692d29e311480da5
URL:
https://github.com/llvm/llvm-project/commit/ca6c9e43ea9ca6b752d4302d692d29e311480da5
DIFF:
https://github.com/llvm/llvm-project/commit/ca6c9e43ea9ca6b752d4302d692d29e311480da5.diff
Author: Joseph Huber
Date: 2022-01-19T20:26:37-05:00
New Revision: 28d718602ad2bddbfcb445fff46bcbbdd0788471
URL:
https://github.com/llvm/llvm-project/commit/28d718602ad2bddbfcb445fff46bcbbdd0788471
DIFF:
https://github.com/llvm/llvm-project/commit/28d718602ad2bddbfcb445fff46bcbbdd0788471.diff
Author: Joseph Huber
Date: 2022-01-20T13:12:02-05:00
New Revision: af5600420b93769a5c7981d247d37ac4d61cce54
URL:
https://github.com/llvm/llvm-project/commit/af5600420b93769a5c7981d247d37ac4d61cce54
DIFF:
https://github.com/llvm/llvm-project/commit/af5600420b93769a5c7981d247d37ac4d61cce54.diff
Author: Joseph Huber
Date: 2022-01-20T21:06:26-05:00
New Revision: 0dfe953294ba1c0fc43fb710518b9b5a608b223a
URL:
https://github.com/llvm/llvm-project/commit/0dfe953294ba1c0fc43fb710518b9b5a608b223a
DIFF:
https://github.com/llvm/llvm-project/commit/0dfe953294ba1c0fc43fb710518b9b5a608b223a.diff
Author: Joseph Huber
Date: 2022-01-27T18:43:41-05:00
New Revision: 2945f11c605b059446ac997f62458a6c489e46f7
URL:
https://github.com/llvm/llvm-project/commit/2945f11c605b059446ac997f62458a6c489e46f7
DIFF:
https://github.com/llvm/llvm-project/commit/2945f11c605b059446ac997f62458a6c489e46f7.diff
Author: Joseph Huber
Date: 2022-01-28T18:22:17-05:00
New Revision: 24f88f57de588817bd21e799e2ac1069c025674c
URL:
https://github.com/llvm/llvm-project/commit/24f88f57de588817bd21e799e2ac1069c025674c
DIFF:
https://github.com/llvm/llvm-project/commit/24f88f57de588817bd21e799e2ac1069c025674c.diff
Author: Joseph Huber
Date: 2022-01-31T15:55:58-05:00
New Revision: 2f9ace9e9a5816684b3c19528bd4a3908b2b8ac0
URL:
https://github.com/llvm/llvm-project/commit/2f9ace9e9a5816684b3c19528bd4a3908b2b8ac0
DIFF:
https://github.com/llvm/llvm-project/commit/2f9ace9e9a5816684b3c19528bd4a3908b2b8ac0.diff
Author: Joseph Huber
Date: 2022-01-31T15:56:00-05:00
New Revision: 551b1774524428aae5692ed3d41f969288ecd5a2
URL:
https://github.com/llvm/llvm-project/commit/551b1774524428aae5692ed3d41f969288ecd5a2
DIFF:
https://github.com/llvm/llvm-project/commit/551b1774524428aae5692ed3d41f969288ecd5a2.diff
Author: Joseph Huber
Date: 2022-01-31T15:56:02-05:00
New Revision: 12ae095bbb639c3dda9607a57487b83ccec9d246
URL:
https://github.com/llvm/llvm-project/commit/12ae095bbb639c3dda9607a57487b83ccec9d246
DIFF:
https://github.com/llvm/llvm-project/commit/12ae095bbb639c3dda9607a57487b83ccec9d246.diff
Author: Joseph Huber
Date: 2022-01-31T15:56:04-05:00
New Revision: 95c8f7464092e2ccd45c3ae6dc42da6bd9a037b5
URL:
https://github.com/llvm/llvm-project/commit/95c8f7464092e2ccd45c3ae6dc42da6bd9a037b5
DIFF:
https://github.com/llvm/llvm-project/commit/95c8f7464092e2ccd45c3ae6dc42da6bd9a037b5.diff
Author: Joseph Huber
Date: 2022-01-31T16:46:51-05:00
New Revision: b79e2a1ccd3b0c8e388fe35ba162c2db498dd882
URL:
https://github.com/llvm/llvm-project/commit/b79e2a1ccd3b0c8e388fe35ba162c2db498dd882
DIFF:
https://github.com/llvm/llvm-project/commit/b79e2a1ccd3b0c8e388fe35ba162c2db498dd882.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:41-05:00
New Revision: b8239af0eeedfa67d9fac28d20685b7a09e2935a
URL:
https://github.com/llvm/llvm-project/commit/b8239af0eeedfa67d9fac28d20685b7a09e2935a
DIFF:
https://github.com/llvm/llvm-project/commit/b8239af0eeedfa67d9fac28d20685b7a09e2935a.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:41-05:00
New Revision: d0744585f9ea842ca97855b2e002fddc893c4a92
URL:
https://github.com/llvm/llvm-project/commit/d0744585f9ea842ca97855b2e002fddc893c4a92
DIFF:
https://github.com/llvm/llvm-project/commit/d0744585f9ea842ca97855b2e002fddc893c4a92.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:41-05:00
New Revision: 0e82c7553be95343f1cb62946eb0b84bd26f1563
URL:
https://github.com/llvm/llvm-project/commit/0e82c7553be95343f1cb62946eb0b84bd26f1563
DIFF:
https://github.com/llvm/llvm-project/commit/0e82c7553be95343f1cb62946eb0b84bd26f1563.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:41-05:00
New Revision: c732c3df749b3d5a127708c05656a226ed5753ab
URL:
https://github.com/llvm/llvm-project/commit/c732c3df749b3d5a127708c05656a226ed5753ab
DIFF:
https://github.com/llvm/llvm-project/commit/c732c3df749b3d5a127708c05656a226ed5753ab.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:41-05:00
New Revision: 3762111aa9608fce12c4f938bfef2b38aed766dd
URL:
https://github.com/llvm/llvm-project/commit/3762111aa9608fce12c4f938bfef2b38aed766dd
DIFF:
https://github.com/llvm/llvm-project/commit/3762111aa9608fce12c4f938bfef2b38aed766dd.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:41-05:00
New Revision: f28c3153ee6d93aa07610682519bdf0ea93755b4
URL:
https://github.com/llvm/llvm-project/commit/f28c3153ee6d93aa07610682519bdf0ea93755b4
DIFF:
https://github.com/llvm/llvm-project/commit/f28c3153ee6d93aa07610682519bdf0ea93755b4.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:41-05:00
New Revision: cb7cfaec71850d0a6bc6e00729f0ef6107c51419
URL:
https://github.com/llvm/llvm-project/commit/cb7cfaec71850d0a6bc6e00729f0ef6107c51419
DIFF:
https://github.com/llvm/llvm-project/commit/cb7cfaec71850d0a6bc6e00729f0ef6107c51419.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:42-05:00
New Revision: ce16ca3c7419fc6cec43d0dae5e9f62df05faf6b
URL:
https://github.com/llvm/llvm-project/commit/ce16ca3c7419fc6cec43d0dae5e9f62df05faf6b
DIFF:
https://github.com/llvm/llvm-project/commit/ce16ca3c7419fc6cec43d0dae5e9f62df05faf6b.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:42-05:00
New Revision: 46d019041cd924d8bdf69c818bbe13f6cd37f466
URL:
https://github.com/llvm/llvm-project/commit/46d019041cd924d8bdf69c818bbe13f6cd37f466
DIFF:
https://github.com/llvm/llvm-project/commit/46d019041cd924d8bdf69c818bbe13f6cd37f466.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:42-05:00
New Revision: a47b1cf306fb7494d493784c25dafb2dd6084b99
URL:
https://github.com/llvm/llvm-project/commit/a47b1cf306fb7494d493784c25dafb2dd6084b99
DIFF:
https://github.com/llvm/llvm-project/commit/a47b1cf306fb7494d493784c25dafb2dd6084b99.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:42-05:00
New Revision: bf499c58af3d3a96661f5c7ef81b264eac575541
URL:
https://github.com/llvm/llvm-project/commit/bf499c58af3d3a96661f5c7ef81b264eac575541
DIFF:
https://github.com/llvm/llvm-project/commit/bf499c58af3d3a96661f5c7ef81b264eac575541.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:42-05:00
New Revision: 58dc981e082df9db2de1cbd867fa6d73e8eea214
URL:
https://github.com/llvm/llvm-project/commit/58dc981e082df9db2de1cbd867fa6d73e8eea214
DIFF:
https://github.com/llvm/llvm-project/commit/58dc981e082df9db2de1cbd867fa6d73e8eea214.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:42-05:00
New Revision: eb6ddf288cd0ec58be8ff6c0840c440a5f31dd0b
URL:
https://github.com/llvm/llvm-project/commit/eb6ddf288cd0ec58be8ff6c0840c440a5f31dd0b
DIFF:
https://github.com/llvm/llvm-project/commit/eb6ddf288cd0ec58be8ff6c0840c440a5f31dd0b.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:42-05:00
New Revision: 9375f1563e87e115cc8f9d052760d68460889f4e
URL:
https://github.com/llvm/llvm-project/commit/9375f1563e87e115cc8f9d052760d68460889f4e
DIFF:
https://github.com/llvm/llvm-project/commit/9375f1563e87e115cc8f9d052760d68460889f4e.diff
Author: Joseph Huber
Date: 2022-01-31T23:11:43-05:00
New Revision: 19fac745e3226fbe9db4d3eab106fdaf19d9019d
URL:
https://github.com/llvm/llvm-project/commit/19fac745e3226fbe9db4d3eab106fdaf19d9019d
DIFF:
https://github.com/llvm/llvm-project/commit/19fac745e3226fbe9db4d3eab106fdaf19d9019d.diff
Author: Joseph Huber
Date: 2022-02-01T09:56:09-05:00
New Revision: 28c15341368bc8c557313d8929a4220a8c38516c
URL:
https://github.com/llvm/llvm-project/commit/28c15341368bc8c557313d8929a4220a8c38516c
DIFF:
https://github.com/llvm/llvm-project/commit/28c15341368bc8c557313d8929a4220a8c38516c.diff
Author: Joseph Huber
Date: 2022-02-18T08:35:05-05:00
New Revision: 0870a4f59aef21bf7707b00ebd4dcad7ce7ef807
URL:
https://github.com/llvm/llvm-project/commit/0870a4f59aef21bf7707b00ebd4dcad7ce7ef807
DIFF:
https://github.com/llvm/llvm-project/commit/0870a4f59aef21bf7707b00ebd4dcad7ce7ef807.diff
Author: Joseph Huber
Date: 2022-02-22T21:22:18-05:00
New Revision: 55cb84d9fbea1ead9434de519e1b4e1d2d803048
URL:
https://github.com/llvm/llvm-project/commit/55cb84d9fbea1ead9434de519e1b4e1d2d803048
DIFF:
https://github.com/llvm/llvm-project/commit/55cb84d9fbea1ead9434de519e1b4e1d2d803048.diff
Author: Joseph Huber
Date: 2022-02-22T21:22:19-05:00
New Revision: 6a0b78af9175af45641c854a88761f284361aaee
URL:
https://github.com/llvm/llvm-project/commit/6a0b78af9175af45641c854a88761f284361aaee
DIFF:
https://github.com/llvm/llvm-project/commit/6a0b78af9175af45641c854a88761f284361aaee.diff
Author: Joseph Huber
Date: 2022-02-23T16:45:36-05:00
New Revision: 2b97b16f294af91281d8a138759f3f772952a902
URL:
https://github.com/llvm/llvm-project/commit/2b97b16f294af91281d8a138759f3f772952a902
DIFF:
https://github.com/llvm/llvm-project/commit/2b97b16f294af91281d8a138759f3f772952a902.diff
Author: Joseph Huber
Date: 2022-02-23T16:54:01-05:00
New Revision: 0c1fd90fe0828aa87518d9be542bd00d36d258d7
URL:
https://github.com/llvm/llvm-project/commit/0c1fd90fe0828aa87518d9be542bd00d36d258d7
DIFF:
https://github.com/llvm/llvm-project/commit/0c1fd90fe0828aa87518d9be542bd00d36d258d7.diff
Author: Joseph Huber
Date: 2022-02-23T18:07:25-05:00
New Revision: 119d71cb73a888a57b368cb5c74ac8ac07fb5c32
URL:
https://github.com/llvm/llvm-project/commit/119d71cb73a888a57b368cb5c74ac8ac07fb5c32
DIFF:
https://github.com/llvm/llvm-project/commit/119d71cb73a888a57b368cb5c74ac8ac07fb5c32.diff
Author: Joseph Huber
Date: 2022-02-24T10:57:09-05:00
New Revision: 7aef8b3754a28e0856a8300980786a45bf7b4cd4
URL:
https://github.com/llvm/llvm-project/commit/7aef8b3754a28e0856a8300980786a45bf7b4cd4
DIFF:
https://github.com/llvm/llvm-project/commit/7aef8b3754a28e0856a8300980786a45bf7b4cd4.diff
Author: Joseph Huber
Date: 2022-02-28T13:28:19-05:00
New Revision: d5b2055769f40386a818e9df0a173eafa0e7dc5f
URL:
https://github.com/llvm/llvm-project/commit/d5b2055769f40386a818e9df0a173eafa0e7dc5f
DIFF:
https://github.com/llvm/llvm-project/commit/d5b2055769f40386a818e9df0a173eafa0e7dc5f.diff
Author: Joseph Huber
Date: 2022-03-02T13:02:41-05:00
New Revision: 3f7c3ff90e33393b7b8a0851f6056ec1d9c164af
URL:
https://github.com/llvm/llvm-project/commit/3f7c3ff90e33393b7b8a0851f6056ec1d9c164af
DIFF:
https://github.com/llvm/llvm-project/commit/3f7c3ff90e33393b7b8a0851f6056ec1d9c164af.diff
Author: Joseph Huber
Date: 2021-12-09T16:30:29-05:00
New Revision: bc9c4d7216a5bcdeec8543834fe1451db2c46e5c
URL:
https://github.com/llvm/llvm-project/commit/bc9c4d7216a5bcdeec8543834fe1451db2c46e5c
DIFF:
https://github.com/llvm/llvm-project/commit/bc9c4d7216a5bcdeec8543834fe1451db2c46e5c.diff
Author: Joseph Huber
Date: 2021-10-07T22:23:09-04:00
New Revision: 9efdca87c78256bb00ed51521272dec2deed7f23
URL:
https://github.com/llvm/llvm-project/commit/9efdca87c78256bb00ed51521272dec2deed7f23
DIFF:
https://github.com/llvm/llvm-project/commit/9efdca87c78256bb00ed51521272dec2deed7f23.diff
Author: Joseph Huber
Date: 2021-10-08T22:21:59-04:00
New Revision: bad44d5f39bc29c1062f0c4ce8b71720734ad3cb
URL:
https://github.com/llvm/llvm-project/commit/bad44d5f39bc29c1062f0c4ce8b71720734ad3cb
DIFF:
https://github.com/llvm/llvm-project/commit/bad44d5f39bc29c1062f0c4ce8b71720734ad3cb.diff
Author: Joseph Huber
Date: 2021-08-20T20:45:14-04:00
New Revision: ec66ed79f43c3303e462b86eff65d08d6cf8229f
URL:
https://github.com/llvm/llvm-project/commit/ec66ed79f43c3303e462b86eff65d08d6cf8229f
DIFF:
https://github.com/llvm/llvm-project/commit/ec66ed79f43c3303e462b86eff65d08d6cf8229f.diff
Author: Joseph Huber
Date: 2021-09-10T14:52:45-04:00
New Revision: f28e710db720a913f4b508a9dc43f25e81629e72
URL:
https://github.com/llvm/llvm-project/commit/f28e710db720a913f4b508a9dc43f25e81629e72
DIFF:
https://github.com/llvm/llvm-project/commit/f28e710db720a913f4b508a9dc43f25e81629e72.diff
Author: Joseph Huber
Date: 2021-09-10T18:19:19-04:00
New Revision: 29b44ca896e7c5d9fef20f3660cbe5eb321b91ea
URL:
https://github.com/llvm/llvm-project/commit/29b44ca896e7c5d9fef20f3660cbe5eb321b91ea
DIFF:
https://github.com/llvm/llvm-project/commit/29b44ca896e7c5d9fef20f3660cbe5eb321b91ea.diff
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/104460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/104790
Summary:
Currently, we assign this to private memory. This causes failures on
some SOLLVE tests. The standard isn't clear on the semantics of this
allocation type, but there seems to be a consensus that it's supp
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/104790
>From eaa00ef74500833f280405c824d0282862c87b11 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 19 Aug 2024 09:44:37 -0500
Subject: [PATCH] [OpenMP] Map `omp_default_mem_alloc` to global memory
Summary:
C
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/104790
>From eaa00ef74500833f280405c824d0282862c87b11 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 19 Aug 2024 09:44:37 -0500
Subject: [PATCH 1/2] [OpenMP] Map `omp_default_mem_alloc` to global memory
Summar
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/104790
>From eaa00ef74500833f280405c824d0282862c87b11 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 19 Aug 2024 09:44:37 -0500
Subject: [PATCH 1/2] [OpenMP] Map `omp_default_mem_alloc` to global memory
Summar
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/104790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
```llvm/llvm-project/build/lib/clang/20/include/avx10_2convertintrin.h:29:19:
error: use of undeclared identifier '__builtin_ia32_vcvt2ps2phx128_mask'
29 | return (__m128h)__builtin_ia32_vcvt2ps2phx128_mask(
| ^
```
I'm getting a lot of errors like thi
jhuber6 wrote:
My guess is that you added these as a target dependent builtin, but made the
headers always reference them.
https://github.com/llvm/llvm-project/pull/101600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
jhuber6 wrote:
This is all it takes to reproduce this on my machine so I'm going to revert.
x64 Linux, CPU is `znver3`.
```console
echo "#include " | ./bin/clang++ -x c++ -
```
https://github.com/llvm/llvm-project/pull/101600
___
cfe-commits mailing l
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/96369
Summary:
This patch implements the `printf` family of functions on the GPU using
the new variadic support. This patch adapts the old handling in the
`rpc_fprintf` placeholder, but adds an extra RPC call to get the
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/96370
Summary:
The variadics lowering for AMDGPU puts all the arguments into a void
pointer struct. The current logic dictates that the minimum alignment is
four regardless of what the underlying type is. This is incor
https://github.com/jhuber6 approved this pull request.
Out of curiosity, how badly does this fail when you use `--offload-new-driver`
w/ HIP? I swear I'll get that passing the internal test suite eventually,
there's a single case for emitting IR that comgr uses that I can't seem to fix.
https:
jhuber6 wrote:
> > Here, because the minimum alignment is 4, we will only increment the
> > buffer by 4,
>
> It should be incrementing by the size? 4 byte aligned access of 8 byte type
> should work fine
Guess that's an AMD thing, so I'm going to assume that @JonChesterfield wrote
this intent
jhuber6 wrote:
> Incrementing by align is just a bug, of course the size is the real value.
> Whether we want to continue wasting space is another not-correctness
> discussion
Struct padding is pretty universal, AMDGPU seems the odd one out here. I
wouldn't mind it so much if it didn't requir
https://github.com/jhuber6 commented:
Seems to be lots of accidental `clang-format` changes. Why do we need new flags
for this instead of just using the old ones and changing behavior when the
target is a known GPU? I.e. SPIR-V, CUDA, or HSA.
https://github.com/llvm/llvm-project/pull/94268
___
jhuber6 wrote:
> @jhuber6 The clang format errors are mostly due to my local version of
> `clang-format` disagreeing with the buildbot's version. Its a bit annoying,
> but it shouldn't be too much of a problem given I plan on squashing and
> merging once this gets approved.
>
> I added new fl
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/96561
Summary:
The `clang-nvlink-wrapper` is a utility that I removed awhile back
during the transition to the new driver. This patch adds back in a new,
upgraded version that does LTO + archive linking. It's not an eas
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/96561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/96561
>From 8a52becd358abb2c96ca150db501d58c40b5250b Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 24 Jun 2024 15:14:52 -0500
Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around
'nvlink'
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/96561
>From 5edeeb9816fa5909f27a781f6e7213dd02ccdfa0 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 24 Jun 2024 15:14:52 -0500
Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around
'nvlink'
jhuber6 wrote:
> @Artem-B asked me to review nvptx patches while he's OOO, but this one is
> pretty far outside my depth. Are you OK waiting until he's back? I don't know
> exactly when that will be, but based on his IMs to me, he should be back
> early July.
No problem, I knew that it would
jhuber6 wrote:
> > > Incrementing by align is just a bug, of course the size is the real
> > > value. Whether we want to continue wasting space is another
> > > not-correctness discussion
> >
> >
> > Struct padding is pretty universal, AMDGPU seems the odd one out here. I
> > wouldn't mind i
jhuber6 wrote:
> > Hm, that's what I'm doing in the `printf` implementation and it doesn't
> > work without that patch. When I look at the varargs struct it didn't have
> > any padding, which explained why `alignTo(ptr + size, align)` was wrong.
> > So, I was trying to do the following, `print
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/96561
>From 6c70e542bbb355160b833ede6f86be0366953b88 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 24 Jun 2024 15:14:52 -0500
Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around
'nvlink'
jhuber6 wrote:
@MaskRay So, I think my symbol resolution is (unsurprisingly) subtly broken. Is
there a canonical way to handle this? I first thought that we could simply
perform the symbol resolutions as normal for every file, but keep track of
which symbols were "lazy". However, I couldn't fi
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/96561
>From 859f6a7fce9503275ad7eb39512dc5833a11bb07 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 24 Jun 2024 15:14:52 -0500
Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around
'nvlink'
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/96650
Summary:
The StringError class has a specialized method that creates the
inconvertible error code for you. It's much easier to read this way.
>From 6860d0101f8babac086156087854e8f94e4f233e Mon Sep 17 00:00:00 20
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/96657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/96657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -284,3 +284,48 @@ Example Usage
Base* basePtr = &obj;
basePtr->virtualFunction(); // Allowed since obj is constructed in
device code
}
+
+SPIR-V Support on HIPAMD ToolChain
+==
+
+The HIPAMD ToolChain supports targetting
+`AMDG
jhuber6 wrote:
> > I'll need to play with this with my driver code. I'm guessing it's because
> > it needs to generate an entirely separate toolchain? The OpenMP path
> > basically does that by inferring the toolchain from the string value, so we
> > can support `--offload-arch=sm_89,gfx90a` f
jhuber6 wrote:
> Do we want some sort of optimization for constant printf? 99% of the time, we
> could parse the string at compile-time. (This sort of optimization is common
> for embedded targets.)
I was going to make a follow-up patch that simply skipped sending back the size
if there were
jhuber6 wrote:
Also, I just merged the prerequisite patches into this, to get the relevant
changed just look at the most recent commit. The lack of stacked PRs in GitHub
really irks me.
https://github.com/llvm/llvm-project/pull/96369
___
cfe-commits
jhuber6 wrote:
> I looked at this and it doesn't look super appealing (turned into something
> of a rabbit hole), it'd duplicate a lot of the existing toolchain, and would
> also try to squat in an already overcrowded space (there's already HIPSPV).
We already have a SPIR-V toolchain for HIP?
@@ -54,7 +54,8 @@ class MockArgList {
}
template LIBC_INLINE T next_var() {
-++arg_counter;
+arg_counter =
jhuber6 wrote:
I now use the `MockArgList` to tell determine how big the "struct" needs to be
to contain the arguments.
https://github.co
@@ -0,0 +1,73 @@
+//===--- GPU helper functions for printf using RPC
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -54,7 +54,8 @@ class MockArgList {
}
template LIBC_INLINE T next_var() {
-++arg_counter;
+arg_counter =
jhuber6 wrote:
I didn't see any tests that actively depended on this value, and figured that
it does a similar job stating how many bytes
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/96650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -54,7 +54,8 @@ class MockArgList {
}
template LIBC_INLINE T next_var() {
-++arg_counter;
+arg_counter =
jhuber6 wrote:
Done
https://github.com/llvm/llvm-project/pull/96369
___
cfe-commits mailing li
@@ -0,0 +1,86 @@
+; Check various clang-linker-wrapper pass options after -offload-opt.
+
+; REQUIRES: llvm-plugins, llvm-examples
+; REQUIRES: x86-registered-target
+; REQUIRES: amdgpu-registered-target
+
+; Setup.
+; RUN: split-file %s %t
+; RUN: opt -o %t/host-x86_64-unknown-li
https://github.com/jhuber6 commented:
Makes sense overall. However in the future I'm looking to move away from the
home-baked LTO pipeline in favor of giving it to the linker. That allows me to
set up libraries as a part of the target toolchain in the driver. I guess for
that I'll just need to
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/96704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,10 @@
+// Check that these simple command lines for listing LLVM options are
supported,
jhuber6 wrote:
Do we have any other tests that just check the output for `--help`? Might be a
little excessive.
https://github.com/llvm/llvm-project/pull/96704
_
@@ -0,0 +1,86 @@
+; Check various clang-linker-wrapper pass options after -offload-opt.
+
+; REQUIRES: llvm-plugins, llvm-examples
+; REQUIRES: x86-registered-target
+; REQUIRES: amdgpu-registered-target
+
+; Setup.
+; RUN: split-file %s %t
+; RUN: opt -o %t/host-x86_64-unknown-li
@@ -0,0 +1,77 @@
+; Check various clang-linker-wrapper pass options after -offload-opt.
jhuber6 wrote:
Hm, is this really the only LLVM-IR file in the Driver directory? I guess it
makes sense, though you could probably just do what the other linker wrapper
test
@@ -0,0 +1,77 @@
+; Check various clang-linker-wrapper pass options after -offload-opt.
jhuber6 wrote:
-disable-O0-optnone handles the optnone, don't think `noinline` affects that
much.
https://github.com/llvm/llvm-project/pull/96704
___
@@ -0,0 +1,77 @@
+; Check various clang-linker-wrapper pass options after -offload-opt.
jhuber6 wrote:
I see, probably fine then.
https://github.com/llvm/llvm-project/pull/96704
___
cfe-commits mailing list
cfe-commits
https://github.com/jhuber6 approved this pull request.
I think this looks good overall, though I'd like to hear some other clang
maintainers chime in on the LIT config changes.
https://github.com/llvm/llvm-project/pull/96704
___
cfe-commits mailing li
https://github.com/jhuber6 approved this pull request.
The fact that it's called `-fcuda-is-device` is historical cruft, but I guess
it's easiest to just work with it. I also hate `-mlink-builtin-bitcode` as a
concept, but we're not quite ready to move away from its hacks unfortunately.
https
@@ -0,0 +1,77 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -emit-llvm -o - %s | FileCheck
%s
+
+extern void varargs_simple(int, ...);
+
+// CHECK-LABEL: define dso_local vo
https://github.com/jhuber6 commented:
Looks fine in general, I'm not a huge fan of all the `isGPUProfTarget` things
we have around now, but I understand it's required to set up the visibility. I
wonder if we could factor that out into something more common.
https://github.com/llvm/llvm-project
1501 - 1600 of 2686 matches
Mail list logo
