[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 417129. jhuber6 added a comment. Add more comments and an entry size field to the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 Files: clang/include/clang

[PATCH] D122133: [LTO] Add configuartion option to use default optimization pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5856f30b5ae0: [LTO] Add configuartion option to use default optimization pipeline (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. In prepar

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 421232. jhuber6 added a comment. Update with the more generic clang argument handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Ba

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. In preparation for allowing other offloa

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 421270. jhuber6 added a comment. Make `-foffload-new-driver` imply GPU-RDC mode, it won't work otherwise. Also adjust tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 421555. jhuber6 added a comment. Update handling for fatbinaries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/tools/clang-linker-wrapper/ClangLinke

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 421595. jhuber6 added a comment. Fix misplaced logic symbol that broke tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Comp

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 421607. jhuber6 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Compilation.h clang/include/clang/Drive

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

jhuber6 updated this revision to Diff 421764. jhuber6 added a comment. clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123460/new/ https://reviews.llvm.org/D123460 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOp

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

jhuber6 updated this revision to Diff 421794. jhuber6 added a comment. Change constant to just be a string since it's all we use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123460/new/ https://reviews.llvm.org/D123460 Files: clang/lib/CodeGen

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, yaxunl, tra. Herald added subscribers: carlosgalvezp, dexonsmith. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald add

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added a comment. In D123471#3443612 , @yaxunl wrote: > Is OpenMP runtime able to find these entries without registering them through > some API functions? If so, do you have a pointer to the code doing that? Yes, the linker will define `__start/

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

jhuber6 added a comment. In D123460#3443925 , @tianshilei1992 wrote: > If we'd like it to be used by CUDA or other programming models, > `llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp` is not a good place. Other than > that, the patch looks good to me. I

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added a comment. In D123471#3446464 , @tra wrote: > I've mentioned in D123441 that it would be > useful to have a list of GPU-side symbols needed by the host and this offload > info is pretty close to what we n

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added a comment. In D123471#3446751 , @yaxunl wrote: > HIP is considering a unified device binary embedding scheme with OpenMP. > However, some large MI frameworks are compiled with -fno-gpu-rdc. If > compiling with -fgpu-rdc, the linking time w

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 422544. jhuber6 added a comment. Maxing suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 Files: llvm/include/llvm/Object/OffloadBinary.h llvm/li

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 422547. jhuber6 added a comment. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/Back

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 422580. jhuber6 added a comment. Fix test after move to opaque pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOpt

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe471ba3d0122: [Object] Add binary format for bundling offloading metadata (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This pa

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. For reference, this is how I used this driver to offload a CUDA and OpenMP offload kernel that both called an external "hello world" function in `device.cu`. $ clang++ hello.cu device.cu -foffload-new-driver --offload-arch=sm_70 -c $ clang++ openmp.cpp -fopenmp-new-

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module &M) { + LLVMContext &C = M.getContext(); tra wrote:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module &M) { + LLVMContext &C = M.getContext(); tra wrote:

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 423176. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG984a0dc38655: [OpenMP] Use new offloading binary when embedding offloading images (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123946: [CUDA][HIP] Fix gpu.used.external

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123946/new/ https://reviews.llvm.org/D123946 ___ cfe-commits mailing list cfe-commits

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3885-3888 + bool UseNewOffloadingDriver = + C.isOffloadingHostKind(C.getActiveOffloadKinds()) && + (Args.hasArg(options::OPT_foffload_new_driver) || + Args.hasArg(options::OPT_fopenmp_new_driv

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423416. jhuber6 added a comment. Herald added a subscriber: mattd. Splitting major changes into two files as per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D1

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423433. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D122831 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae23be84cb60: [OpenMP] Make the new offloading driver the default (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423459. jhuber6 added a comment. Rebase & update after making the new driver default for OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/includ

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 423460. jhuber6 added a comment. Herald added subscribers: mattd, dexonsmith, MaskRay. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/include/

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423461. jhuber6 added a comment. Rebase after making the new driver default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Actio

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423464. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Action.cpp clan

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423465. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Compila

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423466. jhuber6 added a comment. Fix for real after rebasing failure... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423468. jhuber6 added a comment. Sorry for the spam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Ac

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423470. jhuber6 added a comment. Fix after fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/include/clang/Dri

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423478. jhuber6 added a comment. Hopefully this is the last time I need to update this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Dr

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423479. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Compilation.h clang/include/clang/Driver/Op

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423514. jhuber6 added a comment. Removing unnecessary change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. In D123325#3459108 , @yaxunl wrote: > should we have a test to show the effect of -foffload-new-driver on > -ccc-print-phases for CUDA/HIP? We probably should, it's tested w/ OpenMP but we should check the bound architectures a

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. In D123812#3459164 , @yaxunl wrote: > need a CodeGenCUDA test for the registering. Also need a Driver test for the > subcommands. Testing things inside the linker wrapper is a little hairy. I may need to add a special option fo

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 423645. jhuber6 added a comment. Herald added a subscriber: mattd. Adding new test for CUDA phases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/inc

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. In D123325#3459108 , @yaxunl wrote: > should we have a test to show the effect of -foffload-new-driver on > -ccc-print-phases for CUDA/HIP? I decided to add the test in D120272 because this fi

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6949-6952 +CmdArgs.push_back(Args.MakeArgString( +"-fembed-offload-object=" + File + "," + +Action::GetOffloadKindName(OffloadAction->getOffloadingDeviceKind()) + +"," + T

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 423685. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h clang/lib/Drive

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, JonChesterfield, jdoerfert, tianshilei1992. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. T

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 updated this revision to Diff 423743. jhuber6 added a comment. Fix test on Windows failing because of ".exe" at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://reviews.llvm.org/D124039 Files: clang/test/Driver/

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG260c5df2d52b: [OpenMP] Add better testing for the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124039/new/ https://re

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 updated this revision to Diff 423793. jhuber6 added a comment. Herald added a subscriber: mattd. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123810/new/ https://reviews.llvm.org/D123810 Files: clang/tools/clang-linker-wrapper/C

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423796. jhuber6 added a comment. Addings tests for wrapper codegen and fatbinary usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files: clang/test/Driver/lin

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added a comment. In D124039#3461482 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/33656/step_7.txt > > Please take a look and revert for now if it takes a while to fix. (Maybe just > needs an explicit triple?)

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:32 +// RUN: %clang -cc1 %s -emit-obj -o %t.o \ +// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,cuda,nvptx64-nvida-cuda,sm_70 +// RUN: clang-linker-wrapper --print-wrapped-module --dry-run

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423993. jhuber6 added a comment. Herald added a subscriber: sstefan1. Adjusting tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files: clang/test/Driver/link

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry --

[PATCH] D124039: [OpenMP] Add better testing for the linker wrapper

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:8 + +// OPENMP: @__start_omp_offloading_entries = external hidden constant %__tgt_offload_entry +// OPENMP-NEXT: @__stop_omp_offloading_entries = external hidden constant %__tgt_offload_entry --

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

jhuber6 added a comment. In D107668#3464124 , @Naghasan wrote: > Any rational for not calling `addTempFile` during the binding rather than the > call setup ? I had a brief look there and it seems to me this is the root of > the problem. > > I got bitten

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. Ope

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 created this revision. jhuber6 added a reviewer: thakis. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. When we are creating jobs for

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. @thakis could you confirm that this works on your machine? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118858/new/ https://reviews.llvm.org/D118858 ___ cfe-commits mailing list

[PATCH] D118815: [Clang][Docs] Add documention for new OpenMP offloading driver

jhuber6 updated this revision to Diff 405654. jhuber6 added a comment. Some additions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118815/new/ https://reviews.llvm.org/D118815 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ClangL

[PATCH] D118815: [Clang][Docs] Add documention for new OpenMP offloading driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28ab5944cd75: [Clang][Docs] Add documention for new OpenMP offloading driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.

[PATCH] D118934: [OpenMP] Completely remove old device runtime

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, Meinersbur. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The linker wrapper tool uses the 'nv

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8161-8162 + if (CudaInstallation.isValid()) +CmdArgs.push_back(Args.MakeArgString( +"-cuda-path=" + CudaInstallation.getInstallPath())); +} Meinersbur wr

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405783. jhuber6 added a comment. Address style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-lin

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405785. jhuber6 added a comment. Decided to add break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/cl

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9138d96f8b01: [OpenMP] Don't use bound architecture when checking cache on the host (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405799. jhuber6 added a comment. Use long version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. In D118858#3295210 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt > > Please take a look and revert for now if it takes a while to fix. This fixed it on the mac I got to test it

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. In D118858#3295210 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Can you do me a favor and run the command

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc4ca95b02b: [OpenMP] Add Cuda path to linker wrapper tool (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118965/new/ https://reviews.llvm.org/D118965 __

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the '-Bsymbolic

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 updated this revision to Diff 406022. jhuber6 added a comment. Clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang/lib/Driver/

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 added a comment. In D119018#3297391 , @JonChesterfield wrote: > Can we drop an xfail in an existing test as part of this patch? We can drop an XFAIL for AMDGPU, but that's not related to the problem this fixes, we don't have any XFAIL lines for

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 updated this revision to Diff 406027. jhuber6 added a comment. More informative error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index:

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

This revision was automatically updated to reflect the committed changes. Closed by commit rGeeb29c8477d9: [OpenMP] Add -Bsymbolic to arguments for GNU linker (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://r

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. jhuber6 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. This patch adds support for linking CPU

[PATCH] D119638: [OpenMP][NFC] Simplify identifying the device bitcode library

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert. Herald added subscribers: kerbowa, guansong, yaxunl, jvesely. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Now that the old device runti

[PATCH] D119638: [OpenMP][NFC] Simplify identifying the device bitcode library

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e8077d285a: [OpenMP][NFC] Simplify identifying the device bitcode library (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D119638?vs=408193&id=408208#toc Repository: rG LLV

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jhuber6 updated this revision to Diff 408218. jhuber6 added a comment. Fixing LTO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119613/new/ https://reviews.llvm.org/D119613 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-linker

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a projec

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added a comment. I can't test this yet because the AMDGPU cluster is down for maintenance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.org/D119841 ___ cfe-commi

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove once AMDGPU has a proper math library. + for (auto &I : llvm::make_range(OpenMPTCRange.first, OpenMPTCRange.second))

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jhuber6 updated this revision to Diff 408904. jhuber6 added a comment. Add test for the arguments passed to the linker wrapper when doing host offloading. It will be more difficult to do a unit test for the internal operation of the linker wrapper because it is reactive to the data contained in th

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove once AMDGPU has a proper math library. + for (auto &I : llvm::make_range(OpenMPTCRange.first, OpenMPTCRange.second))

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG24ecafb41327: [OpenMP] Add support for CPU offloading in new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119613/new/ https:/

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 updated this revision to Diff 409043. jhuber6 added a comment. Removing `-lm` semantics so it is linked by default. Also adding the flag to the tested output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.or

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8205 +if (llvm::find(LibraryArgs, "m") == LibraryArgs.end() && !D.CCCIsCXX()) + continue; + JonChesterfield wrote: > jdoerfert wrote: > > JonChesterfield wrote: > > > jhuber

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG61fb260d9d8c: [OpenMP] Pass AMDGPU math libraries into the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ h

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added a comment. In D119841#3326638 , @JonChesterfield wrote: > This is asserting somewhere in clang-linker-wrapper, e.g. > https://lab.llvm.org/buildbot/#/builders/193/builds/6939 Yes, must be when we try to sort the device files. I'll revert

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG64ecdc1cb168: [OpenMP] Pass AMDGPU math libraries into the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ h

<    1   2   3   4   5   6   7   8   9   10   >