Author: rupprecht
Date: Thu Aug 16 09:55:07 2018
New Revision: 339899
URL: http://llvm.org/viewvc/llvm-project?rev=339899&view=rev
Log:
NFC: Test commit access
Testing commit access from a new machine, so using this as an opportunity to
revert my old test access commit (r336006) that I never cle
Author: rupprecht
Date: Wed Aug 29 17:04:34 2018
New Revision: 341002
URL: http://llvm.org/viewvc/llvm-project?rev=341002&view=rev
Log:
[AttrDocs] Fix build bots: add missing GNUInline pragma to test.
Modified:
cfe/trunk/test/Misc/pragma-attribute-supported-attributes-list.test
Modified: cfe
Author: rupprecht
Date: Tue Jul 24 13:28:07 2018
New Revision: 337850
URL: http://llvm.org/viewvc/llvm-project?rev=337850&view=rev
Log:
Revert "[VFS] Cleanups to VFS interfaces."
This reverts commit r337834 due to test failures.
Modified:
cfe/trunk/include/clang/Basic/VirtualFileSystem.h
sTests.cpp:953:
Failure
Value of: *Locations
Expected: has 1 element that is equal to 0:0-0:0@file:///clangd-test/foo.h
Actual: {}
>
> On Tue, Jul 24, 2018 at 10:28 PM Jordan Rupprecht via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rupprecht
>> Da
Author: rupprecht
Date: Fri Jul 27 13:02:58 2018
New Revision: 338157
URL: http://llvm.org/viewvc/llvm-project?rev=338157&view=rev
Log:
[libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4
Summary:
[libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4
r338122 cha
Hi Craig,
We're seeing issues building a few other things now; notably this part in
opencv:
https://github.com/opencv/opencv/blob/master/modules/core/src/system.cpp#L422
#ifdef _XCR_XFEATURE_ENABLED_MASK // requires immintrin.h
xcr0 = (int)_xgetbv(_XCR_XFEATURE_ENABLED_M
Thanks! I'll rebuild clang from trunk and give it another try.
Yes, for the second two, I think it should be a more straightforward fix a
la https://chromium-review.googlesource.com/c/v8/v8/+/1414858
On Fri, Jan 18, 2019 at 9:58 AM Topper, Craig
wrote:
> I just committed a change to go back to o
Confirmed that opencv builds now, thanks :)
On Fri, Jan 18, 2019 at 10:05 AM Jordan Rupprecht
wrote:
> Thanks! I'll rebuild clang from trunk and give it another try.
> Yes, for the second two, I think it should be a more straightforward fix a
> la https://chromium-review.googlesource.com/c/v8/v8
Author: rupprecht
Date: Mon Nov 12 10:15:04 2018
New Revision: 346687
URL: http://llvm.org/viewvc/llvm-project?rev=346687&view=rev
Log:
[clang-format] Support breaking consecutive string literals for TableGen
Summary:
clang-format can get confused by string literals in TableGen: it knows that
st
Author: rupprecht
Date: Thu Feb 28 11:16:45 2019
New Revision: 355123
URL: http://llvm.org/viewvc/llvm-project?rev=355123&view=rev
Log:
[clang-format][NFC] Allow getLLVMStyle() to take a language
Summary:
getLLVMStyle() sets the default style, but doesn't take the language as a
parameter, so can
Author: rupprecht
Date: Thu Feb 28 16:12:18 2019
New Revision: 355158
URL: http://llvm.org/viewvc/llvm-project?rev=355158&view=rev
Log:
[clang-format][TableGen] Don't add spaces around items in square braces.
Summary:
clang-formatting wants to add spaces around items in square braces, e.g. [1, 2]
Author: rupprecht
Date: Wed Mar 13 13:34:34 2019
New Revision: 356097
URL: http://llvm.org/viewvc/llvm-project?rev=356097&view=rev
Log:
[clang-format][NFC] Include TableGen in enum->string mapping used for debugging
Running `clang-format -debug` prints "Unknown" for tablegen files because of
thi
Author: rupprecht
Date: Wed Mar 13 14:13:01 2019
New Revision: 356099
URL: http://llvm.org/viewvc/llvm-project?rev=356099&view=rev
Log:
[clang-format] Propagate inferred language to getLLVMStyle() in
getPredefinedStyle()
rC355158 added an optional language parameter to getLLVMStyle(), but this
Author: rupprecht
Date: Tue Mar 19 13:55:14 2019
New Revision: 356517
URL: http://llvm.org/viewvc/llvm-project?rev=356517&view=rev
Log:
Fix CodeGen/arm64-microsoft-status-reg.cpp test
Summary: This test is failing after r356499 (verified with `ninja
check-clang-codegen`). Update the register sel
Author: rupprecht
Date: Wed Mar 20 14:01:56 2019
New Revision: 356614
URL: http://llvm.org/viewvc/llvm-project?rev=356614&view=rev
Log:
[clang][OpenMP] Fix build when using libgomp
Summary: rL356570 introduced a test which only passes with the default openmp
library, libomp, and fails with other
Author: rupprecht
Date: Wed Mar 20 15:51:56 2019
New Revision: 356623
URL: http://llvm.org/viewvc/llvm-project?rev=356623&view=rev
Log:
Revert "[clangd] Print arguments in template specializations"
This reverts commit 44a63f6a150dec72dea43730d2a89d292e58bd6f. It segfaults on
an internal test cas
Author: rupprecht
Date: Wed Mar 20 15:51:56 2019
New Revision: 356623
URL: http://llvm.org/viewvc/llvm-project?rev=356623&view=rev
Log:
Revert "[clangd] Print arguments in template specializations"
This reverts commit 44a63f6a150dec72dea43730d2a89d292e58bd6f. It segfaults on
an internal test cas
Author: rupprecht
Date: Thu Mar 21 12:13:22 2019
New Revision: 356700
URL: http://llvm.org/viewvc/llvm-project?rev=356700&view=rev
Log:
[clang][OpenMP] Fix another test when using libgomp.
Similarly to r356614, -fopenmp=libomp needs to be used for some omp-related AST
matching.
Modified:
cf
Author: rupprecht
Date: Mon May 6 14:55:05 2019
New Revision: 360086
URL: http://llvm.org/viewvc/llvm-project?rev=360086&view=rev
Log:
Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also
sink function calls without used results (PR41259)"
This reverts r357452 (git commit
> Interesting, what kind of failures?
>
> If they are causing you problems, of course feel free to revert.
>
> Dave
Turns out they are all real issues which running the test under asan
mode flags as global-buffer-overflow. I'm guessing the over-alignment
was hiding the bug as reads there would be
Author: rupprecht
Date: Wed Oct 3 16:40:04 2018
New Revision: 343744
URL: http://llvm.org/viewvc/llvm-project?rev=343744&view=rev
Log:
[llvm-nm] Update clang tests based on changed llvm-nm output
Modified:
cfe/trunk/test/CodeGen/thinlto_backend.ll
Modified: cfe/trunk/test/CodeGen/thinlto_ba
Author: rupprecht
Date: Wed Jun 19 10:43:58 2019
New Revision: 363848
URL: http://llvm.org/viewvc/llvm-project?rev=363848&view=rev
Log:
[clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart
These were removed a long time ago in r341573, but this test was missed because
Author: rupprecht
Date: Thu Jul 11 17:32:08 2019
New Revision: 365850
URL: http://llvm.org/viewvc/llvm-project?rev=365850&view=rev
Log:
Re-Revert Devirtualize destructor of final class.
This reverts r365509 (git commit d088720edad9c29ee0d622b5d69092e18a9ac0bd)
This is a second revert[1] due to f
Author: rupprecht
Date: Mon Jul 29 12:57:31 2019
New Revision: 367253
URL: http://llvm.org/viewvc/llvm-project?rev=367253&view=rev
Log:
[driver][test] Update as-options.s to not write to a readonly tree
The as-options.s test writes to the build tree as of r367165. Some build
systems configure th
Author: rupprecht
Date: Mon Jul 29 13:09:20 2019
New Revision: 367256
URL: http://llvm.org/viewvc/llvm-project?rev=367256&view=rev
Log:
[driver][test] Use /dev/null in as-options.s instead
Modified:
cfe/trunk/test/Driver/as-options.s
Modified: cfe/trunk/test/Driver/as-options.s
URL:
http://
Author: rupprecht
Date: Thu Jun 20 15:35:52 2019
New Revision: 363996
URL: http://llvm.org/viewvc/llvm-project?rev=363996&view=rev
Log:
[CodeGen][test] Use FileCheck variable matchers for better test support
Summary: Depending on how clang is built, it may discard the IR names and use
names like
Author: rupprecht
Date: Tue Oct 1 15:30:10 2019
New Revision: 373400
URL: http://llvm.org/viewvc/llvm-project?rev=373400&view=rev
Log:
[clang][OpenMP][NFC] #include GlobalDecl.h to avoid incomplete class type
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
Modified: cfe/trunk/lib/CodeGen/
Author: rupprecht
Date: Fri Jun 29 12:05:21 2018
New Revision: 336006
URL: http://llvm.org/viewvc/llvm-project?rev=336006&view=rev
Log:
Add a blank line to docs/README.txt test commit access
Subscribers: christof, cfe-commits
Differential Revision: https://reviews.llvm.org/D48785
Modified:
Author: rupprecht
Date: Fri Jun 29 12:05:20 2018
New Revision: 336005
URL: http://llvm.org/viewvc/llvm-project?rev=336005&view=rev
Log:
Revert "Support for multiarch runtimes layout"
This reverts commit 0c7cea3c0c6338b99e30c13201365a3dd4edc6f4.
Modified:
libunwind/trunk/CMakeLists.txt
Modif
Author: rupprecht
Date: Fri Jun 29 13:41:50 2018
New Revision: 336014
URL: http://llvm.org/viewvc/llvm-project?rev=336014&view=rev
Log:
Introduce a separate preprocessor macro, _LIBUNWIND_USE_DLADDR, for directly
controlling a dependency on dladdr(). This will allow us to use libunwind
without a
There's also a curious failure caused by this patch (confirmed
passing @r374287, failing @r374288):
$ cat /tmp/vectorize.cc
void a() {
#pragma clang loop vectorize(disable)
for (;;)
;
}
$ clang++ -Werror -O3 -c /tmp/vectorize.cc
/tmp/vectorize.cc:1:6: error: loop not interleaved: the optimi
On Mon, Oct 21, 2019 at 5:12 PM Michael Kruse
wrote:
> Am Mo., 21. Okt. 2019 um 16:01 Uhr schrieb Jordan Rupprecht via
> cfe-commits :
> > There's also a curious failure caused by this patch (confirmed passing
> @r374287, failing @r374288):
>
> It's a warning,
Author: Jordan Rupprecht
Date: 2019-10-24T16:35:45-07:00
New Revision: 6d424a161bf3e52730371da0b9439ed93a8ce406
URL:
https://github.com/llvm/llvm-project/commit/6d424a161bf3e52730371da0b9439ed93a8ce406
DIFF:
https://github.com/llvm/llvm-project/commit/6d424a161bf3e52730371da0b9439ed93a8ce406.di
Reverted in 6d424a161bf3e52730371da0b9439ed93a8ce406 due to the issue
described here. Should hopefully be a trivial fix forward.
On Tue, Oct 22, 2019 at 2:46 PM Michael Kruse
wrote:
> Am Mo., 21. Okt. 2019 um 23:44 Uhr schrieb Jordan Rupprecht
> :
> > At any rate, it sounds like this is not a co
rupprecht wrote:
ping :)
https://github.com/llvm/llvm-project/pull/73067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rupprecht wrote:
> Is this a performance optimization or a function al change?
Neither. This should only affect tests, and the set of tests we skip/mark as
xfail should not change, we just generally know about it earlier in the test
setup.
https://github.com/llvm/llvm-project/pull/73067
_
rupprecht wrote:
After this commit, I'm seeing another "out-of-line definition" error for
`operator=` on the following reduced snippet:
```c++
class Foo {};
template
struct Stuff;
template
struct Stuff {
Stuff& operator=(Stuff&& that);
};
template
using Alias = Stuff;
template
Alias&
rupprecht wrote:
Thanks to @MaskRay for handling the revert.
A reduction for the second `typename` breakage looks similar, so may be the
same underlying issue. But here it is anyway, in case it ends up being a second
bug in the patch:
```c++
class Foo {};
template
struct Ptr {};
template
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73067
>From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 17:28:30 -0800
Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early for
@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
+
+license
@@ -0,0 +1,45 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(default_visibility = ["//visibility:public"])
+
+license
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rupprecht wrote:
Thanks! Sorry about the delay, we should get the bzl tree setup for automatic
assignment to reviewers.
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
rupprecht wrote:
It looks like this caused some new `-Wextra-qualification` warnings
(playground: https://godbolt.org/z/3MbMjGYET)
```
namespace foo {
template
struct Z {};
template <>
struct Z {}; // OK
template <>
struct foo::Z {}; // New warning: extra qualification on member 'Z'
[-Wextr
rupprecht wrote:
Ok, thanks for the quick confirmation!
https://github.com/llvm/llvm-project/pull/78595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jordan Rupprecht
Date: 2024-01-24T21:17:45-08:00
New Revision: 96ec447a6ae39edff92674e9849de2bf21bfd430
URL:
https://github.com/llvm/llvm-project/commit/96ec447a6ae39edff92674e9849de2bf21bfd430
DIFF:
https://github.com/llvm/llvm-project/commit/96ec447a6ae39edff92674e9849de2bf21bfd430.di
Author: Jordan Rupprecht
Date: 2024-01-24T21:17:45-08:00
New Revision: 96ec447a6ae39edff92674e9849de2bf21bfd430
URL:
https://github.com/llvm/llvm-project/commit/96ec447a6ae39edff92674e9849de2bf21bfd430
DIFF:
https://github.com/llvm/llvm-project/commit/96ec447a6ae39edff92674e9849de2bf21bfd430.di
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73067
>From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 17:28:30 -0800
Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early for
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/73067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Artem Belevich
Date: 2021-02-19T09:57:21-08:00
New Revision: 1a368ae3b78dd7a364e8f17658fddaf86b1e98db
URL:
https://github.com/llvm/llvm-project/commit/1a368ae3b78dd7a364e8f17658fddaf86b1e98db
DIFF:
https://github.com/llvm/llvm-project/commit/1a368ae3b78dd7a364e8f17658fddaf86b1e98db.diff
Author: Jordan Rupprecht
Date: 2023-02-03T08:49:34-08:00
New Revision: 74ce297045bac4bc475b8e762d2a1ea19bb16d3c
URL:
https://github.com/llvm/llvm-project/commit/74ce297045bac4bc475b8e762d2a1ea19bb16d3c
DIFF:
https://github.com/llvm/llvm-project/commit/74ce297045bac4bc475b8e762d2a1ea19bb16d3c.di
Author: Jordan Rupprecht
Date: 2023-01-12T13:40:47-08:00
New Revision: 3432f4bf86e7c77666ae9dede1610ae843dde648
URL:
https://github.com/llvm/llvm-project/commit/3432f4bf86e7c77666ae9dede1610ae843dde648
DIFF:
https://github.com/llvm/llvm-project/commit/3432f4bf86e7c77666ae9dede1610ae843dde648.di
Author: Jordan Rupprecht
Date: 2019-12-18T16:51:55-08:00
New Revision: 553a727f5f6407fb6db7ac2dae5f5b2a536d38fc
URL:
https://github.com/llvm/llvm-project/commit/553a727f5f6407fb6db7ac2dae5f5b2a536d38fc
DIFF:
https://github.com/llvm/llvm-project/commit/553a727f5f6407fb6db7ac2dae5f5b2a536d38fc.di
Author: Jordan Rupprecht
Date: 2020-02-06T17:59:15-08:00
New Revision: fafddbd956dbe439787f6d717c247e648bb07ff5
URL:
https://github.com/llvm/llvm-project/commit/fafddbd956dbe439787f6d717c247e648bb07ff5
DIFF:
https://github.com/llvm/llvm-project/commit/fafddbd956dbe439787f6d717c247e648bb07ff5.di
Author: Jordan Rupprecht
Date: 2020-02-12T08:17:01-08:00
New Revision: 60a8a504f16dbbc5f2a6887ecb668ef4cb834949
URL:
https://github.com/llvm/llvm-project/commit/60a8a504f16dbbc5f2a6887ecb668ef4cb834949
DIFF:
https://github.com/llvm/llvm-project/commit/60a8a504f16dbbc5f2a6887ecb668ef4cb834949.di
Author: Jordan Rupprecht
Date: 2023-04-26T05:28:15-07:00
New Revision: 8b39527535ff50837da08509392e3268fb6129f0
URL:
https://github.com/llvm/llvm-project/commit/8b39527535ff50837da08509392e3268fb6129f0
DIFF:
https://github.com/llvm/llvm-project/commit/8b39527535ff50837da08509392e3268fb6129f0.di
Author: Jordan Rupprecht
Date: 2022-12-12T10:11:19-08:00
New Revision: fc7b8e71312f89986be1a7cc67377a2decfcf337
URL:
https://github.com/llvm/llvm-project/commit/fc7b8e71312f89986be1a7cc67377a2decfcf337
DIFF:
https://github.com/llvm/llvm-project/commit/fc7b8e71312f89986be1a7cc67377a2decfcf337.di
Author: Jordan Rupprecht
Date: 2022-12-15T20:38:32-08:00
New Revision: 5a06334c51aa75d7f044785a495cf2de5bf13a9c
URL:
https://github.com/llvm/llvm-project/commit/5a06334c51aa75d7f044785a495cf2de5bf13a9c
DIFF:
https://github.com/llvm/llvm-project/commit/5a06334c51aa75d7f044785a495cf2de5bf13a9c.di
rupprecht wrote:
The last time I followed this attempt was https://reviews.llvm.org/D150226,
where there was objection because it was ignored in system headers, so
effectively impossible to discover how widespread this is. When did this become
unignored in system headers?
I remember fixing al
rupprecht wrote:
> > The last time I followed this attempt was https://reviews.llvm.org/D150226,
> > where there was objection because it was ignored in system headers, so
> > effectively impossible to discover how widespread this is. When did this
> > become unignored in system headers?
>
>
rupprecht wrote:
> Since boost/mpl is at the core of issues and many projects depend directly or
> transitively on it, I think it might be good to wait until version 1.86 is
> released, so people can bump to a release version instead of trunk.
>
> It should be around the corner,
> [AFAICS](ht
rupprecht wrote:
This commit appears to regress an example like this:
```c++
template
struct Foo {
template
int bar(X x) {
return 0;
}
template <>
int bar(int x) {
return bar(5.0);
}
};
void call() {
Foo f;
f.bar(1);
}
```
Used to compile, now results in an error:
``
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/88258
This test just checks for the stdout/stderr of clang, but it incidentally tries
to write to `a.out` in the current directory, which may be write protected.
Typically one would write `clang -o %t.o` for a write
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/88258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/87847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rupprecht wrote:
Still seeing a few more failures, although the original repro is now working.
```c++
struct Base {
int BaseFunc(int x) { return 0; }
int val;
};
template
struct Foo : Base {
template
int bar(X x) {
return BaseFunc(val); // OK
}
template <>
@@ -12,7 +12,7 @@
// RUN: --sysroot=%S/Inputs/mips_mti_linux/sysroot \
// RUN: | FileCheck --check-prefix=CHECK-BE-HF-32R2 %s
//
-// CHECK-BE-HF-32R2: "{{[^"]*}}clang{{[^"]*}}" {{.*}} "-triple"
"mips-mti-linux"
rupprecht wrote:
Instead of changing the c
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/94349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/94349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/89167
Using OptTable to parse will allow including this tool in llvm-driver.
Because CommonOptionsParser is widely used and makes use of `cl::opt` flags, it
needs to be refactored to handle both. The existing
`Comm
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/89260
The `LLDB_TEST_USE_VENDOR_PACKAGES` has defaulted to `Off` for a while. Either
installing `pexpect` or skipping those tests with
`-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` seems to be enough that we can
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/89260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/99731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jordan Rupprecht
Date: 2022-01-25T14:29:35-08:00
New Revision: 493509a40ad1653feb779861badd3ee59fc4a79c
URL:
https://github.com/llvm/llvm-project/commit/493509a40ad1653feb779861badd3ee59fc4a79c
DIFF:
https://github.com/llvm/llvm-project/commit/493509a40ad1653feb779861badd3ee59fc4a79c.di
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/113892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/113892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,17 @@
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fPIC -fxray-instrument
-fxray-shared -c %s -o /dev/null 2>&1 | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fpic -fxray-instrument
-fxray-shared -c %s -o /dev/null 2>&1 | FileCheck %
@@ -0,0 +1,17 @@
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fPIC -fxray-instrument
-fxray-shared -c %s -o /dev/null 2>&1 | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fpic -fxray-instrument
-fxray-shared -c %s -o /dev/null 2>&1 | FileCheck %
https://github.com/rupprecht commented:
Bazel changes LGTM. Updating them is totally not necessary, but appreciated if
you do. Thanks!
https://github.com/llvm/llvm-project/pull/108988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
rupprecht wrote:
> AFAIK the bazel build scripts are externally automatically updated based on
> the cmake scripts, so I don't think we should be touching them.
Bazel files are not updated automatically. Updating them in the same commit is
fine (but not required).
GN files are updated by the
@@ -1,49 +1,49 @@
// REQUIRES: x86-registered-target, amdgpu-registered-target
// Fail on invalid ROCm Path.
-// RUN: not %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
--offload-arch=gfx908:xnack+ -fsanitize=address -fgpu-sanitize -nogpuinc
--rocm-path=%S/Inputs/r
@@ -1,49 +1,49 @@
// REQUIRES: x86-registered-target, amdgpu-registered-target
// Fail on invalid ROCm Path.
-// RUN: not %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
--offload-arch=gfx908:xnack+ -fsanitize=address -fgpu-sanitize -nogpuinc
--rocm-path=%S/Inputs/r
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/125891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/119319
755519f7f661375be05750001ff11e106e6b7f87 added a test that uses `-fopenmp`. The
default configuration of CLANG_DEFAULT_OPENMP_RUNTIME is libomp, which causes
`-fopenmp` to act as `-fopenmp=libomp`. In turn, t
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/119319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/119285
afa2fbf87a8e3fff609fd325c938929c48e94280 adds a test which can fail with
`error: unable to open output file 'fixed-register-global.o': 'Permission
denied'`. We don't check the output file at all, so just use
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/119448
cc1a2ea61e3f8e790125b10d9ec4e7d179156ddf adds a test which can fail if the
output directory is not writeable. Following the pattern of other tests in this
package, use `-o -` to print the IR to stdout instead
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/119448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rupprecht wrote:
Thanks! The issues I mentioned on #120449 seem to be covered by tests, so LGTM.
I will defer to others for a more qualified review though.
https://github.com/llvm/llvm-project/pull/121943
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/123140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rupprecht wrote:
I can't comment on the contents of this fix, but I patched it in and the crash
no longer reproduces on the original target I saw this in. I think this also
takes care of the targets that @alexfh reported.
https://github.com/llvm/llvm-project/pull/133113
___
rupprecht wrote:
> The reduced test case:
>
> ```
> template
> struct A;
> template
> struct A {};
> template
> void e(T) {
> A f;
> }
> struct S {
> struct C {
> void h(int &, S *);
> };
> void i() { e(&C::h); }
> };
> ```
>
> https://gcc.godbolt.org/z/8Pq9EWbTv
That's the same
rupprecht wrote:
Still seeing a crash even with the latest fix applied
```
assertion failed at clang/include/clang/AST/Type.h:945 in const
ExtQualsTypeCommonBase *clang::QualType::getCommonPtr() const: !isNull() &&
"Cannot retrieve a NULL type pointer"
*** Check failure stack trace: ***
@
96 matches
Mail list logo
