Re: Change Request

On 3/10/16 9:38 AM, Wes Witt via cfe-commits wrote: I would like to submit the attached changes for your approval. Gentle etiquette suggestion: please title your emails with something more descriptive. In this case, something like: "[PATCH] Windows support for ObjC codegen". And then in the

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

jroelofs added a comment. This is awesome! LGTM with one nit: add a newline between each function definition, and two between each class. It's a little crowded without that. http://reviews.llvm.org/D15813 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

jroelofs added a comment. > This patch makes it easier to support running the lit tests for new and > unusual platforms. It will break existing users that set LIBCXX_TARGET_INFO > to anything other than the default. I think this is fine, because the old > LIBCXX_TARGET_INFO wasn't terribly usef

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. FOAD: Ball's in @mclow.lists's court, not mine. I don't feel comfortable signing off on this. http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [libcxx] r257422 - Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right place.

On 1/11/16 5:38 PM, Marshall Clow via cfe-commits wrote: Author: marshall Date: Mon Jan 11 18:38:04 2016 New Revision: 257422 URL: http://llvm.org/viewvc/llvm-project?rev=257422&view=rev Log: Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right place. Modified:

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs updated this revision to Diff 44648. jroelofs added a comment. Address review comments. http://reviews.llvm.org/D15528 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/ClangTi

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs marked 9 inline comments as done. jroelofs added a comment. http://reviews.llvm.org/D15528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. In http://reviews.llvm.org/D15528#312031, @alexfh wrote: > Thank you for explaining. The use case seems to be important enough to > support it. And the solution seems to be good for now. A few concerns: > > 1. `Werrors` isn't a good name for this. The only reason why a

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs updated this revision to Diff 44650. jroelofs added a comment. Added docs. http://reviews.llvm.org/D15528 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/ClangTidyOptions.cpp

Re: r257533 - D9600: Add scan-build python implementation

On 1/12/16 3:38 PM, Laszlo Nagy via cfe-commits wrote: Author: rizsotto Date: Tue Jan 12 16:38:41 2016 New Revision: 257533 URL: http://llvm.org/viewvc/llvm-project?rev=257533&view=rev Log: D9600: Add scan-build python implementation Yay! ___ cf

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs updated this revision to Diff 44759. jroelofs added a comment. clang-format the patch, and rename method. http://reviews.llvm.org/D15528 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

[clang-tools-extra] r257642 - Teach clang-tidy how to upgrade warnings into errors.

Author: jroelofs Date: Wed Jan 13 11:36:41 2016 New Revision: 257642 URL: http://llvm.org/viewvc/llvm-project?rev=257642&view=rev Log: Teach clang-tidy how to upgrade warnings into errors. Similar in format to the `-checks=` argument, this new `-warnings-as-errors=` argument upgrades any warnings

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs marked 2 inline comments as done. jroelofs added a comment. Thanks for the review! Committed r257642. http://reviews.llvm.org/D15528 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs abandoned this revision. jroelofs added a comment. Hmm. There's no "close revision" button. Abandoning it in lieu of closing it. http://reviews.llvm.org/D15528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[libcxx] r257707 - Tame a -Wunknown-attributes warning

Author: jroelofs Date: Wed Jan 13 17:27:08 2016 New Revision: 257707 URL: http://llvm.org/viewvc/llvm-project?rev=257707&view=rev Log: Tame a -Wunknown-attributes warning Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-project

Re: [clang-tools-extra] r258327 - Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use

On 1/20/16 11:53 AM, Dimitry Andric via cfe-commits wrote: Author: dim Date: Wed Jan 20 12:53:44 2016 New Revision: 258327 URL: http://llvm.org/viewvc/llvm-project?rev=258327&view=rev Log: Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use the same temporary file, otherwise

Re: [PATCH] D16613: Use LLVM's CheckAtomic cmake module to figure out whether we need to link with libatomic.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

On 1/29/16 11:51 AM, Serge Pavlov via cfe-commits wrote: Can somebody have a look at this fix? Thank you! Testcase? --Serge 2016-01-11 23:50 GMT+06:00 Serge Pavlov mailto:sepavl...@gmail.com>>: Any feedback? Thanks, --Serge 2015-12-11 20:24 GMT+06:00 Serge Pavlov mailto

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

On 1/29/16 12:50 PM, Serge Pavlov wrote: Crash is observed when HandleTranslation unit is not called, clang always calls this method but a clang based project may don't call it if it is not needed. I saw the crash in such project and used this patch to fix it. I do not know how to make a regres

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

jroelofs added a subscriber: jroelofs. jroelofs added a comment. `CommonStuff.pm` (which could stand to have a more descriptive name, `libscanbuild.pm` maybe?) and `scan-build.cfg` belong in `share`. http://reviews.llvm.org/D14629 ___ cfe-commits m

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

jroelofs added a comment. Also, how is this different from `-analyzer-config`? http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

jroelofs added a comment. Actually, now that I think about it more, `scan-build.cfg` doesn't belong in share at all. The location of an instance of it should be read in via a command-line argument, and it shouldn't be installed. http://reviews.llvm.org/D14629 ___

r252977 - [scan-view] Rename 'Resources' --> 'share'

Author: jroelofs Date: Thu Nov 12 18:25:04 2015 New Revision: 252977 URL: http://llvm.org/viewvc/llvm-project?rev=252977&view=rev Log: [scan-view] Rename 'Resources' --> 'share' Added: cfe/trunk/tools/scan-view/share/ - copied from r252671, cfe/trunk/tools/scan-view/Resources/ Removed:

r252981 - [scan-build] Create share directory similar to scan-view's

Author: jroelofs Date: Thu Nov 12 18:32:54 2015 New Revision: 252981 URL: http://llvm.org/viewvc/llvm-project?rev=252981&view=rev Log: [scan-build] Create share directory similar to scan-view's Added: cfe/trunk/tools/scan-build/share/ cfe/trunk/tools/scan-build/share/scanview.css -

r252991 - Fix build

Author: jroelofs Date: Thu Nov 12 19:23:40 2015 New Revision: 252991 URL: http://llvm.org/viewvc/llvm-project?rev=252991&view=rev Log: Fix build Modified: cfe/trunk/tools/scan-view/CMakeLists.txt Modified: cfe/trunk/tools/scan-view/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe

Re: r253016 - scan-build: Fix install.

On 11/12/15 11:48 PM, NAKAMURA Takumi via cfe-commits wrote: Author: chapuni Date: Fri Nov 13 00:48:02 2015 New Revision: 253016 URL: http://llvm.org/viewvc/llvm-project?rev=253016&view=rev Log: scan-build: Fix install. My bad... thanks! Jon Modified: cfe/trunk/tools/scan-build/CMa

r253068 - [scan-build] Move non user-facing utilities to share

Author: jroelofs Date: Fri Nov 13 13:56:07 2015 New Revision: 253068 URL: http://llvm.org/viewvc/llvm-project?rev=253068&view=rev Log: [scan-build] Move non user-facing utilities to share Added: cfe/trunk/tools/scan-view/share/Reporter.py - copied unchanged from r253045, cfe/trunk/tools

r253081 - Fix build... again

Author: jroelofs Date: Fri Nov 13 15:04:14 2015 New Revision: 253081 URL: http://llvm.org/viewvc/llvm-project?rev=253081&view=rev Log: Fix build... again Modified: cfe/trunk/tools/scan-build/Makefile Modified: cfe/trunk/tools/scan-build/Makefile URL: http://llvm.org/viewvc/llvm-project/cfe/

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. Thanks for re-uploading! Comment at: tools/scan-build-py/README.md:39 @@ +38,3 @@ + +$ python setup.py build +$ python setup.py install Mind adding a CMakeLists.txt to drive these from the clang build itself? C

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

jroelofs added a subscriber: jroelofs. jroelofs added a comment. testcase? http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

jroelofs added a comment. hHave a look at the svn-blame for this file, then find other commits which changed this part of the file, and see where those commits added tests. http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D14130: Delete dead code in the LibcxxAndAbiBuilder

jroelofs closed this revision. jroelofs added a comment. r253480 http://reviews.llvm.org/D14130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14616: [libcxx] Replace TEST_HAS_NO_EXCEPTIONS with _LIBCPP_NO_EXCEPTIONS [NFC]

jroelofs requested changes to this revision. jroelofs added a comment. This revision now requires changes to proceed. This change is not the right thing to do. The reason this is a separate macro is that we don't want the tests in `test/std` to depend on implementation details of libcxx itself.

Re: r253486 - Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and on platforms that do not support it, use of thread_local causes an error. Since there'

On 11/18/15 11:37 AM, Aaron Ballman via cfe-commits wrote: Author: aaronballman Date: Wed Nov 18 12:37:29 2015 New Revision: 253486 URL: http://llvm.org/viewvc/llvm-project?rev=253486&view=rev Log: Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS,

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. Sounds reasonable and I can help with setting up the CMake & LIT goop once you've got it committed. FWIW, I was able to get a simple example workin

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

jroelofs added inline comments. Comment at: include/__noexcept:22 @@ +21,3 @@ +template +inline void throw_helper(T t, const char *msg = nullptr) +{ We're not allowed to pollute the global namespace. This must be prefixed with `__`. http://reviews.llvm.org/D146

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

jroelofs added inline comments. Comment at: include/__noexcept:19 @@ +18,3 @@ + +void __libcxx_noexceptions_abort(); +#endif // _LIBCPP_NO_EXCEPTIONS Make this: void __attribute__((weak)) __libcxx_noexceptions_abort(); Comment at: include/__

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

jroelofs added inline comments. Comment at: include/__noexcept:19 @@ +18,3 @@ + +void __libcxx_noexceptions_abort(); +#endif // _LIBCPP_NO_EXCEPTIONS jroelofs wrote: > Make this: > > void __attribute__((weak)) __libcxx_noexceptions_abort(); I meant to write:

Re: [PATCH] D14800: Honor system specific paths of MAN pages

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D14800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

jroelofs added a subscriber: EricWF. jroelofs added a comment. I don't have any more comments, but I don't feel comfortable LGTM-ing this. I'll save that for Eric or Marshall. Comment at: test/support/noexcept.h:14 @@ +13,3 @@ +#include +#include + s/http://rev

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added inline comments. Comment at: tools/scan-build-py/libear/__init__.py:1 @@ +1,2 @@ +# -*- coding: utf-8 -*- +# The LLVM Compiler Infrastructure rizsotto.mailinglist wrote: > dcoughlin wrote: > > How does this file fit into the over

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

jroelofs added a comment. Are you aware of http://reviews.llvm.org/D9600 ? http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9600: Add scan-build python implementation

On 11/21/15 9:50 AM, Devin Coughlin wrote: dcoughlin added a comment. Thanks Laszlo! Is there a more descriptive name than "intercept-build" (I realize scan-build is pretty general too). It seems to me the point of the intercept-build tool is to generate the compilation database. I think it w

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/__locale:411-415 @@ -410,7 +410,3 @@ #else -#if defined(_LIBCPP_HAS_MUSL_LIBC) -typedef unsigned short mask; -#else typedef unsigned lon

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

jroelofs requested changes to this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision now requires changes to proceed. I'm getting a couple of test failures from this patch: Clang :: Driver/linux-header-search.cpp Clang :: Driver/solaris-header-search.cpp

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added inline comments. Comment at: tools/scan-build-py/libscanbuild/driver.py:67 @@ +66,3 @@ +except Exception: +logging.exception("Something unexpected had happened.") +return 127 dcoughlin wrote: > rizsotto.mailinglist wrote: > > jro

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

jroelofs added inline comments. Comment at: test/support/noexcept.h:10 @@ +9,3 @@ +//===--===// +#ifdef _LIBCPP_NO_EXCEPTIONS + You should also add a header guard so that this doesn't get confused

Re: [PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

jroelofs added a subscriber: jroelofs. Comment at: lib/AST/ASTContext.cpp:429 @@ -432,2 +428,3 @@ + auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo); return CFC; } return new ... Repository: rL LLVM http://reviews.llvm.org/D15

Re: [PATCH] D15370: [scan-view] replace deprecated optparse with argparse

jroelofs added a comment. Looks reasonable to me from a "I haven't actually tried it with this patch" perspective. http://reviews.llvm.org/D15370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers]

jroelofs added a comment. Can you write up a couple of testcases for the new diagnostic? There should be some examples you can follow in clang/test/Sema ans clang/test/SemaCXX. I'd also be interested in seeing a concrete example of the setter thing you were talking about in ObjC/ObjC++. http:

[PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs created this revision. jroelofs added a reviewer: aaron.ballman. jroelofs added a subscriber: cfe-commits. http://reviews.llvm.org/D15528 Files: tools/llvm-project/extra/clang-tidy/ClangTidy.cpp tools/llvm-project/extra/clang-tidy/ClangTidy.h tools/llvm-project/extra/clang-tidy/Cla

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added inline comments. Comment at: tools/llvm-project/extra/clang-tidy/ClangTidy.cpp:119 @@ +118,3 @@ + if (Error.IsWError) { +Name += ", -Werrors="; +Level = DiagnosticsEngine::Error; hardcoding happens here ^ Comme

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. In http://reviews.llvm.org/D15528#311019, @alexfh wrote: > Jonathan, can you explain what specific use case does this patch address? Why > one severity level of native clang-tidy warnings (the current situation) is > not enough, and two levels are enough? I have out-

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added inline comments. Comment at: tools/llvm-project/extra/test/clang-tidy/werrors-plural.cpp:7 @@ +6,3 @@ +// CHECK-WARN: warning: namespace 'j' not terminated with a closing comment [llvm-namespace-comment] +// CHECK-WERR: error: namespace 'j' not terminated with a cl

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. In http://reviews.llvm.org/D15528#311135, @alexfh wrote: > In http://reviews.llvm.org/D15528#311053, @jroelofs wrote: > > > In http://reviews.llvm.org/D15528#311019, @alexfh wrote: > > > > > Jonathan, can you explain what specific use case does this patch address? > > >

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added subscribers: howard.hinnant, jroelofs. jroelofs added a comment. Could these large padding things be related to the fact that the test is used as a performance check for the implementation? That being said, I have no idea who is paying attention to the numbers that come out of thi

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. What does having them be `long double`s give over just multiplying the counts by 16 (or however big it is on your platform)? Alignment? Seems like it'd be better to start with a prime that's ~16x larger, say 211, than to have that factor of 16 floating around everywher

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. In http://reviews.llvm.org/D15539#312332, @bcraig wrote: > In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > > > What does having them be `long double`s give over just multiplying the > > counts by 16 (or however big it is on your platform)? Alignment? > > >

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. In http://reviews.llvm.org/D15539#312336, @jroelofs wrote: > In http://reviews.llvm.org/D15539#312332, @bcraig wrote: > > > In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > > > > > What does having them be `long double`s give over just multiplying the > > >

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

jroelofs added inline comments. Comment at: test/libcxx/test/config.py:364 @@ +363,3 @@ +deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and +cxx_abi == 'none' and +not use_llvm_unwinder) --

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. Thanks for the review! I'll rework this a bit early next week. http://reviews.llvm.org/D15528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12834: add gcc abi_tag support

jroelofs added a subscriber: jroelofs. jroelofs added a comment. In http://reviews.llvm.org/D12834#305787, @sberg wrote: > I can't figure out how to add code to someone else's Phabricator review, so > sent it to the mailing list > instead: >

<    1   2   3