jroelofs added a subscriber: jroelofs.
Comment at: lib/Driver/ToolChains.cpp:3535
@@ -3534,1 +3534,3 @@
+static std::string DetectLibcxxIncludePath(const std::string &base) {
+ std::error_code EC;
StringRef instead?
Comment at: lib/Driver/Tool
jroelofs added a comment.
@blastrock have you committed this yet?
http://reviews.llvm.org/D9639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
Ah, usually the process is that you get your patch through review, and when
someone accepts it, then you can commit it. If you do not have commit rights,
then you can get someone else to commit it for you.
Accepted => "ok to commit"
Closed => "I've committed it"
Do yo
Author: jroelofs
Date: Thu Aug 27 12:47:34 2015
New Revision: 246168
URL: http://llvm.org/viewvc/llvm-project?rev=246168&view=rev
Log:
Do not include pthread.h and sched.h when threads are disabled
Patch by Philippe Daouadi!
http://reviews.llvm.org/D9639
Modified:
libcxx/trunk/include/__mut
jroelofs accepted this revision.
jroelofs added a comment.
r246168
http://reviews.llvm.org/D9639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
In http://reviews.llvm.org/D11963#234789, @EricWF wrote:
> Copy the headers to the build directory during every build instead of just
> during CMake configuration.
Sounds like this would cause every build to effectively be a full build. I
don't think we want that...
jroelofs added a comment.
In http://reviews.llvm.org/D11963#236045, @EricWF wrote:
> So that's not what happens but that's because libc++ builds using the headers
> in the source directory. During the build all of the macros in the
> __config_site file are manually defined on the command line s
jroelofs added a comment.
Without the context of this review, this strategy probably won't make any
sense. So it's probably worth capturing these notes in a comment that describes
why we're doing it that way.
http://reviews.llvm.org/D11963
___
cfe
jroelofs added a comment.
In http://reviews.llvm.org/D12512#236988, @majnemer wrote:
> In http://reviews.llvm.org/D12512#236987, @EricWF wrote:
>
> > In http://reviews.llvm.org/D12512#236984, @majnemer wrote:
> >
> > > Wouldn't this change be problematic if you threw to code which was
> > > stat
jroelofs added a subscriber: jroelofs.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
The lifetime of `P` ends here, yet a reference to it lives on because of the `=
P.str()`. Using it later on line
jroelofs added inline comments.
Comment at: utils/gen_link_script/gen_link_script.py:1
@@ +1,2 @@
+#!/usr/bin/env python
+import os
Do you foresee these linker scripts being significantly more complicated for
other platforms? ISTM that it would be much simpler to
jroelofs added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
kromanova wrote:
> jroelofs wrote:
> > The lifetime of `P` ends here, yet a reference to it lives on because of
> > the
On 9/4/15 2:45 PM, Yuri Gribov via cfe-commits wrote:
Hi all,
According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang
gets built on OS X we need to build it with libcxx and libcxxabi
(otherwise tests will fail to link with "can't find iostream". This
patch adds a note to getting
On 9/4/15 2:55 PM, Yuri Gribov wrote:
On Fri, Sep 4, 2015 at 11:49 PM, Jonathan Roelofs
mailto:jonat...@codesourcery.com>> wrote:
On 9/4/15 2:45 PM, Yuri Gribov via cfe-commits wrote:
Hi all,
According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when
Clang
jroelofs added a comment.
I trust your judgement.
http://reviews.llvm.org/D12508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I don't think it's correct to say that `!defined(__GLIBC__) &&
defined(__linux__) ==> Musl` (nor is the converse true). Unfortunately, Musl
intentionally doesn't provide that sort of macro [1], so to provide support for
Musl in l
jroelofs added a comment.
LGTM, with one small nit (and once http://reviews.llvm.org/D13407 lands):
Comment at: src/locale.cpp:1176
@@ -1171,3 +1175,3 @@
}
-#endif // __GLIBC__ || __EMSCRIPTEN__ || __NETBSD__
+#endif // __GLIBC__ || __NETBSD__ || || __EMSCRIPTEN__ ||
defined(_
jroelofs added a comment.
Other than that, LGTM too.
Comment at: lib/Driver/ToolChains.cpp:4081
@@ +4080,3 @@
+
+ std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir + "/../..");
+
Use `llvm::sys::path::append` instead of `std::string::operator+` for
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
http://reviews.llvm.org/D13407 has landed.
http://reviews.llvm.org/D13673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
One small suggestion. Otherwise, this still LGTM.
Comment at: lib/Driver/ToolChains.cpp:4078
@@ +4077,3 @@
+ // should be /host_tools/bin.
+ const char *EnvValue = getenv("SCE_PS4_S
jroelofs added inline comments.
Comment at: include/__config:370
@@ -369,2 +369,3 @@
#elif defined(__linux__)
-#include
+#if defined(__GLIBC__)
+# include
EricWF wrote:
> Where does the `__GLIBC__` macro definition come from? I thought it came
> from the C li
jroelofs added a subscriber: jroelofs.
Comment at: include/__config_site.in:13
@@ -12,1 +12,3 @@
+#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@
+#cmakedefine _LIBCPP_ABI_UNSTABLE
This doesn't look right to me. What do you want this to expand to when it
jroelofs added inline comments.
Comment at: include/__config_site.in:13
@@ -12,1 +12,3 @@
+#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@
+#cmakedefine _LIBCPP_ABI_UNSTABLE
jroelofs wrote:
> This doesn't look right to me. What do you want this to expand
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
jroelofs added inline comments.
Comment at: CMakeLists.txt:71
@@ -70,1 +70,3 @@
+# Use a static copy of the ABI library when linking libc++. This option
+# cannot be used with LIBCXX_ENABLE_ABI_LINKER_SCRIPT.
option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY "Statically link the ABI librar
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
jroelofs added inline comments.
Comment at: test/libcxx/test/config.py:364
@@ +363,3 @@
+deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and
+cxx_abi == 'none' and
+not use_llvm_unwinder)
--
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D13820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 10/22/15 2:50 PM, Eric Fiselier via cfe-commits wrote:
Author: ericwf
Date: Thu Oct 22 15:50:07 2015
New Revision: 251062
URL: http://llvm.org/viewvc/llvm-project?rev=251062&view=rev
Log:
Disable linker scripts when the ABI library is not specified or is none.
Modified:
libcxx/trunk/C
On 10/22/15 2:59 PM, Eric Fiselier wrote:
Yeah, that review hasn't landed yet. It should be called auto, but we
need to make it actually "automatic". Currently "none" really means
don't help me, not that we will automatically figure it out for you. I
agree with your requested change, it's just
jroelofs added a comment.
LGTM
Comment at: lib/Driver/ToolChains.cpp:3545
@@ +3544,3 @@
+!VersionText.slice(1, StringRef::npos).getAsInteger(10, Version)) {
+ if (Version > MaxVersion) {
+MaxVersion = Version;
Since you've got logic here to
jroelofs added inline comments.
Comment at: src/fallback_malloc.ipp:69
@@ -59,1 +68,3 @@
+// Size: 4
+// Alignment: 2
struct heap_node {
EricWF wrote:
> compnerd wrote:
> > Make this a set of static_asserts?
> I was going to but I wasn't 100% sure this would be t
jroelofs created this revision.
jroelofs added a reviewer: EricWF.
jroelofs added a subscriber: cfe-commits.
Now that we store this information in the __config file, these aren't needed.
http://reviews.llvm.org/D14130
Files:
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
Index: zorg/buildbot/b
jroelofs added a subscriber: jroelofs.
Comment at: buildbot/osuosl/master/config/builders.py:771
@@ +770,3 @@
+ # the -fno-exceptions library build.
+ additional_features={'no-libcxx-tests'}),
+ 'category': 'libcxx'},
How bad is the
jroelofs added a comment.
> Counter proposal, we mark all the currently failing (-fno-exceptions) test
> cases with:
>
> // XFAIL: libcpp-no-exceptions
>
>
> This has the following advantages:
>
> - No need to change buildbots to skip tests
> - The bots will catch any regressions
jroelofs created this revision.
jroelofs added reviewers: zaks.anna, beanz.
jroelofs added a subscriber: cfe-commits.
http://reviews.llvm.org/D14403
Files:
tools/CMakeLists.txt
tools/Makefile
tools/scan-build/scan-build
tools/scan-view/Reporter.py
tools/scan-view/ScanView.py
Index: too
jroelofs updated this revision to Diff 39439.
jroelofs added a comment.
Update www too.
http://reviews.llvm.org/D14403
Files:
tools/CMakeLists.txt
tools/Makefile
tools/scan-build/scan-build
tools/scan-view/Reporter.py
tools/scan-view/ScanView.py
www/analyzer/installation.html
Index
jroelofs added inline comments.
Comment at: www/analyzer/installation.html:103
@@ -102,3 +102,1 @@
-Currently these are not installed using make install, and
-are located in $(SRCDIR)/tools/clang/tools/scan-build and
@zaks.anna Do you know if there was a particu
jroelofs updated this revision to Diff 39529.
jroelofs added a comment.
Forgot to `svn add` after rebasing the patch on top of upstream.
http://reviews.llvm.org/D14403
Files:
tools/CMakeLists.txt
tools/Makefile
tools/scan-build/CMakeLists.txt
tools/scan-build/Makefile
tools/scan-build
jroelofs added a comment.
In http://reviews.llvm.org/D14403#284054, @beanz wrote:
> I would prefer if installing these were optional and could be toggled on/off.
I'll add flags for that.
http://reviews.llvm.org/D14403
___
cfe-commits mailing list
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
jroelofs updated this revision to Diff 39693.
jroelofs added a comment.
Add flags to turn the new targets off.
http://reviews.llvm.org/D14403
Files:
tools/CMakeLists.txt
tools/Makefile
tools/scan-build/CMakeLists.txt
tools/scan-build/Makefile
tools/scan-build/scan-build
tools/scan-v
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-build and scan-view
http://reviews.llvm.org/D14403
Added:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
r252474
http://reviews.llvm.org/D14403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: jroelofs
Date: Mon Nov 9 10:47:09 2015
New Revision: 252489
URL: http://llvm.org/viewvc/llvm-project?rev=252489&view=rev
Log:
Fix the cmake build after r252474 broke it
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: cfe/tru
jroelofs added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:880
@@ +879,3 @@
+# See: libcxxabi/test/lit.cfg
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread
-lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux -lclang_rt
Author: jroelofs
Date: Tue Nov 10 14:01:22 2015
New Revision: 252641
URL: http://llvm.org/viewvc/llvm-project?rev=252641&view=rev
Log:
Fix missing CMake dependency introduced in r252474
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified:
On 11/10/15 12:48 PM, Tobias Grosser wrote:
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-build and
On 11/10/15 1:35 PM, Tobias Grosser wrote:
On 11/10/2015 09:05 PM, Jonathan Roelofs wrote:
On 11/10/15 12:48 PM, Tobias Grosser wrote:
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org
Author: jroelofs
Date: Tue Nov 10 16:38:59 2015
New Revision: 252662
URL: http://llvm.org/viewvc/llvm-project?rev=252662&view=rev
Log:
Implement the fix that r252641 should have been
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: cf
Roelofs wrote:
On 11/10/15 12:48 PM, Tobias Grosser wrote:
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-b
Author: jroelofs
Date: Tue Nov 10 16:48:11 2015
New Revision: 252664
URL: http://llvm.org/viewvc/llvm-project?rev=252664&view=rev
Log:
Implement post-commit review feedback on r252662
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: c
Author: jroelofs
Date: Tue Nov 10 16:59:18 2015
New Revision: 252667
URL: http://llvm.org/viewvc/llvm-project?rev=252667&view=rev
Log:
Fix build
Modified:
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: cfe/trunk/tools/scan-view/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Would you mind re-uploading this patch as a diff against upstream trunk with
full context?
http://reviews.llvm.org/D9600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
jroelofs added a comment.
In http://reviews.llvm.org/D14293#287174, @rmaprath wrote:
> Would it be OK if I commit the x86 buildbot changes (Dmitri approved these
> earlier) while the ARM buildbot changes are being reviewed? I suppose the
> changes would only take effect once @gkistanova restart
On 11/11/15 11:13 AM, Aaron Ballman via cfe-commits wrote:
Author: aaronballman
Date: Wed Nov 11 12:13:42 2015
New Revision: 252771
URL: http://llvm.org/viewvc/llvm-project?rev=252771&view=rev
Log:
Hiding the scan-build and scan-view projects under the Misc folder in IDEs
instead of having th
On 11/11/15 8:07 AM, Aaron Ballman wrote:
This change causes MSVC to have two new projects sitting at the root
of the solution: scan-build and scan-view, neither of which appear to
do anything. Are these projects required for IDEs? If they're
installation-only projects, I think the CMake should
jroelofs added a subscriber: jroelofs.
Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114
@@ +113,3 @@
+ printMethodNameWithPramaTypes(Out, C, FName, M,
false);
+ const std::string NS =
qtNormalizeSignature(Out.str
On 11/11/15 5:01 PM, Akira Hatanaka via cfe-commits wrote:
ahatanak added a comment.
In http://reviews.llvm.org/D14471#287412, @rengolin wrote:
In http://reviews.llvm.org/D14471#286380, @ahatanak wrote:
I think I can use macro __aarch64__ to have getAArch64TargetCPU
return "native" when th
jroelofs added a comment.
If you you're familiar with git, I'm asking you to: squash, rebase, and `git
diff -U999`, then upload the resulting patch.
If you use svn, I'm asking you to: `svn diff -r$(FirstCommit):$(LastCommit)
--diff-cmd=diff -x -U999`, and upload that.
The reason to squash all
On 8/8/15 2:23 PM, Fulvio Esposito wrote:
espositofulvio added inline comments.
Comment at: include/__config:742 @@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) ||
defined(__NetBSD__) || defined(__linux__) || defined(__APPLE__) +#
define _LIBCPP_THREAD_
On 7/19/16 8:55 AM, Robinson, Paul wrote:
I think we could emulate any pre-commit hook we like via GitHub
WebHooks by having two repositories: llvm and llvm-staging (say).
People push to llvm-staging, which notifies some LLVM server we own.
That does basic sanity checks and pushes to llvm prop
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I think the replacement is wrong for something like:
int *arr; int offs1, offs2;
offs1[arr + offs2] = 42;
which I think would give:
int *arr; int offs1, offs2;
arr + offs2[offs1] = 42;
If the precedence of the "indexing"
jroelofs added a comment.
In https://reviews.llvm.org/D21134#509522, @danielmarjamaki wrote:
> In https://reviews.llvm.org/D21134#508524, @jroelofs wrote:
>
> > I think the replacement is wrong for something like:
> >
> > int *arr; int offs1, offs2;
> > offs1[arr + offs2] = 42;
> >
> >
> > wh
jroelofs added a subscriber: jroelofs.
Comment at: lib/AST/Expr.cpp:2656
@@ +2655,3 @@
+AllowNonLiteral)) {
+if (!CE->getNumArgs()) return true;
+unsigned numArgs = CE->getNumArgs();
no need for this `if`.
Also, I think the `for` shoul
jroelofs added a comment.
One more thing: need to add docs to `clang/docs/LanguageExtensions.rst`.
https://reviews.llvm.org/D23385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6807
@@ +6806,3 @@
+
+def err_has_constant_init_expression_trait_invalid_arg : Error<
+ "expression does not reference a named variable">;
EricWF wrote:
> Help improving this w
jroelofs added a comment.
I don't think I have any more comments, but I'll let one of the other reviewers
give the final go/no-go.
Comment at: docs/LanguageExtensions.rst:1047
@@ +1046,3 @@
+ Determines whether `expr` names
+ a object that will be initialized during
+ `const
jroelofs added a comment.
Doesn't libgcc_s contain bits of gcc's unwinder?
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
This breaks the ODR... the behavior under those circumstances is undefined.
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
In https://reviews.llvm.org/D23420#513820, @zatrazz wrote:
> Yes, although in pratice for shared libraries this is not an issue (at least
> on Linux with current linker strategies). And I open for suggestion on how to
> proceed in this case since we have some other opt
jroelofs added a subscriber: jroelofs.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
While you're here, may as well shorten these three lines t
jroelofs added inline comments.
Comment at: test/Modules/ModuleDebugInfo.cpp:25
@@ -25,1 +24,3 @@
+// CHECK-SAME:dwoId:
+// CHECK-SAME:)
jlebar wrote:
> jroelofs wrote:
> > This `CHECK-SAME` line and all the others are sti
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | F
On 2/11/16 7:24 PM, Hans Wennborg wrote:
On Mon, Nov 9, 2015 at 8:12 AM, Jonathan Roelofs via cfe-commits
wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-build
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
jroelofs added a subscriber: jroelofs.
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17380
___
cfe-commits mailing list
jroelofs added a subscriber: EricWF.
jroelofs added a comment.
> The private redirector symbol names are all prefixed with _CXX_* so that they
> won't conflict with user symbols,
This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes
would be safer (so that there's no chanc
jroelofs added a comment.
In http://reviews.llvm.org/D17456#357245, @bcraig wrote:
> In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
>
> > > The private redirector symbol names are all prefixed with _CXX_* so that
> > > they won't conflict with user symbols,
> >
> >
> > This is more @
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I think you could lean on the linker to cause the test to fail when the type is
wrong:
bool isinf(double);
typedef int (*expected_signature)(double);
void assert_via_linker(decltype(isinf) blah);
void assert_via_linke
jroelofs added a comment.
> Alternatively `static_assert(std::is_same bool>::value);` :-P
>
> Testing the return type isn't the problem. The problem is telling LIT *when*
> we expect the test to fail using the `XFAIL` directive.
O. I see.
http://reviews.llvm.org/D19835
___
jroelofs added a comment.
Wouldn't this break cross unwinding?
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
In http://reviews.llvm.org/D19920#421173, @rmaprath wrote:
> In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
>
> > Wouldn't this break cross unwinding?
>
>
> I wasn't aware of cross unwinding, I think you are referring to [1]. Thanks
> for the pointer.
>
> Wo
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Drive-by thought: I think it would be useful to be able to match implicit casts
separately from explicit casts when using this new matcher.
http://reviews.llvm.org/D19871
___
cfe-comm
jroelofs added a comment.
In http://reviews.llvm.org/D19871#429153, @etienneb wrote:
> In http://reviews.llvm.org/D19871#428997, @jroelofs wrote:
>
> > Drive-by thought: I think it would be useful to be able to match implicit
> > casts separately from explicit casts when using this new matcher.
jroelofs added a comment.
Just one question, otherwise LGTM:
Comment at: src/UnwindCursor.hpp:580
@@ -579,3 +605,1 @@
_isSignalFrame(false) {
- static_assert(sizeof(UnwindCursor) < sizeof(unw_cursor_t),
-"UnwindCursor<> does not fit in unw_cursor_t");
---
jroelofs added a comment.
In http://reviews.llvm.org/D20119#431997, @rmaprath wrote:
> Addressing review comments from @jroelofs:
>
> - Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it
> really belogs.
>
> @jroelofs: I just realized that, with this new native-only bui
jroelofs added a comment.
In http://reviews.llvm.org/D20119#437191, @rmaprath wrote:
> In http://reviews.llvm.org/D20119#436849, @jroelofs wrote:
>
> > In http://reviews.llvm.org/D20119#431997, @rmaprath wrote:
> >
> > > Addressing review comments from @jroelofs:
> > >
> > > - Moved the assertion
jroelofs added a comment.
This is the canonical reference for the Itanium ABI:
https://mentorembedded.github.io/cxx-abi/abi.html
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
jroelofs added a comment.
In http://reviews.llvm.org/D20119#441516, @rmaprath wrote:
> Please shout!
Just add some parens:
static_assert((check_fit::does_fit),
"or1k registers do not fit into unw_context_t");
http://reviews.llvm.org/D20119
___
On 5/26/16 3:45 PM, Asiri Rathnayake via cfe-commits wrote:
struct blk_count {
-static const uint32_t count =
+static const uint64_t count =
(sizeof(T) + sizeof(uint64_t) -
Should that be 'size_t' instead?
Jon
--
Jon Roelofs
jonat...@codesourcery.com
CodeSourcery / Ment
jroelofs added a comment.
In http://reviews.llvm.org/D14727#441758, @bryanpkc wrote:
> Fixed the code to set GoodVersion.MajorStr before returning, and removed an
> unnecessary file
> (test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o).
That file is not unnec
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
Probably worth doing the same thing for the non-EHABI non-SJLJ implementation,
too (that can of course go in a separate commit).
LGTM
http://reviews.llvm.org/D20320
__
On 6/14/16 9:51 AM, Asiri Rathnayake via cfe-commits wrote:
Author: asiri
Date: Tue Jun 14 10:51:01 2016
New Revision: 272680
URL: http://llvm.org/viewvc/llvm-project?rev=272680&view=rev
Log:
[libunwind] Improve unwinder stack usage - III
Implement the same optimization committed under r27100
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM. Do you want me to commit it for you?
http://reviews.llvm.org/D14727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
jroelofs added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
jroelofs added a subscriber: jroelofs.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can s
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Testcases?
Repository:
rL LLVM
http://reviews.llvm.org/D17952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D17419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 262 matches
Mail list logo
