Author: jonastoth
Date: Thu Feb 7 03:00:59 2019
New Revision: 353389
URL: http://llvm.org/viewvc/llvm-project?rev=353389&view=rev
Log:
[clang-tidy] Fixed a std::bind() transformation
There was an extra semicolon that was somehow working in some contexts.
Patch by oleg.smolsky.
Modified:
cl
Author: jonastoth
Date: Wed Feb 20 13:04:36 2019
New Revision: 354517
URL: http://llvm.org/viewvc/llvm-project?rev=354517&view=rev
Log:
[clang-tidy] refactor ExceptionAnalyzer further to give ternary answer
Summary:
The analsis on the throwing behvaiour on functions and statements gave only
a bin
Author: jonastoth
Date: Wed Aug 30 00:50:28 2017
New Revision: 312102
URL: http://llvm.org/viewvc/llvm-project?rev=312102&view=rev
Log:
[clang-tidy] test commit for granted access
Modified:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp
Modified: clang-tools-extra/tru
Author: jonastoth
Date: Wed Aug 30 06:32:05 2017
New Revision: 312122
URL: http://llvm.org/viewvc/llvm-project?rev=312122&view=rev
Log:
[clang-tidy] hicpp bitwise operations on signed integers
Summary:
This check implements the rule [[
http://www.codingstandard.com/section/5-6-shift-operators/ |
Author: jonastoth
Date: Wed Aug 30 08:59:01 2017
New Revision: 312134
URL: http://llvm.org/viewvc/llvm-project?rev=312134&view=rev
Log:
[clang-tidy] Improve hicpp-exception-baseclass to handle generic code better
Summary:
This patch is a followup to the first revision D36583, that had problems wi
u should use 'signed char' in your clang-tidy
test to fix the bot failures"
Please be more careful with the buildbots in the future.
Thanks,
Diana
(*) My apologies if I missed it, but I really don't see anything in
cfe-commits nor in the situation of the bots to reflect that
failures"
Please be more careful with the buildbots in the future.
Thanks,
Diana
(*) My apologies if I missed it, but I really don't see anything in
cfe-commits nor in the situation of the bots to reflect that.
On 30 August 2017 at 17:59, Jonas Toth via cfe-commits
wrote:
Author: jo
Author: jonastoth
Date: Wed Aug 30 10:21:41 2017
New Revision: 312141
URL: http://llvm.org/viewvc/llvm-project?rev=312141&view=rev
Log:
[clang-tidy] fix buildbot
Use `signed char` instead of `char`.
Modified:
clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp
Modified: clang-t
Author: jonastoth
Date: Mon Sep 11 02:20:07 2017
New Revision: 312901
URL: http://llvm.org/viewvc/llvm-project?rev=312901&view=rev
Log:
[clang-tidy] add more aliases for the hicpp module
This patch will introduce even more aliases for the hicpp-module to already
existing
checks and is a follow u
Author: jonastoth
Date: Tue Sep 12 09:20:51 2017
New Revision: 313043
URL: http://llvm.org/viewvc/llvm-project?rev=313043&view=rev
Log:
[clang-tidy] Implement type-based check for `gsl::owner`
This check implements the typebased semantic of `gsl::owner`.
Meaning, that
- only `gsl::owner` is allo
Author: jonastoth
Date: Tue Sep 12 11:35:54 2017
New Revision: 313059
URL: http://llvm.org/viewvc/llvm-project?rev=313059&view=rev
Log:
[clang-tidy] Revert Implement type-based check for gsl::owner
This should unbreak the buildbot for visual studio 2015 for now.
Removed:
clang-tools-extra/tr
Author: jonastoth
Date: Tue Sep 12 13:00:42 2017
New Revision: 313067
URL: http://llvm.org/viewvc/llvm-project?rev=313067&view=rev
Log:
[clang-tidy] Implement type-based check for `gsl::owner`
This check implements the typebased semantic of `gsl::owner`.
Meaning, that
- only `gsl::owner` is allo
Author: jonastoth
Date: Thu May 16 02:22:39 2019
New Revision: 360869
URL: http://llvm.org/viewvc/llvm-project?rev=360869&view=rev
Log:
[clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy.
Summary: When run-clang-tidy is given the -quiet flag, do not output the
potenti
Author: jonastoth
Date: Thu May 16 05:35:00 2019
New Revision: 360882
URL: http://llvm.org/viewvc/llvm-project?rev=360882&view=rev
Log:
[clang-tidy] Handle member variables in readability-simplify-boolean-expr
- Add readability-simplify-boolean-expr test cases for member variables
Fixes PR40179
Author: jonastoth
Date: Thu May 16 05:39:22 2019
New Revision: 360883
URL: http://llvm.org/viewvc/llvm-project?rev=360883&view=rev
Log:
[clang-tidy] Removed superfluous and slightly annoying newlines in
run-clang-tidy's output.
Summary: The output of clang-tidy itself already has enough newlines
Author: jonastoth
Date: Sat Jan 5 03:40:05 2019
New Revision: 350466
URL: http://llvm.org/viewvc/llvm-project?rev=350466&view=rev
Log:
[Documentation] fix order of checks in checks/list.rst
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
Modified: clang-tools-extra/trunk/d
Author: jonastoth
Date: Wed Jan 9 12:50:50 2019
New Revision: 350760
URL: http://llvm.org/viewvc/llvm-project?rev=350760&view=rev
Log:
[clang-tidy] Adding a new modernize use nodiscard checker
Summary: Adds a checker to clang-tidy to warn when a non void const member
function, taking only param
Author: jonastoth
Date: Wed Jan 9 13:03:54 2019
New Revision: 350761
URL: http://llvm.org/viewvc/llvm-project?rev=350761&view=rev
Log:
[clang-tidy] fix-up failing tests
Removed:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nodiscard.h
Modified:
clang-tools-extra/trunk/test/clang
Author: jonastoth
Date: Wed Jan 9 13:19:44 2019
New Revision: 350763
URL: http://llvm.org/viewvc/llvm-project?rev=350763&view=rev
Log:
[clang-tidy] tryfix documentation build
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst
Modified:
clang-tools-extra/tr
Author: jonastoth
Date: Wed Jan 9 13:27:59 2019
New Revision: 350765
URL: http://llvm.org/viewvc/llvm-project?rev=350765&view=rev
Log:
[clang-tidy] another take at fixing doc
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst
Modified:
clang-tools-extra/tr
Author: jonastoth
Date: Thu Jan 10 03:56:44 2019
New Revision: 350814
URL: http://llvm.org/viewvc/llvm-project?rev=350814&view=rev
Log:
[clang-tidy] Fix case of local variables in modernize-use-nodiscard checker
Summary:
Correct the case of the local variables..
Rational:
I want to be able to ru
Author: jonastoth
Date: Tue Dec 5 08:37:49 2017
New Revision: 319785
URL: http://llvm.org/viewvc/llvm-project?rev=319785&view=rev
Log:
[clang-tidy] adjust cppcoreguidelines-owning-memory documentation
Summary:
A user of the check opened a bugreport and reported that `std::exchange`
triggers a fa
Author: Jonas Toth
Date: 2022-08-29T11:20:47+02:00
New Revision: b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4
URL:
https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4
DIFF:
https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4.diff
LO
Author: Jonas Toth
Date: 2022-04-24T17:17:02+02:00
New Revision: 3f0f20366622ee5fd35a1d65d7db5226f5e5751f
URL:
https://github.com/llvm/llvm-project/commit/3f0f20366622ee5fd35a1d65d7db5226f5e5751f
DIFF:
https://github.com/llvm/llvm-project/commit/3f0f20366622ee5fd35a1d65d7db5226f5e5751f.diff
LO
Author: Jonas Toth
Date: 2022-07-24T19:37:54+02:00
New Revision: 46ae26e7eb7095faeda6d6c15470c256f9294c48
URL:
https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48
DIFF:
https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48.diff
LO
Author: Jonas Toth
Date: 2020-01-03T20:37:47+01:00
New Revision: cf48101200ee192dd82e6ed0512ae42e7b3162a9
URL:
https://github.com/llvm/llvm-project/commit/cf48101200ee192dd82e6ed0512ae42e7b3162a9
DIFF:
https://github.com/llvm/llvm-project/commit/cf48101200ee192dd82e6ed0512ae42e7b3162a9.diff
LO
Author: Jonas Toth
Date: 2020-01-03T21:55:51+01:00
New Revision: 05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8
URL:
https://github.com/llvm/llvm-project/commit/05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8
DIFF:
https://github.com/llvm/llvm-project/commit/05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8.diff
LO
Author: Jonas Toth
Date: 2020-01-03T22:02:11+01:00
New Revision: fed2a5033af564af390faa8f8438018fe747126a
URL:
https://github.com/llvm/llvm-project/commit/fed2a5033af564af390faa8f8438018fe747126a
DIFF:
https://github.com/llvm/llvm-project/commit/fed2a5033af564af390faa8f8438018fe747126a.diff
LO
Author: Jonas Toth
Date: 2020-01-03T22:32:10+01:00
New Revision: 48ee04033cce2e085fd8909c6ebaa0de68ab65d0
URL:
https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0
DIFF:
https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0.diff
LO
Author: Jonas Toth
Date: 2020-01-10T16:10:55+01:00
New Revision: cdd05f2aea3b950a4e2c496175117e6b47b2a050
URL:
https://github.com/llvm/llvm-project/commit/cdd05f2aea3b950a4e2c496175117e6b47b2a050
DIFF:
https://github.com/llvm/llvm-project/commit/cdd05f2aea3b950a4e2c496175117e6b47b2a050.diff
LO
Author: Jonas Toth
Date: 2020-01-11T19:21:03+01:00
New Revision: 4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4
URL:
https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4
DIFF:
https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4.diff
LO
Author: Jonas Toth
Date: 2020-01-11T19:41:27+01:00
New Revision: 23a799adf0abbe9a7be1494d5efd1ab3215ee4fb
URL:
https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb
DIFF:
https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb.diff
LO
Author: Jonas Toth
Date: 2020-09-15T21:07:30+02:00
New Revision: 69f98311ca42127df92527b6fc3be99841a15f12
URL:
https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12
DIFF:
https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12.diff
LO
Author: Jonas Toth
Date: 2020-09-24T13:13:38+02:00
New Revision: 4e534900476d2a5c620e74ddb9c9e7d321e6d443
URL:
https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443
DIFF:
https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443.diff
LO
Author: Jonas Toth
Date: 2020-10-09T13:45:32+02:00
New Revision: e517e5cfec90a00a488ad8df901ab9b903ebb966
URL:
https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966
DIFF:
https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966.diff
LO
Author: Jonas Toth
Date: 2022-09-26T10:39:11+02:00
New Revision: e66345d54d5f5e803f54c1ace487d57bb11ee884
URL:
https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884
DIFF:
https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884.diff
LO
Hi Anshil,
take a look at this: https://clang.llvm.org/docs/InternalsManual.html
cxx1x is probably done already, but cxx2a has some outstanding features ;)
In general, please use 'cfe-dev' instead of 'cfe-commits'. There is the
normal discussion and questions/answers for developers.
Regards Jon
Author: jonastoth
Date: Wed Mar 21 08:34:15 2018
New Revision: 328107
URL: http://llvm.org/viewvc/llvm-project?rev=328107&view=rev
Log:
[clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test
The original check did break the green buildbot in the sanitizer build.
It took a while
Author: jonastoth
Date: Wed Mar 21 08:50:15 2018
New Revision: 328108
URL: http://llvm.org/viewvc/llvm-project?rev=328108&view=rev
Log:
[Fix] fix type deduction on ARM and MSVC
Modified:
clang-tools-extra/trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp
Modified: clang-tools-extra/trunk/
Author: jonastoth
Date: Wed Apr 11 03:22:25 2018
New Revision: 329790
URL: http://llvm.org/viewvc/llvm-project?rev=329790&view=rev
Log:
[clang-tidy] fix buildbots from hicpp-signed-bitwise
The applied patch to diagnose assignment operators introduced
breakage on some architectures. This patch tri
Author: jonastoth
Date: Wed Apr 11 02:53:08 2018
New Revision: 329789
URL: http://llvm.org/viewvc/llvm-project?rev=329789&view=rev
Log:
[clang-tidy] add missing assignment operations in hicpp-signed-bitwise
This patch resolves the bug https://bugs.llvm.org/show_bug.cgi?id=36963.
- implement miss
Author: jonastoth
Date: Fri Oct 27 07:44:08 2017
New Revision: 316767
URL: http://llvm.org/viewvc/llvm-project?rev=316767&view=rev
Log:
[clang-tidy] Fix bug 34845, offending standard bitmask types
Summary:
The C++ standard allows implementations to choose the underlying type for
bitmask types (e.
Author: jonastoth
Date: Sat Nov 18 11:48:33 2017
New Revision: 318600
URL: http://llvm.org/viewvc/llvm-project?rev=318600&view=rev
Log:
[clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches
Summary:
This check searches for missing `else` branches in `if-else if`-chains and
Author: jonastoth
Date: Mon Nov 20 10:01:35 2017
New Revision: 318670
URL: http://llvm.org/viewvc/llvm-project?rev=318670&view=rev
Log:
[clang-tidy] revert hicpp-multiway-paths-covered
The address sanitizer found a stackoverflow with this patch.
There is no obvious fix. This patch will be reappli
Author: jonastoth
Date: Wed Jan 17 02:23:50 2018
New Revision: 322624
URL: http://llvm.org/viewvc/llvm-project?rev=322624&view=rev
Log:
[clang-tidy] fix minor formatting issue
Modified:
clang-tools-extra/trunk/clang-tidy/hicpp/HICPPTidyModule.cpp
Modified: clang-tools-extra/trunk/clang-tidy/
Author: jonastoth
Date: Wed Jan 17 02:27:41 2018
New Revision: 322626
URL: http://llvm.org/viewvc/llvm-project?rev=322626&view=rev
Log:
[clang-tidy] implement check for goto
The usage of `goto` is discourage in C++ since forever. This check implements
a warning for every `goto`. Even though there
JonasToth wrote:
As you requested my review:
The original linking was done for the `ExprMutAnalyzer` used in
'misc-const-correctness'. If clang-tidy is builtin without static analyzer
Support, you get linker failure.
If the `ExprMutAnalyzer` is moved (back) to clang-tidy, the issue is not
ex
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From b10c536f66521249a374908f0bd0eb1fe2ff42ad Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
https://github.com/JonasToth created
https://github.com/llvm/llvm-project/pull/118209
This PR improves the docs for this check to include an example of hidden
narrowing conversions from the integer promotion rules in arithmetic.
>From c662917b248335c85714e791f55e12e834baa87d Mon Sep 17 00:00:0
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
+T
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
--
https://github.com/JonasToth edited
https://github.com/llvm/llvm-project/pull/118209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From 4340df440863de154ed305dc487d23ef46c9277a Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
--
@@ -27,6 +27,29 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Note that arithmetic with integer types may perform implicit conversions if
the used integer types are smaller than ``int``.
+T
JonasToth wrote:
@PiotrZSL I did assign you as reviewer because I noticed you do many reviews.
Please remove yourself if that was not appropriate.
I did not contribute to clang-tidy for a longer period and not sure who to
assign (if any!) for the PR. It was not meant offensively or so :)
https
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From f4345664e10ac6a9e87b33b1e816b685a1355bb6 Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From f7f570b3fa5a96cd3eb140abd02e4351a4586e26 Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH] [clang-tidy][docs] improve documentation on
cppcoreguidelines-nar
@@ -27,6 +27,39 @@ This check will flag:
- All applications of binary operators with a narrowing conversions.
For example: ``int i; i+= 0.1;``.
+Arithmetic with smaller integer types than ``int`` trigger implicit
conversions,
+as explained under `"Integral Promotion" on c
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From f4345664e10ac6a9e87b33b1e816b685a1355bb6 Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH 1/2] [clang-tidy][docs] improve documentation on
cppcoreguidelines
https://github.com/JonasToth closed
https://github.com/llvm/llvm-project/pull/118209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JonasToth updated
https://github.com/llvm/llvm-project/pull/118209
>From 4340df440863de154ed305dc487d23ef46c9277a Mon Sep 17 00:00:00 2001
From: Jonas Toth
Date: Sun, 1 Dec 2024 12:02:13 +0100
Subject: [PATCH 1/2] [clang-tidy][docs] improve documentation on
cppcoreguidelines
101 - 162 of 162 matches
Mail list logo
