Re: Fwd: patch file for bug 38557

Do you have a phabricator account? Otherwise I will create a revision for you (ofc mentioning your name in the commit message) for review. Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: > Hi, > > Attached is the patch file for Bug 38557 > (https://bugs.llvm.org/show_bug.cgi?id=38557). >

Re: Fwd: patch file for bug 38557

Hi Owen, thank you for your patch. I created a revision for it to pass review: https://reviews.llvm.org/D50697 If you do have an phabricator account you can take over, otherwise we can get it into trunk for you :) All the best, Jonas Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: > H

[clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 09:25:01 2017 New Revision: 314808 URL: http://llvm.org/viewvc/llvm-project?rev=314808&view=rev Log: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise The bug happened with stream operations, that were not recognized in all cases. Even the

[clang-tools-extra] r314811 - [clang-tidy] Remove target specification hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 09:27:41 2017 New Revision: 314811 URL: http://llvm.org/viewvc/llvm-project?rev=314811&view=rev Log: [clang-tidy] Remove target specification hicpp-signed-bitwise This patch removes the targetspecification of a testcase, that broke for ARM. The underlying proble

[clang-tools-extra] r314812 - [clang-tidy] potentially fix buildbot

Author: jonastoth Date: Tue Oct 3 09:53:56 2017 New Revision: 314812 URL: http://llvm.org/viewvc/llvm-project?rev=314812&view=rev Log: [clang-tidy] potentially fix buildbot I tried to silence lit with `| count 0`, which did not work. Other testcases did not have `-- --` but only `--` in the RUN

[clang-tools-extra] r314816 - [clang-tidy] fix buildbot hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 10:08:57 2017 New Revision: 314816 URL: http://llvm.org/viewvc/llvm-project?rev=314816&view=rev Log: [clang-tidy] fix buildbot hicpp-signed-bitwise To finally fix the buildbot I added one single warning testcase. Modified: clang-tools-extra/trunk/test/clang

Re: [clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

; > Thanks > > Cheers, > Juergen > > On Tue, Oct 3, 2017 at 9:25 AM, Jonas Toth via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > Author: jonastoth > Date: Tue Oct  3 09:25:01 2017 > New Revision: 314808 > > URL: http://llvm.

[clang-tools-extra] r314913 - [clang-tidy] Emit note for variable declaration that are later deleted

Author: jonastoth Date: Wed Oct 4 09:49:20 2017 New Revision: 314913 URL: http://llvm.org/viewvc/llvm-project?rev=314913&view=rev Log: [clang-tidy] Emit note for variable declaration that are later deleted This patch introduces a note for variable declaration that are later deleted. Adds FIXME n

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

Hi, I am not sure if could follow correctly, but the test for nested namespaces comments does not work correctly and is therefore currently disabled by fileextension? When running the check from trunk i get the following issues: $ clang-check google-readability-namespace-comments-cxx17.cpp -

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

Ok. I subscribe to r315057. I can look at debugging the change as well if you guys want. Should have time today evening and tomorrow. Am 12.10.2017 um 12:46 schrieb Alexander Kornienko: On Thu, Oct 12, 2017 at 11:12 AM, Jonas Toth > wrote: Hi, I am not

[clang-tools-extra] r316092 - [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'

Author: jonastoth Date: Wed Oct 18 09:14:15 2017 New Revision: 316092 URL: http://llvm.org/viewvc/llvm-project?rev=316092&view=rev Log: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory' Summary: This patch introduces support for legacy C-style resource functio

[clang-tools-extra] r316093 - [clang-tidy] Fix buildbot for msvc

Author: jonastoth Date: Wed Oct 18 09:28:06 2017 New Revision: 316093 URL: http://llvm.org/viewvc/llvm-project?rev=316093&view=rev Log: [clang-tidy] Fix buildbot for msvc The testcase defined `FILE` as `unsigned long`, but MSVC expect `unsigned long long`. Modified: clang-tools-extra/trunk

[clang-tools-extra] r316094 - [clang-tidy] Fix 32bit platform MSVC

Author: jonastoth Date: Wed Oct 18 09:40:19 2017 New Revision: 316094 URL: http://llvm.org/viewvc/llvm-project?rev=316094&view=rev Log: [clang-tidy] Fix 32bit platform MSVC The previous fix only worked for 64bit MSVC, this one should fix all different architectures. Modified: clang-tools-ex

r340623 - [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

Author: jonastoth Date: Fri Aug 24 10:14:31 2018 New Revision: 340623 URL: http://llvm.org/viewvc/llvm-project?rev=340623&view=rev Log: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All Summary: See bug report https://bugs.llvm.org/show

r340624 - [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

Author: jonastoth Date: Fri Aug 24 10:25:06 2018 New Revision: 340624 URL: http://llvm.org/viewvc/llvm-project?rev=340624&view=rev Log: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier Summary: The Bug was reported and fixed by

[clang-tools-extra] r340928 - [clang-tidy] Add abseil-no-internal-dependencies check

Author: jonastoth Date: Wed Aug 29 07:23:15 2018 New Revision: 340928 URL: http://llvm.org/viewvc/llvm-project?rev=340928&view=rev Log: [clang-tidy] Add abseil-no-internal-dependencies check Finds instances where the user depends on internal details and warns them against doing so. Should not be

[clang-tools-extra] r341039 - [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES

Author: jonastoth Date: Thu Aug 30 01:44:27 2018 New Revision: 341039 URL: http://llvm.org/viewvc/llvm-project?rev=341039&view=rev Log: [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES Summary: The check_clang_tidy.py script would allow mixing of `CHECK-NOTES`

r341284 - Fix Bug 38713: clang-format mishandles a short block after "default:" in a switch statement

Author: jonastoth Date: Sun Sep 2 02:04:51 2018 New Revision: 341284 URL: http://llvm.org/viewvc/llvm-project?rev=341284&view=rev Log: Fix Bug 38713: clang-format mishandles a short block after "default:" in a switch statement Summary: See https://bugs.llvm.org/show_bug.cgi?id=38713 Patch by O

[clang-tools-extra] r341933 - [NFC][clangd] fix warning for extra semicolon

Author: jonastoth Date: Tue Sep 11 06:01:49 2018 New Revision: 341933 URL: http://llvm.org/viewvc/llvm-project?rev=341933&view=rev Log: [NFC][clangd] fix warning for extra semicolon Modified: clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp Modified: clang-tools-extra/trunk/unittests/

r341958 - [ASTMatchers] add three matchers for dependent expressions

Author: jonastoth Date: Tue Sep 11 09:09:19 2018 New Revision: 341958 URL: http://llvm.org/viewvc/llvm-project?rev=341958&view=rev Log: [ASTMatchers] add three matchers for dependent expressions Summary: The new matchers can be used to check if an expression is type-, value- or instantiation-dep

[clang-tools-extra] r342267 - [NFC][clangd] silence pedantic extra '; ' warning

Author: jonastoth Date: Fri Sep 14 12:42:37 2018 New Revision: 342267 URL: http://llvm.org/viewvc/llvm-project?rev=342267&view=rev Log: [NFC][clangd] silence pedantic extra ';' warning Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified: clang-tools-extra/trunk/

r337703 - [ASTMatchers] add matcher for decltypeType and its underlyingType

Author: jonastoth Date: Mon Jul 23 08:59:27 2018 New Revision: 337703 URL: http://llvm.org/viewvc/llvm-project?rev=337703&view=rev Log: [ASTMatchers] add matcher for decltypeType and its underlyingType Summary: This patch introduces a new matcher for `DecltypeType` and its underlying type in orde

[clang-tools-extra] r337707 - [clang-tidy] remove private decltypeType in TrailingReturnType

Author: jonastoth Date: Mon Jul 23 09:30:13 2018 New Revision: 337707 URL: http://llvm.org/viewvc/llvm-project?rev=337707&view=rev Log: [clang-tidy] remove private decltypeType in TrailingReturnType Summary: This patch removes a private matcher in fuchsia/TrailingReturnType check because the matc

[clang-tools-extra] r337710 - [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

Author: jonastoth Date: Mon Jul 23 10:13:06 2018 New Revision: 337710 URL: http://llvm.org/viewvc/llvm-project?rev=337710&view=rev Log: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well Summary: The cppcoreguidelines-pro-bounds-pointer-arithmetic warns on all occassion wh

[clang-tools-extra] r337712 - Revert "[clang-tidy] fix PR36489 - respect deduced pointer types from auto as well"

Author: jonastoth Date: Mon Jul 23 10:34:25 2018 New Revision: 337712 URL: http://llvm.org/viewvc/llvm-project?rev=337712&view=rev Log: Revert "[clang-tidy] fix PR36489 - respect deduced pointer types from auto as well" I applied the wrong patch. Modified: clang-tools-extra/trunk/test/clan

[clang-tools-extra] r337716 - [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

Author: jonastoth Date: Mon Jul 23 10:46:17 2018 New Revision: 337716 URL: http://llvm.org/viewvc/llvm-project?rev=337716&view=rev Log: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well Summary: The cppcoreguidelines-pro-bounds-pointer-arithmetic warns on all occassion wh

r338022 - [ASTMatchers] fix the missing documentation for new decltypeType matcher

Author: jonastoth Date: Thu Jul 26 06:02:05 2018 New Revision: 338022 URL: http://llvm.org/viewvc/llvm-project?rev=338022&view=rev Log: [ASTMatchers] fix the missing documentation for new decltypeType matcher Summary: Regenerate the Matchers documentation, forgotten in the original patch. Review

[clang-tools-extra] r338393 - [clang-tidy] add all clang-tidy modules to plugin

Author: jonastoth Date: Tue Jul 31 08:23:49 2018 New Revision: 338393 URL: http://llvm.org/viewvc/llvm-project?rev=338393&view=rev Log: [clang-tidy] add all clang-tidy modules to plugin Summary: This patch addresses PR38359 and adds all existing clang-tidy modules to the plugin that can be used t

r338996 - [clang-rename] make clang-rename.py vim integration python3 compatible

Author: jonastoth Date: Mon Aug 6 02:08:06 2018 New Revision: 338996 URL: http://llvm.org/viewvc/llvm-project?rev=338996&view=rev Log: [clang-rename] make clang-rename.py vim integration python3 compatible Summary: This patch makes the clang-rename.py script useable for vim with only python3 sup

Re: [PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

Hmm. SVN does not want  me to commit anything :/ I will retry later today, but maybe i cant commit. Best, Jonas Am 06.06.2018 um 10:47 schrieb Aaron Ballman: > On Wed, Jun 6, 2018 at 4:40 AM Jonas Toth via Phabricator > wrote: >> JonasToth added a comment. >> >> @shuaiwang I can commit it in

[clang-tools-extra] r344044 - [clangd] fix miscompiling lower_bound call

Author: jonastoth Date: Tue Oct 9 06:24:50 2018 New Revision: 344044 URL: http://llvm.org/viewvc/llvm-project?rev=344044&view=rev Log: [clangd] fix miscompiling lower_bound call Modified: clang-tools-extra/trunk/clangd/index/Index.cpp Modified: clang-tools-extra/trunk/clangd/index/Index.cpp

[clang-tools-extra] r344046 - [clang-tidy] NFC fix warnings from missing braces

Author: jonastoth Date: Tue Oct 9 06:29:31 2018 New Revision: 344046 URL: http://llvm.org/viewvc/llvm-project?rev=344046&view=rev Log: [clang-tidy] NFC fix warnings from missing braces The std::array create multiple StringRef but did not wrap them in braces. Some compilers warned for that. Addin

[clang-tools-extra] r344374 - [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Author: jonastoth Date: Fri Oct 12 10:22:36 2018 New Revision: 344374 URL: http://llvm.org/viewvc/llvm-project?rev=344374&view=rev Log: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length New checker called bugprone-not-null-terminated-result. This

[clang-tools-extra] r344379 - [doc] fix markup in clang-tidy bugprone-not-null-terminated-result

Author: jonastoth Date: Fri Oct 12 10:36:04 2018 New Revision: 344379 URL: http://llvm.org/viewvc/llvm-project?rev=344379&view=rev Log: [doc] fix markup in clang-tidy bugprone-not-null-terminated-result Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-not-null-terminated-res

r344382 - [Doc] fix BB, add code-block type

Author: jonastoth Date: Fri Oct 12 10:44:01 2018 New Revision: 344382 URL: http://llvm.org/viewvc/llvm-project?rev=344382&view=rev Log: [Doc] fix BB, add code-block type Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/llvm-projec

[clang-tools-extra] r344384 - [clangd] NFC fix semicolon warning

Author: jonastoth Date: Fri Oct 12 10:47:43 2018 New Revision: 344384 URL: http://llvm.org/viewvc/llvm-project?rev=344384&view=rev Log: [clangd] NFC fix semicolon warning Modified: clang-tools-extra/trunk/clangd/index/IndexAction.cpp Modified: clang-tools-extra/trunk/clangd/index/IndexAction

r344388 - [Doc] fix second error in UsersManual

Author: jonastoth Date: Fri Oct 12 10:57:18 2018 New Revision: 344388 URL: http://llvm.org/viewvc/llvm-project?rev=344388&view=rev Log: [Doc] fix second error in UsersManual Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/llvm-pr

[clang-tools-extra] r344441 - Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result"

Author: jonastoth Date: Sat Oct 13 02:30:46 2018 New Revision: 31 URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev Log: Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result" This reverts commit r344379. Modified: clang-tools-extra/trunk/docs/clang-tidy/

[clang-tools-extra] r344442 - Revert "[clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length"

Author: jonastoth Date: Sat Oct 13 02:30:58 2018 New Revision: 32 URL: http://llvm.org/viewvc/llvm-project?rev=32&view=rev Log: Revert "[clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length" This reverts commit r344374. Removed: clang-too

[clang-tools-extra] r344940 - [clang-tidy] implement cppcoreguidelines macro rules

Author: jonastoth Date: Mon Oct 22 12:20:01 2018 New Revision: 344940 URL: http://llvm.org/viewvc/llvm-project?rev=344940&view=rev Log: [clang-tidy] implement cppcoreguidelines macro rules Summary: In short macros are discouraged by multiple rules (and sometimes reference randomly). [Enum.1], [E

[clang-tools-extra] r344947 - [clang-tidy] tryfix windows build

Author: jonastoth Date: Mon Oct 22 13:29:15 2018 New Revision: 344947 URL: http://llvm.org/viewvc/llvm-project?rev=344947&view=rev Log: [clang-tidy] tryfix windows build Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp Modified: clang-tools-extra/trunk/clan

[clang-tools-extra] r345167 - [clang-tidy] Add the abseil-duration-factory-float check

Author: jonastoth Date: Wed Oct 24 10:40:50 2018 New Revision: 345167 URL: http://llvm.org/viewvc/llvm-project?rev=345167&view=rev Log: [clang-tidy] Add the abseil-duration-factory-float check Summary: This check finds cases where calls to an absl::Duration factory could use the more efficient i

[clang-tools-extra] r351569 - [clang-tidy] add reproducer for PR39949 into test-suite

Author: jonastoth Date: Fri Jan 18 10:03:11 2019 New Revision: 351569 URL: http://llvm.org/viewvc/llvm-project?rev=351569&view=rev Log: [clang-tidy] add reproducer for PR39949 into test-suite Summary: The underlying issue is fixed in https://reviews.llvm.org/D56444 and this test ensures the issue

r351743 - [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

Author: jonastoth Date: Mon Jan 21 05:26:18 2019 New Revision: 351743 URL: http://llvm.org/viewvc/llvm-project?rev=351743&view=rev Log: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers Summary: This patch adds two unit-tests that are the result of reducing a crashing TU

[clang-tools-extra] r352231 - [clang-tidy] fix unit tests for dropped _Float16 support in X86

Author: jonastoth Date: Fri Jan 25 11:05:12 2019 New Revision: 352231 URL: http://llvm.org/viewvc/llvm-project?rev=352231&view=rev Log: [clang-tidy] fix unit tests for dropped _Float16 support in X86 Summary: Because _Float16 was disabled for X86 targets the unit-tests started failing. Extract th

[clang-tools-extra] r352741 - [clang-tidy] refactor bugprone-exception-escape analysis into class

Author: jonastoth Date: Thu Jan 31 02:46:37 2019 New Revision: 352741 URL: http://llvm.org/viewvc/llvm-project?rev=352741&view=rev Log: [clang-tidy] refactor bugprone-exception-escape analysis into class Summary: The check `bugprone-exception-escape` does an AST-based analysis to determine if a f

[clang-tools-extra] r345735 - [clang-tidy] new check 'readability-isolate-declaration'

Author: jonastoth Date: Wed Oct 31 09:50:44 2018 New Revision: 345735 URL: http://llvm.org/viewvc/llvm-project?rev=345735&view=rev Log: [clang-tidy] new check 'readability-isolate-declaration' Summary: This patch introduces a new clang-tidy check that matches on all `declStmt` that declare more

[clang-tools-extra] r345736 - [clang-tools-extra] fix broken link in release notes

Author: jonastoth Date: Wed Oct 31 09:59:41 2018 New Revision: 345736 URL: http://llvm.org/viewvc/llvm-project?rev=345736&view=rev Log: [clang-tools-extra] fix broken link in release notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseN

r345737 - [clang] try-fix broken documentation builder

Author: jonastoth Date: Wed Oct 31 10:00:50 2018 New Revision: 345737 URL: http://llvm.org/viewvc/llvm-project?rev=345737&view=rev Log: [clang] try-fix broken documentation builder Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewv

[clang-tools-extra] r345738 - [clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot

Author: jonastoth Date: Wed Oct 31 10:08:09 2018 New Revision: 345738 URL: http://llvm.org/viewvc/llvm-project?rev=345738&view=rev Log: [clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot Modified: clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp M

[clang-tools-extra] r345742 - [clang-tidy] add missing '--' in RUN-line, unbreak buildbot

Author: jonastoth Date: Wed Oct 31 10:26:10 2018 New Revision: 345742 URL: http://llvm.org/viewvc/llvm-project?rev=345742&view=rev Log: [clang-tidy] add missing '--' in RUN-line, unbreak buildbot Modified: clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp Modified:

[clang-tools-extra] r345995 - [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

Author: jonastoth Date: Fri Nov 2 09:36:21 2018 New Revision: 345995 URL: http://llvm.org/viewvc/llvm-project?rev=345995&view=rev Log: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds r345961 introduced a path check in .\tools\clang\tools\extra\test\clang-tidy\

[clang-tools-extra] r346173 - [clang-tidy] doc removew hitespace in front of code-block-line

Author: jonastoth Date: Mon Nov 5 14:21:27 2018 New Revision: 346173 URL: http://llvm.org/viewvc/llvm-project?rev=346173&view=rev Log: [clang-tidy] doc removew hitespace in front of code-block-line Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/boost-use-to-string.rst clang-to

[clang-tools-extra] r346176 - [clang-tidy] fix example code-blocks indendation

Author: jonastoth Date: Mon Nov 5 14:30:17 2018 New Revision: 346176 URL: http://llvm.org/viewvc/llvm-project?rev=346176&view=rev Log: [clang-tidy] fix example code-blocks indendation Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst

r346554 - [ASTMatchers] overload ignoringParens for Expr

Author: jonastoth Date: Fri Nov 9 12:54:06 2018 New Revision: 346554 URL: http://llvm.org/viewvc/llvm-project?rev=346554&view=rev Log: [ASTMatchers] overload ignoringParens for Expr Summary: This patch allows fixing PR39583. Reviewers: aaron.ballman, sbenza, klimek Reviewed By: aaron.ballman

[clang-tools-extra] r346555 - [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

Author: jonastoth Date: Fri Nov 9 12:57:28 2018 New Revision: 346555 URL: http://llvm.org/viewvc/llvm-project?rev=346555&view=rev Log: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay Summary: The fix to the issue that `const char* p = ("foo

[clang-tools-extra] r346665 - [clang-tidy] new check: bugprone-too-small-loop-variable

Author: jonastoth Date: Mon Nov 12 08:01:39 2018 New Revision: 346665 URL: http://llvm.org/viewvc/llvm-project?rev=346665&view=rev Log: [clang-tidy] new check: bugprone-too-small-loop-variable The new checker searches for those for loops which has a loop variable with a "too small" type which me

[clang-tools-extra] r346676 - [clang-tidy] fix ARM tests, because int and long have same width

Author: jonastoth Date: Mon Nov 12 09:02:05 2018 New Revision: 346676 URL: http://llvm.org/viewvc/llvm-project?rev=346676&view=rev Log: [clang-tidy] fix ARM tests, because int and long have same width Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-too-small-loop-variable.cpp Modi

[clang-tools-extra] r346678 - Revert "Add a test checking clang-tidy can find libc++ on Mac"

Author: jonastoth Date: Mon Nov 12 09:22:36 2018 New Revision: 346678 URL: http://llvm.org/viewvc/llvm-project?rev=346678&view=rev Log: Revert "Add a test checking clang-tidy can find libc++ on Mac" This reverts commit r346653. Removed: clang-tools-extra/trunk/test/clang-tidy/Inputs/mock-li

r347676 - Revert "[clang] - Simplify tools::SplitDebugName."

Author: jonastoth Date: Tue Nov 27 09:28:38 2018 New Revision: 347676 URL: http://llvm.org/viewvc/llvm-project?rev=347676&view=rev Log: Revert "[clang] - Simplify tools::SplitDebugName." This reverts commit r347035 as it introduced assertion failures under certain conditions. More information can

[clang-tools-extra] r348161 - [clang-tidy] Add the abseil-duration-comparison check

Author: jonastoth Date: Mon Dec 3 10:35:56 2018 New Revision: 348161 URL: http://llvm.org/viewvc/llvm-project?rev=348161&view=rev Log: [clang-tidy] Add the abseil-duration-comparison check Summary: This check finds instances where Duration values are being converted to a numeric value in a comp

[clang-tools-extra] r348165 - Revert "[clang-tidy] Add the abseil-duration-comparison check"

Author: jonastoth Date: Mon Dec 3 10:59:27 2018 New Revision: 348165 URL: http://llvm.org/viewvc/llvm-project?rev=348165&view=rev Log: Revert "[clang-tidy] Add the abseil-duration-comparison check" This commit broke buildbots and needs adjustments. Removed: clang-tools-extra/trunk/clang-tid

[clang-tools-extra] r348169 - [clang-tidy] Recommit: Add the abseil-duration-comparison check

Author: jonastoth Date: Mon Dec 3 11:22:08 2018 New Revision: 348169 URL: http://llvm.org/viewvc/llvm-project?rev=348169&view=rev Log: [clang-tidy] Recommit: Add the abseil-duration-comparison check Summary: This check finds instances where Duration values are being converted to a numeric value

[clang-tools-extra] r348172 - [clang-tidy] Fix unordered_map failure with specializing std::hash<> and remove previous wrong attempt at doing so

Author: jonastoth Date: Mon Dec 3 11:41:04 2018 New Revision: 348172 URL: http://llvm.org/viewvc/llvm-project?rev=348172&view=rev Log: [clang-tidy] Fix unordered_map failure with specializing std::hash<> and remove previous wrong attempt at doing so Modified: clang-tools-extra/trunk/clang-t

[clang-tools-extra] r348341 - Fix a false positive in misplaced-widening-cast

Author: jonastoth Date: Wed Dec 5 00:29:56 2018 New Revision: 348341 URL: http://llvm.org/viewvc/llvm-project?rev=348341&view=rev Log: Fix a false positive in misplaced-widening-cast Summary: bugprone-misplaced-widening-cast check used to give a false warning to the following example. enum Day

[clang-tools-extra] r348343 - [clang-tidy] new check: bugprone-branch-clone

Author: jonastoth Date: Wed Dec 5 01:16:25 2018 New Revision: 348343 URL: http://llvm.org/viewvc/llvm-project?rev=348343&view=rev Log: [clang-tidy] new check: bugprone-branch-clone Summary: Implement a check for detecting if/else if/else chains where two or more branches are Type I clones of eac

[clang-tools-extra] r348344 - Revert "[clang-tidy] new check: bugprone-branch-clone"

Author: jonastoth Date: Wed Dec 5 01:34:18 2018 New Revision: 348344 URL: http://llvm.org/viewvc/llvm-project?rev=348344&view=rev Log: Revert "[clang-tidy] new check: bugprone-branch-clone" The patch broke on buildbot with assertion-failure. Revert until this is figured out. Removed: clang-

[clang-tools-extra] r348793 - [clang-tidy] insert release notes for new checkers alphabetically

Author: jonastoth Date: Mon Dec 10 11:41:53 2018 New Revision: 348793 URL: http://llvm.org/viewvc/llvm-project?rev=348793&view=rev Log: [clang-tidy] insert release notes for new checkers alphabetically Summary: Almost all code review comments on new checkers {D55433} {D48866} {D54349} seem to a

[clang-tools-extra] r348840 - [clang-tidy] NFC Consolidate test absl::Time implementation

Author: jonastoth Date: Tue Dec 11 04:42:17 2018 New Revision: 348840 URL: http://llvm.org/viewvc/llvm-project?rev=348840&view=rev Log: [clang-tidy] NFC Consolidate test absl::Time implementation Summary: Several tests re-implement these same prototypes (differently), so we can put them in a com

[clang-tools-extra] r348842 - Use the standard Duration factory matcher

Author: jonastoth Date: Tue Dec 11 04:45:51 2018 New Revision: 348842 URL: http://llvm.org/viewvc/llvm-project?rev=348842&view=rev Log: Use the standard Duration factory matcher Summary: A new check came in over the weekend; it should use our existing infrastructure for matching `absl::Duration`

[clang-tools-extra] r354903 - [clang-tidy] undo bitfields in ExceptionAnalyzer

Author: jonastoth Date: Tue Feb 26 10:15:17 2019 New Revision: 354903 URL: http://llvm.org/viewvc/llvm-project?rev=354903&view=rev Log: [clang-tidy] undo bitfields in ExceptionAnalyzer Scoped enums do induce some problems with some MSVC and GCC versions if used as bitfields. Therefor this is deac

[clang-tools-extra] r355093 - [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

Author: jonastoth Date: Thu Feb 28 06:55:12 2019 New Revision: 355093 URL: http://llvm.org/viewvc/llvm-project?rev=355093&view=rev Log: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions Addresses the bugzilla bug #30397. (https://bugs.llvm.org/show_bug.cgi?id=30397) modernize-use-ov

[clang-tools-extra] r355094 - [clang-tidy] attempt to fix documentation build-error

Author: jonastoth Date: Thu Feb 28 07:01:17 2019 New Revision: 355094 URL: http://llvm.org/viewvc/llvm-project?rev=355094&view=rev Log: [clang-tidy] attempt to fix documentation build-error Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified: clang-

[clang-tools-extra] r355095 - [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block

Author: jonastoth Date: Thu Feb 28 07:18:54 2019 New Revision: 355095 URL: http://llvm.org/viewvc/llvm-project?rev=355095&view=rev Log: [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil

[clang-tools-extra] r355097 - [clang-tidy] tryfix documenation continued

Author: jonastoth Date: Thu Feb 28 07:28:36 2019 New Revision: 355097 URL: http://llvm.org/viewvc/llvm-project?rev=355097&view=rev Log: [clang-tidy] tryfix documenation continued Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-subtraction.rst Modified: clang-tools-

[clang-tools-extra] r355098 - [clang-tidy] documentation fixing the actual correct file

Author: jonastoth Date: Thu Feb 28 07:39:47 2019 New Revision: 355098 URL: http://llvm.org/viewvc/llvm-project?rev=355098&view=rev Log: [clang-tidy] documentation fixing the actual correct file Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified: cl

[clang-tools-extra] r355100 - [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection

Author: jonastoth Date: Thu Feb 28 07:47:10 2019 New Revision: 355100 URL: http://llvm.org/viewvc/llvm-project?rev=355100&view=rev Log: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection Modified: clang-tools-extra/trunk/docs/clang-tidy/c

[clang-tools-extra] r355102 - [clang-tidy] redirection in list of checks adjusted

Author: jonastoth Date: Thu Feb 28 07:56:40 2019 New Revision: 355102 URL: http://llvm.org/viewvc/llvm-project?rev=355102&view=rev Log: [clang-tidy] redirection in list of checks adjusted Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified: clang-tools-extra/trunk/docs

[clang-tools-extra] r355108 - [clang-tidy] fix documentation link in list of clang-tidy checks

Author: jonastoth Date: Thu Feb 28 09:53:51 2019 New Revision: 355108 URL: http://llvm.org/viewvc/llvm-project?rev=355108&view=rev Log: [clang-tidy] fix documentation link in list of clang-tidy checks Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified: clang-tools-ext

[clang-tools-extra] r342393 - [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

Author: jonastoth Date: Mon Sep 17 06:55:10 2018 New Revision: 342393 URL: http://llvm.org/viewvc/llvm-project?rev=342393&view=rev Log: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly Summary: PR37913 documents wrong behaviour for a templated exception factory function.

[clang-tools-extra] r342458 - [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

Author: jonastoth Date: Tue Sep 18 03:15:15 2018 New Revision: 342458 URL: http://llvm.org/viewvc/llvm-project?rev=342458&view=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment Summary: This patch uses CHECK-NOTES for the tests. Its part of an effort to test *ALL* gener

[clang-tools-extra] r342459 - [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

Author: jonastoth Date: Tue Sep 18 03:21:33 2018 New Revision: 342459 URL: http://llvm.org/viewvc/llvm-project?rev=342459&view=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun, cfe

[clang-tools-extra] r342468 - [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

Author: jonastoth Date: Tue Sep 18 04:49:20 2018 New Revision: 342468 URL: http://llvm.org/viewvc/llvm-project?rev=342468&view=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits

[clang-tools-extra] r343000 - [clang-tidy] Add modernize-concat-nested-namespaces check

Author: jonastoth Date: Tue Sep 25 11:12:28 2018 New Revision: 343000 URL: http://llvm.org/viewvc/llvm-project?rev=343000&view=rev Log: [clang-tidy] Add modernize-concat-nested-namespaces check Summary: Finds instances of namespaces concatenated using explicit syntax, such as `namespace a { name

[clang-tools-extra] r343001 - [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects

Author: jonastoth Date: Tue Sep 25 11:15:52 2018 New Revision: 343001 URL: http://llvm.org/viewvc/llvm-project?rev=343001&view=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: xazax.

[clang-tools-extra] r343198 - [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace

Author: jonastoth Date: Thu Sep 27 05:17:59 2018 New Revision: 343198 URL: http://llvm.org/viewvc/llvm-project?rev=343198&view=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace Reviewers: aaron.ballman, alexfh, hokein Subscribers: xazax.hun, cfe-commits D

[clang-tools-extra] r343199 - [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move

Author: jonastoth Date: Thu Sep 27 05:22:48 2018 New Revision: 343199 URL: http://llvm.org/viewvc/llvm-project?rev=343199&view=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move Reviewers: alexfh, aaron.ballman, hokein Subscribers: xazax.hun, cfe-commits Differential Rev

[clang-tools-extra] r343201 - [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage

Author: jonastoth Date: Thu Sep 27 05:30:44 2018 New Revision: 343201 URL: http://llvm.org/viewvc/llvm-project?rev=343201&view=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage Reviewers: alexfh, aaron.ballman, hokein Subscribers: xazax.hun, cfe-commits Different

[clang-tools-extra] r343564 - [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory

Author: jonastoth Date: Tue Oct 2 02:38:20 2018 New Revision: 343564 URL: http://llvm.org/viewvc/llvm-project?rev=343564&view=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanja

[clang-tools-extra] r343565 - [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto

Author: jonastoth Date: Tue Oct 2 02:38:26 2018 New Revision: 343565 URL: http://llvm.org/viewvc/llvm-project?rev=343565&view=rev Log: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanjai, x

[clang-tools-extra] r343673 - [clang-tidy] NFC reorder registering in CppCoreGuidelines module

Author: jonastoth Date: Wed Oct 3 03:37:19 2018 New Revision: 343673 URL: http://llvm.org/viewvc/llvm-project?rev=343673&view=rev Log: [clang-tidy] NFC reorder registering in CppCoreGuidelines module Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.

[clang-tools-extra] r343788 - [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check.

Author: jonastoth Date: Thu Oct 4 08:47:57 2018 New Revision: 343788 URL: http://llvm.org/viewvc/llvm-project?rev=343788&view=rev Log: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check. Summary: Option to check for different naming conventions on the following

[clang-tools-extra] r343789 - [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up

Author: jonastoth Date: Thu Oct 4 08:49:25 2018 New Revision: 343789 URL: http://llvm.org/viewvc/llvm-project?rev=343789&view=rev Log: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up Summary: The check bugprone-exception-escape should not register if -fno-exceptions is set for the c

[clang-tools-extra] r343791 - [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

Author: jonastoth Date: Thu Oct 4 08:55:37 2018 New Revision: 343791 URL: http://llvm.org/viewvc/llvm-project?rev=343791&view=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: lebed

[clang-tools-extra] r343792 - [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments

Author: jonastoth Date: Thu Oct 4 08:59:30 2018 New Revision: 343792 URL: http://llvm.org/viewvc/llvm-project?rev=343792&view=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: xazax.hun, cf

[clang-tools-extra] r343796 - [clangd] fix another ambigous constructor in DexTest

Author: jonastoth Date: Thu Oct 4 09:29:58 2018 New Revision: 343796 URL: http://llvm.org/viewvc/llvm-project?rev=343796&view=rev Log: [clangd] fix another ambigous constructor in DexTest Modified: clang-tools-extra/trunk/unittests/clangd/DexTests.cpp Modified: clang-tools-extra/trunk/unitt

[clang-tools-extra] r343797 - [clang-tidy] fix failing unit tests

Author: jonastoth Date: Thu Oct 4 09:39:41 2018 New Revision: 343797 URL: http://llvm.org/viewvc/llvm-project?rev=343797&view=rev Log: [clang-tidy] fix failing unit tests The removal from the FIX-IT notes through the check-clang-tidy script was done incorrect. I did not detect beforehand but adj

[clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

Author: jonastoth Date: Fri Oct 5 06:36:00 2018 New Revision: 343848 URL: http://llvm.org/viewvc/llvm-project?rev=343848&view=rev Log: [clang-tidy] Replace deprecated std::ios_base aliases This check warns the uses of the deprecated member types of std::ios_base and replaces those that have a no

[clang-tools-extra] r343850 - [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext

Author: jonastoth Date: Fri Oct 5 07:15:19 2018 New Revision: 343850 URL: http://llvm.org/viewvc/llvm-project?rev=343850&view=rev Log: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext Summary: This patch is a small refactoring necessary for 'readability-isolate-declaration'

Re: [clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

m not alone seeing it. > This is still giving the warning with clang 3.6. > > Thanks, > Mikael > >> Regards, >> Mikael >> >> On 10/05/2018 03:36 PM, Jonas Toth via cfe-commits wrote: >>> Author: jonastoth >>> Date: Fri Oct 5 06:36:00 2018 >

  1   2   >