Alexey, Hans,
does it make sense to backport for 7.0 as it fixes PR37580?
Thanks,
Jonas
On 2018-08-13 21:04, Alexey Bataev via cfe-commits wrote:
Author: abataev
Date: Mon Aug 13 12:04:24 2018
New Revision: 339603
URL: http://llvm.org/viewvc/llvm-project?rev=339603&view=rev
Log:
[OPENMP] Fix
Jonas Hahnfeld via cfe-commits пишет:
Alexey, Hans,
does it make sense to backport for 7.0 as it fixes PR37580?
Thanks,
Jonas
On 2018-08-13 21:04, Alexey Bataev via cfe-commits wrote:
Author: abataev
Date: Mon Aug 13 12:04:24 2018
New Revision: 339603
URL: http://llvm.org/viewvc/llvm-project?rev=3
Author: hahnfeld
Date: Fri May 25 08:56:12 2018
New Revision: 333283
URL: http://llvm.org/viewvc/llvm-project?rev=333283&view=rev
Log:
[Sema] Add tests for weak functions
I found these checks to be missing, just add some simple cases.
Differential Revision: https://reviews.llvm.org/D47200
Modif
Author: hahnfeld
Date: Wed Sep 27 11:12:34 2017
New Revision: 314329
URL: http://llvm.org/viewvc/llvm-project?rev=314329&view=rev
Log:
[OpenMP] Fix passing of -m arguments to device toolchain
AuxTriple is not set if host and device share a toolchain. Also,
removing an argument modifies the DAL wh
Author: hahnfeld
Date: Wed Sep 27 11:12:31 2017
New Revision: 314328
URL: http://llvm.org/viewvc/llvm-project?rev=314328&view=rev
Log:
[OpenMP] Fix memory leak when translating arguments
Parsing the argument after -Xopenmp-target allocates memory that needs
to be freed. Associate it with the fina
Author: hahnfeld
Date: Wed Sep 27 11:12:36 2017
New Revision: 314330
URL: http://llvm.org/viewvc/llvm-project?rev=314330&view=rev
Log:
[OpenMP] Fix translation of target args
ToolChain::TranslateArgs() returns nullptr if no changes are performed.
This would currently mean that OpenMPArgs are lost
Author: hahnfeld
Date: Mon Oct 2 10:50:11 2017
New Revision: 314691
URL: http://llvm.org/viewvc/llvm-project?rev=314691&view=rev
Log:
[CUDA] Fix name of __activemask()
The name has two underscores in the official CUDA documentation:
http://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html
Author: hahnfeld
Date: Wed Oct 4 06:32:59 2017
New Revision: 314902
URL: http://llvm.org/viewvc/llvm-project?rev=314902&view=rev
Log:
[OpenMP] Fix passing of -m arguments correctly
The recent fix in D38258 was wrong: getAuxTriple() only returns
non-null values for the CUDA toolchain. That is why
Author: hahnfeld
Date: Wed Oct 4 06:54:09 2017
New Revision: 314904
URL: http://llvm.org/viewvc/llvm-project?rev=314904&view=rev
Log:
[test] Pass in fixed triple for openmp-offload.c
This should fix the test on other architectures.
Related to: https://reviews.llvm.org/D38372
Modified:
cfe/
Author: hahnfeld
Date: Mon Oct 16 06:31:30 2017
New Revision: 315902
URL: http://llvm.org/viewvc/llvm-project?rev=315902&view=rev
Log:
[CUDA] Require libdevice only if needed
If the user passes -nocudalib, we can live without it being present.
Simplify the code by just checking whether LibDeviceM
Author: hahnfeld
Date: Tue Oct 17 06:37:36 2017
New Revision: 315996
URL: http://llvm.org/viewvc/llvm-project?rev=315996&view=rev
Log:
[CMake][OpenMP] Customize default offloading arch
For the shuffle instructions in reductions we need at least sm_30
but the user may want to customize the default
Author: hahnfeld
Date: Tue Oct 17 07:28:14 2017
New Revision: 316001
URL: http://llvm.org/viewvc/llvm-project?rev=316001&view=rev
Log:
[OpenMP] Implement omp_is_initial_device() as builtin
This allows to return the static value that we know at compile time.
Differential Revision: https://reviews
Author: hahnfeld
Date: Fri Oct 20 12:40:40 2017
New Revision: 316229
URL: http://llvm.org/viewvc/llvm-project?rev=316229&view=rev
Log:
[OpenMP] Avoid VLAs for some reductions on array sections
In some cases the compiler can deduce the length of an array section
as constants. With this information
Author: hahnfeld
Date: Fri Oct 20 13:16:17 2017
New Revision: 316235
URL: http://llvm.org/viewvc/llvm-project?rev=316235&view=rev
Log:
Revert "[OpenMP] Avoid VLAs for some reductions on array sections"
This breaks at least two buildbots:
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-l
Author: hahnfeld
Date: Mon Oct 23 12:01:35 2017
New Revision: 316362
URL: http://llvm.org/viewvc/llvm-project?rev=316362&view=rev
Log:
[OpenMP] Avoid VLAs for some reductions on array sections
In some cases the compiler can deduce the length of an array section
as constants. With this information
Author: hahnfeld
Date: Sat Aug 25 06:42:40 2018
New Revision: 340681
URL: http://llvm.org/viewvc/llvm-project?rev=340681&view=rev
Log:
[CUDA/OpenMP] Define only some host macros during device compilation
When compiling CUDA or OpenMP device code Clang parses header files
that expect certain prede
On 2018-07-19 15:43, Hal Finkel wrote:
On 07/16/2018 01:19 PM, Jonas Hahnfeld wrote:
[ Moving discussion from https://reviews.llvm.org/D49386 to the
relevant comment on cfe-commits, CC'ing Hal who commented on the
original issue ]
Is this change really a good idea? It always requires libatomic
On 2018-07-19 20:55, Hal Finkel wrote:
On 07/19/2018 09:01 AM, Jonas Hahnfeld wrote:
On 2018-07-19 15:43, Hal Finkel wrote:
On 07/16/2018 01:19 PM, Jonas Hahnfeld wrote:
[ Moving discussion from https://reviews.llvm.org/D49386 to the
relevant comment on cfe-commits, CC'ing Hal who commented on
Author: hahnfeld
Date: Mon Jul 23 11:27:09 2018
New Revision: 337722
URL: http://llvm.org/viewvc/llvm-project?rev=337722&view=rev
Log:
Revert "[OPENMP] Fix PR38026: Link -latomic when -fopenmp is used."
This reverts commit r336467: libatomic is not available on all Linux
systems and this commit c
[ + cfe-commits ]
Reverted in r337722, I've reopened the bug.
Regards,
Jonas
On 2018-07-23 11:37, Alexey Bataev wrote:
Hi Jonas, yes, go ahead.
Best regards,
Alexey Bataev
23 июля 2018 г., в 5:16, Jonas Hahnfeld
написал(а):
On 2018-07-23 11:08, Jonas Hahnfeld via cfe-commits
Hi Eric,
this breaks
test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pass.cpp
for me:
In access_denied_on_recursion_test_case():176 Assertion TEST_CHECK(ec)
failed.
in file:
<<>>/projects/libcxx/test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.it
Thanks for your work, the test is now passing on my system.
Cheers,
Jonas
On 2018-07-24 01:00, Eric Fiselier wrote:
Sorry for the repeated emails. I did more digging and we were indeed
handling DT_UNKNOWN incorrectly.
I've fixed that in r337768.
/Eric
On Mon, Jul 23, 2018 at 4:43 PM Eric Fise
Hi Alexey,
maybe we can now raise the version generally? Is that something that we
want to do before branching for 7.0?
According to http://clang.llvm.org/docs/OpenMPSupport.html, all
directives of OpenMP 4.5 are supported (even if Clang may not generate
optimal code).
Cheers,
Jonas
On 2018
Hi Alexey,
On 2018-07-26 19:53, Alexey Bataev via cfe-commits wrote:
Author: abataev
Date: Thu Jul 26 10:53:45 2018
New Revision: 338049
URL: http://llvm.org/viewvc/llvm-project?rev=338049&view=rev
Log:
[OPENMP] What's new for OpenMP in clang.
Updated ReleaseNotes + Status of the OpenMP suppor
Hi Alexey,
from what I can see this change can't handle the case where there are
static variables with the same name in multiple TUs.
(The same problem exists for static CUDA kernels with -fcuda-rdc. I
found that nvcc mangles the function names in this case, but didn't have
time yet to prepare
I just noticed that UsersManual says: "Clang supports all OpenMP 3.1
directives and clauses." Maybe this should link to OpenMPSupport?
On 2018-07-26 19:53, Alexey Bataev via cfe-commits wrote:
Author: abataev
Date: Thu Jul 26 10:53:45 2018
New Revision: 338049
URL: http://llvm.org/viewvc/llvm-
Author: hahnfeld
Date: Tue Jul 31 04:36:14 2018
New Revision: 338360
URL: http://llvm.org/viewvc/llvm-project?rev=338360&view=rev
Log:
Fix linux-header-search.cpp with CLANG_DEFAULT_CXX_STDLIB
This configuration was broken after r338294 because Clang might
be configured to always use libc++.
Mod
Author: hahnfeld
Date: Tue Jul 31 11:47:48 2018
New Revision: 338414
URL: http://llvm.org/viewvc/llvm-project?rev=338414&view=rev
Log:
Fix riscv32-toolchain.c with CLANG_DEFAULT_CXX_STDLIB
This configuration was (again) broken after r338385 because Clang
might be configured to always use libc++.
Author: hahnfeld
Date: Mon Feb 12 02:46:34 2018
New Revision: 324877
URL: http://llvm.org/viewvc/llvm-project?rev=324877&view=rev
Log:
[CUDA] Fix test cuda-external-tools.cu
This didn't verify the CHECK prefix before!
Differential Revision: https://reviews.llvm.org/D42920
Modified:
cfe/trun
Author: hahnfeld
Date: Mon Feb 12 02:46:45 2018
New Revision: 324878
URL: http://llvm.org/viewvc/llvm-project?rev=324878&view=rev
Log:
[CUDA] Add option to generate relocatable device code
As a first step, pass '-c/--compile-only' to ptxas so that it
doesn't complain about references to external
Author: hahnfeld
Date: Wed Feb 14 08:04:03 2018
New Revision: 325136
URL: http://llvm.org/viewvc/llvm-project?rev=325136&view=rev
Log:
[CUDA] Allow external variables in separate compilation
According to the CUDA Programming Guide this is prohibited in
whole program compilation mode. This makes s
Hi Alexey,
I think that's mostly my test case from PR35348?
Am 2018-02-16 22:23, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Fri Feb 16 13:23:23 2018
New Revision: 325391
URL: http://llvm.org/viewvc/llvm-project?rev=325391&view=rev
Log:
[OPENMP] Do not emit messages for templa
Author: hahnfeld
Date: Thu Feb 22 09:06:27 2018
New Revision: 325805
URL: http://llvm.org/viewvc/llvm-project?rev=325805&view=rev
Log:
[docs] Fix duplicate arguments for JoinedAndSeparate
We can't see how many arguments are in the meta var name, so just
assume that it is the right number.
Differ
Author: hahnfeld
Date: Thu Feb 22 09:06:35 2018
New Revision: 325806
URL: http://llvm.org/viewvc/llvm-project?rev=325806&view=rev
Log:
[docs] Improve help for OpenMP options, NFC.
* Add HelpText for -fopenmp so that it appears in clang --help.
* Hide -fno-openmp-simd, only list the positive opt
Author: hahnfeld
Date: Thu Feb 22 09:10:28 2018
New Revision: 325807
URL: http://llvm.org/viewvc/llvm-project?rev=325807&view=rev
Log:
[docs] Regenerate command line reference
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
Modified: cfe/trunk/docs/ClangCommandLineReference.rst
URL:
Author: hahnfeld
Date: Wed Dec 27 02:39:56 2017
New Revision: 321486
URL: http://llvm.org/viewvc/llvm-project?rev=321486&view=rev
Log:
[OpenMP] Further adjustments of nvptx runtime functions
Pass in default value of 1, similar to previous commit r318836.
Differential Revision: https://reviews.ll
Hi Alexey,
should this change be backported to 6.0?
Regards,
Jonas
Am 2018-01-04 20:45, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Thu Jan 4 11:45:16 2018
New Revision: 321816
URL: http://llvm.org/viewvc/llvm-project?rev=321816&view=rev
Log:
[OPENMP] Add debug info for gene
You mean r321818 and r321820? I skipped them because they are for NVPTX
and target directives which aren't fully functional in 6.0 anyway,
right?
Or patches in the future?
Am 2018-01-04 21:58, schrieb Alexey Bataev:
Hi Jonas, I don't think it is necessary. It is better to backport my 2
next pa
Can we backport this page to release_60? I think the documented support
is also valid for 6.0 or did I miss recent commits that added support
for new directives / clauses?
Am 2018-01-08 20:02, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Mon Jan 8 11:02:51 2018
New Revision: 3
Why is this NFC and doesn't change a test?
Am 2018-01-09 20:59, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Tue Jan 9 11:59:25 2018
New Revision: 322112
URL: http://llvm.org/viewvc/llvm-project?rev=322112&view=rev
Log:
[OPENMP] Fix directive kind on stand-alone target data dir
Author: hahnfeld
Date: Wed Feb 28 09:53:46 2018
New Revision: 326342
URL: http://llvm.org/viewvc/llvm-project?rev=326342&view=rev
Log:
[CUDA] Include single GPU binary, NFCI.
Binaries for multiple architectures are combined by fatbinary,
so the current code was effectively not needed.
Differenti
Hi Alexey,
Am 2018-03-02 18:17, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Fri Mar 2 09:17:12 2018
New Revision: 326590
URL: http://llvm.org/viewvc/llvm-project?rev=326590&view=rev
Log:
[OPENMP] Treat local variables in CUDA mode as thread local.
In CUDA mode all local varia
Author: hahnfeld
Date: Fri Jun 1 07:43:48 2018
New Revision: 333757
URL: http://llvm.org/viewvc/llvm-project?rev=333757&view=rev
Log:
[OpenMP] Fix typo in NVPTX linker, NFC.
Clang calls "nvlink" for linking multiple object files with OpenMP
target functions, so correct this information when prin
Author: hahnfeld
Date: Fri Jun 8 04:17:08 2018
New Revision: 334281
URL: http://llvm.org/viewvc/llvm-project?rev=334281&view=rev
Log:
[CUDA] Fix emission of constant strings in sections
CGM.GetAddrOfConstantCString() sets the adress of the created GlobalValue
to unnamed. When emitting the object
Author: hahnfeld
Date: Thu Sep 27 09:12:32 2018
New Revision: 343230
URL: http://llvm.org/viewvc/llvm-project?rev=343230&view=rev
Log:
[OpenMP] Improve search for libomptarget-nvptx
When looking for the bclib Clang considered the default library
path first while it preferred directories in LIBRAR
Author: hahnfeld
Date: Thu Sep 27 10:27:48 2018
New Revision: 343240
URL: http://llvm.org/viewvc/llvm-project?rev=343240&view=rev
Log:
Fix greedy FileCheck expression in test/Driver/mips-abi.c
'ld{{.*}}"' seems to match the complete line for me which is failing
the test. Only allow an optional '.
Does this fix an issue or is it just 'this looks incorrect'?
__kmpc_data_sharing_push_stack has an extra case if the runtime is
uninitialized, so AFAICS the initialization in __kmpc_spmd_kernel_init
should not be needed.
If the runtime needs to be initialized Clang emits a call to
__kmpc_data
Author: hahnfeld
Date: Tue Oct 2 12:12:54 2018
New Revision: 343618
URL: http://llvm.org/viewvc/llvm-project?rev=343618&view=rev
Log:
[OpenMP][NVPTX] Simplify codegen for orphaned parallel, NFCI.
Worker threads fork off to the compiler generated worker function
directly after entering the kernel
Author: hahnfeld
Date: Tue Oct 2 12:12:47 2018
New Revision: 343617
URL: http://llvm.org/viewvc/llvm-project?rev=343617&view=rev
Log:
[OpenMP] Simplify code for reductions on distribute directives, NFC.
Only need to care about the 'distribute simd' case, all other composite
directives are handle
Author: hahnfeld
Date: Fri Apr 20 06:04:54 2018
New Revision: 330426
URL: http://llvm.org/viewvc/llvm-project?rev=330426&view=rev
Log:
[CUDA] Document recent changes
* Finding installations via ptxas binary
* Relocatable device code
Differential Revision: https://reviews.llvm.org/D45449
Modif
Author: hahnfeld
Date: Fri Apr 20 06:04:45 2018
New Revision: 330425
URL: http://llvm.org/viewvc/llvm-project?rev=330425&view=rev
Log:
[CUDA] Register relocatable GPU binaries
nvcc generates a unique registration function for each object file
that contains relocatable device code. Unique names ar
Author: hahnfeld
Date: Fri Apr 20 06:26:03 2018
New Revision: 330430
URL: http://llvm.org/viewvc/llvm-project?rev=330430&view=rev
Log:
[docs] Regenerate command line reference
This will correctly sort some manually added entries which should
generally be avoided!
Modified:
cfe/trunk/docs/Cla
Author: hahnfeld
Date: Fri Apr 20 06:25:59 2018
New Revision: 330429
URL: http://llvm.org/viewvc/llvm-project?rev=330429&view=rev
Log:
[OpenMP] Hide -fopenmp-cuda-mode
This is an advanced flag that should show up neither in clang --help
nor in the ClangCommandLineReference.
Modified:
cfe/tru
[ Moving discussion from https://reviews.llvm.org/D49386 to the relevant
comment on cfe-commits, CC'ing Hal who commented on the original issue ]
Is this change really a good idea? It always requires libatomic for all
OpenMP applications, even if there is no 'omp atomic' directive or all
of th
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D24601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
In https://reviews.llvm.org/D24601#553482, @vsk wrote:
> It should be fine to XFAIL this test temporarily. Is there a PR for this?
I've now created an entry in Bugzilla:
https://llvm.org/bugs/show_bug.cgi?id=30548
https://reviews.llvm.org/D24601
_
Hahnfeld updated the summary for this revision.
Hahnfeld updated this revision to Diff 72765.
Hahnfeld added a comment.
Link PR
https://reviews.llvm.org/D24601
Files:
test/Driver/darwin-stdlib.cpp
test/lit.cfg
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
=
Author: hahnfeld
Date: Thu Sep 29 02:43:08 2016
New Revision: 282701
URL: http://llvm.org/viewvc/llvm-project?rev=282701&view=rev
Log:
XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set
Until someone rewrites the stdlib logic for Darwin so that we don't need
to pass down the -stdli
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282701: XFAIL Driver/darwin-stdlib.cpp if
CLANG_DEFAULT_CXX_STDLIB is set (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D24601?vs=72765&id=72960#toc
Repository:
rL LLVM
h
Hahnfeld added a comment.
ping?
https://reviews.llvm.org/D22452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
Have you run all tests with `CLANG_DEFAULT_LINKER` not being the platform
default? I imagine there might be some tests that expect `ld` to be used...
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use
Hahnfeld created this revision.
Hahnfeld added reviewers: mgorny, ddunbar, phosek.
Hahnfeld added subscribers: cfe-commits, zlei.
I made the wrong assumption that execution would continue after an error Diag
which led to unneeded complex code.
This patch aligns with the better implementation of
Author: hahnfeld
Date: Wed Nov 22 06:46:49 2017
New Revision: 318836
URL: http://llvm.org/viewvc/llvm-project?rev=318836&view=rev
Log:
[OpenMP] Adjust arguments of nvptx runtime functions
In the future the compiler will analyze whether the OpenMP
runtime needs to be (fully) initialized and avoid
Author: hahnfeld
Date: Wed Dec 6 11:15:28 2017
New Revision: 319931
URL: http://llvm.org/viewvc/llvm-project?rev=319931&view=rev
Log:
Fix PR35542: Correct adjusting of private reduction variable
The adjustment is calculated with CreatePtrDiff() which returns
the difference in (base) elements. Th
Hi Ahmed,
Am 2017-12-07 19:57, schrieb Ahmed Bougacha:
Hi Jonas,
On Tue, Oct 17, 2017 at 6:37 AM, Jonas Hahnfeld via cfe-commits
wrote:
Author: hahnfeld
Date: Tue Oct 17 06:37:36 2017
New Revision: 315996
URL: http://llvm.org/viewvc/llvm-project?rev=315996&view=rev
Log:
[CMake][Op
Am 2017-12-07 20:34, schrieb Jonas Hahnfeld via cfe-commits:
Hi Ahmed,
Am 2017-12-07 19:57, schrieb Ahmed Bougacha:
Hi Jonas,
On Tue, Oct 17, 2017 at 6:37 AM, Jonas Hahnfeld via cfe-commits
wrote:
Author: hahnfeld
Date: Tue Oct 17 06:37:36 2017
New Revision: 315996
URL: http://llvm.org
Author: Jonas Hahnfeld
Date: 2022-09-12T13:49:57+02:00
New Revision: f0403c853bc93fe1127fef7493a4feff1479191e
URL:
https://github.com/llvm/llvm-project/commit/f0403c853bc93fe1127fef7493a4feff1479191e
DIFF:
https://github.com/llvm/llvm-project/commit/f0403c853bc93fe1127fef7493a4feff1479191e.diff
hahnjo wrote:
ping @shafik @cor3ntin @ChuanqiXu9, how can we make progress here?
https://github.com/llvm/llvm-project/pull/69076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hahnjo closed https://github.com/llvm/llvm-project/pull/68253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hahnjo wrote:
I can add the comment as requested, but for the other questions related to full
expressions and modules I'd really need input from experts...
https://github.com/llvm/llvm-project/pull/69076
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/hahnjo approved this pull request.
Very interesting... See also https://github.com/llvm/llvm-project/issues/68092,
now I understand even less what the problem is...
https://github.com/llvm/llvm-project/pull/70991
___
cfe-commits mai
https://github.com/hahnjo approved this pull request.
Looks reasonable to me. I know this fixes a test error for MinGW, but if
possible maybe let it sit until early next week in case somebody else has a
different opinion on moving `host=` to `lit`.
https://github.com/llvm/llvm-project/pull/711
hahnjo wrote:
I tried to craft a test here, but declaration unloading in `clang-repl` is not
powerful enough (yet) to show a (user-visible) consequence of the problem.
On a high level, the problem should be triggered by:
```
clang-repl> template struct A { void f() { } };
clang-repl> A().f();
https://github.com/hahnjo closed https://github.com/llvm/llvm-project/pull/73955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hahnjo created
https://github.com/llvm/llvm-project/pull/73955
Before, it was only cleared if there were undefined entities. This is important
for Clang's incremental parsing as used by `clang-repl` that might receive
multiple calls to `Sema.ActOnEndOfTranslationUnit`.
>Fro
hahnjo wrote:
I will try, but observing the consequences of this depends on unloading:
Basically it happens if a declaration in `UndefinedButUsed` thas was previously
defined is unloaded, which makes it undefined. For now, it's possible that for
the upstream cases it's only an optimization bec
https://github.com/hahnjo created
https://github.com/llvm/llvm-project/pull/76473
`ParmVarDecl::getDefaultArg()` strips the outermost `FullExpr`, such as
`ExprWithCleanups`. This leads to an `llvm_unreachable` being executed with the
added test `clang/test/Modules/pr68702.cpp`; instead use the
https://github.com/hahnjo updated
https://github.com/llvm/llvm-project/pull/69076
>From a55ca99a373b17501d56d18af9e8aa2dc2cbcea0 Mon Sep 17 00:00:00 2001
From: Jonas Hahnfeld
Date: Sat, 14 Oct 2023 20:10:28 +0200
Subject: [PATCH] Fix crash with modules and constexpr destructor
With modules, se
hahnjo wrote:
I finally had time to debug this: The reason for modules being involved here is
because the serialization code calls `ParmVarDecl::getDefaultArg()` which
strips the outermost `FullExpr`, such as `ExprWithCleanups`. A potential fix is
in https://github.com/llvm/llvm-project/pull/7
@@ -1249,3 +1249,5 @@ void ODRHash::AddQualType(QualType T) {
void ODRHash::AddBoolean(bool Value) {
Bools.push_back(Value);
}
+
+void ODRHash::AddInteger(unsigned Value) { ID.AddInteger(Value); }
hahnjo wrote:
The review related to `ODRHash` is this one: ht
hahnjo wrote:
Ping, is this ok to be accepted and landed?
> So personally I am fine with the current workaround with a `FIXME`.
You mean next to the comment I already added referring to the C++ standard? Can
you formulate what I should put there?
https://github.com/llvm/llvm-project/pull/6907
hahnjo wrote:
Well, this patch is up since almost three months now (!). Sure, we can keep
carrying a similar fix downstream, but ideally I would really like to get rid
of as many local changes as possible. That's not possible without proper
review, but the current situation is quite unsatisfac
@@ -1249,3 +1249,5 @@ void ODRHash::AddQualType(QualType T) {
void ODRHash::AddBoolean(bool Value) {
Bools.push_back(Value);
}
+
+void ODRHash::AddInteger(unsigned Value) { ID.AddInteger(Value); }
hahnjo wrote:
That test does not exercise an alias argument t
https://github.com/hahnjo edited https://github.com/llvm/llvm-project/pull/69076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hahnjo wrote:
> address my previous comment: [#69076
> (comment)](https://github.com/llvm/llvm-project/pull/69076#issuecomment-1780327252)
I had already expanded the commit message with the full details, now also
copied to the PR summary. Is that sufficient to address the comment?
https://git
https://github.com/hahnjo updated
https://github.com/llvm/llvm-project/pull/69076
>From a55ca99a373b17501d56d18af9e8aa2dc2cbcea0 Mon Sep 17 00:00:00 2001
From: Jonas Hahnfeld
Date: Sat, 14 Oct 2023 20:10:28 +0200
Subject: [PATCH 1/3] Fix crash with modules and constexpr destructor
With modules
@@ -15754,10 +15754,18 @@ bool Expr::EvaluateAsInitializer(APValue &Value,
const ASTContext &Ctx,
LValue LVal;
LVal.set(VD);
-if (!EvaluateInPlace(Value, Info, LVal, this,
- /*AllowNonLiteralTypes=*/true) ||
-EStatus.HasSideEffects)
hahnjo wrote:
> Please add a release note
> This change needs a release note. Please add an entry to
> `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change,
> and referencing any Github issue this change fixes. Thanks!
Done.
https://github.com/llvm/llvm-project/pull/69
Author: Jonas Hahnfeld
Date: 2022-06-30T21:25:14+02:00
New Revision: f22795de683d571bbf7e655a7b4ed5ccda186e66
URL:
https://github.com/llvm/llvm-project/commit/f22795de683d571bbf7e655a7b4ed5ccda186e66
DIFF:
https://github.com/llvm/llvm-project/commit/f22795de683d571bbf7e655a7b4ed5ccda186e66.diff
Author: Jonas Hahnfeld
Date: 2022-04-09T12:34:41+02:00
New Revision: e4903d8be399864cc978236fc4a28087f91c20fe
URL:
https://github.com/llvm/llvm-project/commit/e4903d8be399864cc978236fc4a28087f91c20fe
DIFF:
https://github.com/llvm/llvm-project/commit/e4903d8be399864cc978236fc4a28087f91c20fe.diff
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); };
// PartialTranslationUnit.
inline A::~A() { printf("~A(%d)\n", a); }
-// Create one instance with new and delete it.
+// Create one instance with new
@@ -2,56 +2,56 @@
// REQUIRES: nvptx-registered-target
// REQUIRES: zlib
-// RUN: not %clang -### --target=x86_64-linux-gnu -c %s -g -gz 2>&1 \
+// RUN: %clang -### --target=x86_64-linux-gnu --offload-arch=sm_52 -nogpulib
-nogpuinc -c %s -g -gz 2>&1 \
// RUN: | FileCheck %s
https://github.com/hahnjo closed https://github.com/llvm/llvm-project/pull/84008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hahnjo wrote:
https://github.com/llvm/llvm-project/pull/84017 changed the test in ways that
this isn't needed anymore.
https://github.com/llvm/llvm-project/pull/84008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -2,56 +2,56 @@
// REQUIRES: nvptx-registered-target
// REQUIRES: zlib
-// RUN: not %clang -### --target=x86_64-linux-gnu -c %s -g -gz 2>&1 \
+// RUN: %clang -### --target=x86_64-linux-gnu --offload-arch=sm_52 -nogpulib
-nogpuinc -c %s -g -gz 2>&1 \
// RUN: | FileCheck %s
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); };
// PartialTranslationUnit.
inline A::~A() { printf("~A(%d)\n", a); }
-// Create one instance with new and delete it.
+// Create one instance with new
hahnjo wrote:
> We had a lot that were like this previously. Guessing this one slipped
> through because of the `zlib` requirement.
I actually think there are some more left; for example
`clang/test/Driver/cuda-dwarf-2.cu` has many `not %clang` invocations that
don't specify `--cuda-path`. Th
hahnjo wrote:
> > It definitely doesn't work for the "pure" CUDA invocations, it still finds
> > my local installation and complains. It might work for the OpenMP
> > invocations, but hard to tell for me on a system with CUDA installed. As
> > it's a `.cu` test after all, I think I would prefe
hahnjo wrote:
> > > Might need `-nogpulib -nogpuinc` in those cases, we do that in other
> > > `.cu` files in the test suite.
> >
> >
> > No, I already tried that, it doesn't work for me. All
> > `clang/test/Driver/*.cu` that supply `-nocudainc` also pass `--cuda-path`...
>
> The only reason
hahnjo wrote:
Ok, but that still doesn't change the fact that the Clang driver will search
for a system-wide CUDA installation unless passed `--cuda-path`...
https://github.com/llvm/llvm-project/pull/84008
___
cfe-commits mailing list
cfe-commits@list
1 - 100 of 299 matches
Mail list logo
