[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0173e024fd9e: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370024. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp openmp

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a228f872fbb: [openmp] No longer use LIBRARY_PATH to find devicertl (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. In D109057#2977632 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/44930/step_7.txt > > Please take a look and revert if it takes a while to fix. Probably just need > to optionally accept win slash

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Nope, works the same as it used to - looks relative to clang. However I think it's broken some CI machines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 ___

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Bad times. Changing that to accept the / was a shotgun fix for the problem but it collides with one of the nearby regex, reverting while I work out what is going on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Using LIBRARY_PATH to find the bitcode is a reasonable interpretation of LIBRARY_PATH but it's a disaster in terms of using clang on a system that has LIBRARY_PATH pointing at some other version of clang. Rpath will be ignored by the bitcode lib handling. How d

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. That helps disambiguate. You aren't concerned that this change will break the in tree tests, rather that people who currently rely on LIBRARY_PATH to choose a bitcode library to use with a clang located somewhere else in the filesystem will now need to pass --li

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7cbf1a03ea6: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D109057?vs=370006&id=370040#toc Repository: rG LLVM G

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370047. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp openmp/libomptarget/test/lit.cfg Index: openmp/l

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Turns out {{.}} is also fine as far as Linux is concerned and unacceptable to Windows. I can't run anything on Windows locally, and trial and error while watching http://45.33.8.238/win has taken too many iterations already, so I've dropped the test case in 06cd

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370087. JonChesterfield added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield requested review of this revision. JonChesterfield added a comment. Sending back to review now that the test updates are included and LIBRARY_PATH removed from the test setup entirely Comment at: clang/test/Driver/openmp-offload-gpu.c:151 /// Check that the

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex:48 +#ifdef __NVPTX__ #pragma omp begin declare variant match( \ device = {arch(nvptx, nvptx64)}, \

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. @tianshilei1992 can we agree that the tests must point to a specific deviceRTL, and not dig one out of LIBRARY_PATH? That can be factored out of this patch to make the tests always use exactly the library that was just built, and also makes them easier to run ou

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Discussed at weekly call. Going to go with the priority order: 1/ commandline argument 2/ look next to clang 3/ LIBRARY_PATH 4/ error That means people who have installed clang+openmp together have something that works out of the box, and they can override the de

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 __

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Nice, thanks! I'll wait for the main CI to come back up before trying that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 ___

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371419. JonChesterfield added a comment. - Keep LIBRARY_PATH search, as fallback if local file is missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 File

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371450. JonChesterfield added a comment. - Use regex for windows path compat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolCha

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:153 -/// bitcode library and add it to the LIBRARY_PATH. -// RUN: env LIBRARY_PATH=%S/Inputs/libomptarget %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \ -// RUN: -Xo

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371605. JonChesterfield added a comment. - Add test checking LIBRARY_PATH is used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/To

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371614. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a581710c194: [openmp] No longer use LIBRARY_PATH to find devicertl (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. I'm seeing crashes in this area when running OvO, e.g. 0. $HOME/OvO/test_src/cpp/mathematical_function/cpp11-complex/pow_complex_float_complex_float_complex_float.cpp 1. $HOME/OvO/test_src/cpp/mathematical_function/cpp11-complex/pow_complex_float_complex_flo

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. Let's change to the uglier #ifdef for now, and add it to the short list of things that aren't quite right in declare variant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D10934

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. In D109344#2997495 , @jdoerfert wrote: > Can you please file a bug with a reproducer, I'm not sure I follow your > problem. Should be a case of trying to compile complex test cases for ovo for amdgpu immediately crashes

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Ah, nice! Thanks for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109770/new/ https://reviews.llvm.org/D109770 _

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

JonChesterfield added a comment. In D105191#3001508 , @saiislam wrote: > PS: We (mulit-company OpenMP-dev meetings) have been tracking this feature > for a while and we would very much like it to be picked for llvm-13. I think llvm-13 is on -final now s

<    4   5   6   7   8   9