[PATCH] D43630: [Driver] Fix search paths on x32

glaubitz added a comment. I have just rebased the patch and I am looking at the tests now. Repository: rC Clang https://reviews.llvm.org/D43630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D43630: [Driver] Fix search paths on x32

glaubitz added a comment. I don't think that "test/Driver/linux-header-search.cpp" needs to be updated. x32 is actually supported in both an x86_64-linux-gnu environment and x86_64-linux-gnux32 environment. In order to update test/Driver/linux-header-search.cpp, we would have to add a debian-10

[PATCH] D43630: [Driver] Fix search paths on x32

glaubitz added a comment. I have pushed a rebase revision here: https://reviews.llvm.org/D52050 I have no idea how to edit the author though. Repository: rC Clang https://reviews.llvm.org/D43630 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D52050: [Driver] Fix search paths on x32

glaubitz created this revision. glaubitz added reviewers: rsmith, dschuff. Herald added a subscriber: cfe-commits. When targeting x32, the x32 libraries and headers should be used, not the x86_64 ones (which may not even be available), so prioritise those and use the right multiarch triple. Repo

[PATCH] D52066: [Driver] Fix missing MultiArch include dir on powerpcspe

glaubitz created this revision. glaubitz added reviewers: kristina, dschuff. Herald added subscribers: cfe-commits, nemanjai. On powerpc-linux-gnuspe, the header files are located in their own include directory named /usr/lib/powerpc-linux-gnuspe, so add this directory to PPCMultiarchIncludeDirs.

[PATCH] D52066: [Driver] Fix missing MultiArch include dir on powerpcspe

glaubitz added a comment. I don't have commit access, btw. So it would be nice if someone else could commit this for me. Thanks! Repository: rC Clang https://reviews.llvm.org/D52066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D52066: [Driver] Fix missing MultiArch include dir on powerpcspe

glaubitz added a comment. Not sure how this is supposed to be tested as this requires a proper Debian powerpcspe chroot. I also checked saw that not all mips64 include paths are covered by the testsuite. Repository: rL LLVM https://reviews.llvm.org/D52066 ___

[PATCH] D43630: [Driver] Fix search paths on x32

glaubitz added a comment. As a heads-up, powerpcspe needs a similar treatment as it suffers from the same problem: cd build-llvm \ CFLAGS=`dpkg-buildflags --get CFLAGS`; \ CFLAGS="$CFLAGS `dpkg-buildflags --get CPPFLAGS`"; \ echo $CFLAGS; \ bin/clang++ -c $CFLAGS -std=c++11 ../lib/Fuzz

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz created this revision. glaubitz added reviewers: jrtc27, kristina. Herald added subscribers: cfe-commits, jsji, nemanjai. On SUSE distributions for 32-bit PowerPC, gcc is configured as a 64-bit compiler using the GNU triplet "powerpc64-suse-linux", but invoked with "-m32" by default. Thus

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. Well, I agree on the comment to clarify why it has to be powerpc64-suse-linux, but I'm not sure whether anyone will ever start a SUSE derivative for 32-bit PowerPC, then fix the path in SUSE's gcc and then do a mass-rebuild. I think the probability is pretty low. Rep

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz updated this revision to Diff 176830. glaubitz added a comment. Added a comment explaining the unusual triplet name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 Files: lib/Driver/ToolChains/Gnu.cpp Index:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

glaubitz added a comment. I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D54409 and https://reviews.llvm.org/D54583 saw no regressions on x86

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

glaubitz added a comment. In D49754#1323642 , @vit9696 wrote: > Might the first crash from https://reviews.llvm.org/D49754#1183753 reproduce > for you or perhaps you have already bisected to trunk to figure out the > changest that fixes it? Yes, it doe

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. Well, I don't really know what to add here. The GCCDIST path on 32-bit PowerPC SUSE distributions has always been "powerpc64-suse-linux" according to SUSE's gcc maintainer Richard Biener and my patch just fixes that. We're already using this patch in openSUSE without a

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

glaubitz added a comment. In D49754#1339161 , @vit9696 wrote: > Ok, I found the fix for the first crash that landed in 8.0 trunk. It works > fine for me if backported to 7.0.1: > https://reviews.llvm.org/D50461 That's awesome, thanks so much for fixing

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. In D55326#1342412 , @nemanjai wrote: > A couple of questions since I am not all that familiar with clang and am > certainly not familiar with this unusual SUSE 32-bit situation: > > - We seem to be changing the set of aliases her

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. Thanks, this is definitely very useful. I have pinged glibc upstream and asked them about the progress about this change. Let' see. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://reviews.llvm.org/D13340

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. In D133405#3782092 , @nikic wrote: >> I've been using this hack to work around the Linux/sparc64 compile failure >> described in Issue #47994, especially since the underlying glibc PR >> build/27558 doesn't seem to be making pr

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. In D133405#3782137 , @nikic wrote: > In D133405#3782136 , @glaubitz > wrote: > >> In D133405#3782092 , @nikic wrote: >> I've been using thi

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

glaubitz added a comment. Interesting and thanks for catching this! How did you discover this issue? Is there any particular program that fails to build due to this issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130566/new/ https://reviews.l

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux [clang-linux-sparc-libatomic.patch, submitted 2022-07-26]

glaubitz accepted this revision. glaubitz added a comment. This revision is now accepted and ready to land. This should address the current CI issues on sparc64 together with D130571 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/Sparc.cpp:139 + if (Triple.getArch() == llvm::Triple::sparc && + (Triple.isOSSolaris() || Distro(D.getVFS(), Triple).IsDebian())) return "v9"; Can we do it "IsLinux()" instead

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2880499 , @hvdijk wrote: > Updated to use `Triple.isX32()`. > > Should we perhaps just merge this as is, ahead of the update to compiler-rt > to create x32 objects? For non-x32, this change is NFC, for x32, the change

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2881382 , @MaskRay wrote: > Since @glaubitz is here: > > I want to set `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` to on by default so that > the libraries for x86-64 will be in > `lib/clang/13.0.0/lib/x86_64-unknown-linux-

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441094 , @hvdijk wrote: > I've been able to check what Ubuntu 20.10 offers in terms of x32 support. Its > kernel supports x32 binaries, it provides x32 versions of core system > libraries in separate packages (e.g. li

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441141 , @jrtc27 wrote: > What gets done currently for i386? That suffers potentially the same problem > given both /usr/lib/gcc/x86_64-linux-gnu/$V/32 and > /usr/lib/gcc/i386-linux-gnu/$V are possible locations for a

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441164 , @glaubitz wrote: > In D52050#2441141 , @jrtc27 wrote: > >> What gets done currently for i386? That suffers potentially the same problem >> given both /usr/lib/gcc/x86_6

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ https://reviews.llvm.org/D90549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Hi Rainer! Thanks for your review. In D90524#2382555 , @ro wrote: > As it happens, I'd arrived at exactly the same patch when I tried a build on > a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582 >

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz updated this revision to Diff 303846. glaubitz edited the summary of this revision. glaubitz added a comment. Herald added subscribers: steven.zhang, jrtc27. Update as requested in previous review, also merge with D90549 . Repository: rG LLVM Github M

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz added a comment. Merged into D90524 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ https://reviews.llvm.org/D90549 ___ cfe-commits mailing list cfe-c

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 __

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393319 , @ro wrote: > In D90524#2388214 , @glaubitz wrote: > >> I think it should be good for merging now. I addressed all remarks. I'm >> still convinced that "workaround" is t

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393320 , @ro wrote: > In D90524#2393312 , @glaubitz wrote: > >> Ping. It would be nice to get this finally merged so that the testsuite >> noise finally goes down on the sparc64

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. > ! In D90524#2393635 , @ro wrote: > > I had an extremely hard time researching the history of directory layouts for > my patch D85582 . Do as you like, I'm out > of this. Please feel free to re

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393746 , @ro wrote: > In D90524#2393651 , @glaubitz wrote: > >> > > > >> Please feel free to reach out to the corresponding debian-$ARCH mailing list >> for such questions. Deb

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. I changed it to 4.5 to be consisted with the other Multi-Arch tests for x86, MIPS and PowerPC. That's all. Debian Multi-Arch on sparc/sparc64 behaves the exact same way as it does on mips*, powerpc* and x86, so I think it makes sense to use the exact same path pattern

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Thanks so much! Would you mind pushing that change for me? I don't have commit access at the moment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 _

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. Yeah, @hvdijk has made multiple other improvements which should finally allow the backend to be usable. We still disagree on the search paths for libraries and headers though if I remember correctly. My goal is to make LLVM and Rust work on an full Debian x32 system w

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

glaubitz added a comment. Not sure if this is related, but on SPARC, stage2 builds recently started to fail with: [379/5552] Building CXX object projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/ubsan_diag.cpp.o FAILED: projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2423144 , @RKSimon wrote: > Were you able to compare against GCC and also determine debian/ubuntu's > x86_64 current support for x32 executables? Not yet. Currently freeing up space on my VM host so I can perform a fre

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. Just as a heads-up, I haven't forgotten about this. Freeing up the server just takes a little longer as I need to backup files through a DSL line. Should be ready by tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. I stumbled over one problem with my patch which is that when I run an x32 version of clang in a x32 environment, it will still default to "-m64" instead of "-mx32". Thus: glaubitz@epyc:..llvm-project/build> ./bin/clang hello.c -o hello /usr/bin/ld: cannot find crt

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428590 , @hvdijk wrote: > That sounds like it's one thing in > https://lists.llvm.org/pipermail/llvm-dev/2020-October/146049.html I haven't > extracted into a separate patch for submission yet: LLVM does not call > `

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428685 , @glaubitz wrote: > I have not found the place yet in clang where to adjust that. Maybe `sys::getDefaultTargetTriple()` needs to be adjusted. I'll have a look. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. The problem seems to be that `LLVM_HOST_TRIPLE:STRING` is set to `x86_64-unknown-linux-gnu` instead of ``x86_64-unknown-linux-gnux32`. I haven't found the place to fix that yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428709 , @hvdijk wrote: > `sys::getDefaultTargetTriple()` defaults to `LLVM_DEFAULT_TARGET_TRIPLE`, > which in turn defaults to `LLVM_HOST_TRIPLE`, which in turn defaults to > `LLVM_INFERRED_HOST_TRIPLE`, which calls

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428743 , @hvdijk wrote: > In D52050#2428735 , @glaubitz wrote: > >> Hmm, I was pretty sure that autoconf can deal with x32 inside an x32 chroot. > > Most autoconf-using software

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz created this revision. glaubitz added a reviewer: nemanjai. Herald added subscribers: cfe-commits, pengfei, fedor.sergeev, jyknight. Herald added a project: clang. glaubitz requested review of this revision. This fixes the Builtins-sparc-linux testsuite failures on Linux SPARC which occur

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Hmm, I'm not sure why the CHECK-DEBIAN-SPARC32 test is failing but I assume the expected output needs to be updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 __

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz created this revision. glaubitz added reviewers: chandlerc, rengolin. Herald added subscribers: cfe-commits, steven.zhang, pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: clang. glaubitz requested review of this revision. Both sparc and sparc64 are using the MultiArch m

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. The tests are fixed by this change: https://reviews.llvm.org/D90549. The tests CHECK-DEBIAN-SPARC32 is outdated and does not reflect the fact that sparc and sparc64 use MultiArch on Debian as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz updated this revision to Diff 302131. glaubitz edited the summary of this revision. glaubitz added a comment. Update commit comment to reflect the rename of CHECK-DEBIAN-SPARC32 to CHECK-DEBIAN-SPARC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz updated this revision to Diff 302133. glaubitz edited the summary of this revision. glaubitz added a comment. Update the patch to include the linux-header-search.cpp tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ h

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz updated this revision to Diff 302139. glaubitz added a comment. The previous patch accidentally missed the necessary files changes in Inputs/debian_multiarch_tree, let's hope this one is correct now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz updated this revision to Diff 302142. glaubitz retitled this revision from "[Driver] Fix search paths on x32" to "[Driver] Fix architecture triplets and search paths for Linux x32". glaubitz edited the summary of this revision. glaubitz added reviewers: chandlerc, rengolin. glaubitz added

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz added a comment. This change is required to fix testsuite failures as a result of this fix: https://reviews.llvm.org/D90524 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ https://reviews.llvm.org/D90549

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2369581 , @dschuff wrote: > Can you upload the diff with full context (e.g. use `diff -U ` or use > arcanist to upload)? > > I'm a bit confused; the commit message talks about X32 being a separate > architecture, b

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz updated this revision to Diff 302404. glaubitz added a comment. Regenerated with more context (using git format-patch -W). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D52050 Files: clang/lib/Driver/

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2369838 , @dschuff wrote: > One other question then: do you know if Debian and/or Ubuntu still have the > same support for running x32 programs on the regular x86-64 distribution? > (presumably yes, since you aren't ch

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2576679 , @alsoijw wrote: > In D52050#2369838 , @dschuff wrote: > >> One other question then: do you know if Debian and/or Ubuntu still have the >> same support for running x32 p

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +//

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

glaubitz added a comment. In D105457#2873294 , @dyung wrote: > This change I suspect is causing a build failure on a build bot. > > https://lab.llvm.org/buildbot/#/builders/110/builds/4827 > > FAILED: /usr/bin/c++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

glaubitz added a comment. In D105457#2874516 , @dblaikie wrote: > Any ideas what version of the standard library these buildbots are using? > This /looks/ a bit like a bug in the standard library in use, perhaps? (also > because it's not showing up in l

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

glaubitz added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck --che

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

glaubitz added inline comments. Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck --che

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

glaubitz created this revision. glaubitz added reviewers: jrtc27, ro, efriedma, brad, jfb, venkatra, jyknight. Herald added a subscriber: fedor.sergeev. glaubitz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting SPARC V8+ or V9

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

glaubitz added a comment. In D130688#3731577 , @ro wrote: > It's almost three weeks since the last comments. Any suggestions on how to > proceed with this patch? Given that the original issue (atomics not inlined > with `-m32`) is now worked around by

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

glaubitz added a comment. In D130688#3731619 , @ro wrote: > In D130688#3731611 , @glaubitz > wrote: > >> > > > >> Yeah, someone from the LEON community should comment whether they would be >> OK to default to V

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

glaubitz accepted this revision. glaubitz added a comment. Tested and works as expected. Thanks a lot for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

glaubitz added a comment. In D140695#4019189 , @brad wrote: > How come the Clang M68k backend defaults to 68000? GCC defaults to 68020 for > all targets. The Clang M68k is a complete rewrite from scratch, independent of GCC, so it's not surprising you

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Maybe these patches need to be reposted to Github as they seem to be ignored here now after the swtich from Phabricator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Any news on this? I guess it would be nice to get the remaining m68k patches merged before the Phrabricator shutdown. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cf

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. In D149867#4612589 , @myhsu wrote: > In D149867#4603853 , @aaron.ballman > wrote: > >> In D149867#4544489 , @myhsu wrote: >> >>> Sorry I was bus

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. In D149867#4386271 , @jrtc27 wrote: > I disagree. Being experimental doesn't mean you should do the wrong thing. > Reusing stdcall in the frontend is ugly, pollutes non-m68k code paths (doing > your own thing _avoids_ that and

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

glaubitz added a comment. @myhsu Can you fix the typo in the commit message? s/supports/support/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/ https://reviews.llvm.org/D147481 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401950. glaubitz added a comment. Made changes according to review and dropped every change except removing __sparcv9 and __sparcv9__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401951. glaubitz edited the summary of this revision. glaubitz added a comment. Updated the patch as requested and dropped all changes except the removal of __sparcv9 and __sparcv9__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 401953. glaubitz edited the summary of this revision. glaubitz added a comment. Minor improvement to the commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D9

[PATCH] D98574: [Sparc] Don't define __sparcv9 and __sparcv9__ when targeting V8+

glaubitz added a comment. Could someone land this for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added a comment. Ah, I actually ran into this very problem! Thanks for fixing this. Will test this today on Linux and report back! Could you maybe have a look at my updated revision here? https://reviews.llvm.org/D98575 I think this particular change should be save on Solaris as well.

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:138-139 +if (getToolChain().getTriple().getArch() == llvm::Triple::sparc) { + CmdArgs.push_back(getAsNeededOption(getToolChain(), true)); + CmdArgs.push_back("-latomic"); + CmdA

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. joerg wrote: > This comment is misleading. It's not so much

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. ro wrote: > glaubitz wrote: > > joerg wrote: > > > This com

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:138-139 +if (getToolChain().getTriple().getArch() == llvm::Triple::sparc) { + CmdArgs.push_back(getAsNeededOption(getToolChain(), true)); + CmdArgs.push_back("-latomic"); + CmdA

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. ro wrote: > ro wrote: > > glaubitz wrote: > > > ro wrote: >

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > ro wrote: > > ro wrote: > > > glaubitz wr

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

glaubitz added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:160-164 + // Linux doesn't need these variants, but the BSDs do. + if (getTriple().getOS() != llvm::Triple::Linux) { +Builder.defineMacro("__sparcv9"); +Builder.defineMacro("__

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

glaubitz added a comment. In D98574#2624558 , @brad wrote: > I do not immediately see why the other tests are failing, but at a bare > minimum the following test from > clang/test/Preprocessor/predefined-arch-macros.c will have to be updated.. > > // R

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332312. glaubitz retitled this revision from "[Sparc] Define the same macros for -mcpu=v9 as GCC on Linux" to "[Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs". glaubitz edited the summary of this revision. Repository: rG LLVM Gi

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332320. glaubitz edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Targets/Sparc.cpp clang/test/Preprocesso

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. For reference, here is what GCC defines on Linux with regards to SPARC: glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep arch glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep LP glaubitz@gcc202:~$ echo | gcc -E -dM -mcpu=v9 -m32 - |grep v9 #de

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332339. glaubitz edited the summary of this revision. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Ta

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. I have updated the patch now with the result that clang should behave as GCC now on Linux, NetBSD and OpenBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332380. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Targets/Sparc.cpp clang/test/Preprocessor/predefined-arch-macros.c Index: clang/test

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332567. glaubitz edited the summary of this revision. Herald added subscribers: arichardson, emaste. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/B

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Updated as I previously forgot to account for FreeBSD as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing l

  1   2   >