[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 239292. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: llvm-commits. john.brawn added a comment. Herald added a project: clang. Heral

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239295. john.brawn retitled this revision from "Move ParsedAttrInfos into a registry and point to one in AttributeList" to "Move ParsedAttrInfos into a registry and point to one in ParsedAttr". john.brawn added reviewers: erichkeane, aaron.ballman, rjmccal

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 239299. john.brawn edited the summary of this revision. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: cfe-commits. john.brawn added

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 239307. john.brawn added reviewers: erichkeane, aaron.ballman, rjmccall. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a subscriber: cfe-commits. john.brawn added a comment. Herald added a project: clang. Resur

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 4 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:143 + // otherwise return a default ParsedAttrInfo. + const ParsedAttrInfo *Info = AttrInfoMap[A.getKind()]; + if (Info) erichkeane wrote:

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239536. john.brawn added a comment. Updated to match latest changes to D31337 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31338/new/ https://reviews.llvm.org/D31338 Files: clang/include/clang/Sema/CMakeList

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 239535. john.brawn added a comment. Update based on review comments. Also fix warnings due to missing virtual destructor that I hadn't noticed before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31337/new/ https://reviews.llvm.org/D31337 File

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was automatically updated to reflect the committed changes. Closed by commit rG72073fc95cd4: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D144651?vs=502977&id=506642#toc Repository: rG

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. In D144651#4210787 , @fdeazeve wrote: > According to git-bisect, this patch is causing the LLDB bots to crash. > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console > > (They were failing for other reasons b

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Unfortunately I still can't reproduce this even using exactly the same cmake command as you gave. Looking at above cmake log some possible causes of difference are: - I'm doing this on an M1 macbook with host triple arm64-apple-darwin21

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, rsmith, jansvoboda11, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GNU line marker directives are not recognis

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502683. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Herald added a project: clang-tools-extra. Fixed a couple of things causing failures in clangd tests (path being

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. In D144654#4156430 , @aaron.ballman wrote: > This seems to cause precommit CI failures that should be addressed, and it > should also have a release note about the fix. Failures in CI should be fixed by D145397

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502977. john.brawn added a comment. Ran clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang/lib/Serialization/ASTReader.cpp

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

This revision was automatically updated to reflect the committed changes. Closed by commit rG128f7dac82ea: [Lex] Use line markers in preprocessed assembly predefines file (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D145397?vs=502680&id=503058#toc Repository: r

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 503305. john.brawn added a comment. Add command line test and release note, and run clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPD

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D145691 should fix the libc++ CI failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3189-3192 +if ((MI->isBuiltinMacro() || + SourceMgr.isWrittenInBuiltinFile(MI->getDefinitionLoc())) && +!(getLangOpts().ObjC && isObjCProtectedMacro(II))) + Diag(MacroNameTok, di

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM, with one minor nitpick. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106 + +def : TokenAlias<"DSYNC", "dsync">; + It would make mor

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 511153. john.brawn edited the summary of this revision. john.brawn added a comment. New version that checks for special filenames in ResolveImportedPath. I spent a while trying to come up with a test using just clang where not doing this fails, but couldn

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, thakis, arichardson, pratlucas. Herald added subscribers: luke, abrachet, frasercrmck, phosek, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 523785. john.brawn added a comment. Remove redundant braces, explain more in test comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 523803. john.brawn marked 2 inline comments as done. john.brawn added a comment. Send test output to /dev/null CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cp

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added a comment. In D150966#4356403 , @barannikov88 wrote: > Is it possible/worth to add an assertion to Builder.defineMacro to enforce > this one definition rule? It just appends a string to a raw_ostream, so it's not possible to check what

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added a comment. In D150966#4356779 , @barannikov88 wrote: > Check that the predefined macros don't contain anything that causes a > warning > > What is 'anything', exactly? Does it include duplicate predefined macros, or > it tests someth

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_CRC32", "1"); } aaron.ballma

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 524686. john.brawn added a comment. Add VE test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_C

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_CRC32", "1"); } aaron.ballma

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 525165. john.brawn added a comment. Use -Eonly in test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/T

[PATCH] D150966: [clang] Don't define predefined macros multiple times

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78bf8a0a2212: [clang] Don't define predefined macros multiple times (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D150966 should fix the failure that was seen in buildbots, so I've now re-committed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 __

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. gcc has the same warning so I wasn't expecting this cause to change problems, but looking more closely at gcc's behaviour it looks like it only warns for some builtin macros and not others (though glancing over the gcc source code it's not clear which macros and for

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, nathanchance, mstorsjo. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D144654 made it

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527024. john.brawn added a comment. Add more testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c Index: clang/te

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:163-172 + // C defines macros starting with __STDC, and C++ defines macros starting with + // __STDCPP + if (MacroName.startswith("__STDC")) +return t

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527164. john.brawn added a comment. Move some of the testing to init-x86.c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/init-x86.c

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527432. john.brawn added a comment. Put x86 tests in undef-x86.c. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c cla

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG844e9534c6d9: [Lex] Only warn on defining or undefining language-defined builtins (authored by john.brawn). Changed prior to commit: https://revie

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn created this revision. john.brawn added reviewers: mstorsjo, jansvoboda11, DHowett-MSFT, sammccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix two problems happening during deseria

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn created this revision. john.brawn added reviewers: rsmith, jansvoboda11, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we warn when MI->isBuiltinMacro, but this is onl

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 521263. john.brawn added a comment. Rebasing now that the patches this depends on have been committed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 Files: clang/docs/ReleaseNotes.rst clang/lib/Le

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn planned changes to this revision. john.brawn added a comment. The clang-tidy failures in pre-merge are because - clang-tidy tests use the compile database from building llvm (though you have to manually copy it otherwise the tests silently pass without actually running the test, whic

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 522215. john.brawn edited the summary of this revision. john.brawn added a comment. I've gone with handling the _GNU_SOURCE problem in the clang-tidy tests by re-using the list of feature test macros in shouldWarnOnMacroDef, and not warning if there's a m

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 522683. john.brawn added a comment. Adjusted in order to make clang-format happy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPDirectives.cpp

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added inline comments. Comment at: clang/test/Preprocessor/macro-reserved.cpp:15 -#undef __cplusplus +#undef __cplusplus // expected-warning {{undefining builtin macro}} #define __cplusplus aaron.ballman wrote: > Why do we diagnose the undef but not

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22e3f587fd1f: [Lex] Warn when defining or undefining any builtin macro (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. This patch caused a failure in AArch64 buildbots due to AArch64TargetInfo::getTargetDefines redefining _LP64 and __LP64__. Fixed in https://reviews.llvm.org/rGe55d52cd34fb7a6a6617639d147b9d0abaceeeab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG524ed4b1ba51: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit: https://reviews.ll

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. I accidentally pushed the old version of this patch in rG524ed4b1ba51 , I've pushed a change to match what was reviewed here in rG78086af43ade

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 ___

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn updated this revision to Diff 91745. john.brawn added a comment. Respond to review comments, and also fix a couple of 80-column violations that I spotted. Repository: rL LLVM https://reviews.llvm.org/D30582 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/fast-math.c Index

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:2452 + if (!HonorInfs && !HonorNans && !MathErrno && AssociativeMath && + ReciprocalMath && !SignedZeros && !TrappingMath && FpContract == "fast") +CmdArgs.push_back("-ffast-math"); --

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

This revision was automatically updated to reflect the committed changes. Closed by commit rL297837: [Driver] Restructure handling of -ffast-math and similar options (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D30582?vs=91745&id=91871#toc Repository: rL LLVM

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn created this revision. The way -ffast-math and the various related options to tweak floating-point handling are handled is inflexible and rather confusing. This patch restructures things so that we go through the options adjusting our idea of what's enabled as we go, instead of tryin

[PATCH] D30582: [Driver] Restructure handling of -ffast-math and similar options

john.brawn updated this revision to Diff 91311. john.brawn added a comment. Rebase on top of recent driver changes. Repository: rL LLVM https://reviews.llvm.org/D30582 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/fast-math.c Index: test/Driver/fast-math.c =

[PATCH] D117795: [AArch64] Fixes for strict FP vector instructions

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added subscribers: hiraditya, kristof.beyls. john.brawn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Fix several thi

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D11825

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. This test no longer fails during isel, but does need the expected outp

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 403614. john.brawn retitled this revision from "[AArch64] Fixes for strict FP vector instructions" to "[AArch64] Add some missing strict FP vector lowering". john.brawn edited the summary of this revision. john.brawn added a comment. The other parts of thi

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

john.brawn added inline comments. Comment at: llvm/test/CodeGen/ARM/2013-05-05-IfConvertBug.ll:1-4 ; RUN: llc < %s -mtriple=thumbv7-apple-ios -mcpu=cortex-a8 | FileCheck %s ; RUN: llc < %s -mtriple=thumbv8 | FileCheck -check-prefix=CHECK-V8 %s -; RUN: llc < %s -mtriple=thumbv7

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison instructions

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn planned changes to this revision. john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially m

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 405213. john.brawn added a comment. Update based on review comments and adjust formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117795/new/ https://reviews.llvm.org/D117795 Files: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp llvm

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. In D118259#3275297 , @fhahn wrote: > Does this clang test actually need to check the generated assembly? Shouldn't > it be enough to check that the correct intrinsics are generated? I could remove the CHECK-ASM checks, but th

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D99606: [clang][cli] Fix round-trip of OPT_plugin_arg

john.brawn created this revision. john.brawn added reviewers: jansvoboda11, dexonsmith, Bigcheese. john.brawn requested review of this revision. Herald added a project: clang. The test Frontend/plugin-delayed-template.cpp is failing when asserts are enabled because it hits an assertion in denorma

[PATCH] D99606: [clang][cli] Fix round-trip of OPT_plugin_arg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeae3b2a715d7: [clang][cli] Fix round-trip of OPT_plugin_arg (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added a comment. Looking at the behaviour of gcc it looks like there -march=armv8-r enables instructions that are present in 8-r but not 8-a, but doesn't disable any instructions. So e.g. it will accept the dcps3 instruction when compiling with -march=armv8-r whereas clang won't. Tha

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1548 + +static const AArch64SysReg::SysReg *lookupSysReg(unsigned Val, bool Read, + const MCSubtargetInfo &STI) {

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. I have one small comment, but otherwise LGTM. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1558 + + if (Reg && !isValidSysReg(Reg, Read, S

<    1   2