[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4b7a1da9d87: [OpenMP] Context selector extensions for return value overloading (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D85878?vs=285262&id=292291#toc Repository: r

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. This works for me. @arichardson you want to continue the review or should we take this and if needed improve upon it in subsequent patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.or

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added a comment. I guess you can try to use `sed` to update the tests. Comment at: openmp/libomptarget/include/omptarget.h:4 -// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. -// See https://llvm.org/LICENSE.txt for license information

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:446 +/// from +/// https://github.com/llvm/llvm-project/blob/master/openmp/runtime/src/kmp.h enum OpenMPLocationFlags : unsigned { A lot here seems unrelated. Did you clang format

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/interface.cpp:118 + __tgt_target_data_begin_mapper_loc(nullptr, device_id, arg_num, args_base, args, + arg_sizes, arg_types, nullptr); +} why not pass arg_mappers Comme

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/interface.cpp:161 if (depNum + noAliasDepNum > 0) __kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL)); Remove this and call the nowait_mapper_loc version. Let's not duplicate log

[PATCH] D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88240/new/ https://reviews.llvm.org/D88240 ___

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. One minor remark from me, otherwise LGTM. @grokos Any concerns or is this OK? Comment at: openmp/libomptarget/src/interface.cpp:73-76 + FATAL_MESSAGE0(1, "fail

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Nice to get async through "regular" tasks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D7807

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added a comment. In what situation do we generate `mustprogress` function attributes now? I was expecting them in `clang/test/CodeGen/attr-mustprogress.cpp` but did not see any. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ h

[PATCH] D88384: [OpenMP][FIX] Verify compatible types for declare variant calls

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev, aaron.ballman, ye-luo. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Especially for

[PATCH] D88384: [OpenMP][FIX] Verify compatible types for declare variant calls

jdoerfert updated this revision to Diff 294567. jdoerfert added a comment. Remove lefotver dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88384/new/ https://reviews.llvm.org/D88384 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/AST/ast-du

[PATCH] D88384: [OpenMP][FIX] Verify compatible types for declare variant calls

jdoerfert updated this revision to Diff 294596. jdoerfert added a comment. Add instantiation check and expand test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88384/new/ https://reviews.llvm.org/D88384 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nit: Maybe we should mention `complex` support on nvptx devices. The rest looks good to me. Others might want to add stuff but we can merge this right away (IMHO) Repository: rG LLVM

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex_cmath.h:58 + +template __DEVICE__ _Tp norm(const std::complex<_Tp> &__c) { + if (std::isinf(__c.real())) JonChesterfield wrote: > Doesn't matter hugely given inlining, but I'

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl &Base

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

jdoerfert added a comment. Can you add the test that exposed this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

jdoerfert added a comment. LG, @ABataev ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87250/new/ https://reviews.llvm.org/D87250 ___

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 ___

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 ___

[PATCH] D86558: [OPENMP]Add support for allocate vars in untied tasks.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86558/new/ https://reviews.llvm.org/D86558 ___

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert added a comment. I like this a lot. We might even look into generating the clang OpenMPClause classes via TableGen later, thanks a lot. There is a file missing, right? The list of actual clauses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. (I missed the part that we duplicated the information so far) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://revi

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 310724. jdoerfert added a comment. List known assumptions and warn if unknown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/LanguageExtensions.

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert added a comment. I added the warning and typo recognition as discussed in IRC. We list known assumption strings in the documentation and SemaDeclAttr. As we add new ones we should include a short description or link to their meaning. The ones I added so far are OpenMP specific (dubbed

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 310727. jdoerfert added a comment. minor spelling improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/LanguageExtensions.rst clang/incl

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 310938. jdoerfert marked 8 inline comments as done. jdoerfert added a comment. Addressed remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/L

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert added a comment. Dropping the attribute and forcing the attribute to be somehow registered makes various use cases impossible. All we would allow is an integrated compilation where the consumers are available and the FE is aware of them. This is hard for optional LLVM plugins, potenti

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311010. jdoerfert added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya, mgorny. Herald added a project: LLVM. Allow to register assumption stings through llvm-core. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311060. jdoerfert added a comment. Move into LLVMCore and provide more helper to extracts assumptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/d

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311070. jdoerfert added a comment. Remove accidental test change and ensure users create `KnownAssumptionString` objects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D919

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert updated this revision to Diff 311105. jdoerfert added a comment. Herald added a reviewer: aaron.ballman. Herald added projects: clang, OpenMP. Herald added a subscriber: cfe-commits. Add remark and documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert updated this revision to Diff 311106. jdoerfert added a comment. Add remark summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93079/new/ https://reviews.llvm.org/D93079 Files: clang/include/clang/Basic/AttrDocs.td llvm/lib/Transf

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Apologies for being silent for too long. This is missing a lang ref entry for `nocallback` and the `attributes.ll` test is arguably broken (see below). The "definition" in `llvm/include/

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#2453641 , @gulfem wrote: >> This is missing a lang ref entry for `nocallback` and the `attributes.ll` >> test is arguably broken (see below). > > Could you please elaborate on missing lang ref entry? Where that should

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311922. jdoerfert marked 5 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1689 + +llvm::StringSet<> Sema::KnownAssumptionStrings({ +"omp_no_openmp", // OpenMP 5.1 aaron.ballman wrote: > The current approach is reasonable, but I wonder if there's a

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert added a comment. In D93079#2451782 , @JonChesterfield wrote: > Is this for cases where we are compiling a subset of the target code, i.e. > without link time optimisation? Upstream cannot to LTO on any target code as of now :( > It's interest

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9c77542e237: [Clang][Attr] Introduce the `assume` function attribute (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a14cbe7f87: [OpenMP] Add initial support for `omp [begin/end] assumes` (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. I guess I revert it for now :( Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101 +#include "llvm/Frontend/OpenMP/OMPKinds.def" +}; + mehdi_amini wrote: > This is broken on gcc-5: > ``` > llvm/include/llvm/Frontend/Open

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2456600 , @thakis wrote: > In addition to the build error, it also broke check-clang everywhere as far > as I can tell. > mac: http://45.33.8.238/macm1/292/step_6.txt > linux: http://45.33.8.238/linux/35399/step_7.txt

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert accepted this revision. jdoerfert added a comment. LGTM still Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. In D91944#2457744 , @dreachem wrote: > In D91944#2414364 , @jdoerfert wrote: > >> This looks close to an OpenMP 5.0 implementation. I left comments inlined. >> >> We need tests that show h

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 312277. jdoerfert added a comment. Fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Parse/Parser.h clang/include/clan

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

jdoerfert added a comment. Thanks for continuing to work on this. Change the commit message as it is working for non integer types now, just not for "too many". Some more comments below. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:119 ///

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert updated this revision to Diff 312535. jdoerfert added a comment. Rebase on top of D93439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93079/new/ https://reviews.llvm.org/D93079 Files: clang/include/cl

[PATCH] D93439: [OpenMP][NFC] Provide a new remark and documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG994bb6eb7d01: [OpenMP][NFC] Provide a new remark and documentation (authored by jdoerfert). Herald added a project: clang. Herald added a subscriber:

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jdoerfert added a comment. @nikic Is this OK or do you want it split? Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:661 + } +} } atmnpatel wrote: > nikic wrote: > > These fixes look unrelated. Is it possible to test them separately? > So my un

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Disclaimer: I request changes because of the next sentence, other than that I have no objection but also cannot review this. All `cuda_wrapper` headers say something about compl

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

jdoerfert resigned from this revision. jdoerfert added a comment. In D93638#2466333 , @hliao wrote: > In D93638#2466097 , @jdoerfert wrote: > >>> The device compilation should not relies on the host STL implementati

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. As discussed in the OpenMP in LLVM call on December 9th, we should go ahead with this patch and add support for the missing features, e.g., dependent selectors, afterwards. LGTM Reposi

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. (Please make sure all clang and clang-tidy tests pass properly so we can merge the patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944

[PATCH] D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last

jdoerfert created this revision. jdoerfert added reviewers: tianshilei1992, jhuber6, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. S

[PATCH] D93786: [OpenMP][Fix] Make the arch selector for x86_64 work

jdoerfert created this revision. jdoerfert added reviewers: tianshilei1992, jhuber6, JonChesterfield. Herald added subscribers: pengfei, guansong, bollu, hiraditya, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added proje

[PATCH] D93786: [OpenMP][Fix] Make the arch selector for x86_64 work

jdoerfert added a comment. In D93786#2470796 , @tianshilei1992 wrote: > Is it because the triple is separated by `-`? x86 and 64 is separated by - in the architecture list so `getArchTypeForLLVMName` will not recognize "x86_64". Repository: rG LLVM

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#2371764 , @aqjune wrote: > Hi, > > Naming is a hard thing... I have no special preference. :/ > > However, I'd like to understand the details of this attribute. > > Would LTO be affected because `leaf` is guaranteed to

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

jdoerfert added a comment. I do not understand the commit message. Can you try to make it clearer? Comment at: clang/test/OpenMP/target_data_use_device_ptr_codegen.cpp:518 + #endif #endif Create a new file please. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:343 ++--+--+--+---+ +| mis

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/OpenMPSupport.rst:343 ++--+--+--

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

jdoerfert added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1242 +def int_ubsantrap : Intrinsic<[], [llvm_i8_ty], + [IntrNoReturn, IntrCold, ImmArg>]>; should this be readonly and inaccesiblememonly? CHANGES SI

[PATCH] D91075: [clang] Fix ForStmt mustprogress handling

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91075/new/ https://reviews.llvm.org/D91075 ___

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

jdoerfert added a comment. Let's start by adding an updated test to this so we can see how the result looks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/ https://reviews.llvm.org/D90670 ___

[PATCH] D91376: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91376/new/ https://reviews.llvm.org/D91376 ___

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1267 assert(!isa(constant)); - emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant); + emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant, true); } Nit: `/*

[PATCH] D91428: Add support for multiple program address spaces

jdoerfert added a subscriber: tianshilei1992. jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. I'll be on the lookout for the RFC. There, and in an updated commit message, you have to provide more details. http://lists.llvm.o

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. Please modify the commit subject and add a proper message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D91627: [OPENMP] Fix PR47999: correctly map implicit firstprivates in outer tasks.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91627/new/ https://reviews.llvm.org/D91627 ___

[PATCH] D91660: [OPENMP]Fix PR48174: compile-time crash with target enter data on a global struct.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91660/new/ https://reviews.llvm.org/D91660 ___

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); arichardson w

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); rjmccall wrot

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert accepted this revision. jdoerfert added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7641 + /// (which accepts anything) and (later) extensions. + StringRef RawString; }; mikerice wrote: > This field doesn't seem to have serialization code. Is that expected or

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added inline comments. Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:24 + } +} + Now here, and below with `while(1)` I would *not* expect `mustprogress`. Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:185 + do { +

[PATCH] D88384: [OpenMP][FIX] Verify compatible types for declare variant calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc942095790de: [OpenMP][FIX] Verify compatible types for declare variant calls (authored by jdoerfert). Changed prior to commit: https://reviews.ll

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert created this revision. jdoerfert added a reviewer: aaron.ballman. Herald added a subscriber: bollu. Herald added a project: clang. jdoerfert requested review of this revision. Add and pass AllowCXX not only in mergeFunctionTypes but all merge*Type methods. Use it to determine if referenc

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +MustProgress = true; Also in C? And C2x in t

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 ___

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, that should mean OpenMPKinds lists all OpenMP runtime functions clang generates, which is great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D88829: [OpenMP][RTL] Remove dead code

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks for removing dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88829/new/ https://reviews.llvm.org/D88829 ___

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, a new triple makes sense here, we don't support arbitrary combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 ___

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added a subscriber: jyknight. jdoerfert added a comment. One minor nit from me. @jyknight @aaron.ballman @rjmccall any more thoughts? Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + ge

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert added a comment. In D88491#2306099 , @aaron.ballman wrote: > Do you have test cases for this change? I didn't see any relevant ones in > D88384 . In the revert (rG4fc69ab002382675d84f611f22599cb3cb4a0787

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert abandoned this revision. jdoerfert added a comment. Changing the assume to a proper exit did the trick for the tests. I recommited D88384 with that minor modification. Apologies for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jdoerfert added a comment. @ye-luo good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://reviews.llvm.org/D88929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jdoerfert added a comment. The new code/functionality wrt. no exit blocks should be a separate commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 ___ cfe-com

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

jdoerfert added a comment. (Drive By: This is cool) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. Can you please upload again with full context? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. I think this is the wrong patch now. @xbolva00 posted a command that works if `git show HEAD` shows the commit you want to upload. If not, replace HEAD with the commit hash. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D1

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2174 + } + unsigned ArgNo = 0; Even if null pointer is valid we should place dereferenceable. We also could never place nonnull and let the middle-end make the dereferenceable -> nonn

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added subscribers: aaron.ballman, lebedev.ri. jdoerfert added a comment. Overall this looks sane to me. Don't know who wants to accept this. @rjmccall @lebedev.ri @aaron.ballman @rsmith Comment at: clang/lib/CodeGen/CGCall.cpp:2165 +assert(getContext().getTargetA

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2174 + } + unsigned ArgNo = 0; rsmith wrote: > CJ-Johnson wrote: > > jdoerfert wrote: > > > Even if null pointer is valid we should place dereferenceable. > > > > > > We also could nev

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Are you still working on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

jdoerfert accepted this revision. jdoerfert added a comment. LGTM. We can change the name later if we need to. This is now "opt-in" and (IIRC) we addressed all the known issues. Comment at: llvm/include/llvm/IR/Intrinsics.td:359 +class DefaultIntrinsic ret_types, +

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, aaron.ballman, jhuber6. Herald added a subscriber: bollu. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. The `assume` attribute is a way to provide additio

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, aaron.ballman, jhuber6, grokos, ggeorgakoudis, ABataev. Herald added subscribers: llvm-commits, guansong, bollu, yaxunl. Herald added projects: clang, LLVM. jdoerfert requested review of this revision. Herald added a subs

<    3   4   5   6   7   8   9   10   11   12   >