[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor created this revision. fodinabor added reviewers: bkramer, djasper, klimek. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. fodinabor requested review of this revision. Currently newer clang-format options cannot be included in .clang-f

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor accepted this revision. fodinabor added a comment. This revision is now accepted and ready to land. LGTM as well :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D105221 __

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 291405. fodinabor added a comment. Address review comments, copy the help text into docs and add some basic unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D8613

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a comment. All comments should be adressed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 291826. fodinabor marked 9 inline comments as done. fodinabor added a comment. Unit test cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 Files: clang/docs

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 292781. fodinabor marked an inline comment as done. fodinabor added a comment. Fix the nit :) Anyone with access may commit this now (ideally ofc someone with a final opinion on the clang-format part). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

fodinabor added a comment. Okay, I requested commit access. So the patch is fine with you from a clang-format perspective? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 ___

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf64903fd8176: Add -Wno-error=unknown flag to clang-format. (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a comment. I see the possible issue with the possible version mismatches and that is why I'd make people opt-in for this option, to still being able to format their files (e.g. if using out-dated built-in versions like in Visual Studio - I know you can specify your own binary) b

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a subscriber: grimar. fodinabor added a comment. Thank you so far for the feedback! maybe you can give further guidance on the comments on the comments :) As of the git history it seems that @grimar did some work on YAML error handling.. Comment at: clang/tool

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 290460. fodinabor marked 9 inline comments as done. fodinabor added a comment. Incorporating review comments: - renaming option to -Wno-error=unknown and adding warning in description - emit warnings instead of fully ignoring the issues Documentation and u

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 290461. fodinabor added a comment. Remove test entry form .clang-format :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 Files: clang/include/clang/Format/Format.

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

fodinabor added a comment. I can reproduce the issue, but not sure what introduced this. In D86137#2460135 , @njames93 wrote: > Should the name be changed to `Wno-error-unknown`? I don't think this should be the solution, as we aimed for the common synta

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor created this revision. fodinabor added reviewers: MyDeveloperDay, JakeMerdichAMD. fodinabor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted in https://reviews.llvm.org/D86137#2460135 parsing of the clang-format parameter

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor added a comment. Quoting my questions from the other review, as it should be more appropriate to discuss this here: The formatting of the `--help` page is still slightly off (I guess `cl::values` descriptions are supposed to be single line), so I guess I have to investigate my format

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor updated this revision to Diff 312518. fodinabor added a comment. Add lit test to ensure behaviour of the -Wno-error=unkown flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93459/new/ https://reviews.llvm.org/D93459 Files: clang/test

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor updated this revision to Diff 312596. fodinabor added a comment. Update ClangFormat.rst. This is manually well formatted.. will try to make a new patch in the coming days to actually fix it in the support library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc755e41c336c: Fix -Wno-error= parsing in clang-format. (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. fodinabor requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. This is very similar to 7f1e6fcff942

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor updated this revision to Diff 301726. fodinabor edited the summary of this revision. fodinabor added a comment. Add missing macro definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90415/new/ https://reviews.llvm.org/D90415 Files

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor added a comment. Thanks, will land it later. For the bug see: https://bugs.llvm.org/show_bug.cgi?id=48014 Do I have to create a new phabricator review, too? I'm currently building the release/11.x branch with the patch cherry-picked (which worked flawlessly). Repository: rG LLVM Gi

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaee608448c8: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers. (authored by fodinabor). Repository: rG LLVM Github Mon

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

fodinabor added a comment. Sadly don't have stdibc++11 available locally as well.. so can't verify, but looks good to me except for the push and pop macros. Comment at: clang/lib/Headers/cuda_wrappers/complex:77 +// https://bugs.llvm.org/show_bug.cgi?id=50383 +#pragma push_mac

[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

fodinabor accepted this revision. fodinabor added a comment. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor added a comment. Looks pretty much like a revert of https://reviews.llvm.org/D90415 which was necessary to allow building with `-x cuda -fopenmp`. Won't this break that again? I fear there's no test covering that case and I either wasn't sure where to add such a test.. (also `-x hip -

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor requested changes to this revision. fodinabor added a comment. This revision now requires changes to proceed. citing from https://reviews.llvm.org/rG7f1e6fcff9427adfa8efa3bfeeeac801da788b87: > Due to recent changes we cannot use OpenMP in CUDA files anymore (PR45533) as > the math hand

[PATCH] D105322: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

fodinabor created this revision. fodinabor added reviewers: jdoerfert, tra. Herald added subscribers: guansong, yaxunl. fodinabor requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This adds a very basic test in `cuda_with_openmp.cu`

[PATCH] D105322: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

fodinabor updated this revision to Diff 356043. fodinabor added a comment. Cleanup left over commented out code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105322/new/ https://reviews.llvm.org/D105322 Files: clang/test/Headers/Inputs/include/

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor added a comment. I added a pretty simple regression that should make testing this -x cuda -fopenmp issue simpler: https://reviews.llvm.org/D105322 I guess a similar test for -x hip -fopenmp could be added, but it hasn't been an issue so far as HIP and OpenMP AMDGCN seem to use the same

[PATCH] D105322: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

This revision was automatically updated to reflect the committed changes. Closed by commit rG75e941b05c78: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp` (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105322/new/ h

[PATCH] D109232: [CUDA][NFC] Fix a wrong assert message

fodinabor accepted this revision. fodinabor added a comment. This revision is now accepted and ready to land. LGTM, guess this can be commited right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109232/new/ https://reviews.llvm.org/D109232 _