[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

2018-08-20 Thread João Távora via Phabricator via cfe-commits
joaotavora added a comment. Herald added a subscriber: kadircet. > LGTM. Let's watch out for possible breakages in any of the clients, though. > I've checked VSCode and it seems to be fine with the added fields. This isn't in the spec and broke the LSP client eglot (https://github.com/joaotavor

[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

2018-08-21 Thread João Távora via Phabricator via cfe-commits
joaotavora added a comment. In https://reviews.llvm.org/D50571#1206020, @arphaman wrote: > In https://reviews.llvm.org/D50571#1205650, @joaotavora wrote: > > > > LGTM. Let's watch out for possible breakages in any of the clients, > > > though. I've checked VSCode and it seems to be fine with t