[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c:100 struct packed_struct on_callee_stack; on_callee_stack = va_arg(vl, struct packed_struct); } chill wrote: > Can we add some `CHECK:` lines here and to othe

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu added a comment. Ping: @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D152932: [ARM] Adding precommit tests for D146242

This revision was automatically updated to reflect the committed changes. Closed by commit rG16902df6f25a: [ARM] Adding precommit tests for D146242 (authored by JiruiWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152932/new/ https://reviews.llvm

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

JiruiWu marked 2 inline comments as done. JiruiWu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5811 +// For alignment adjusted HFAs, cap the argument alignment to 16, otherwise +// set it to 8 according to the AAPCS64 document. unsigned Align =

[PATCH] D152932: [ARM] Adding precommit tests for D146242

JiruiWu updated this revision to Diff 536157. JiruiWu added a comment. Update tests, adding an assembly test to better demonstrate the effects of D146242 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152932/new/

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu marked an inline comment as done. JiruiWu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5813 getContext().getTypeUnadjustedAlignInChars(Ty).getQuantity(); -unsigned BaseAlign = getContext().getTypeAlignInChars(Base).getQuantity(); -A

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

JiruiWu marked an inline comment as done. JiruiWu added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2118 + if (Packed) +UnadjustedAlignment = std::max(UnadjustedAlignment, UnpackedFieldAlign); UpdateAlignment(FieldAlign, UnpackedFieldAlign, Preferre

[PATCH] D152932: [ARM] Adding precommit tests for D146242.

JiruiWu created this revision. JiruiWu added reviewers: olista01, simon_tatham, rjmccall, tmatheson, pratlucas. Herald added a subscriber: kristof.beyls. Herald added a project: All. JiruiWu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A

[PATCH] D152932: [ARM] Adding precommit tests for D146242

JiruiWu updated this revision to Diff 531373. JiruiWu retitled this revision from "[ARM] Adding precommit tests for D146242." to "[ARM] Adding precommit tests for D146242". JiruiWu added a comment. Updating the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu marked an inline comment as done. JiruiWu added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.c:34 struct aligned_member_8 { uint16x8_t M0 __attribute((aligned (8))); // member alignment 16 since __attribute((aligned (n))) sets the minimum