[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

2021-09-03 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. In D109255#2983052 , @ABataev wrote: > In D109255#2983017 , @jdenny wrote: > >> This test is meant to check that the driver processes these options >> correctly. -cc1 isn't the driver and o

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

2021-09-03 Thread Jinsong Ji via Phabricator via cfe-commits
jsji updated this revision to Diff 370663. jsji added a comment. use `_cc1` for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255 Files: clang/test/OpenMP/driver-fopenmp-extensions.c clang/test/Ope

[PATCH] D109255: [NFC][OpenMP] Add fsyntax-only to driver tests

2021-09-03 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. > I probably won't get to it today, but I can work on it later. Sure, take your time. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109255/new/ https://reviews.llvm.org/D109255

[PATCH] D109255: [NFC][OpenMP] Use clang_cc1 to driver tests

2021-09-03 Thread Jinsong Ji via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd364eccdd5a9: [NFC][OpenMP] Use clang_cc1 to driver tests (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

2021-09-07 Thread Jinsong Ji via Phabricator via cfe-commits
jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.llvm.org/D109060 _

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

2021-09-07 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, sc

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

2021-09-08 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, sc

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

2021-09-09 Thread Jinsong Ji via Phabricator via cfe-commits
jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. But please wait to see whether @aprantl has any comments. Thanks. Comment at: clang/test/Modules/ExtDebugInfo.cpp:27 +#line 50 using DebugCXX::Struct; A

<    1   2   3