[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

paquette added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:201 + /// comparison)? + bool isGreaterOrEqual(const Expr *E, unsigned long long Val); + Maybe something like ``` /// Returns true if the value of \p E

[PATCH] D59509: Make static constructors + destructors minsize + cold (except for in -O0)

paquette created this revision. paquette added reviewers: rsmith, jyknight. Herald added a project: clang. Since these are only ever run once, they can be marked as cold. On top of that, since they're only ever run once, they might as well be minsize. I observed a 0.21% code size improvement in

[PATCH] D59509: Make static constructors + destructors minsize + cold (except for in -O0)

paquette updated this revision to Diff 196085. paquette added a comment. Made the test less fragile by splitting the WITHOUT-NOT into three lines. (Thanks for the suggestion!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59509/new/ https://reviews.llvm.org/D59509 Files: clang/lib/C

[PATCH] D45917: Pass -Oz/-Os along to the backend

paquette updated this revision to Diff 143584. paquette added a comment. Add context to diff. https://reviews.llvm.org/D45917 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/arm64-outline.c Index: test/CodeGen/arm64-outline.c ===

[PATCH] D45917: Pass -Oz/-Os along to the backend

paquette abandoned this revision. paquette added a comment. We decided it'd be better to just use function attributes for the outliner, so I'm abandoning this. https://reviews.llvm.org/D45917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. I think this looks reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91417/new/ https://reviews.llvm.org/D91417 ___

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132538/new/ https://reviews.llvm.org/D132538

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

paquette added inline comments. Comment at: clang/test/Driver/mcmodel.c:9 // RUN: not %clang -c -mcmodel=lager %s 2>&1 | FileCheck --check-prefix=INVALID %s +// RUN: %clang -target aarch64 -### -c -mcmodel=medium %s 2>&1 | FileCheck --check-prefix=AARCH64-MEDIUM %s +// RUN: %c

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

paquette added a comment. +1, someone just asked me if this feature exists and then found this patch. If this could be revived, I think it would help a lot of folks out. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37624/new/ https://reviews.llvm.org/D37624 ___

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

paquette added a comment. maybe link back to the discourse thread in the commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https://reviews.llvm.org/D137269 ___ cfe-commits mailing

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. If there's nothing else to add wrt telling people what's changed, I think this looks good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff

paquette accepted this revision. paquette added a comment. LGTM too thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156515/new/ https://reviews.llvm.org/D156515 ___ cfe-commits mailing list cfe-com

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

paquette created this revision. paquette added reviewers: fhahn, aemerson, jroelofs, arphaman, ahatanak. paquette added a project: clang. Herald added a reviewer: aaron.ballman. Herald added a subscriber: StephenFan. Herald added a project: All. paquette requested review of this revision. Sometime

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

paquette added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1474 + let Spellings = [Clang<"nooutline">]; + let Subjects = SubjectList<[Function, ObjCMethod]>; + let Documentation = [NoOutlineDocs]; jroelofs wrote: > does it make sense on `Blo

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

paquette updated this revision to Diff 522894. paquette added a comment. Also support blocks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150740/new/ https://reviews.llvm.org/D150740 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17cfd2e025cb: [profiling] Improve error message for raw profile header mismatches (authored by paquette). Herald added a project: clang. Herald added

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

paquette added a comment. Sorry for the inconvenience and thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149361/new/ https://reviews.llvm.org/D149361 ___ cfe-commits mailing list cfe-c

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

paquette added a comment. GISel part LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99126/new/ https://reviews.llvm.org/D99126 _

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93385/new/ https://reviews.llvm.org/D93385 _

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

paquette added a comment. I just reverted this again because of a bot failure here: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/23380/consoleFull Please fix and recommit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108