[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

2018-11-06 Thread Jessica Han via Phabricator via cfe-commits
jessicah created this revision. Herald added a subscriber: cfe-commits. Linux toolchain accidentally added "-u__llvm_runtime_variable" when "-fprofile-arcs -ftest-coverage", this is not added when "--coverage" option is used. Using "-u__llvm_runtime_variable" generates an empty default.profraw f

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

2018-11-08 Thread Jessica Han via Phabricator via cfe-commits
jessicah updated this revision to Diff 173209. jessicah added a comment. Updated diff with additional context upon review comments. Repository: rC Clang https://reviews.llvm.org/D54195 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/clang_f_opts.c Index: test/Driver/clang_f_opts.c =

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

2018-11-14 Thread Jessica Han via Phabricator via cfe-commits
jessicah updated this revision to Diff 174076. jessicah added a comment. Update test case for "--coverage" upon review comments. Repository: rC Clang https://reviews.llvm.org/D54195 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/clang_f_opts.c Index: test/Driver/clang_f_opts.c

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

2018-11-26 Thread Jessica Han via Phabricator via cfe-commits
jessicah added a comment. I don't have commit permission to Clang review, can somebody commit this for me? Thanks, Jessica Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54195/new/ https://reviews.llvm.org/D54195 ___