[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG187ccc66fa5d: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 created this revision. jyu2 added reviewers: ddpagan, ABataev, mikerice. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: openmp-com

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129872/new/ https://reviews.llvm.org/D129872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added a comment. In D129872#3671847 , @ABataev wrote: > Why does it get truncated if the type must be integer? Probably, something > incorrect in sema. This is only failed with C. But not for C++. So I don't think we have problem for Seam. I ma

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 updated this revision to Diff 447372. jyu2 edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129872/new/ https://reviews.llvm.org/D129872 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/omp_init_alloc

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, ABataev wro

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, ABataev wro

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, ABataev wro

[PATCH] D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16379 +// UnsignedPointerDiffType avoid truncate. +AllocatorHT = Context.getUnsignedPointerDiffType(); + Allocator = PerformImplicitConversion(Allocator.get(), AllocatorHT, ABataev wro

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, sstefan1. Herald added a proje

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

jyu2 updated this revision to Diff 430715. jyu2 added a comment. Thanks Alexey for the review. This is fix the nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125912/new/ https://reviews.llvm.org/D125912 Files: clang/docs/LibASTMatchersRefer

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa9c3938198: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause (authored by jyu2). Changed prior to commit: https://reviews.llv

[PATCH] D33537: [clang-tidy] Exception Escape Checker

jyu2 added a comment. In https://reviews.llvm.org/D33537#827509, @baloghadamsoftware wrote: > Test changed. I made some bad throws reachable, but the frontend check still > does detects them. If block contains two or more throws, that mean compiler can not statically know throw is really thro

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 closed this revision. jyu2 added a comment. commit by rGf8d5b49c786f : Fix missing error for use of 128-bit integer inside SPIR64 device code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92439/new/ https://rev

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2066 + // Keep track of defined physregs. + std::set PhysRegOutputs; + Use llvm::SmallSet? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jyu2 accepted this revision. jyu2 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 created this revision. jyu2 added reviewers: erichkeane, aaron.ballman, Fznamznon, rjmccall, jdoerfert, rsmith. jyu2 added a project: clang. Herald added a subscriber: Anastasia. jyu2 requested review of this revision. Emit error for use of 128-bit integer inside device code had been already

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:108 + + virtual bool hasInt128Type() const { return false; } }; jdoerfert wrote: > Not virtual but override. Thank you. I will change that. Comment at: clang/lib/Sema/Sem

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jdoerfert wrote: > jyu

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jyu2 wrote: > jdoerfer

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 updated this revision to Diff 309067. jyu2 retitled this revision from "Fix missing error for use of 128-bit integer inside SPIR64 device code." to "[CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.". jyu2 added a comment. Fix problem with @jdoerfert pointed wh

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jdoerfert wrote: > jyu

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added a comment. In D92439#2429511 , @jdoerfert wrote: > Still unsure if we should also error out for NVPTX but that is a different > story. Looks OK from my side, assuming you address the earlier comment. With this change if NVPTX need diagnostic f

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added a comment. Thanks @aaron.ballman to accept my change!!! Hi @jdoerfert, Thank you for your review. it seems you still has request change for for this. I did address your earlier comment in SPIR.h and upload the change. Is there anything else I need to change? Thanks. Jennifer CHA

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. The problem is happening when user passes lambda function wit

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

jyu2 created this revision. jyu2 added reviewers: jdoerfert, ABataev, mikerice, cfe-commits. jyu2 added a project: OpenMP. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Stop emit incomplete type error for a variable in a map clause wher

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

jyu2 added a comment. >>> I don't find any document about GCC and ICC's behavior and the generated code doesn't make much sense to me. Besides, if we change "=rm" to "=r" or "=m", GCC and ICC will report error differently. Which gives me an impression that the use of constraint is undefined behav

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

jyu2 added a comment. First I did not say "code doesn't make much sense to me". This is copy form your description. Okay, thank for explanation. So if I understand right, both gcc and icc generated code is not making sense to you. So instead, you want clang give error for this when output

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

jyu2 updated this revision to Diff 363538. jyu2 added a comment. Fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107200/new/ https://reviews.llvm.org/D107200 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribute_f

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

This revision was automatically updated to reflect the committed changes. jyu2 marked an inline comment as done. Closed by commit rG656d02233170: Stop emit incomplete type error for a variable in a map clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D107385: Fix signal during the call to checkOpenMPLoop.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, cfe-commits. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fix signal during the c

[PATCH] D107385: Fix signal during the call to checkOpenMPLoop.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b0f35931a44: Fix signal during the call to checkOpenMPLoop. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107385/new/ https://reviews.l

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. A new rule is added in 5.0: If a list item appears in a reduction, lastprivate or linear clause on a combined

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. Hi ABataev, Thanks for reviedw. In D108132#2946927 , @ABataev wrote: > Why it can not be performed in codegen? I am not sure I can do that. Do you mean when generate map adding coding code to look though reduction clause and gen

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. >> I am not sure I can do that. Do you mean when generate map adding coding >> code to look though reduction clause and generate map for it? > Yes, exactly. We are missing mappable checking for example: #pragma omp target parallel for reduction(task, +: b[0:2][2:4][1])

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366894. jyu2 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Fix format and add new runtime test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://revie

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366945. jyu2 edited the summary of this revision. jyu2 added a comment. Address Alex's comments. Thanks Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 Files: c

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 marked 4 inline comments as not done. jyu2 added a comment. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); ABataev wrote: > `isa`. Also,

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); ABataev wrote: > jyu2 wrote: > > ABataev wrote: > > > `isa`. Also, wh

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366991. jyu2 added a comment. Address Alex's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOpenM

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc274b1986680: Add implicit map for a list item appears in a reduction clause. (authored by jyu2). Changed prior to commit: https://reviews.llvm.org/D108132?vs=366991&id=367597#toc Repository: rG LLVM

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. Thank you so much for Alex's review!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. This will eliminate some IRS and it works okay with me. Thanks! But I don't know enough about this domain, please wait for some time to see if others may command on it. Comm

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 updated this revision to Diff 451939. jyu2 added a comment. Thanks Alexey! Address the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9073 SmallVector DeclComponentLists; +if (DevPointersMap.count(VD)) { + // For member fields list in is_device_ptr, store it in ABataev wrote: > If VD is nullptr, why do w

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9076 +// DeclComponentLists for generating components info. +auto It = DevPointersMap.find(VD); +if (It != DevPointersMap.end()) ABataev wrote: > VD is still nullptr here, w

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 updated this revision to Diff 451959. jyu2 added a comment. Thanks Alexey. This to fix test format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp c

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 updated this revision to Diff 452272. jyu2 added a comment. Fix test problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_is_device_ptr_codegen.cpp:296 +// CK2-DAG: [[A8:%.*]] = getelementptr inbounds [[STRUCT_ST]], %struct.ST* [[THIS1]], i32 0, i32 0 +// CK2-DAG: [[B9:%.*]] = getelementptr inbounds [[STRUCT_ST]], %struct.ST* [[THIS1

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ca27206f973: [OpenMP] Fix segmentation fault when data field is used in is_device_pt (authored by jyu2). Changed prior to commit: https://reviews

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 added a comment. Hi @alexfh, How could I reproduce the problem? Thanks. Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 ___ cfe-commits

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:317 +// CHECK-NEXT:store [10 x i32]* [[AA]], [10 x i32]** [[RAA]], align 8 +// CHECK-NEXT:[[TMP2:%.*]] = load i32*, i32** [[K]], align 8 +// CHECK-NEXT:[[TMP3:%.*]] = geteleme

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:351 +// CHECK: omp_offload.failed: +// CHECK-NEXT:call void @{{__omp_offloading_[0-9a-z]+_[0-9a-z]+}}_main_l145(i32* [[TMP2]]) #[[ATTR5:[0-9]+]] +// CHECK-NEXT:br label [[

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald adde

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8561-8617 for (const auto *Cl : Clauses) { const auto *C = dyn_cast(Cl); if (!C) continue; for (const auto L : C->component_lists()) { OMPClauseMappableExprCo

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

jyu2 updated this revision to Diff 463257. jyu2 added a comment. Merge duplicate code as Alexey suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134556/new/ https://reviews.llvm.org/D134556 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

This revision was automatically updated to reflect the committed changes. jyu2 marked an inline comment as done. Closed by commit rG30cc712eb6f2: [Clang][OpenMP] Fix run time crash when use_device_addr is used. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. The problem is happened

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added a comment. In D141350#4038619 , @ye-luo wrote: > Does this patch work when there are more than one level of inheritance? For > example `class B: public A; class C: public B` Yes, that works. For that we emit this[:1] instead. I can add mor

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 updated this revision to Diff 487845. jyu2 added a comment. Thanks Alexey for code review. This is to address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350 Files: clang/lib/CodeGen

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8490 +if (MD) + if (const CXXRecordDecl *RD = dyn_cast(MD->getParent())) +HasBaseClass = RD->getNumBases() > 0; ABataev wrote: > `const auto *RD = dyn_cast(MD->getParen

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe29a1695a6c: This is to fix runtime problem for member data used in target region. (authored by jyu2). Changed prior to commit: https://reviews.l

[PATCH] D137209: [OPENMP]Initial support for error directive.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice. jyu2 added projects: clang, OpenMP. Herald added subscribers: steakhal, martong, arphaman, guansong, yaxunl. Herald added a reviewer: NoQ. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewe

[PATCH] D137209: [OPENMP]Initial support for error directive.

jyu2 updated this revision to Diff 472640. jyu2 added a comment. Thanks Alexey for the review. This is to address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/ https://reviews.llvm.org/D137209 Files: clang/include/clan

[PATCH] D137209: [OPENMP]Initial support for error directive.

jyu2 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:6229 +/// \endcode +class OMPErrorDirective : public OMPExecutableDirective { + friend class ASTStmtReader; ABataev wrote: > final Sorry, forget that. Changed. Comme

[PATCH] D137209: [OPENMP]Initial support for error directive.

jyu2 updated this revision to Diff 472707. jyu2 added a comment. Fix clang format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/ https://reviews.llvm.org/D137209 Files: clang/include/clang-c/Index.h clang/include/clang/AST/

[PATCH] D137209: [OPENMP]Initial support for error directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rGea64e66f7b71: [OPENMP]Initial support for error directive. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/ https://reviews.llv

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 created this revision. jyu2 added reviewers: abhinavgaba, ABataev, mikerice. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. I

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 added a comment. In D137313#3904805 , @ABataev wrote: > Whyt it is NFC? I assume it fixes the dereferencing of references, right? Thanks Alexey. I really don't expect run time change for this change. The change only change BP/PP of the map inste

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 added a comment. In D137313#3906487 , @ABataev wrote: > Do we have a runtime test for this? Would be good to try to test it if the > offloading fails and the host version is executed instead. I have runtime test in https://reviews.llvm.org/D134268

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 updated this revision to Diff 473084. jyu2 added a comment. Herald added a subscriber: openmp-commits. Thanks Alexey. New runtime test is added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 Files

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 closed this revision. jyu2 added a comment. de14befa7730093ff3d46c7628fa1084f251e98d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Her

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 474826. jyu2 added a comment. Herald added a project: Flang. Thanks Alexey, for the review. This is addressing his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + ABataev wrote: > Make it private Thanks. Yes. Changed Co

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:102 .Default(OMPC_ATOMIC_DEFAULT_MEM_ORDER_unknown); + case OMPC_at: + return llvm::StringSwitch(Str) I run git-clang-format I don't see any change. I don't know where has prob

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 474874. jyu2 added a comment. Fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/A

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475013. jyu2 added a comment. try fix format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475177. jyu2 added a comment. Thanks Alexey! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Re

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/Parse/Parser.h:3302 + void ParseOpenMPClauses(OpenMPDirectiveKind DKind, + SmallVector *Clauses, + SourceLocation Loc); ABataev wrote: > `SmallVectorImp

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475225. jyu2 added a comment. Thanks Alexey! Address Alexey comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11293 + SourceLocation EndLoc, + bool InExContext = true); /// Called on well-formed '\#pragma omp barrier'. ABa

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added a comment. In D137851#3925661 , @jdoerfert wrote: > Drive by: Please add commit messages to non trivial changes to explaining > what's going on. Thanks. Added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475490. jyu2 added a comment. Thanks Alexey for the review. This is address his comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2168 +Actions.ActOnOpenMPErrorDirective(Clauses, StartLoc, SourceLocation(), + /*InExcontext = */ false); +break; ABataev wrote: > InExContext Sor

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

jyu2 added a comment. It is okay with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D137851: [OPENMP]Initial support for at clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG628fdc3f57ad: [OPENMP]Initial support for at clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added projects: Flang, All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 updated this revision to Diff 476194. jyu2 added a comment. Thanks Alexey for code review! Address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138227/new/ https://reviews.llvm.org/D138227 Files: clang/include/clang/AST/OpenM

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:538-539 let allowedClauses = [ -VersionedClause +VersionedClause, +VersionedClause ]; ABataev wrote: > Add a version where these clauses were introduced Thanks. Ch

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 updated this revision to Diff 476212. jyu2 added a comment. Thanks Alexey! Address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138227/new/ https://reviews.llvm.org/D138227 Files: clang/include/clang/AST/OpenMPClause.h clan

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 added inline comments. Comment at: clang/test/OpenMP/error_message.cpp:85 return T(); } ABataev wrote: > Di you have a test for tge directive with 2 or more severity clauses? Sorry, added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 updated this revision to Diff 476223. jyu2 added a comment. Thanks Alexey! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138227/new/ https://reviews.llvm.org/D138227 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Re

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 added inline comments. Comment at: clang/test/OpenMP/error_ast_print.cpp:16 // CHECK: static int a; -// CHECK-NEXT: #pragma omp error at(execution) +// CHECK-NEXT: #pragma omp error at(execution) severity(fatal // CHECK-NEXT: a = argv[0][0]; ABataev wrote:

[PATCH] D138227: [OPENMP]Initial support for severity clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e054e6b522b: [OPENMP5.1] Initial support for severity clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. In D127855#3956014 , @sandeepkosuri wrote: > As I do not have commit access, can someone commit this patch, now that it > passes the pre-merge tests ? I see some tests failed after this patch. Failed only with -fopenmp-vesion=51

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. That part of code is original add for is_device_address, so I just wonder, if the change could break is_device_address? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 _

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits mailing lis

[PATCH] D127803: Generate the capture for field when the field is used with implicit default.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. This is to fix assert when field is referenced and default clause is used. T

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb83f8e70bd1: [OpenMP] Initial parsing and sema for 'parallel masked' construct (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES S

<    1   2   3   4   >