[PATCH] D14052: clang-format: Format std::function template parameter consistently inside function

jeanphilippeD created this revision. jeanphilippeD added a reviewer: djasper. jeanphilippeD added a subscriber: cfe-commits. Herald added a subscriber: klimek. The function type declared in an std::function template parameter is confused for a cast: Currently: Pass: "std::function< void(int, int

Re: [PATCH] D14052: clang-format: Format std::function template parameter consistently inside function

jeanphilippeD added a comment. Thanks a lot. Yes, it makes a lot more sense this way. http://reviews.llvm.org/D14052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16524: [clang-format-vs] Fix sort include main include: Use current path for the '-assume-filename'

jeanphilippeD added a comment. Ping, Hi Daniel, Sorry, should I have put someone else as reviewer, I see the previous committers for this file where Manuel Klimek, Hans Wennborg and Marek Kurdej. Should have i added any or all of them. I thought it made sense to put you originally since you up

Re: [PATCH] D16524: [clang-format-vs] Fix sort include main include: Use current path for the '-assume-filename'

jeanphilippeD added a comment. Hi Manuel, Thank you very much for the review. I do not have commit access, would you be able to commit this patch for me. Kind Regards, Jean-Philippe http://reviews.llvm.org/D16524 ___ cfe-commits mailing list cfe-c

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Hi Daniel, I'm not sure I understand the logic behind modifying 'AlwaysBreak' to be 'AlwaysBreakExceptForSingleArgument'. AlwaysBreak is always going to lead to "wasted space". Some consider consistently break to not be a waste but actually contribute to readability, it seems that was what 'Alway

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Hi Daniel, Thanks a lot for your answer and clarifications. Sorry for the long answer, TLDR at the beginning (and end for code examples). To answer your 2 questions immediately: - It happens a lot more than I thought, about 10% of the few thousands file I checked had instances of this. - Yes, the

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Hi Daniel, Thanks, I understand why your users would have requested that and why you need to provide this improvement for them. I will survey the other people writing code with me on whether they are happy with this improvement considering both the readability of the statements and the relatively

Re: [PATCH] D15639: [clang-format] Ensure Sort include is stable with negative Priority

jeanphilippeD abandoned this revision. jeanphilippeD added a comment. This was fixed by other patch. http://reviews.llvm.org/D15639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15266: [clang-format] Handle \n the same way as std::endl with stream operator.

jeanphilippeD added a comment. Ping. Is that patch of interest? http://reviews.llvm.org/D15266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15266: [clang-format] Handle \n the same way as std::endl with stream operator.

jeanphilippeD added a comment. Thanks, Would you be happy to commit it for me since i do not have commit access. http://reviews.llvm.org/D15266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D16524: [clang-format-vs] Fix sort include main include: Use current path for the '-assume-filename'

jeanphilippeD created this revision. jeanphilippeD added a reviewer: djasper. jeanphilippeD added a subscriber: cfe-commits. clang-format sort include use the source file name to determine the "main include" that will be the 1st include (category 0). Because the clang-format visual studio extensi

[PATCH] D15062: [clang-format] Add test for AlignAfterOpenBracket = AlwaysBreak in C++.

jeanphilippeD created this revision. jeanphilippeD added a subscriber: cfe-commits. Herald added a subscriber: klimek. Revision 251405 added AlwaysBreak to support Google's JavaScript style. This changeset complete existing AlignsAfterOpenBracket tests to exercise AlwaysBreak for C++. I thought

Re: [PATCH] D15062: [clang-format] Add test for AlignAfterOpenBracket = AlwaysBreak in C++.

jeanphilippeD added a comment. Hi Daniel, Realized that I should have added you when I submitted it. Not sure if this review slipped through, or you were too busy, or if this change is not desired since the code was added to support JS. Kind Regards, Jean-Philippe. http://reviews.llvm.org/D1506

[PATCH] D15266: [clang-format] Handle \n the same way as std::endl with stream operator.

jeanphilippeD created this revision. jeanphilippeD added a reviewer: djasper. jeanphilippeD added a subscriber: cfe-commits. Herald added a subscriber: klimek. clang-format break multi-line streams after std::endl. It now also break for '\n', the suggested replacement for std::endl: http://llvm.o

Re: [PATCH] D15062: [clang-format] Add test for AlignAfterOpenBracket = AlwaysBreak in C++.

jeanphilippeD added a comment. Thanks a lot, I do not have commit access. I'm happy for you to commit it when you have time. http://reviews.llvm.org/D15062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D15639: [clang-format] Ensure Sort include is stable with negative Priority

jeanphilippeD created this revision. jeanphilippeD added a reviewer: djasper. jeanphilippeD added a subscriber: cfe-commits. Herald added a subscriber: klimek. The new sort include with negative priority was not stable when running it again over the updated includes. Extend the test NegativePrio