[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 377033. ricejasonf added a comment. I rebased onto `main` and made one small style fix. I don't think the rebase changes anything. I do not understand why random things are failing in the CI. Even on my own build machine with a fresh build directory CMak

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf added a comment. In D108482#3105889 , @tambre wrote: > I presume you lack the permissions to push this to the main repo yourself. > Would you like me to do that for you? Yes, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf added a comment. In D108482#314 , @tambre wrote: > In D108482#3108013 , @ricejasonf > wrote: > >> In D108482#3105889 , @tambre wrote: >> >>> I presume you

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 377316. ricejasonf marked 2 inline comments as done. ricejasonf added a comment. Fix up c++ version in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 Files:

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 377566. ricejasonf marked an inline comment as done. ricejasonf added a comment. Remove unnecessary cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 Files:

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf marked an inline comment as done. ricejasonf added a comment. In D108482#3047141 , @rjmccall wrote: > I assume we rebuild an AILE and OVE when we process the initializer and see > it's a structured binding? In that case, this should be fine.

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf added a comment. Can this be accepted if there are no other issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 ___ cfe-commits mailing list cfe-

[PATCH] D108482: [Clang] Fixes instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf created this revision. ricejasonf added a reviewer: aaron.ballman. ricejasonf added a project: clang. ricejasonf requested review of this revision. Herald added a subscriber: cfe-commits. The structured bindings decomposition of a non-dependent array in a dependent context (a template)

[PATCH] D108482: [Clang] Fixes instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 367907. ricejasonf added a comment. Fixed the formatting with clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/TreeTransform.h Index:

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 368485. ricejasonf added a comment. I added a simple lit test. The case is the reduced case mentioned in the bug. I spent some time trying to reproduce this outside decomposition. The only other way (I know of) to produce an ArrayInitLoopExpr is an implic

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 368962. ricejasonf added a comment. I moved the test to CodeGenCXX and actually test output with FileCheck. I used the code from a non-template function as the expected output. Some minor formatting changes are also addressed. Repository: rG LLVM Gith

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 369828. ricejasonf added a comment. I think I found a simple solution that bypasses transforming the OVE. The ArrayInitLoop always has an OVE in it so I strip it along with it in TransformInitializer. I looked around in CodeGen and might have a better un

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 370353. ricejasonf marked 2 inline comments as done. ricejasonf added a comment. Fixed minor formatting issue. 😅 (Perhaps this should be in the tests included with check-clang?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r