jnykiel created this revision.
jnykiel added a reviewer: aganea.
Herald added subscribers: usaxena95, kadircet, abidh.
jnykiel requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang.
As of CMake commit https://gitlab.kitware.com/cmake
jnykiel updated this revision to Diff 331570.
jnykiel retitled this revision from "[Tooling] Handle compilation databases
with clang-cl commands generated by CMake 3.19+" to "[Tooling] Handle
compilation databases containing commands with double dashes".
jnykiel edited the summary of this revisio
jnykiel updated this revision to Diff 331605.
jnykiel added a comment.
Fixed logic error in `injectResourceDir` causing a test failure on the build
machine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98824/new/
https://reviews.llvm.org/D98824
Files:
clang/lib/Tooling/ArgumentsAdj
jnykiel updated this revision to Diff 331884.
jnykiel edited the summary of this revision.
jnykiel added a comment.
I've addressed your comments (I agree with them, essentially). After
implementing the insertion of '--' for problematic file names, I had to modify
some interpolation unit tests to
jnykiel updated this revision to Diff 332268.
jnykiel added a comment.
Thanks. About committing/attribution, I'm not sure how it's supposed to work -
I've asked a co-worker (@aganea) to commit this, but if he can't do it, please
do it instead. I'm Janusz Nykiel, email address janusz.nykiel at ub
