[clang] d6e617c - [clang][modules] NFCI: Use `DirectoryEntryRef` for umbrella directory

2023-05-26 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-26T15:30:28-07:00 New Revision: d6e617c8efab582121e0a0a9d539652bdfd544da URL: https://github.com/llvm/llvm-project/commit/d6e617c8efab582121e0a0a9d539652bdfd544da DIFF: https://github.com/llvm/llvm-project/commit/d6e617c8efab582121e0a0a9d539652bdfd544da.diff L

[clang] 769d282 - [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 769d282d7292d14591a721ee967962736160095e URL: https://github.com/llvm/llvm-project/commit/769d282d7292d14591a721ee967962736160095e DIFF: https://github.com/llvm/llvm-project/commit/769d282d7292d14591a721ee967962736160095e.diff L

[clang] 95279d7 - [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule()

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 95279d7670cd54a50cf72d1fbc99701ef1faa72b URL: https://github.com/llvm/llvm-project/commit/95279d7670cd54a50cf72d1fbc99701ef1faa72b DIFF: https://github.com/llvm/llvm-project/commit/95279d7670cd54a50cf72d1fbc99701ef1faa72b.diff L

[clang-tools-extra] d574e91 - [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile()

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: d574e918dba31e670a87c46e7de281819b3c0ea9 URL: https://github.com/llvm/llvm-project/commit/d574e918dba31e670a87c46e7de281819b3c0ea9 DIFF: https://github.com/llvm/llvm-project/commit/d574e918dba31e670a87c46e7de281819b3c0ea9.diff L

[clang] 32d6f3c - [clang] NFCI: Use DirectoryEntryRef in Module::Directory

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: 32d6f3cfd90b90321e84477b2bd353afbf9876ea URL: https://github.com/llvm/llvm-project/commit/32d6f3cfd90b90321e84477b2bd353afbf9876ea DIFF: https://github.com/llvm/llvm-project/commit/32d6f3cfd90b90321e84477b2bd353afbf9876ea.diff L

[clang] b1e5b28 - [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: b1e5b28b8c4d8af294906ee27a62b28079d3f337 URL: https://github.com/llvm/llvm-project/commit/b1e5b28b8c4d8af294906ee27a62b28079d3f337 DIFF: https://github.com/llvm/llvm-project/commit/b1e5b28b8c4d8af294906ee27a62b28079d3f337.diff L

[clang] e19f352 - [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T13:54:06-07:00 New Revision: e19f352beee72d8fc30d9a5366eadd2372719fa3 URL: https://github.com/llvm/llvm-project/commit/e19f352beee72d8fc30d9a5366eadd2372719fa3 DIFF: https://github.com/llvm/llvm-project/commit/e19f352beee72d8fc30d9a5366eadd2372719fa3.diff L

[clang] e6830b6 - [clang][modules] NFCI: Extract optionality out of `Module::{Header,DirectoryName}`

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T21:06:51-07:00 New Revision: e6830b6028ec5434ccf8dbebdd992918f67b1751 URL: https://github.com/llvm/llvm-project/commit/e6830b6028ec5434ccf8dbebdd992918f67b1751 DIFF: https://github.com/llvm/llvm-project/commit/e6830b6028ec5434ccf8dbebdd992918f67b1751.diff L

[clang] 3473f72 - [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T21:42:01-07:00 New Revision: 3473f728b36e21d322f141e576377c20a02c9aad URL: https://github.com/llvm/llvm-project/commit/3473f728b36e21d322f141e576377c20a02c9aad DIFF: https://github.com/llvm/llvm-project/commit/3473f728b36e21d322f141e576377c20a02c9aad.diff L

[clang] a5bf486 - print user provide value in tabstop diagnostic

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: csmoe Date: 2023-05-30T21:44:10-07:00 New Revision: a5bf4860eaee23c5bb7bd945516cd4d9f1873d5d URL: https://github.com/llvm/llvm-project/commit/a5bf4860eaee23c5bb7bd945516cd4d9f1873d5d DIFF: https://github.com/llvm/llvm-project/commit/a5bf4860eaee23c5bb7bd945516cd4d9f1873d5d.diff LOG: pr

[clang] e517c5a - [clang] Add test for -ftabstop diagnostics

2023-05-30 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-30T21:58:29-07:00 New Revision: e517c5a897c3332ce12b584ff5e522395a0e0469 URL: https://github.com/llvm/llvm-project/commit/e517c5a897c3332ce12b584ff5e522395a0e0469 DIFF: https://github.com/llvm/llvm-project/commit/e517c5a897c3332ce12b584ff5e522395a0e0469.diff L

[clang] 53690f8 - [clang] NFCI: Use `FileEntryRef` in `PPDirectives`

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T12:17:37-07:00 New Revision: 53690f8f0db78d27a9ab5a7b924faaae627da4c4 URL: https://github.com/llvm/llvm-project/commit/53690f8f0db78d27a9ab5a7b924faaae627da4c4 DIFF: https://github.com/llvm/llvm-project/commit/53690f8f0db78d27a9ab5a7b924faaae627da4c4.diff L

[clang] dfce185 - [clang] NFCI: Use `FileEntryRef` in `VerifyDiagnosticConsumer`

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T12:17:37-07:00 New Revision: dfce18506b7a9354ddc6706c9ca12644a7be9767 URL: https://github.com/llvm/llvm-project/commit/dfce18506b7a9354ddc6706c9ca12644a7be9767 DIFF: https://github.com/llvm/llvm-project/commit/dfce18506b7a9354ddc6706c9ca12644a7be9767.diff L

[clang] 20edfae - [clang] NFCI: Use `DirectoryEntryRef` in `ASTWriter`

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T14:54:42-07:00 New Revision: 20edfaeef7c55bc6ef320ffe1dcb82b88583c92c URL: https://github.com/llvm/llvm-project/commit/20edfaeef7c55bc6ef320ffe1dcb82b88583c92c DIFF: https://github.com/llvm/llvm-project/commit/20edfaeef7c55bc6ef320ffe1dcb82b88583c92c.diff L

[clang] 6587d9d - [clang] NFCI: Use `DirectoryEntryRef` for `ModuleMap::BuiltinIncludeDir`

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T14:54:42-07:00 New Revision: 6587d9d87a58b08e86484ab25a121c3bfeb68949 URL: https://github.com/llvm/llvm-project/commit/6587d9d87a58b08e86484ab25a121c3bfeb68949 DIFF: https://github.com/llvm/llvm-project/commit/6587d9d87a58b08e86484ab25a121c3bfeb68949.diff L

[clang] 54e4772 - [clang] NFCI: Use `DirectoryEntryRef` in `PrecompiledPreamble`

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T14:54:42-07:00 New Revision: 54e47724cfbf12dce05412c5b127ae311066afb3 URL: https://github.com/llvm/llvm-project/commit/54e47724cfbf12dce05412c5b127ae311066afb3 DIFF: https://github.com/llvm/llvm-project/commit/54e47724cfbf12dce05412c5b127ae311066afb3.diff L

[clang] 5be0e83 - [clang] NFCI: Use `FileEntryRef` in `PPLexerChange`

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T16:04:45-07:00 New Revision: 5be0e83635a22da0a42aeeeca8d42193ff2f9db6 URL: https://github.com/llvm/llvm-project/commit/5be0e83635a22da0a42aeeeca8d42193ff2f9db6 DIFF: https://github.com/llvm/llvm-project/commit/5be0e83635a22da0a42aeeeca8d42193ff2f9db6.diff L

[clang] 2d817d0 - [clang] NFCI: Use the `*Ref()` variant on search paths

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T16:04:45-07:00 New Revision: 2d817d0368ee72e2bd97bad88434cba2df30be8a URL: https://github.com/llvm/llvm-project/commit/2d817d0368ee72e2bd97bad88434cba2df30be8a DIFF: https://github.com/llvm/llvm-project/commit/2d817d0368ee72e2bd97bad88434cba2df30be8a.diff L

[clang] 0038d6c - [clang] NFCI: Use `DirectoryEntryRef` in framework lookup

2023-05-31 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-31T16:04:46-07:00 New Revision: 0038d6c7fe75a9f45076a347e4fd9b1f59051899 URL: https://github.com/llvm/llvm-project/commit/0038d6c7fe75a9f45076a347e4fd9b1f59051899 DIFF: https://github.com/llvm/llvm-project/commit/0038d6c7fe75a9f45076a347e4fd9b1f59051899.diff L

[clang] f097290 - [clang] NFCI: Use `FileEntryRef` in `ModuleMapCallbacks`

2023-06-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-01T10:10:00-07:00 New Revision: f09729042d8f99e1b896f6a04ebf6f842f6cc7ad URL: https://github.com/llvm/llvm-project/commit/f09729042d8f99e1b896f6a04ebf6f842f6cc7ad DIFF: https://github.com/llvm/llvm-project/commit/f09729042d8f99e1b896f6a04ebf6f842f6cc7ad.diff L

[clang] 2e1ec4c - [clang] NFCI: Split `HeaderSearch::findAllModulesForHeader()`

2023-06-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-01T10:11:26-07:00 New Revision: 2e1ec4c737f93925e29e4037e758b940c6fef448 URL: https://github.com/llvm/llvm-project/commit/2e1ec4c737f93925e29e4037e758b940c6fef448 DIFF: https://github.com/llvm/llvm-project/commit/2e1ec4c737f93925e29e4037e758b940c6fef448.diff L

[clang] b092f41 - [clang] Use `FileEntryRef` in modular header search (part 1/2)

2023-06-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-01T10:38:07-07:00 New Revision: b092f417db211b5316bc29bc651eaaa86ce1 URL: https://github.com/llvm/llvm-project/commit/b092f417db211b5316bc29bc651eaaa86ce1 DIFF: https://github.com/llvm/llvm-project/commit/b092f417db211b5316bc29bc651eaaa86ce1.diff L

[clang] 152f291 - [clang][deps] Fix race condition

2023-02-07 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-02-07T09:26:56-08:00 New Revision: 152f2914607ffe632202ee660208d6dfba6c8870 URL: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870 DIFF: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870.diff L

[clang] 5e14a48 - [clang] NFC: Remove GCC 5.1 workaround in FileEntry

2023-02-07 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-02-07T09:27:24-08:00 New Revision: 5e14a48463b4c3eb3f36eeef30dee7312f9127da URL: https://github.com/llvm/llvm-project/commit/5e14a48463b4c3eb3f36eeef30dee7312f9127da DIFF: https://github.com/llvm/llvm-project/commit/5e14a48463b4c3eb3f36eeef30dee7312f9127da.diff L

[clang] ea2c144 - [clang][cli] Simplify repetitive macro invocations

2023-02-08 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-02-08T14:54:21-08:00 New Revision: ea2c144e85c7a6c29104c059b4b08aa9f9221a32 URL: https://github.com/llvm/llvm-project/commit/ea2c144e85c7a6c29104c059b4b08aa9f9221a32 DIFF: https://github.com/llvm/llvm-project/commit/ea2c144e85c7a6c29104c059b4b08aa9f9221a32.diff L

[clang] 29b95f0 - [clang][deps] NFC: Refactor inferred modules test

2023-02-08 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-02-08T16:57:41-08:00 New Revision: 29b95f05738fed5bf9777e285ccb084ada54b9b1 URL: https://github.com/llvm/llvm-project/commit/29b95f05738fed5bf9777e285ccb084ada54b9b1 DIFF: https://github.com/llvm/llvm-project/commit/29b95f05738fed5bf9777e285ccb084ada54b9b1.diff L

[clang] 63eb04a - [clang][modules] Avoid unnecessary writes of .timestamp files

2023-05-10 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-10T10:41:33-07:00 New Revision: 63eb04a3683996db26dbf1534682c5696d93b080 URL: https://github.com/llvm/llvm-project/commit/63eb04a3683996db26dbf1534682c5696d93b080 DIFF: https://github.com/llvm/llvm-project/commit/63eb04a3683996db26dbf1534682c5696d93b080.diff L

[clang] f60cc47 - [clang][modules] NFC: Only sort interesting identifiers

2023-05-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-15T13:28:10-07:00 New Revision: f60cc473b82b16edc448199c84e612c1e5c3014c URL: https://github.com/llvm/llvm-project/commit/f60cc473b82b16edc448199c84e612c1e5c3014c DIFF: https://github.com/llvm/llvm-project/commit/f60cc473b82b16edc448199c84e612c1e5c3014c.diff L

[clang] 09c5d69 - Revert "[clang][deps] Only cache files with specific extension"

2023-05-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-15T17:43:53-07:00 New Revision: 09c5d69592f7df4db62063e4dd231a7e154bdac6 URL: https://github.com/llvm/llvm-project/commit/09c5d69592f7df4db62063e4dd231a7e154bdac6 DIFF: https://github.com/llvm/llvm-project/commit/09c5d69592f7df4db62063e4dd231a7e154bdac6.diff L

[clang] 94d22b0 - [clang][deps] Do not cache PCM files

2023-05-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-15T17:43:54-07:00 New Revision: 94d22b09bbb212773a226726ee03a44edbbe98c7 URL: https://github.com/llvm/llvm-project/commit/94d22b09bbb212773a226726ee03a44edbbe98c7 DIFF: https://github.com/llvm/llvm-project/commit/94d22b09bbb212773a226726ee03a44edbbe98c7.diff L

[clang] 3948aed - [clang] NFC: Modernize Decl iteration via IdentifierResolver

2023-05-17 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-05-17T16:45:46-07:00 New Revision: 3948aedb7ab9a0626faccbe14624dbafeb2e3931 URL: https://github.com/llvm/llvm-project/commit/3948aedb7ab9a0626faccbe14624dbafeb2e3931 DIFF: https://github.com/llvm/llvm-project/commit/3948aedb7ab9a0626faccbe14624dbafeb2e3931.diff L

[clang] e766e3a - [clang][deps] Print timing information

2023-04-20 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-04-20T11:18:32-07:00 New Revision: e766e3afedeba90dfbd0513a675a9bf32c5cc8e9 URL: https://github.com/llvm/llvm-project/commit/e766e3afedeba90dfbd0513a675a9bf32c5cc8e9 DIFF: https://github.com/llvm/llvm-project/commit/e766e3afedeba90dfbd0513a675a9bf32c5cc8e9.diff L

[clang] 53a4a2b - [clang] NFCI: Optimize storage and lookup of analyzer options

2023-04-21 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-04-21T10:39:55-07:00 New Revision: 53a4a2b45bb2407f3249dea54f1a8b3e230b188a URL: https://github.com/llvm/llvm-project/commit/53a4a2b45bb2407f3249dea54f1a8b3e230b188a DIFF: https://github.com/llvm/llvm-project/commit/53a4a2b45bb2407f3249dea54f1a8b3e230b188a.diff L

[clang] 6b80f00 - [clang][deps] NFC: Refactor and comment ModuleDeps sorting

2023-04-21 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-04-21T10:56:42-07:00 New Revision: 6b80f00bac6a4832af4f8ebde96564690a35f7e1 URL: https://github.com/llvm/llvm-project/commit/6b80f00bac6a4832af4f8ebde96564690a35f7e1 DIFF: https://github.com/llvm/llvm-project/commit/6b80f00bac6a4832af4f8ebde96564690a35f7e1.diff L

[clang] 1dee56a - [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()`

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T11:22:31+02:00 New Revision: 1dee56aed7357ad87e7b30316554b760c75d5779 URL: https://github.com/llvm/llvm-project/commit/1dee56aed7357ad87e7b30316554b760c75d5779 DIFF: https://github.com/llvm/llvm-project/commit/1dee56aed7357ad87e7b30316554b760c75d5779.diff L

[clang] 7bca6f4 - [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T11:22:31+02:00 New Revision: 7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb URL: https://github.com/llvm/llvm-project/commit/7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb DIFF: https://github.com/llvm/llvm-project/commit/7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb.diff L

[clang] 462bda1 - [clang] Deprecate `DirectoryEntry::getName()`

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T12:14:41+02:00 New Revision: 462bda1d562acc5a907eafe0afeb79556101c65d URL: https://github.com/llvm/llvm-project/commit/462bda1d562acc5a907eafe0afeb79556101c65d DIFF: https://github.com/llvm/llvm-project/commit/462bda1d562acc5a907eafe0afeb79556101c65d.diff L

[clang] fa5788f - [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

2023-06-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-15T12:34:54+02:00 New Revision: fa5788ff8dc10f36e0947757e335cd180a1a63c9 URL: https://github.com/llvm/llvm-project/commit/fa5788ff8dc10f36e0947757e335cd180a1a63c9 DIFF: https://github.com/llvm/llvm-project/commit/fa5788ff8dc10f36e0947757e335cd180a1a63c9.diff L

[clang] 6443539 - [clang][deps] Implement `dump()` for the VFS

2022-12-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2022-12-15T16:03:00-08:00 New Revision: 64435396c5a0ba33a1197915673c1071e6d64f25 URL: https://github.com/llvm/llvm-project/commit/64435396c5a0ba33a1197915673c1071e6d64f25 DIFF: https://github.com/llvm/llvm-project/commit/64435396c5a0ba33a1197915673c1071e6d64f25.diff L

[clang] Add support for sysroot-relative system header search paths (PR #82084)

2024-02-16 Thread Jan Svoboda via cfe-commits
@@ -3256,12 +3262,14 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions &Opts, ArgList &Args, } for (const auto *A : Args.filtered(OPT_idirafter)) -Opts.AddPath(A->getValue(), frontend::After, false, true); +Opts.AddPath(ConvertHeaderPath(A), frontend::After

[clang] Add support for sysroot-relative system header search paths (PR #82084)

2024-02-16 Thread Jan Svoboda via cfe-commits
@@ -3229,16 +3244,7 @@ static bool ParseHeaderSearchArgs(HeaderSearchOptions &Opts, ArgList &Args, IsIndexHeaderMap ? frontend::IndexHeaderMap : frontend::Angled; bool IsFramework = A->getOption().matches(OPT_F); -std::string Path = A->getValue(); - -if (I

[clang] [clang][ScanDeps] Canonicalize -D and -U flags (PR #82298)

2024-02-19 Thread Jan Svoboda via cfe-commits
@@ -179,6 +179,73 @@ static void sanitizeDiagOpts(DiagnosticOptions &DiagOpts) { DiagOpts.IgnoreWarnings = true; } +// Clang implements -D and -U by splatting text into a predefines buffer. This +// allows constructs such as `-DFඞ=3 "-D F\u{0D9E} 4 3 2”` to be accepted and +

[clang] [clang][ScanDeps] Canonicalize -D and -U flags (PR #82298)

2024-02-19 Thread Jan Svoboda via cfe-commits
@@ -179,6 +179,73 @@ static void sanitizeDiagOpts(DiagnosticOptions &DiagOpts) { DiagOpts.IgnoreWarnings = true; } +// Clang implements -D and -U by splatting text into a predefines buffer. This +// allows constructs such as `-DFඞ=3 "-D F\u{0D9E} 4 3 2”` to be accepted and +

[clang] [clang][ScanDeps] Canonicalize -D and -U flags (PR #82298)

2024-02-20 Thread Jan Svoboda via cfe-commits
@@ -179,6 +179,73 @@ static void sanitizeDiagOpts(DiagnosticOptions &DiagOpts) { DiagOpts.IgnoreWarnings = true; } +// Clang implements -D and -U by splatting text into a predefines buffer. This +// allows constructs such as `-DFඞ=3 "-D F\u{0D9E} 4 3 2”` to be accepted and +

[clang] [clang][ScanDeps] Canonicalize -D and -U flags (PR #82298)

2024-02-20 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/82298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-20 Thread Jan Svoboda via cfe-commits
@@ -65,11 +66,25 @@ static void optimizeHeaderSearchOpts(HeaderSearchOptions &Opts, llvm::DenseSet Visited; std::function VisitMF = [&](const serialization::ModuleFile *MF) { - VFSUsage |= MF->VFSUsage; Visited.insert(MF); - for (co

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-20 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 commented: Just to clarify, this patch doesn't attempt to solve the case where the Clang can crash when the VFS overlay files are different between the PCH and the TU, since that's existing behavior. Correct? https://github.com/llvm/llvm-project/pull/82294 _

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-20 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/82294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-20 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/82294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-20 Thread Jan Svoboda via cfe-commits
@@ -67,7 +68,7 @@ static bool checkHeaderSearchPaths(const HeaderSearchOptions &HSOpts, if (LangOpts.Modules) { if (HSOpts.VFSOverlayFiles != ExistingHSOpts.VFSOverlayFiles) { if (Diags) { -Diags->Report(diag::err_pch_vfsoverlay_mismatch); +Diags->R

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/82294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-22 Thread Jan Svoboda via cfe-commits
@@ -65,11 +66,25 @@ static void optimizeHeaderSearchOpts(HeaderSearchOptions &Opts, llvm::DenseSet Visited; std::function VisitMF = [&](const serialization::ModuleFile *MF) { - VFSUsage |= MF->VFSUsage; Visited.insert(MF); - for (co

[clang] [clang][modules] Fix use-after-free in header serialization (PR #96356)

2024-07-02 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Ping @vsapsai. https://github.com/llvm/llvm-project/pull/96356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-07-02 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > To clarify, that means setting the `RawStringLiterals` LangOpt in > `DependencyDirectivesScanner.cpp`, right? I’m assuming yes, but I just want > to make sure. Yes, that's what I had in mind 👍 https://github.com/llvm/llvm-project/pull/88265 _

[clang] clang: Relax LangOpts checks when lexing quoted numbers during preprocessing (PR #95798)

2024-07-02 Thread Jan Svoboda via cfe-commits
@@ -2068,7 +2068,8 @@ bool Lexer::LexNumericConstant(Token &Result, const char *CurPtr) { } // If we have a digit separator, continue. - if (C == '\'' && (LangOpts.CPlusPlus14 || LangOpts.C23)) { + if (C == '\'' && + (LangOpts.CPlusPlus14 || LangOpts.C23 || Parsing

[clang] Pass LangOpts from CompilerInstance to DependencyScanningWorker (PR #93753)

2024-07-02 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > > You can certainly construct cases where the different lexing rules in > > different language modes allow you to detect which language you're in from > > within the preprocessor ([1](https://eel.is/c++draft/diff.cpp11.lex) > > [2](https://eel.is/c++draft/diff.cpp14.lex#2

[clang] clang: Relax LangOpts checks when lexing quoted numbers during preprocessing (PR #95798)

2024-07-03 Thread Jan Svoboda via cfe-commits
@@ -2068,7 +2068,8 @@ bool Lexer::LexNumericConstant(Token &Result, const char *CurPtr) { } // If we have a digit separator, continue. - if (C == '\'' && (LangOpts.CPlusPlus14 || LangOpts.C23)) { + if (C == '\'' && + (LangOpts.CPlusPlus14 || LangOpts.C23 || Parsing

[clang] [clang][modules] Fix use-after-free in header serialization (PR #96356)

2024-07-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/96356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][scan] Report module dependencies in topological order (PR #107474)

2024-09-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/107474 Clients of the dependency scanner may benefit from being able to process modular dependencies in topological order. The scanner already processes dependencies in this order, so it makes sense to make it ea

[clang] [clang][scan] Report module dependencies in topological order (PR #107474)

2024-09-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/107474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-09-06 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: To better understand the motivation, I have two questions: * Why do you give Clang module maps describing modules that are already described in PCM files? Unless the module map describes some other top-level module that's yet to be built, the information it provides is redun

[clang] [clang-tools-extra] [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (PR #106271)

2024-09-06 Thread Jan Svoboda via cfe-commits
@@ -216,7 +216,7 @@ enum OpenCLTypeKind : uint8_t { /// class TargetInfo : public TransferrableTargetInfo, public RefCountedBase { - std::shared_ptr TargetOpts; + TargetOptions *TargetOpts; jansvoboda11 wrote: Upstream breaks internal APIs

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-09-06 Thread Jan Svoboda via cfe-commits
@@ -1125,6 +1125,54 @@ class YAMLVFSWriter { void write(llvm::raw_ostream &OS); }; +/// File system that tracks the number of calls to the underlying file system. +/// This is particularly useful when wrapped around \c RealFileSystem to add +/// lightweight tracking of expen

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-09-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/88326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 92cd66d - [clang][deps][test] Update reference to tracing VFS

2024-09-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-09-06T14:29:44-07:00 New Revision: 92cd66d905aa63fe4d77bb632812dff87e0e1c08 URL: https://github.com/llvm/llvm-project/commit/92cd66d905aa63fe4d77bb632812dff87e0e1c08 DIFF: https://github.com/llvm/llvm-project/commit/92cd66d905aa63fe4d77bb632812dff87e0e1c08.diff L

[clang] [llvm] Fix build errors with a `LLVM_ENABLE_MODULES=ON` build (PR #107654)

2024-09-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. https://github.com/llvm/llvm-project/pull/107654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Print tracing VFS data (PR #108056)

2024-09-10 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/108056 Clang's `-cc1 -print-stats` shows lots of useful internal data including basic `FileManager` stats. Since this layer caches some results, it is unclear how that information translates to actual filesystem

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

2024-08-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/88800 >From e1aed43691bc02fe6d775c68908182289f2727c0 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 11 Apr 2024 14:44:55 -0700 Subject: [PATCH 1/2] [clang][deps] Only bypass scanning VFS for the module cac

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

2024-08-08 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: @aganea Rebased, added tests and a prep-patch: https://github.com/llvm/llvm-project/pull/102540. https://github.com/llvm/llvm-project/pull/88800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-08-09 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/88326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Stop adjusting the module cache path (PR #102540)

2024-08-12 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > > This enables more efficient implementation of the caching VFS in #88800. > > Thanks @jansvoboda11 for working on this, I appreciate. One question, what do > you mean by "more efficient"? Sorry, I should've clarified. I think that without this patch, #88800 would need t

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-08-12 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/88326 >From c543c01b144f702e57d04c961fbfd5ebfa43e863 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 12 Apr 2024 10:47:13 -0700 Subject: [PATCH 1/2] [llvm][support] Implement tracing virtual file system ---

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-08-12 Thread Jan Svoboda via cfe-commits
@@ -2933,8 +2933,21 @@ recursive_directory_iterator::increment(std::error_code &EC) { return *this; } +void TracingFileSystem::printImpl(raw_ostream &OS, PrintType Type, jansvoboda11 wrote: Good idea, implemented in the new commit. https://github.com/llvm

[clang] [clang] Stop adjusting the module cache path (PR #102540)

2024-08-13 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/102540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

2024-08-13 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/88800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

2024-08-13 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Hi, we're seeing a test failure in our x64 linux CI. This was the only commit > in the blame. Can you take a look and revert if it will take a while to fix? > > Failing test: LLVM :: tools/llvm-debuginfod-find/cache.test > > Bot: > https://ci.chromium.org/ui/p/fuchsia/bu

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

2024-04-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/83660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Remove pgo profile flags from modules (PR #87724)

2024-04-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/87724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/87848 None >From ee56548604be9473f33cd809c901886f37a3d8e9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 5 Apr 2024 15:12:39 -0700 Subject: [PATCH] [clang][modules] Do not resolve `HeaderFileInfo` external

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/87849 None >From 158ecc0736f0011f7da2c737ae323ddf5ef599c9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 4 Apr 2024 12:31:09 -0700 Subject: [PATCH] [clang][modules] Only compute affecting module maps with

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/87848 >From ee56548604be9473f33cd809c901886f37a3d8e9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 5 Apr 2024 15:12:39 -0700 Subject: [PATCH 1/2] [clang][modules] Do not resolve `HeaderFileInfo` externall

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/87848 >From ee56548604be9473f33cd809c901886f37a3d8e9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 5 Apr 2024 15:12:39 -0700 Subject: [PATCH 1/3] [clang][modules] Do not resolve `HeaderFileInfo` externall

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/87849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/87849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-08 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: CC @ilyakuteev https://github.com/llvm/llvm-project/pull/87849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/87848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/87848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Cache `VFS::getRealPath()` (PR #68645)

2024-04-08 Thread Jan Svoboda via cfe-commits
@@ -230,6 +251,26 @@ class DependencyScanningFilesystemLocalCache { assert(InsertedEntry == &Entry && "entry already present"); return *InsertedEntry; } + + /// Returns real path associated with the filename or nullptr if none is + /// found. + const CachedRealPath

[clang] 2248164 - Revert "[clang] Move state out of `PreprocessorOptions` (1/n) (#86358)"

2024-04-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-04-09T13:26:45-07:00 New Revision: 2248164a9ab791a3ed1b9586dc340b5303155021 URL: https://github.com/llvm/llvm-project/commit/2248164a9ab791a3ed1b9586dc340b5303155021 DIFF: https://github.com/llvm/llvm-project/commit/2248164a9ab791a3ed1b9586dc340b5303155021.diff L

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-09 Thread Jan Svoboda via cfe-commits
@@ -409,7 +409,7 @@ class SymbolCollector::HeaderFileURICache { // Framework headers are spelled as , not // "path/FrameworkName.framework/Headers/Foo.h". auto &HS = PP->getHeaderSearchInfo(); -if (const auto *HFI = HS.getExistingFileInfo(*FE, /*WantExternal*/ f

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-09 Thread Jan Svoboda via cfe-commits
@@ -409,7 +409,7 @@ class SymbolCollector::HeaderFileURICache { // Framework headers are spelled as , not // "path/FrameworkName.framework/Headers/Foo.h". auto &HS = PP->getHeaderSearchInfo(); -if (const auto *HFI = HS.getExistingFileInfo(*FE, /*WantExternal*/ f

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-09 Thread Jan Svoboda via cfe-commits
@@ -149,14 +157,44 @@ class SourceLocationSequence::State { operator SourceLocationSequence *() { return &Seq; } }; -inline uint64_t SourceLocationEncoding::encode(SourceLocation Loc, - SourceLocationSequence *Seq) { - return Se

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-09 Thread Jan Svoboda via cfe-commits
@@ -942,6 +942,12 @@ class ASTReader /// Sema tracks these to emit deferred diags. llvm::SmallSetVector DeclsToCheckForDeferredDiags; + /// The module files imported by different module files. Indirectly imported + /// module files are included too. The information comes

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-09 Thread Jan Svoboda via cfe-commits
@@ -5574,10 +5577,34 @@ void ASTWriter::AddFileID(FileID FID, RecordDataImpl &Record) { Record.push_back(getAdjustedFileID(FID).getOpaqueValue()); } +SourceLocationEncoding::RawLocEncoding +ASTWriter::getRawSourceLocationEncoding(SourceLocation Loc, LocSeq *Seq) { + unsign

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-09 Thread Jan Svoboda via cfe-commits
@@ -2220,40 +2227,47 @@ class ASTReader return Sema::AlignPackInfo::getFromRawEncoding(Raw); } + using RawLocEncoding = SourceLocationEncoding::RawLocEncoding; + /// Read a source location from raw form and return it in its /// originating module file's source loc

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-09 Thread Jan Svoboda via cfe-commits
@@ -696,7 +696,7 @@ class ASTReader /// Mapping from global submodule IDs to the module file in which the /// submodule resides along with the offset that should be added to the /// global submodule ID to produce a local ID. - GlobalSubmoduleMapType GlobalSubmoduleMap; +

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-09 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I left a couple of initial comments. With the 64-bit `SourceLocation` aspect of this change solved and with just 2% size increase, I think this approach makes sense. Could you share the rest of the "no transitive change" patches, or at least their outline? I'm curious what

[clang] [clang][modules] Stop eagerly reading files with diagnostic pragmas (PR #87442)

2024-04-10 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/87442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-10 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/87849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][deps] Cache `VFS::getRealPath()` (PR #68645)

2024-04-10 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/68645 >From fce5325720bcc945baed5923e00d09d84daf58e6 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 9 Oct 2023 10:14:17 -0700 Subject: [PATCH 1/5] [clang] Move lookup filename into function --- .../Depend

<    3   4   5   6   7   8   9   10   11   12   >