[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Up to you if you act on the last comment. Thanks for seeing this through! Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:295

[PATCH] D133209: [clang] Document environment variables used by the driver

jansvoboda11 added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by han

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

jansvoboda11 updated this revision to Diff 458555. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127647/new/ https://reviews.llvm.org/D127647 Files: clang/include/clang/Lex/HeaderSearch.h clang/lib/Frontend

[PATCH] D133617: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path on implicit builds

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM, thanks! Though we usually put the cache directory into `%t/cache` (aka `DIR/cache` in the JSON file) in other scanner tests, which would allow you to drop the second `sed` expression. (And you'd want to `rm -rf %t` instead.

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

jansvoboda11 added a comment. Could you explain why this is necessary and even correct? I'd expect Clang to give an error when seeing `##` in this position, and I'd expect the scanner to do the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133674/new/ https://reviews.llvm.org/D133674 ___

[PATCH] D129030: [Driver] Ignore the clang modules validation-related flags if clang modules are not enabled

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129030/new/ https://reviews.llvm.org/D129030 __

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, saudi. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One goal of the ad-hoc command line argument parsing i

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Sorry for the breakage and thanks for reporting this! This is a real bug uncovered by your build using `/opt`. I have a fix here: D122385 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Thanks for the revert @gulfem. I was hoping I'll be able to quickly forward-fix the issue, but turns out there's more to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

jansvoboda11 accepted this revision. jansvoboda11 added a comment. Thank you for working on this! I you haven't already, I suggest you test this change by dumping all TableGen records in the backend and comparing the before and after. When working on `Options.td`, I found it quite easy to intro

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, akyrtzi. Herald added a subscriber: mgrang. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dep

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

jansvoboda11 updated this revision to Diff 420905. jansvoboda11 added a comment. Finish test description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123229/new/ https://reviews.llvm.org/D123229 Files: clang/include/clang/Lex/DirectoryLookup.h

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 added a comment. In D121997#3676972 , @alanphipps wrote: > Should there be an aarch64 guard on the test? There exist downstream Arm > compilers that don't support Arm64 and fail. I know other tests explicitly > state "REQUIRES: aarch64-re

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

jansvoboda11 added a comment. Makes sense, thanks. LGTM provided you add brief explanation to each of the new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/ https://reviews.llvm.org/D129884 __

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 added a comment. Thanks for the fix! Left one suggestion. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4549 +Invocation.generateCC1CommandLine(Args, SA); +Args.insert(Args.begin(), "-cc1"); + }, This will shift all gen

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 added a comment. The code change looks good to me, could you also include a test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130620/new/ https://reviews.llvm.org/D130620 ___

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 added a comment. Thanks for adding the tests. They are failing in CI though, and I don't think they're entirely correct. My understanding is that the goal is to make sure Clang doesn't drop the `-cc1` flag when embedding command-lines into object files. During normal compilation,

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130620/new/ https://reviews.llvm.org/D130620

[PATCH] D131124: [Serialization] Remove `ORIGINAL_PCH_DIR` record

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131124/new/ https://reviews.llvm.org/D131124 __

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. It'd be nice to have some tests for this, but since it's just forwarding arguments to `FileManager` I'm also fine with this as is. Repository: rG LLVM Github Monorepo CHA

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

jansvoboda11 added a comment. Do you think it would make sense to introduce a command-line flag that would control this behavior? Also, I'd like to test this patch internally to see if it affects anything on our end. I should be able to do so next week. Repository: rG LLVM Github Monorepo

[PATCH] D131412: [clang][deps] Stop sharing FileManager across module builds in scanner

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks. (For context, this patch build on top of D131076 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D131420: [clang][deps] Always generate module paths

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since D129389 (and downst

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM, no issues on our side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126676/new/ https://reviews.llvm.org/D126676 ___ cfe-commits

[PATCH] D131420: [clang][deps] Always generate module paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG71e32d5cf005: [clang][deps] Always generate module paths (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D131420?vs=450887&id=451593#toc Repository: rG LLVM Github Monor

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 added a project: clang. jansvoboda11 requested review of this revision. This patch normalizes paths in `DependencyScanningWorkerFilesystem` so that lookup of ignored files and cached fi

[PATCH] D104536: WIP: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 updated this revision to Diff 358951. jansvoboda11 edited the summary of this revision. jansvoboda11 set the repository for this revision to rG LLVM Github Monorepo. jansvoboda11 added a comment. Rebase on top of D106064 , solving Windows CI failure.

[PATCH] D106146: [clang][deps] Separate filesystem caches for minimized and original files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 added a project: clang. Herald added a subscriber: mgorny. jansvoboda11 requested review of this revision. This patch separates the local and global caches of `DependencyScanningFilesys

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 updated this revision to Diff 359299. jansvoboda11 added a comment. Rebase on top of D106146 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104536/new/ https://reviews.llvm.org/D104536 Files: clang/lib/Tooling/DependencyScanning/Depende

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { + llvm::SmallString<256> Filename; + llvm::sys::path::native(RawFilename, Filename); + dexonsmith

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

jansvoboda11 added a comment. With the call to `llvm::sys::path::native` scoped only to `IgnoredFiles`, would this patch LGTY? Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { + llvm::SmallString<25

[PATCH] D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106100/new/ https://reviews.llvm.org/D106100 ___ cfe-commits mailing list

[PATCH] D106064: [clang][deps] Normalize ignored filenames in minimizing file system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63fd109d3aa6: [clang][deps] Normalize ignored filenames in minimizing file system (authored by jansvoboda11). Changed prior to commit: https://rev

[PATCH] D106146: [clang][deps] Separate filesystem caches for minimized and original files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1a2979fc70: [clang][deps] Separate filesystem caches for minimized and original files (authored by jansvoboda11). Changed prior to commit: https

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe564fd93ab85: [clang][deps] Avoid minimizing PCH input files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 added a comment. In D104536#288 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/42264/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks, that was a bad rebase.

[PATCH] D106787: [clang][driver] NFC: Move InputInfo.h from lib to include

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, usaxena95, s.egerton, Jim, kadircet, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc2

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. After speaking with @dexonsmith, the laziness is probably not necessary when dealing with a short bit vector. I'll also explore using `llvm::BitVector` instead of `std::vector`. Repository: rG LLVM Github Monorepo

[PATCH] D106788: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch exposes `InputInfo` in `Job` instead of plain filenames. This is use

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 updated this revision to Diff 361626. jansvoboda11 added a comment. Also ignore cc1 jobs that have inputs that are not source files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105695/new/ https://reviews.llvm.org/D105695 Files: c

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. Requesting re-review, since there are two changes: - `-cc1` commands that don't read a source file are ignored (e.g. jobs generated by `-fembed-bitcode`), - test now have `-target arm64-apple-macosx11.0.0` to ensure th

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 updated this revision to Diff 361630. jansvoboda11 added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105695/new/ https://reviews.llvm.org/D105695 Files: clang/include/clang/Tooling/Tooling.h clang/lib/Tooli

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

jansvoboda11 added a comment. Sorry, I'm not sure I follow. In D105881#2890134 , @awarzynski wrote: > Apologies, it has taken me a bit longer to get back to this. @jansvoboda11 , > now I'm realising the key disadvantage of using `OptInFFlag/OptOutFFlag

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

jansvoboda11 added a comment. In D105695#2905028 , @dexonsmith wrote: > Seeing the `-fembed-bitcode` case made me think of `-save-temps`. I think > this will work since `-x cpp-output` should return false for `isSrcFile()`... > but probably worth addin

[PATCH] D106787: [clang][driver] NFC: Move InputInfo.h from lib to include

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60426f33b1d4: [clang][driver] NFC: Move InputInfo.h from lib to include (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106788: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb76c7c6faf06: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames (authored by jansvoboda11). Repository: rG LLVM Github Monor

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11ee699b3c81: [clang][tooling] Accept Clang invocations with multiple jobs (authored by jansvoboda11). Changed prior to commit: https://reviews.ll

[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, christof. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some parts of the codebase use `FullSourceLoc` -- a wrapper around reg

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For some use-cases, it might be useful to be ab

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

jansvoboda11 added inline comments. Comment at: clang/test/Modules/cxx20-disable.cpp:2 +// RUN: rm -rf %t && mkdir %t +// RUN: not %clang_cc1 -x objective-c++ -std=c++20 -fno-cxx-modules -I %t %s + I'm not sure how to best test this. Checking the error messages i

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To reduce the number of modules we build in explicit builds (

[PATCH] D121303: [clang][deps] Don't prune search paths used by dependencies

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When pruning header search paths (to reduce the number of mod

[PATCH] D120465: [clang][deps] Disable implicit module maps

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273 + // However, some module maps loaded implicitly during the dependency scan can + // describe anti-dependencies. That happens when the current module is marked +

[PATCH] D121465: WIP: [clang][modules] Do not report declarations without linkage as ambiguous

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When finalizing the result of name lookup that encountered ambig

[PATCH] D120465: [clang][deps] Disable implicit module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6ef3635461c: [clang][deps] Disable implicit module maps (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D120465?vs=

[PATCH] D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f6af607464e: [clang][deps] Generate '-fmodule-file=' only for direct dependencies (authored by jansvoboda11). Repository: rG LLVM Github Monorep

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf4a31fc0f97: [clang][deps] Remove '-fmodules-cache-path=' arguments (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121516: [clang][deps] Simplify PREFIX definitions in tests

jansvoboda11 created this revision. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of outputting the test directory into the JSON result file, parsing it with `FileCheck` and then potentia

[PATCH] D121516: [clang][deps] Simplify PREFIX definitions in tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc4b13f7a2f7f: [clang][deps] Simplify PREFIX definitions in tests (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D121516: [clang][deps] Simplify PREFIX definitions in tests

jansvoboda11 added a reviewer: Bigcheese. jansvoboda11 added a comment. In case you want to do a post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121516/new/ https://reviews.llvm.org/D121516 ___

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch gets rid of the ridiculous relative path we use to invoke the

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code for traversing precompiled dependencies is somewhat

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

jansvoboda11 added a comment. I agree. My understanding is that `-fcxx-modules` enables Clang modules that don't interact with C++20 modules. @Bigcheese, any thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

jansvoboda11 updated this revision to Diff 415380. jansvoboda11 added a comment. Throw away recursive implementation, add reproducer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121533/new/ https://reviews.llvm.org/D121533 Files: clang/lib/Tool

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

jansvoboda11 added a comment. Fair enough, iterative implementation will be better. I simplified it a bit by using the in-out parameter `ModuleFiles` to keep track of visited files. I also switched to using `SmallVector` for the newly discovered (not-yet-visited) imports, which allows using the

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

jansvoboda11 updated this revision to Diff 415381. jansvoboda11 added a comment. Undo unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121295/new/ https://reviews.llvm.org/D121295 Files: clang/lib/Lex/HeaderSearch.cpp clang/test

[PATCH] D121685: [clang][deps] NFC: Use range-based for loop instead of iterators

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The iterator is needed after the loop body, meaning we can us

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG77924d60efa8: [clang][deps] Modules don't contribute to search path usage (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D121295?vs=415381&id=415776#toc Repository: rG

[PATCH] D121685: [clang][deps] NFC: Use range-based for loop instead of iterators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6007b0b67bcb: [clang][deps] NFC: Use range-based for loop instead of iterators (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CH

[PATCH] D121303: [clang][deps] Don't prune search paths used by dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd73daa913546: [clang][deps] Don't prune search paths used by dependencies (authored by jansvoboda11). Changed prior to commit: https://reviews.llv

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e25ff84d89e: [clang][deps] Fix traversal of precompiled dependencies (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.or

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Herald added a project: All. Abandoning this. We don't need to collect usage info from `-fimplicit-module-maps` because we don't use that feature during explicit builds: D120465 . Support for us

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, saudi. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D92191 , a bunch o

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Herald added a project: All. Abandoning this. We don't need to collect usage info from -fimplicit-module-maps because we don't use that feature during explicit builds: D120465 . Support for usag

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 updated this revision to Diff 415856. jansvoboda11 added a comment. Remove backslashes from make output checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 Files: clang/test/ClangScanDep

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 updated this revision to Diff 415857. jansvoboda11 added a comment. Add `-NEXT` to a check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 Files: clang/test/ClangScanDeps/Inputs/has_include

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, jkorous. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Command lines with multiple `-arch` argume

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 updated this revision to Diff 416569. jansvoboda11 added a comment. Specify the `apple-darwin` target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121997/new/ https://reviews.llvm.org/D121997 Files: clang/lib/Driver/ToolChains/Clan

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:2 +// RUN: rm -rf %t && mkdir -p %t +// RUN: %clang -c %s -o %t/out -arch x86_64 -arch arm64 -MJ %t/compilation_database.json +// RUN: FileCheck --input-file=%t/compilation_databas

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 updated this revision to Diff 416576. jansvoboda11 added a comment. Avoid buggy driver behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121997/new/ https://reviews.llvm.org/D121997 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 updated this revision to Diff 416846. jansvoboda11 added a comment. Introduce `-driver-only` to avoid running `-cc1`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121997/new/ https://reviews.llvm.org/D121997 Files: clang/include/c

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

jansvoboda11 created this revision. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `HeaderSearch` currently assumes `LookupFileCache` is eventually populated in `LookupFile`. However, that's not a

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 added a comment. Thanks for reporting this (also reported here: https://github.com/llvm/llvm-project/issues/54426). I have a fix up for review here: D122237 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121525/new/ https://reviews.llvm.org/D121525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

jansvoboda11 updated this revision to Diff 417527. jansvoboda11 added a comment. Remove slash from test to make it pass on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/new/ https://reviews.llvm.org/D122237 Files: clang/lib/Lex/He

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

This revision was automatically updated to reflect the committed changes. Closed by commit rG59dadd178b0b: [clang][lex] Fix failures with Microsoft header search rules (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/n

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/cl-resource-dir.c:3 + +// REQUIRES: shell + saudi wrote: > I was wondering whether it could be a concern that this test will be skipped > on Windows systems, where `clang-cl` specific devel

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

This revision was automatically updated to reflect the committed changes. Closed by commit rG26053ce05a87: [clang][deps] Create lit substitution for deps-to-rsp (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D121525?vs=414843&id=417608#toc Repository: rG LLVM G

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30cb49b44e4e: [clang][deps] NFC: De-duplicate clang-cl tests (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

jansvoboda11 updated this revision to Diff 421221. jansvoboda11 added a comment. Windows path separators... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123229/new/ https://reviews.llvm.org/D123229 Files: clang/include/clang/Lex/DirectoryLookup

[PATCH] D123229: [clang][deps] Ensure deterministic filename case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb672638dbc7c: [clang][deps] Ensure deterministic filename case (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added subscribers: carlosgalvezp, usaxena95, shchenz, kadircet, arphaman, kbarton, nemanjai. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added projects: clang, cla

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

jansvoboda11 updated this revision to Diff 422763. jansvoboda11 added a comment. Rebase, apply review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123574/new/ https://reviews.llvm.org/D123574 Files: clang-tools-extra/clang-move/Move

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:564-565 IncludeStructure Includes = ExpectedAST.getIncludeStructure(); - auto MainFE = FM.getFile(testPath("foo.cpp")); + auto

[PATCH] D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rGd79ad2f1dbc2: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective() (authored by ja

[PATCH] D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `DirectoryEntry::getN

[PATCH] D123768: [clang][CodeGen] NFCI: Use FileEntryRef

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `DirectoryEntry::getN

[PATCH] D123769: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `DirectoryEntry::getN

  1   2   3   4   5   6   7   8   9   10   >