[clang] [flang] [flang][Driver] Support -print-supported-cpus and associated aliases (PR #117199)

2024-11-25 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: I believe this results in tests failures on our bot: https://lab.llvm.org/staging/#/builders/105/builds/9796 (and a few others) https://github.com/llvm/llvm-project/pull/117199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [LinkerWrapper] Clean up options after proper forwarding (PR #126297)

2025-02-10 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: This broke our flang-enabled buildbot https://lab.llvm.org/staging/#/builders/105/builds/15554 Looking at it currently https://github.com/llvm/llvm-project/pull/126297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] Revert "[LinkerWrapper] Clean up options after proper forwarding" (PR #126495)

2025-02-10 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr created https://github.com/llvm/llvm-project/pull/126495 Reverts llvm/llvm-project#126297 Broken buildbots https://lab.llvm.org/staging/#/builders/105/builds/15554 https://lab.llvm.org/buildbot/#/builders/30/builds/15490 Error is ``` # .---command stderr #

[clang] Revert "[LinkerWrapper] Clean up options after proper forwarding" (PR #126495)

2025-02-10 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr closed https://github.com/llvm/llvm-project/pull/126495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload] Add support for loongarch64 to host plugin (PR #120173)

2024-12-16 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Is there the possibility to set up a buildbot for this architecture? https://github.com/llvm/llvm-project/pull/120173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload] Add support for loongarch64 to host plugin (PR #120173)

2024-12-17 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > Do you mean adding a dedicate buildbot for the `offload` sub-project? I think > the answer is yes. Actually we plan to setup more buildbots for any other > sub-projects, including `flang`, `lld` and `openmp`, etc. Not necessarily a dedicated buildbot for the `offload` project,

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

2025-01-09 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Hi @tahonermann do you have an idea on why this is failing? https://github.com/llvm/llvm-project/pull/120327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

2025-01-09 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Can someone more familiar with this push a fix? That would be much appreciated. Thanks! https://github.com/llvm/llvm-project/pull/120327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-01-22 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Thank you. https://github.com/llvm/llvm-project/pull/95474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Fix ctor / dtor lowering when NVPTX target is not enabled (PR #124116)

2025-01-23 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr approved this pull request. Fixes a build issue I was hitting in https://github.com/llvm/llvm-project/pull/123673 https://github.com/llvm/llvm-project/pull/124116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [llvm] [mlir] [Offload] Rework offloading entry type to be more generic (PR #124018)

2025-01-27 Thread Jan Patrick Lehr via cfe-commits
@@ -24,11 +24,24 @@ namespace offloading { /// This is the record of an object that just be registered with the offloading /// runtime. struct EntryTy { + /// Reserved bytes used to detect an older version of the struct, always zero. + uint64_t Reserved = 0x0; + /// The cur

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-09 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: This also failed one of our bots: https://lab.llvm.org/buildbot/#/builders/140/builds/14350 https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-09 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > Yep already working on it, integration issue with another change from me, my > bad Thank you for working on a fix. :) https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [Clang] Force expressions with UO_Not to not be non-negative (PR #126846)

2025-03-15 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > Hi, I think this broke two of our buildbots -- for reasons I don't quite > understand, but reverting fixed the issue locally. Can you please take a look > at it? > > https://lab.llvm.org/buildbot/#/builders/10/builds/980 > https://lab.llvm.org/buildbot/#/builders/73/builds/143

[clang] Revert "Reland [Clang][Cmake] fix libtool duplicate member name warnings" (PR #134656)

2025-04-07 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr approved this pull request. LGTM thx https://github.com/llvm/llvm-project/pull/134656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle instantiated members to determine visibility (PR #136128)

2025-04-18 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: I think this broke one of our bots: https://lab.llvm.org/buildbot/#/builders/10/builds/3726/steps/10/logs/stdio The bot was red for another issue at the time, but the stack trace includes methods that are touched in this PR. This is part of the stack trace: ``` #12 0x748dc31b

[clang] [clang] Handle instantiated members to determine visibility (PR #136128)

2025-04-18 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: I can try later today to get dumps/preprocessed source or maybe some better idea on how to reproduce the issue. @jhuber6 if you have immediate thoughts on how to provide that (or maybe even what may be the issue), let me know. https://github.com/llvm/llvm-project/pull/136128

[clang] clang/AMDGPU: Stop looking for oclc_daz_opt_* control libraries (PR #134805)

2025-04-13 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` > running on `hip-vega20-0` while building `clang` at step 3 "annotate". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/123/builds/17410 > > Here is the relevant piece of the

[clang] clang/AMDGPU: Stop looking for oclc_daz_opt_* control libraries (PR #134805)

2025-04-13 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: This should be device libs from ROCm 6.3.3. ``` $ apt show rocm-device-libs Package: rocm-device-libs Version: 1.0.0.60303-74~22.04 Priority: optional Section: devel Maintainer: ROCm Compiler Support Installed-Size: 3424 kB Depends: rocm-core Homepage: https://github.com/RadeonOpe

[clang] Revert "[clang] Handle instantiated members to determine visibility" (PR #136317)

2025-04-18 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr approved this pull request. LGTM Thanks! https://github.com/llvm/llvm-project/pull/136317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Hi, this turned a few bots red. Can this be fixed forward or should we revert in the meantime? Let me know if you need help with the bot setup / build config. Thanks! https://github.com/llvm/llvm-project/pull/134174 ___ cfe-commits mailin

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #125648)

2025-02-19 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Did anybody to run the OpenMP VV suite before and after this change? Curious to know if that improves results. https://github.com/llvm/llvm-project/pull/125648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [Offload] Always consider `flto` on for AMDGPU (PR #129118)

2025-03-07 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > but it turns on LTO by default right? This is very much how I read that patch too. Maybe the flag names and comments are a bit misleading here. https://github.com/llvm/llvm-project/pull/129118 ___ cfe-commits mailing list cfe-commits@l

[clang] [Offload] Always consider `flto` on for AMDGPU (PR #129118)

2025-03-07 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > I think people are just confusing what `-flto` means when put on a link job. Including me. :) Apologies for my ignorance, what does this do and why do we want it? It allows for some (LTO-related?) flags to be forwarded/handled correctly? https://github.com/llvm/llvm-project/pul

[clang] [Offload] Always consider `flto` on for AMDGPU (PR #129118)

2025-03-07 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr approved this pull request. With the explanation that change seems reasonable. Thank you. https://github.com/llvm/llvm-project/pull/129118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [Clang] Force expressions with UO_Not to not be non-negative (PR #126846)

2025-03-11 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Hi, I think this broke two of our buildbots -- for reasons I don't quite understand, but reverting fixed the issue locally. Can you please take a look at it? https://lab.llvm.org/buildbot/#/builders/10/builds/980 https://lab.llvm.org/buildbot/#/builders/73/builds/14304 https://gi

[clang] [Clang][Docs] Document -Xarch_ better (PR #127890)

2025-02-19 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr commented: Certainly an improvement. I think this is good, but do not feel confident right now to already approve. https://github.com/llvm/llvm-project/pull/127890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [Clang][Docs] Document -Xarch_ better (PR #127890)

2025-02-19 Thread Jan Patrick Lehr via cfe-commits
@@ -932,9 +932,18 @@ def W_Joined : Joined<["-"], "W">, Group, def Xanalyzer : Separate<["-"], "Xanalyzer">, HelpText<"Pass to the static analyzer">, MetaVarName<"">, Group; -def Xarch__ : JoinedAndSeparate<["-"], "Xarch_">, Flags<[NoXarchOption]>, - HelpText<"Pass to th

[clang] [Clang][Docs] Document -Xarch_ better (PR #127890)

2025-02-19 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr edited https://github.com/llvm/llvm-project/pull/127890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] Document -Xarch_ better (PR #127890)

2025-02-19 Thread Jan Patrick Lehr via cfe-commits
@@ -932,9 +932,18 @@ def W_Joined : Joined<["-"], "W">, Group, def Xanalyzer : Separate<["-"], "Xanalyzer">, HelpText<"Pass to the static analyzer">, MetaVarName<"">, Group; -def Xarch__ : JoinedAndSeparate<["-"], "Xarch_">, Flags<[NoXarchOption]>, - HelpText<"Pass to th

[clang] [Clang][Docs] Document -Xarch_ better (PR #127890)

2025-02-19 Thread Jan Patrick Lehr via cfe-commits
@@ -932,9 +932,18 @@ def W_Joined : Joined<["-"], "W">, Group, def Xanalyzer : Separate<["-"], "Xanalyzer">, HelpText<"Pass to the static analyzer">, MetaVarName<"">, Group; -def Xarch__ : JoinedAndSeparate<["-"], "Xarch_">, Flags<[NoXarchOption]>, - HelpText<"Pass to th

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #125648)

2025-02-20 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr approved this pull request. Thanks for all the comments and addressing concerns. https://github.com/llvm/llvm-project/pull/125648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [llvm] [Driver] Reject -mcmodel=tiny on X86 (PR #125643)

2025-05-07 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: I put up https://github.com/llvm/llvm-project/pull/138959 which removes the offending `tiny` mcmodel from the Flang driver test. I don't know if this is the right fix though. https://github.com/llvm/llvm-project/pull/125643 ___ cfe-comm

[clang] [flang] [llvm] Revert "Add IR Profile-Guided Optimization (IR PGO) support to the Flang compiler" (PR #142159)

2025-05-30 Thread Jan Patrick Lehr via cfe-commits
https://github.com/jplehr approved this pull request. LG https://github.com/llvm/llvm-project/pull/142159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [modules] Add err_main_in_named_module (PR #146247)

2025-06-30 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: > It seems I need to add the line `// WARNING-NEXT: > -Wmain-attached-to-named-module` on this > [line](https://sourcegraph.com/github.com/llvm/llvm-project/-/blob/clang/test/Driver/autocomplete.c?L114) > to fix the autocomplete test. > > What is the process to amend this PR? I

[clang-tools-extra] [clang-tidy] Add new check: `readability-use-concise-preprocessor-directives` (PR #146830)

2025-07-14 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: A LLVM syncbot commit turned our buildbot red: https://lab.llvm.org/buildbot/#/builders/123/builds/23254 The syncbot commit links to this PR. https://github.com/llvm/llvm-project/pull/146830 ___ cfe-commits mailing list cfe-commits@lis

[clang-tools-extra] [clang-tidy] Add new check: `readability-use-concise-preprocessor-directives` (PR #146830)

2025-07-14 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Hi, I don't know why, but it seems that on those machines, some git issue creped up with some stale refs. I think I resolved them. Nothing to worry about with this PR ,and apologies for the noise! https://github.com/llvm/llvm-project/pull/146830 __

<    1   2