[clang-tools-extra] r339781 - [clangd][tests] Fix typo in tests - invalid LSP exit message

2018-08-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Aug 15 08:50:45 2018 New Revision: 339781 URL: http://llvm.org/viewvc/llvm-project?rev=339781&view=rev Log: [clangd][tests] Fix typo in tests - invalid LSP exit message Syntactically invalid JSON payload was causing clangd to terminate because of unexpected EOF rather t

[clang-tools-extra] r339782 - [clangd][tests] Rename tests of clangd instance termination

2018-08-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Aug 15 08:58:05 2018 New Revision: 339782 URL: http://llvm.org/viewvc/llvm-project?rev=339782&view=rev Log: [clangd][tests] Rename tests of clangd instance termination Just making testnames better reflect their testing scenarios. Differential Revision: https://reviews.l

r332598 - Use dotted format of version tuple for availability diagnostics

2018-05-17 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu May 17 04:51:49 2018 New Revision: 332598 URL: http://llvm.org/viewvc/llvm-project?rev=332598&view=rev Log: Use dotted format of version tuple for availability diagnostics E. g. use "10.11" instead of "10_11". We are maintaining backward compatibility by parsing undersc

r315236 - PR13575: Fix USR mangling for fixed-size arrays

2017-10-09 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 9 12:51:33 2017 New Revision: 315236 URL: http://llvm.org/viewvc/llvm-project?rev=315236&view=rev Log: PR13575: Fix USR mangling for fixed-size arrays Differential Revision: https://reviews.llvm.org/D38643 Added: cfe/trunk/test/Index/USR/ cfe/trunk/test/Ind

r315241 - PR13575: Fix test

2017-10-09 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 9 13:17:28 2017 New Revision: 315241 URL: http://llvm.org/viewvc/llvm-project?rev=315241&view=rev Log: PR13575: Fix test Ignore OS-specific mangled name. Modified: cfe/trunk/test/Index/USR/array-type.cpp Modified: cfe/trunk/test/Index/USR/array-type.cpp URL:

r315252 - Fix typos in documentation

2017-10-09 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 9 16:45:20 2017 New Revision: 315252 URL: http://llvm.org/viewvc/llvm-project?rev=315252&view=rev Log: Fix typos in documentation Differential Revision: https://reviews.llvm.org/D38711 Modified: cfe/trunk/docs/InternalsManual.rst Modified: cfe/trunk/docs/Inter

r315255 - R13575: Fix USR mangling for function pointer types

2017-10-09 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 9 17:35:16 2017 New Revision: 315255 URL: http://llvm.org/viewvc/llvm-project?rev=315255&view=rev Log: R13575: Fix USR mangling for function pointer types Differential Revision: https://reviews.llvm.org/D38707 Added: cfe/trunk/test/Index/USR/func-type.cpp Modif

r315367 - Fix indexer crash for default template template parameter value

2017-10-10 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Oct 10 14:09:49 2017 New Revision: 315367 URL: http://llvm.org/viewvc/llvm-project?rev=315367&view=rev Log: Fix indexer crash for default template template parameter value rdar://33058798 Differential Revision: https://reviews.llvm.org/D38755 Added: cfe/trunk/test/

r315652 - Typos in tutorial

2017-10-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Oct 12 17:31:07 2017 New Revision: 315652 URL: http://llvm.org/viewvc/llvm-project?rev=315652&view=rev Log: Typos in tutorial Modified: cfe/trunk/www/hacking.html Modified: cfe/trunk/www/hacking.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www/hacking.ht

r341074 - [Sema][NFC] Trivial cleanup in ActOnCallExpr

2018-08-30 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Aug 30 07:46:48 2018 New Revision: 341074 URL: http://llvm.org/viewvc/llvm-project?rev=341074&view=rev Log: [Sema][NFC] Trivial cleanup in ActOnCallExpr Use logical or operator instead of a bool variable and if/else. Differential Revision: https://reviews.llvm.org/D5148

r324607 - [Parser][FixIt] Better diagnostics for "typedef" instead of "typename" typo

2018-02-08 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Feb 8 06:37:58 2018 New Revision: 324607 URL: http://llvm.org/viewvc/llvm-project?rev=324607&view=rev Log: [Parser][FixIt] Better diagnostics for "typedef" instead of "typename" typo rdar://problem/10214588 Differential Revision: https://reviews.llvm.org/D42170 Added:

r327313 - [Driver] Add text description of --help-hidden so it is shown in help

2018-03-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Mar 12 11:33:55 2018 New Revision: 327313 URL: http://llvm.org/viewvc/llvm-project?rev=327313&view=rev Log: [Driver] Add text description of --help-hidden so it is shown in help Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Dr

r327735 - [Parser] Remove hard-coded bracket depth limit

2018-03-16 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Mar 16 13:17:28 2018 New Revision: 327735 URL: http://llvm.org/viewvc/llvm-project?rev=327735&view=rev Log: [Parser] Remove hard-coded bracket depth limit The diagnostics produced if assert fails are using proper limit from language definition already. Modified: cf

[clang-tools-extra] r327901 - [clangd][nfc] Give name to a magic constant

2018-03-19 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Mar 19 13:26:15 2018 New Revision: 327901 URL: http://llvm.org/viewvc/llvm-project?rev=327901&view=rev Log: [clangd][nfc] Give name to a magic constant Modified: clang-tools-extra/trunk/clangd/index/Index.h Modified: clang-tools-extra/trunk/clangd/index/Index.h URL:

[clang-tools-extra] r327902 - [clangd] Fix undefined behavior due to misaligned type cast

2018-03-19 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Mar 19 13:26:18 2018 New Revision: 327902 URL: http://llvm.org/viewvc/llvm-project?rev=327902&view=rev Log: [clangd] Fix undefined behavior due to misaligned type cast The current code was casting pointer to a misaligned type which is undefined behavior. Found by compil

r334062 - [Sema] Fix parsing of anonymous union in language linkage specification

2018-06-05 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Jun 5 22:16:34 2018 New Revision: 334062 URL: http://llvm.org/viewvc/llvm-project?rev=334062&view=rev Log: [Sema] Fix parsing of anonymous union in language linkage specification C++17 [dcl.link]p4: A linkage specification does not establish a scope. C++17 [class.union

[clang-tools-extra] r351280 - [clangd] XPC transport layer

2019-01-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Jan 15 16:24:22 2019 New Revision: 351280 URL: http://llvm.org/viewvc/llvm-project?rev=351280&view=rev Log: [clangd] XPC transport layer - New transport layer for macOS. - XPC Framework - Test client Framework and client were written by Alex Lorenz. Differential Revisi

[clang-tools-extra] r347674 - [clangd][NFC] Move SymbolID to a separate file

2018-11-27 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Nov 27 08:40:34 2018 New Revision: 347674 URL: http://llvm.org/viewvc/llvm-project?rev=347674&view=rev Log: [clangd][NFC] Move SymbolID to a separate file Prerequisity for textDocument/SymbolInfo Differential Revision: https://reviews.llvm.org/D54799 Added: clang-t

[clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-27 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Nov 27 08:40:46 2018 New Revision: 347675 URL: http://llvm.org/viewvc/llvm-project?rev=347675&view=rev Log: [clangd] textDocument/SymbolInfo extension New method returning symbol info for given source position. Differential Revision: https://reviews.llvm.org/D54799 rda

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Jan Korous via cfe-commits
ct] >> typename = typename std::enable_if> bool>::value>::type, >> ^ >> ../include/llvm/Support/JSON.h:337:42: note: candidate template ignored: >> disabled by 'enable_if' [with T = llvm::json::Object] >&g

[clang-tools-extra] r347738 - [clangd] Fix backward-compatibility - follow-up to textDocument/SymbolInfo

2018-11-28 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Nov 28 02:24:07 2018 New Revision: 347738 URL: http://llvm.org/viewvc/llvm-project?rev=347738&view=rev Log: [clangd] Fix backward-compatibility - follow-up to textDocument/SymbolInfo Apparently clang 3.6 couldn't build the preceding patch. Modified: clang-tools-extr

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

2018-11-28 Thread Jan Korous via cfe-commits
;> viable: no known conversion from 'json::Object' to 'std::nullptr_t' > > > >>> (aka > > > >>> 'nullptr_t') for 1st argument > > > >>> Value(std::nullptr_t) : Type(T_Null) {} > > > >>> ^ >

r348379 - [NFC] Use clang-format on PrintingPolicy::PrintingPolicy() after fd5c386f743

2018-12-05 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Dec 5 08:19:49 2018 New Revision: 348379 URL: http://llvm.org/viewvc/llvm-project?rev=348379&view=rev Log: [NFC] Use clang-format on PrintingPolicy::PrintingPolicy() after fd5c386f743 The white-space change was causing conflicts downstream. rdar://problem/46486841 Mod

[clang-tools-extra] r354949 - [clangd] Library dependencies in XPC

2019-02-26 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Feb 26 18:37:44 2019 New Revision: 354949 URL: http://llvm.org/viewvc/llvm-project?rev=354949&view=rev Log: [clangd] Library dependencies in XPC Patch by Nicholas Allegra Differential Revision: https://reviews.llvm.org/D58089 Modified: clang-tools-extra/trunk/clang

r355035 - [clang][index-while-building] FileIndexRecord

2019-02-27 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Feb 27 13:47:40 2019 New Revision: 355035 URL: http://llvm.org/viewvc/llvm-project?rev=355035&view=rev Log: [clang][index-while-building] FileIndexRecord Basic data structures for index Tests are missing from this patch - will be covered properly by tests for the whole

r355036 - [clang][index-while-building][NFC] FileIndexRecord - Comments, replace auto with type

2019-02-27 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Feb 27 13:48:02 2019 New Revision: 355036 URL: http://llvm.org/viewvc/llvm-project?rev=355036&view=rev Log: [clang][index-while-building][NFC] FileIndexRecord - Comments, replace auto with type Differential Revision: https://reviews.llvm.org/D58478 Modified: cfe/tr

r355061 - [clang][index-while-building][NFC] Comment about implementation detail in FileIndexRecord

2019-02-27 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Feb 27 17:12:27 2019 New Revision: 355061 URL: http://llvm.org/viewvc/llvm-project?rev=355061&view=rev Log: [clang][index-while-building][NFC] Comment about implementation detail in FileIndexRecord Modified: cfe/trunk/lib/Index/FileIndexRecord.cpp Modified: cfe/tru

r355365 - [clang-format][docs][NFC] Fix example for Allman brace breaking style

2019-03-04 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Mar 4 17:45:31 2019 New Revision: 355365 URL: http://llvm.org/viewvc/llvm-project?rev=355365&view=rev Log: [clang-format][docs][NFC] Fix example for Allman brace breaking style I assume the example is wrong as it's clearly missing line-breaks before braces. I just ran

r355434 - [clang-format] Fix lambdas returning template specialization that contains operator in parameter

2019-03-05 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Mar 5 11:27:24 2019 New Revision: 355434 URL: http://llvm.org/viewvc/llvm-project?rev=355434&view=rev Log: [clang-format] Fix lambdas returning template specialization that contains operator in parameter A template specialization of a template foo can contain integer

[clang-tools-extra] r356974 - [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC

2019-03-25 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Mar 25 20:48:25 2019 New Revision: 356974 URL: http://llvm.org/viewvc/llvm-project?rev=356974&view=rev Log: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC We shouldn't prevent user from disabling XPC framework build on Darwin. However, by keeping it on b

r358133 - [clang][ASTContext] Try to exit early before loading serialized comments from AST files

2019-04-10 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Apr 10 13:23:33 2019 New Revision: 358133 URL: http://llvm.org/viewvc/llvm-project?rev=358133&view=rev Log: [clang][ASTContext] Try to exit early before loading serialized comments from AST files Loading external comments is expensive. This change probably doesn't apply

[clang-tools-extra] r359489 - [clangd][xpc] Fix XPC unittests

2019-04-29 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Apr 29 12:41:30 2019 New Revision: 359489 URL: http://llvm.org/viewvc/llvm-project?rev=359489&view=rev Log: [clangd][xpc] Fix XPC unittests Fix build after recent changes in clangd tests & add xpc unittests to check-clangd target. Differential Revision: https://reviews.

[clang-tools-extra] r359824 - [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching

2019-05-02 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu May 2 13:32:56 2019 New Revision: 359824 URL: http://llvm.org/viewvc/llvm-project?rev=359824&view=rev Log: [clangd][xpc] Cannonicalize value of CLANGD_BUILD_XPC before caching Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk

r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

2019-02-14 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Feb 14 15:02:35 2019 New Revision: 354075 URL: http://llvm.org/viewvc/llvm-project?rev=354075&view=rev Log: [clang][FileManager] fillRealPathName even if we aren't opening the file The pathname wasn't previously filled when the getFile() method was called with openFile

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

2019-02-18 Thread Jan Korous via cfe-commits
llvm-clang-x86_64-expensive-checks-win> > . . . > Failing Tests (1): > Clang-Unit :: > Basic/./BasicTests.exe/FileManagerTest.getFileDontOpenRealPath > > Please have a look ASAP? > > Thanks > > Galina > > On Thu, Feb 14, 2019 at 3:02 PM Jan Korous via cfe-commi

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

2019-02-18 Thread Jan Korous via cfe-commits
ance testing to check if this slows down clang? > > On Thu, Feb 14, 2019 at 6:02 PM Jan Korous via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: jkorous > Date: Thu Feb 14 15:02:35 2019 > New Revision: 354075 > > URL: http://llvm.org/viewvc/llvm-

r354291 - Reland "[clang][FileManager] fillRealPathName even if we aren't opening the file"

2019-02-18 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Feb 18 14:33:40 2019 New Revision: 354291 URL: http://llvm.org/viewvc/llvm-project?rev=354291&view=rev Log: Reland "[clang][FileManager] fillRealPathName even if we aren't opening the file" This reverts commit e2bb3121fd4ab5b01f9ec1d2e3e9877db9c6a54c. + fixed test for W

r354296 - [clang][test] Fix FileManagerTest.getFileDontOpenRealPath for Windows

2019-02-18 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Feb 18 15:12:29 2019 New Revision: 354296 URL: http://llvm.org/viewvc/llvm-project?rev=354296&view=rev Log: [clang][test] Fix FileManagerTest.getFileDontOpenRealPath for Windows Modified: cfe/trunk/unittests/Basic/FileManagerTest.cpp Modified: cfe/trunk/unittests/Ba

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

2019-02-19 Thread Jan Korous via cfe-commits
? > > Thanks. > > Jan > >> On Feb 15, 2019, at 6:15 AM, Nico Weber > <mailto:tha...@chromium.org>> wrote: >> >> Did you do any performance testing to check if this slows down clang? >> >> On Thu, Feb 14, 2019 at 6:02 PM Jan Korous via cfe-

r362646 - [clang-format][NFC] Fix BS_Allman style example in the header docs are generated from

2019-06-05 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Jun 5 13:59:48 2019 New Revision: 362646 URL: http://llvm.org/viewvc/llvm-project?rev=362646&view=rev Log: [clang-format][NFC] Fix BS_Allman style example in the header docs are generated from Differential Revision: https://reviews.llvm.org/D61729 Modified: cfe/tr

[clang-tools-extra] r365804 - [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test

2019-07-11 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Jul 11 11:21:21 2019 New Revision: 365804 URL: http://llvm.org/viewvc/llvm-project?rev=365804&view=rev Log: [clangd][NFC] Decrease template depth limit in RecursiveHierarchyUnbounded test ...to minimize the chance of stack overflow before reaching the limit. Modified:

r365947 - Reland [clang] DirectoryWatcher

2019-07-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jul 12 12:47:55 2019 New Revision: 365947 URL: http://llvm.org/viewvc/llvm-project?rev=365947&view=rev Log: Reland [clang] DirectoryWatcher This reverts commit abce8c457dd3de6b156756e547cc0eefb7653c79. + Fix the build for platforms that don't have DW implementated. Add

r365948 - Revert "Reland [clang] DirectoryWatcher"

2019-07-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jul 12 12:54:36 2019 New Revision: 365948 URL: http://llvm.org/viewvc/llvm-project?rev=365948&view=rev Log: Revert "Reland [clang] DirectoryWatcher" This reverts commit fdcb7f47e783933e0af8a5fae91132269a208268. Removed: cfe/trunk/include/clang/DirectoryWatcher/

r365954 - Reland [clang] DirectoryWatcher

2019-07-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jul 12 13:34:10 2019 New Revision: 365954 URL: http://llvm.org/viewvc/llvm-project?rev=365954&view=rev Log: Reland [clang] DirectoryWatcher This reverts commit f561227d133224d2d6a5a016abe4be051fa75501. - DirectoryWatcher - Fix the build for platforms that don't have DW

r365966 - [DirectoryWatcher][linux] Fix use of uninitialized value

2019-07-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jul 12 15:11:43 2019 New Revision: 365966 URL: http://llvm.org/viewvc/llvm-project?rev=365966&view=rev Log: [DirectoryWatcher][linux] Fix use of uninitialized value Modified: cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp Modified: cfe/trunk/lib/Dir

r365968 - [DirectoryWatcher][NFC] Silence warnings in release build

2019-07-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jul 12 15:25:17 2019 New Revision: 365968 URL: http://llvm.org/viewvc/llvm-project?rev=365968&view=rev Log: [DirectoryWatcher][NFC] Silence warnings in release build Modified: cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp cfe/trunk/unittests/Dir

r365976 - [DirectoryWatcher][test][NFC] Add information to test failure reports

2019-07-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jul 12 17:09:04 2019 New Revision: 365976 URL: http://llvm.org/viewvc/llvm-project?rev=365976&view=rev Log: [DirectoryWatcher][test][NFC] Add information to test failure reports Modified: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp Modified: cfe/tr

r366137 - [DirectoryWatcher][NFC][test] Add typedef for enum

2019-07-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Jul 15 15:11:28 2019 New Revision: 366137 URL: http://llvm.org/viewvc/llvm-project?rev=366137&view=rev Log: [DirectoryWatcher][NFC][test] Add typedef for enum Modified: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp Modified: cfe/trunk/unittests/Direc

r366138 - [DirectoryWatcher][test] Relax test assumptions

2019-07-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Jul 15 15:11:51 2019 New Revision: 366138 URL: http://llvm.org/viewvc/llvm-project?rev=366138&view=rev Log: [DirectoryWatcher][test] Relax test assumptions Workaround for FSEvents sometimes sending notifications for events that happened before DirectoryWatcher was create

r366152 - [DirectoryWatcher][linux] Fix for older kernels

2019-07-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Jul 15 16:14:00 2019 New Revision: 366152 URL: http://llvm.org/viewvc/llvm-project?rev=366152&view=rev Log: [DirectoryWatcher][linux] Fix for older kernels IN_EXCL_UNLINK exists since Linux 2.6.36 Differential Revision: https://reviews.llvm.org/D64764 Modified: cfe

r366823 - [clang][NFCI] Fix random typos

2019-07-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Jul 23 09:54:11 2019 New Revision: 366823 URL: http://llvm.org/viewvc/llvm-project?rev=366823&view=rev Log: [clang][NFCI] Fix random typos Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h cfe/trunk/lib/Index/IndexSymbol.cpp cfe/trunk/lib/Se

[clang-tools-extra] r367354 - [clangd][NFC] Typo in comment

2019-07-30 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Jul 30 13:39:39 2019 New Revision: 367354 URL: http://llvm.org/viewvc/llvm-project?rev=367354&view=rev Log: [clangd][NFC] Typo in comment Modified: clang-tools-extra/trunk/clangd/Headers.h Modified: clang-tools-extra/trunk/clangd/Headers.h URL: http://llvm.org/view

[clang-tools-extra] r367361 - [clangd][NFC] Fix typo in comment

2019-07-30 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Jul 30 15:18:04 2019 New Revision: 367361 URL: http://llvm.org/viewvc/llvm-project?rev=367361&view=rev Log: [clangd][NFC] Fix typo in comment Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL: http:/

r367632 - [DirectoryWatcher] Relax assumption to prevent test flakiness

2019-08-01 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Aug 1 16:24:30 2019 New Revision: 367632 URL: http://llvm.org/viewvc/llvm-project?rev=367632&view=rev Log: [DirectoryWatcher] Relax assumption to prevent test flakiness Modified: cfe/trunk/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp cfe/trunk/unittests/Dir

Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

2019-08-01 Thread Jan Korous via cfe-commits
Oh! Interesting! Thanks for investigating this. I'm happy to review the patch. > On Aug 1, 2019, at 5:17 PM, Puyan Lotfi wrote: > > Hi Jan, Thanks for the follow up! > > Me and Compnerd narrowed down the issue to the inotify file count limit being > exceeded as the cause. DirectoryWatcherLinu

r367906 - [DirectoryWatcher][linux] Fix build for older kernels

2019-08-05 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Aug 5 11:44:07 2019 New Revision: 367906 URL: http://llvm.org/viewvc/llvm-project?rev=367906&view=rev Log: [DirectoryWatcher][linux] Fix build for older kernels Apparently kernel support for IN_EXCL_UNLINK in inotify_add_watch() doesn't imply it's defined in sys/inotif

r368732 - [clang] Refactor doc comments to Decls attribution

2019-08-13 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Aug 13 11:11:44 2019 New Revision: 368732 URL: http://llvm.org/viewvc/llvm-project?rev=368732&view=rev Log: [clang] Refactor doc comments to Decls attribution - Create ASTContext::attachCommentsToJustParsedDecls so we don't have to load external comments in Sema when tr

r368761 - [clang] DirectoryWatcher for Windows stubs (to fix build break).

2019-08-13 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Aug 13 15:39:26 2019 New Revision: 368761 URL: http://llvm.org/viewvc/llvm-project?rev=368761&view=rev Log: [clang] DirectoryWatcher for Windows stubs (to fix build break). This is just a code skeleton for DirectoryWatcher-windows.cpp so the build on Windows stops breaki

r368762 - [clang][DirectoryWatcher] Fix Windows stub after LLVM change

2019-08-13 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Aug 13 15:39:50 2019 New Revision: 368762 URL: http://llvm.org/viewvc/llvm-project?rev=368762&view=rev Log: [clang][DirectoryWatcher] Fix Windows stub after LLVM change r367979 changed DirectoryWatcher::Create to return an llvm::Expected. Adjust the Windows stub accordin

r364690 - [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test

2019-06-28 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jun 28 15:37:31 2019 New Revision: 364690 URL: http://llvm.org/viewvc/llvm-project?rev=364690&view=rev Log: [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test Clang <= 4 used the pre-C++11 rule about which structures can be passed in registers. Modified

r365574 - [clang] DirectoryWatcher

2019-07-09 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Jul 9 15:44:48 2019 New Revision: 365574 URL: http://llvm.org/viewvc/llvm-project?rev=365574&view=rev Log: [clang] DirectoryWatcher Asynchronously monitors specified directory for changes and passes notifications to provided callback. Dependency for index-while-buildi

r360607 - [clang][ASTContext] Call setAttached for comments attached to a declaration

2019-05-13 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon May 13 10:52:09 2019 New Revision: 360607 URL: http://llvm.org/viewvc/llvm-project?rev=360607&view=rev Log: [clang][ASTContext] Call setAttached for comments attached to a declaration This is a bug affecting performance when compiling with -Wdocumentation. In Sema::ActO

r371578 - [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path

2019-09-10 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Sep 10 17:30:26 2019 New Revision: 371578 URL: http://llvm.org/viewvc/llvm-project?rev=371578&view=rev Log: [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir path Differential Revision: https://reviews.llvm.org/D67379 Modified: cfe/trunk/test/Cl

r371697 - [clang-scan-deps] Add dependency targets

2019-09-11 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Sep 11 17:48:45 2019 New Revision: 371697 URL: http://llvm.org/viewvc/llvm-project?rev=371697&view=rev Log: [clang-scan-deps] Add dependency targets Differential Revision: https://reviews.llvm.org/D67475 Modified: cfe/trunk/test/ClangScanDeps/Inputs/subframework_hea

r371787 - [libclang] Expose abort()-ing LLVM fatal error handler

2019-09-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Sep 12 15:55:55 2019 New Revision: 371787 URL: http://llvm.org/viewvc/llvm-project?rev=371787&view=rev Log: [libclang] Expose abort()-ing LLVM fatal error handler Differential Revision: https://reviews.llvm.org/D66775 Added: cfe/trunk/include/clang-c/FatalErrorHandl

r371794 - [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test

2019-09-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Sep 12 16:51:48 2019 New Revision: 371794 URL: http://llvm.org/viewvc/llvm-project?rev=371794&view=rev Log: [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test Modified: cfe/trunk/unittests/libclang/CrashTests/LibclangCrashTest.cpp Modified: cfe/trunk/unittes

r371890 - [Support] Add overload writeFileAtomically(std::function Writer)

2019-09-13 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Sep 13 13:08:27 2019 New Revision: 371890 URL: http://llvm.org/viewvc/llvm-project?rev=371890&view=rev Log: [Support] Add overload writeFileAtomically(std::function Writer) Differential Revision: https://reviews.llvm.org/D67424 Modified: cfe/trunk/lib/Frontend/ASTUn

[clang-tools-extra] r371890 - [Support] Add overload writeFileAtomically(std::function Writer)

2019-09-13 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Sep 13 13:08:27 2019 New Revision: 371890 URL: http://llvm.org/viewvc/llvm-project?rev=371890&view=rev Log: [Support] Add overload writeFileAtomically(std::function Writer) Differential Revision: https://reviews.llvm.org/D67424 Modified: clang-tools-extra/trunk/clan

r372174 - [clang-scan-deps] Add verbose mode

2019-09-17 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Sep 17 12:45:24 2019 New Revision: 372174 URL: http://llvm.org/viewvc/llvm-project?rev=372174&view=rev Log: [clang-scan-deps] Add verbose mode When running in the default mode we don't print anything other than actual output to stdout to make automated processing easier

r372679 - [static analyzer] Define __clang_analyzer__ macro in driver

2019-09-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Sep 23 17:33:47 2019 New Revision: 372679 URL: http://llvm.org/viewvc/llvm-project?rev=372679&view=rev Log: [static analyzer] Define __clang_analyzer__ macro in driver Differential Revision: https://reviews.llvm.org/D67938 Added: cfe/trunk/test/Analysis/misc-driver.

r372680 - [static analyzer] Remove --analyze-auto

2019-09-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Sep 23 17:37:25 2019 New Revision: 372680 URL: http://llvm.org/viewvc/llvm-project?rev=372680&view=rev Log: [static analyzer] Remove --analyze-auto Differential Revision: https://reviews.llvm.org/D67934 Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/

r372683 - [static analyzer][test] Test directly that driver sets D__clang_analyzer__

2019-09-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Sep 23 19:06:59 2019 New Revision: 372683 URL: http://llvm.org/viewvc/llvm-project?rev=372683&view=rev Log: [static analyzer][test] Test directly that driver sets D__clang_analyzer__ Follow-up to fbd13570b0d Modified: cfe/trunk/test/Analysis/misc-driver.c Modified:

Re: r372679 - [static analyzer] Define __clang_analyzer__ macro in driver

2019-09-23 Thread Jan Korous via cfe-commits
t/clang-tools-extra/test/clang-tidy/clang-tidy-__clang_analyzer__macro.cpp. > Found compiler error(s). > Expected 0 lines, got 3. > > -- > > > Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. > Testing Time: 4.11s > ************ &g

r372685 - Revert "[static analyzer][test] Test directly that driver sets D__clang_analyzer__"

2019-09-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Sep 23 20:19:20 2019 New Revision: 372685 URL: http://llvm.org/viewvc/llvm-project?rev=372685&view=rev Log: Revert "[static analyzer][test] Test directly that driver sets D__clang_analyzer__" This reverts commit c7541903d72765a38808e9973572a8d50c9d94fb. Modified: c

r372687 - Revert "[static analyzer] Define __clang_analyzer__ macro in driver"

2019-09-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Sep 23 20:21:22 2019 New Revision: 372687 URL: http://llvm.org/viewvc/llvm-project?rev=372687&view=rev Log: Revert "[static analyzer] Define __clang_analyzer__ macro in driver" This reverts commit fbd13570b0d5f92ef2cf6bcfe7cc2f6178500187. Removed: cfe/trunk/test/Ana

Re: r329804 - [Sema] Fix built-in decrement operator overload resolution

2018-04-12 Thread Jan Korous via cfe-commits
2018, at 15:19, Richard Smith wrote: > > While you're here... ++ should not be available for bool in C++17 onwards. :) > > On Wed, 11 Apr 2018, 14:39 Jan Korous via cfe-commits, > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: jkorous > Date: Wed Apr 11 06:3

[clang-tools-extra] r329958 - [clangd][nfc] Simplify readDelimitedMessage()

2018-04-12 Thread Jan Korous via cfe-commits
Author: jkorous Date: Thu Apr 12 14:33:24 2018 New Revision: 329958 URL: http://llvm.org/viewvc/llvm-project?rev=329958&view=rev Log: [clangd][nfc] Simplify readDelimitedMessage() istream::eof() is always false after successful getline() Modified: clang-tools-extra/trunk/clangd/JSONRPCDispat

r330254 - [Sema] Disable built-in increment operator for bool in overload resolution in C++17

2018-04-18 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Apr 18 06:38:39 2018 New Revision: 330254 URL: http://llvm.org/viewvc/llvm-project?rev=330254&view=rev Log: [Sema] Disable built-in increment operator for bool in overload resolution in C++17 Following: https://llvm.org/svn/llvm-project/cfe/trunk@329804 For C++17 the w

[clang-tools-extra] r330608 - [clangd][tests] Fix handling of EOF in delimited input

2018-04-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Apr 23 08:55:07 2018 New Revision: 330608 URL: http://llvm.org/viewvc/llvm-project?rev=330608&view=rev Log: [clangd][tests] Fix handling of EOF in delimited input Request in delimited input ended by EOF shouldn't be an error state. Comments at the end of test file should

[clang-tools-extra] r330609 - [clangd][tests] Fix delimiter handling

2018-04-23 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Apr 23 08:58:42 2018 New Revision: 330609 URL: http://llvm.org/viewvc/llvm-project?rev=330609&view=rev Log: [clangd][tests] Fix delimiter handling Empty line shouldn't be considered a delimiter Differential Revision: https://reviews.llvm.org/D45764 Added: clang-too

r373977 - Add VFS support for sanitizers' blacklist

2019-10-07 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 7 15:36:19 2019 New Revision: 373977 URL: http://llvm.org/viewvc/llvm-project?rev=373977&view=rev Log: Add VFS support for sanitizers' blacklist Differential Revision: https://reviews.llvm.org/D67742 Added: cfe/trunk/test/CodeGen/Inputs/sanitizer-blacklist-vfso

r373999 - Revert "Add VFS support for sanitizers' blacklist"

2019-10-07 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 7 17:36:19 2019 New Revision: 373999 URL: http://llvm.org/viewvc/llvm-project?rev=373999&view=rev Log: Revert "Add VFS support for sanitizers' blacklist" Fix tests on Windows for now. This reverts commit 96ac97a4213287003f08636d0c372b3f71e9cfca. Removed: cfe/t

r374006 - Reland 'Add VFS support for sanitizers' blacklist'

2019-10-07 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 7 18:13:17 2019 New Revision: 374006 URL: http://llvm.org/viewvc/llvm-project?rev=374006&view=rev Log: Reland 'Add VFS support for sanitizers' blacklist' The original patch broke the test for Windows. Trying to fix as per Reid's suggestions outlined here: https://re

r374011 - [NFC] Fix ubsan-blacklist test

2019-10-07 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 7 19:26:17 2019 New Revision: 374011 URL: http://llvm.org/viewvc/llvm-project?rev=374011&view=rev Log: [NFC] Fix ubsan-blacklist test Restored original test and marked tests for VFS as unsupported on Windows. Added: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c

r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

2019-10-08 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Oct 8 11:13:04 2019 New Revision: 374098 URL: http://llvm.org/viewvc/llvm-project?rev=374098&view=rev Log: [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows Previously disabled in d0c2d5daa3e Modified: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c Modi

Re: r374098 - [NFC] Attempt to make ubsan-blacklist-vfs test pass on Windows

2019-10-08 Thread Jan Korous via cfe-commits
obj/clang/test/CodeGen/Output/invalid-virtual-file.blacklist': > no such file or directory > > > Looks like it expects a "No such file" with a capital "No" but gets a "no > such file" with a lower-case n. {{[Nn]}}o probably fixes this. > > On Tu

Re: r374006 - Reland 'Add VFS support for sanitizers' blacklist'

2019-10-09 Thread Jan Korous via cfe-commits
l clang-tidy integrations for > obscure reasons. > > Can we instead just pass VFS instance to the SanitizerBlacklist and use > relative paths? > > We might also need to revert the patch to unbreak our release, sorry about > the inconvenience. > > On Tue, Oct 8, 2019 a

[clang-tools-extra] r374815 - [clang-scan-deps] Support for clang --analyze in clang-scan-deps

2019-10-14 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 14 13:15:01 2019 New Revision: 374815 URL: http://llvm.org/viewvc/llvm-project?rev=374815&view=rev Log: [clang-scan-deps] Support for clang --analyze in clang-scan-deps The goal is to have 100% fidelity in clang-scan-deps behavior when --analyze is present in compila

r374815 - [clang-scan-deps] Support for clang --analyze in clang-scan-deps

2019-10-14 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 14 13:15:01 2019 New Revision: 374815 URL: http://llvm.org/viewvc/llvm-project?rev=374815&view=rev Log: [clang-scan-deps] Support for clang --analyze in clang-scan-deps The goal is to have 100% fidelity in clang-scan-deps behavior when --analyze is present in compila

r374821 - [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows

2019-10-14 Thread Jan Korous via cfe-commits
Author: jkorous Date: Mon Oct 14 14:06:11 2019 New Revision: 374821 URL: http://llvm.org/viewvc/llvm-project?rev=374821&view=rev Log: [NFC] Fix ClangScanDeps/static-analyzer.c test on Windows Follow-up to c5d14b5c6fa Modified: cfe/trunk/test/ClangScanDeps/static-analyzer.c Modified: cfe/tru

r374926 - Reland [Driver] Fix -working-directory issues

2019-10-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Oct 15 10:51:59 2019 New Revision: 374926 URL: http://llvm.org/viewvc/llvm-project?rev=374926&view=rev Log: Reland [Driver] Fix -working-directory issues Don't change the default VFS in Driver, update tests & reland. This reverts commit 999f8a7416f8edc54ef92e715fd23c532

r374929 - Fix Driver/working-directory.c test

2019-10-15 Thread Jan Korous via cfe-commits
Author: jkorous Date: Tue Oct 15 11:04:18 2019 New Revision: 374929 URL: http://llvm.org/viewvc/llvm-project?rev=374929&view=rev Log: Fix Driver/working-directory.c test Accidentally committed debug print. Modified: cfe/trunk/test/Driver/working-directory.c Modified: cfe/trunk/test/Driver/w

[clang] - b26e9e2 - Revert "[static analyzer] Define __clang_analyzer__ macro in driver"

2019-10-16 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2019-09-24T03:21:22Z New Revision: b26e9e2a8f1865711c4e9b9aa7be712589169b3d URL: https://github.com/llvm/llvm-project/commit/b26e9e2a8f1865711c4e9b9aa7be712589169b3d DIFF: https://github.com/llvm/llvm-project/commit/b26e9e2a8f1865711c4e9b9aa7be71

[clang] f7c7e8a - [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker

2020-05-21 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-21T11:54:49-07:00 New Revision: f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2 URL: https://github.com/llvm/llvm-project/commit/f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2 DIFF: https://github.com/llvm/llvm-project/commit/f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2.diff LO

[clang] 54e91a3 - Reland "[Analyzer][WebKit] RefCntblBaseVirtualDtorChecker"

2020-05-21 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-21T16:41:00-07:00 New Revision: 54e91a3c701040d9d2e467bd483c197073b2c5e4 URL: https://github.com/llvm/llvm-project/commit/54e91a3c701040d9d2e467bd483c197073b2c5e4 DIFF: https://github.com/llvm/llvm-project/commit/54e91a3c701040d9d2e467bd483c197073b2c5e4.diff LO

[clang] 660cda5 - [Analyzer][WebKit] NoUncountedMembersChecker

2020-05-27 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-27T19:46:32-07:00 New Revision: 660cda572d6e05e55a9d959e61aba51790c0abbd URL: https://github.com/llvm/llvm-project/commit/660cda572d6e05e55a9d959e61aba51790c0abbd DIFF: https://github.com/llvm/llvm-project/commit/660cda572d6e05e55a9d959e61aba51790c0abbd.diff LO

[clang] 1a5c97f - [ASTMatchers] Matchers related to C++ inheritance

2020-05-29 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-29T12:38:01-07:00 New Revision: 1a5c97f3a4b88438b19ff34a285e559e57b1e9d4 URL: https://github.com/llvm/llvm-project/commit/1a5c97f3a4b88438b19ff34a285e559e57b1e9d4 DIFF: https://github.com/llvm/llvm-project/commit/1a5c97f3a4b88438b19ff34a285e559e57b1e9d4.diff LO

[clang] d61ad66 - [Analyzer][WebKit] Check record definition is available in NoUncountedMembers checker

2020-06-02 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-06-02T13:10:36-07:00 New Revision: d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc URL: https://github.com/llvm/llvm-project/commit/d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc DIFF: https://github.com/llvm/llvm-project/commit/d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc.diff LO

[clang] 39fa431 - [Analyzer][NFC] Fix markup in WebKit checkers documentation

2020-06-02 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-06-02T16:04:23-07:00 New Revision: 39fa431c8ccad45de9ec67e8681da923d0cd28c7 URL: https://github.com/llvm/llvm-project/commit/39fa431c8ccad45de9ec67e8681da923d0cd28c7 DIFF: https://github.com/llvm/llvm-project/commit/39fa431c8ccad45de9ec67e8681da923d0cd28c7.diff LO

[clang] 5e8b4be - [AST][NFC] Simplify a regression test

2020-07-16 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-07-16T12:07:18-07:00 New Revision: 5e8b4be9f8546884889b1f178a6a2c2a5c1c9d1f URL: https://github.com/llvm/llvm-project/commit/5e8b4be9f8546884889b1f178a6a2c2a5c1c9d1f DIFF: https://github.com/llvm/llvm-project/commit/5e8b4be9f8546884889b1f178a6a2c2a5c1c9d1f.diff LO

  1   2   >