[PATCH] D55052: Fix junk output in clangd vscode plugin

2018-11-29 Thread James Findley via Phabricator via cfe-commits
jfindley created this revision. jfindley added a reviewer: ioeric. jfindley added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. When using the vscode clangd plugin, lots and lots of junk output is printed to the output w

[PATCH] D55052: Fix junk output in clangd vscode plugin

2018-11-29 Thread James Findley via Phabricator via cfe-commits
jfindley marked an inline comment as done. jfindley added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:59 +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never }; ioeric wr

[PATCH] D55052: Fix junk output in clangd vscode plugin

2018-11-29 Thread James Findley via Phabricator via cfe-commits
jfindley updated this revision to Diff 175897. jfindley added a comment. Changed the comment to be a little more helpful. I used 'output' rather than errors because depending on verbosity level it can be more than just errors printed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5505

[PATCH] D55052: Fix junk output in clangd vscode plugin

2018-11-29 Thread James Findley via Phabricator via cfe-commits
jfindley marked an inline comment as done. jfindley added a comment. In D55052#1313048 , @ioeric wrote: > James, do you have commit access to llvm? If not, I'm happy to land the patch > for you. I do not have commit access - if you could land it that wo