[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

2019-01-15 Thread James Dennett via Phabricator via cfe-commits
jdennett added a comment. In D56731#1358907 , @Quuxplusone wrote: > For my own use-cases, I will continue to want a 100% comprehensive `-Wctad`. > All these "heuristics" you're proposing seem very ad-hoc, and make a lot of > work for the compiler vendor,

[PATCH] D28189: Extend documentation of how to test clang-tidy checks.

2017-01-02 Thread James Dennett via Phabricator via cfe-commits
jdennett marked 2 inline comments as done. jdennett added a comment. Thanks for the review. I've address your comments, and will check over the (presumed-final) diff before submitting. Comment at: docs/clang-tidy/index.rst:558 +typically the basic `CHECK` forms (`CHECK-MESSAG

[PATCH] D28189: Extend documentation of how to test clang-tidy checks.

2017-01-02 Thread James Dennett via Phabricator via cfe-commits
jdennett updated this revision to Diff 82818. jdennett added a comment. Addressed review comments: double-backtick quoting, underscores for references to FileCheck, and change "matcher tests" to "clang-tidy tests". https://reviews.llvm.org/D28189 Files: docs/clang-tidy/index.rst Index: docs