[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

@@ -101,7 +101,7 @@ module.exports = { // $predicate `,` $lhs `,` $rhs attr-dict `:` type($lhs) seq(choice('arith.cmpi', 'arith.cmpf'), field('predicate', - choice('eq', 'ne', 'oeq', 'o

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

@@ -24,7 +24,7 @@ "eq" "ne" "oeq" - "olt" + "old" kuhar wrote: also here https://github.com/llvm/llvm-project/pull/108355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/108355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

https://github.com/kuhar requested changes to this pull request. I think this will be easier to review / merge if you split the PR into a few smaller ones, e.g., by project (clang, mlir, llvm, etc.). We could further split it down by stuff that's clearly safe to land (e.g., comments), and thing

[clang] [llvm] [NFC] Replace more DenseMaps with SmallDenseMaps (PR #111836)

https://github.com/kuhar commented: Could you open a separate PR the code formatting changes? This will make it easier to review. https://github.com/llvm/llvm-project/pull/111836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [clang] Prefer StringRef::substr(0, N) to slice(0, N) (NFC) (PR #113784)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/113784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ADT] Simplify SmallSet (PR #109412)

https://github.com/kuhar approved this pull request. LGTM. Could you also add [NFC] to the PR title? https://github.com/llvm/llvm-project/pull/109412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [llvm] [mlir] Fix typo "tranpose" (PR #124929)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/124929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

@@ -2596,6 +2596,15 @@ template using has_sizeof = decltype(sizeof(T)); template constexpr bool is_incomplete_v = !is_detected::value; +//===--===// +// Extra additions to +//===---

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

@@ -2596,6 +2596,15 @@ template using has_sizeof = decltype(sizeof(T)); template constexpr bool is_incomplete_v = !is_detected::value; +//===--===// +// Extra additions to +//===---

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

https://github.com/kuhar requested changes to this pull request. https://github.com/llvm/llvm-project/pull/119740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][modules] Separate parsing of modulemaps (PR #119740)

@@ -2596,6 +2596,15 @@ template using has_sizeof = decltype(sizeof(T)); template constexpr bool is_incomplete_v = !is_detected::value; +//===--===// +// Extra additions to +//===---

[clang] [clang-tools-extra] Remove `StringLiteral` in favor of `StringRef` (PR #122366)

https://github.com/kuhar commented: Note that now we also have a new type for string tables: https://github.com/llvm/llvm-project/pull/119488 which doesn't result in relocations https://github.com/llvm/llvm-project/pull/122366 ___ cfe-commits mailing

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

https://github.com/kuhar dismissed https://github.com/llvm/llvm-project/pull/119740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ADT] Remove old range constructors of SmallSet and StringSet (PR #133205)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use DenseMap::insert_range (NFC) (PR #133844)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Use llvm::erase_if (NFC) (PR #134017)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/134017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Call hash_combine_range with a range (NFC) (PR #136525)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Call hash_combine_range with a range (NFC) (PR #136526)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Use llvm::unique (NFC) (PR #136470)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::unique (NFC) (PR #136469)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Use llvm::unique (NFC) (PR #136514)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use llvm::less_second (NFC) (PR #136396)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::SmallVector::pop_back_val (NFC) (PR #136451)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Simplify isDefaultedHelper (NFC) (PR #137571)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Simplify isDefaultedHelper (NFC) (PR #137571)

@@ -871,14 +871,11 @@ IteratorT matchesFirstInPointerRange(const MatcherT &Matcher, IteratorT Start, return End; } -template ::value> - * = nullptr> -inline bool isDefaultedHelper(const T *) { +template inline bool isDefaultedHelper(const T *FD) {

[clang] [clang] Use range constructors of *Set (NFC) (PR #137574)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

kuhar wrote: > High level question: I don't understand why you call this a "gather" > operation. What do you mean by that? Isn't it semantically just a memcpy, or > a (global/buffer) load followed by a (LDS) store? This is more like a subgroup operation because the destination offset is unifo

[clang] [Analysis] Remove has_arg_iterator_range (NFC) (PR #137568)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [NFC] Use more isa and isa_and_nonnull instead dyn_cast for predicates (PR #137393)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Use llvm::erase_if (NFC) (PR #135574)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/135574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Use llvm::map_range (NFC) (PR #135990)

@@ -103,11 +103,9 @@ template class MultiOnDiskHashTable { /// The current set of on-disk tables. table_range tables() { -auto Begin = Tables.begin(), End = Tables.end(); -if (getMergedTable()) - ++Begin; -return llvm::make_range(llvm::map_iterator(Begin,

[clang] [Frontend] Use StringRef::ends_with (NFC) (PR #135988)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/135988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Use llvm::map_range (NFC) (PR #135990)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/135990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/136543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

@@ -2113,12 +2113,63 @@ void erase(Container &C, ValueType V) { C.erase(std::remove(C.begin(), C.end(), V), C.end()); } +namespace detail { +template +using check_has_member_iterator_category_t = +typename decltype(std::declval().begin())::iterator_category; + +template

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

https://github.com/kuhar commented: > I understand that you are working on improving the performance of > llvm::append_range. I'm interested and attempted to, but I have very few cycles these days (mostly weekends/holidays). The biggest blocker for me is setting up something I can quickly tes

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

@@ -2113,12 +2113,63 @@ void erase(Container &C, ValueType V) { C.erase(std::remove(C.begin(), C.end(), V), C.end()); } +namespace detail { +template +using check_has_member_iterator_category_t = +typename decltype(std::declval().begin())::iterator_category; + +template

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

@@ -2113,12 +2113,63 @@ void erase(Container &C, ValueType V) { C.erase(std::remove(C.begin(), C.end(), V), C.end()); } +namespace detail { +template +using check_has_member_iterator_category_t = +typename decltype(std::declval().begin())::iterator_category; + +template

[clang] [llvm] DO NOT MERGE: Identify places that need reserve. (PR #136543)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/136543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Use llvm::is_detected (NFC) (PR #137560)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/137560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] llvm::append_range (NFC) (PR #136440)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use llvm::append_range (NFC) (PR #136448)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/136448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use DenseMap::insert_range (NFC) (PR #133655)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Use llvm::reverse (NFC) (PR #133550)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Format] Use a range constructor of DenseSet (NFC) (PR #133382)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Use *Set::insert_range (NFC) (PR #133589)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Basic] Use SmallSet::insert_range (NFC) (PR #133594)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/133594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2