[flang] [libcxx] [libc] [compiler-rt] [llvm] [clang-tools-extra] [clang] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

@@ -95,7 +95,7 @@ class SerializeToHsacoPass std::unique_ptr> serializeISA(const std::string &isa) override; - std::unique_ptr> assembleIsa(const std::string &isa); + std::unique_ptr> assembleIsa(const std::string &isa); kuhar wrote: IMO this should eit

[flang] [compiler-rt] [libc] [libcxx] [clang-tools-extra] [llvm] [clang] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/71439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [mlir] [compiler-rt] [clang-tools-extra] [flang] [llvm] [libc] Make SmallVectorImpl destructor protected (PR #71439)

https://github.com/kuhar commented: Overall I think this makes sense, but the `SerializeToHsaco` changes look suboptimal https://github.com/llvm/llvm-project/pull/71439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[flang] [compiler-rt] [libc] [libcxx] [clang-tools-extra] [llvm] [clang] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/71439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [mlir] [llvm] [clang] [libcxx] [flang] [clang-tools-extra] [libc] Make SmallVectorImpl destructor protected (PR #71439)

https://github.com/kuhar approved this pull request. I think we have reached consensus that this is the preferred direction. `SerializeToHsaco` is a tiny detail in the grand scheme of things, and because this PR doesn't make it any worse, I don't think we should be blocked by it. https://githu

[mlir] [clang-tools-extra] [llvm] [mlir][ArithToAMDGPU] Add option for saturating truncation to fp8 (PR #74153)

https://github.com/kuhar approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,38 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar commented: Thanks for all the fixes, this is looking very good. Did another pass and left some local suggestions. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,303 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar approved this pull request. Thanks for all the changes, LGTM. Please wait for a second approval before submitting if you can. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,266 @@ +//===- llvm/ADT/PagedVector.h - 'Lazily allocated' vectors --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Introduce paged vector (PR #66430)

kuhar wrote: @vvereschaka I submitted a fix for death tests in https://github.com/llvm/llvm-project/commit/8580010672e9ff37b0744927296ca00dbcbef5be https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Introduce paged vector (PR #66430)

kuhar wrote: @vgvassilev I've seen other tests use the pattern from my fix. Feel free to overwrite with your version if that's preferred. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] Introduce paged vector (PR #66430)

kuhar wrote: Also, don't use have to guard that with `#ifdef EXPECT_DEBUG_DEATH`? https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

kuhar wrote: @vgvassilev > I find the use of the macro I proposed cleaner though. Ideally, I think we could have an llvm-specific macro that combines the guard and the check (say `LLVM_EXPECT_DEATH`), so that it's less of a footgun. In any case, the failures should be resolved now, and we can

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

@@ -103,6 +103,12 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + [[nodiscard]] bool isMaterialized(size_t Index) const { +assert(Index < Size); +assert(Index / PageSize < PageToDataPtrs.siz

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

@@ -103,6 +103,12 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + [[nodiscard]] bool isMaterialized(size_t Index) const { kuhar wrote: Could you add a documentation comment above?

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

@@ -103,6 +103,14 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + /// @return true in case the element at index @a Index belongs to a page which + /// was already materialised. ku

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

@@ -180,6 +180,20 @@ TEST(PagedVectorTest, FillNonTrivialConstructor) { EXPECT_EQ(std::distance(V.materialized_begin(), V.materialized_end()), 10LL); } +// Test that isMaterialized returns true for all the elements +// of the page, not only the one that was accessed. +TEST(P

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

https://github.com/kuhar commented: The ADT change looks good to me, I'm not familiar with the clang code though. https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [Support] Deprecate system_endianness (PR #68279)

https://github.com/kuhar approved this pull request. nit: typos in the commit/PR message: bit --> big code lgtm https://github.com/llvm/llvm-project/pull/68279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,84 @@ +//===- llvm/unittest/ADT/PagedVectorTest.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,92 @@ +//===- llvm/unittest/ADT/PagedVectorTest.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

kuhar wrote: A few more questions @ktf: 1. Would it be possible to add a benchmark that compares this paged vector to `std::vector` and `llvm::SmallVector` for a few data types? Maybe `int`, `std::string`, `std::vector`. I would love to see what the performance characteristics are like. We hav

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,132 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] b9db89f - [ADT][NFCI] Do not use non-const lvalue-refs with enumerate in llvm/

Author: Jakub Kuderski Date: 2023-03-13T20:59:06-04:00 New Revision: b9db89fbcfdaece8656159a2a0f0a2f09cdd7db7 URL: https://github.com/llvm/llvm-project/commit/b9db89fbcfdaece8656159a2a0f0a2f09cdd7db7 DIFF: https://github.com/llvm/llvm-project/commit/b9db89fbcfdaece8656159a2a0f0a2f09cdd7db7.diff

r308041 - [Dominators] Update Clang's DominatorTree to use the new template argument

Author: kuhar Date: Fri Jul 14 11:26:21 2017 New Revision: 308041 URL: http://llvm.org/viewvc/llvm-project?rev=308041&view=rev Log: [Dominators] Update Clang's DominatorTree to use the new template argument Summary: This patch makes the Clang's DominatorTree use the new IsPostDom template argume

[clang-tools-extra] r301365 - [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

Author: kuhar Date: Tue Apr 25 17:38:39 2017 New Revision: 301365 URL: http://llvm.org/viewvc/llvm-project?rev=301365&view=rev Log: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds Summary: When running run-clang-tidy.py with -fix it tries to apply found replacements at

[clang-tools-extra] r301651 - [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls

Author: kuhar Date: Fri Apr 28 11:25:45 2017 New Revision: 301651 URL: http://llvm.org/viewvc/llvm-project?rev=301651&view=rev Log: [clang-tidy] modernize-use-emplace: remove unnecessary make_pair calls Summary: When there is a push_back with a call to make_pair, turn it into emplace_back and re

[clang-tools-extra] r301780 - [clang-tidy] Fix naming convention in modernize-use-emplace

Author: kuhar Date: Sun Apr 30 16:12:56 2017 New Revision: 301780 URL: http://llvm.org/viewvc/llvm-project?rev=301780&view=rev Log: [clang-tidy] Fix naming convention in modernize-use-emplace Summary: Conform to the llvm naming convention for local variables in modernize-use-emplace check. Revi

[clang-tools-extra] r302281 - [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

Author: kuhar Date: Fri May 5 15:35:30 2017 New Revision: 302281 URL: http://llvm.org/viewvc/llvm-project?rev=302281&view=rev Log: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce Summary: This patch fixes [[ https://bugs.llvm.org/show_bug.cgi?id=32896 | PR32896 ]]. T

r302287 - Add cxxStdInitializerListExpr AST matcher

Author: kuhar Date: Fri May 5 16:01:12 2017 New Revision: 302287 URL: http://llvm.org/viewvc/llvm-project?rev=302287&view=rev Log: Add cxxStdInitializerListExpr AST matcher Summary: This adds a new ASTMatcher for CXXStdInitializerListExprs that matches C++ initializer list expressions. The pri

[clang-tools-extra] r302317 - [clang-tidy] Use cxxStdInitializerListExpr in modernize-use-emplace

Author: kuhar Date: Fri May 5 18:00:37 2017 New Revision: 302317 URL: http://llvm.org/viewvc/llvm-project?rev=302317&view=rev Log: [clang-tidy] Use cxxStdInitializerListExpr in modernize-use-emplace Summary: Use the cxxStdInitializerListExp matcher from ASTMatchers.h instead of a local one. Re

[clang-tools-extra] r303139 - [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

Author: kuhar Date: Mon May 15 23:25:42 2017 New Revision: 303139 URL: http://llvm.org/viewvc/llvm-project?rev=303139&view=rev Log: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls Summary: This patch makes modernize-use-emplace remove unnecessary make_ calls from push_bac

[clang-tools-extra] r303140 - Revert "[clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls"

Author: kuhar Date: Tue May 16 00:07:40 2017 New Revision: 303140 URL: http://llvm.org/viewvc/llvm-project?rev=303140&view=rev Log: Revert "[clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls" This reverts commit r303139. The commit made docs build emit a warning. Modified:

[clang-tools-extra] r303145 - [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

Author: kuhar Date: Tue May 16 01:32:38 2017 New Revision: 303145 URL: http://llvm.org/viewvc/llvm-project?rev=303145&view=rev Log: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls Summary: This patch makes modernize-use-emplace remove unnecessary make_ calls from push_bac

Re: [PATCH] D12400: Fix store detection for return value in CGCall

kuhar updated this revision to Diff 34206. kuhar added a comment. Merge with the latest changes to CGCall.cpp Repository: rL LLVM http://reviews.llvm.org/D12400 Files: lib/CodeGen/CGCall.cpp test/CodeGen/arm_function_epilog.cpp Index: test/CodeGen/arm_function_epilog.cpp ===

r247003 - findDominatingStoreToReturn in CGCall.cpp didn't check if a candidate store

Author: kuhar Date: Tue Sep 8 05:36:42 2015 New Revision: 247003 URL: http://llvm.org/viewvc/llvm-project?rev=247003&view=rev Log: findDominatingStoreToReturn in CGCall.cpp didn't check if a candidate store instruction used the ReturnValue as pointer operand or value operand. This led to wrong co

Re: [PATCH] D12400: Fix store detection for return value in CGCall

This revision was automatically updated to reflect the committed changes. Closed by commit rL247003: findDominatingStoreToReturn in CGCall.cpp didn't check if a candidate store (authored by kuhar). Changed prior to commit: http://reviews.llvm.org/D12400?vs=34206&id=34207#toc Repository: rL L

[PATCH] D12400: Fix store detection for return value in CGCall

kuhar created this revision. kuhar added a subscriber: cfe-commits. kuhar set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. `findDominatingStoreToReturn` in CGCall.cpp didn't check if a candidate store instruction used the ReturnValue as p

Re: [PATCH] D12400: Fix store detection for return value in CGCall

kuhar added a comment. ping Repository: rL LLVM http://reviews.llvm.org/D12400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12400: Fix store detection for return value in CGCall

kuhar updated this revision to Diff 33919. kuhar added a comment. Some refactoring + comments added. Repository: rL LLVM http://reviews.llvm.org/D12400 Files: lib/CodeGen/CGCall.cpp test/CodeGen/arm_function_epilog.cpp Index: test/CodeGen/arm_function_epilog.cpp

Re: [PATCH] D12400: Fix store detection for return value in CGCall

kuhar marked 2 inline comments as done. kuhar added a comment. Repository: rL LLVM http://reviews.llvm.org/D12400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12400: Fix store detection for return value in CGCall

kuhar updated this revision to Diff 33921. Repository: rL LLVM http://reviews.llvm.org/D12400 Files: lib/CodeGen/CGCall.cpp test/CodeGen/arm_function_epilog.cpp Index: test/CodeGen/arm_function_epilog.cpp === --- /dev/null ++

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

@@ -878,6 +896,10 @@ void IEEEFloat::copySignificand(const IEEEFloat &rhs) { for the significand. If double or longer, this is a signalling NaN, which may not be ideal. If float, this is QNaN(0). */ void IEEEFloat::makeNaN(bool SNaN, bool Negative, const APInt *fill) {

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

@@ -68,6 +68,10 @@ enum class fltNonfiniteBehavior { // `fltNanEncoding` enum. We treat all NaNs as quiet, as the available // encodings do not distinguish between signalling and quiet NaN. NanOnly, + + // This behavior is present in Float6E3M2FN and Float6E2M3FN types.

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

@@ -1499,16 +1521,18 @@ static void tcSetLeastSignificantBits(APInt::WordType *dst, unsigned parts, /* Handle overflow. Sign is preserved. We either become infinity or the largest finite number. */ IEEEFloat::opStatus IEEEFloat::handleOverflow(roundingMode rounding_mode)

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

@@ -68,6 +68,10 @@ enum class fltNonfiniteBehavior { // `fltNanEncoding` enum. We treat all NaNs as quiet, as the available // encodings do not distinguish between signalling and quiet NaN. NanOnly, + + // This behavior is present in Float6E3M2FN and Float6E2M3FN types.

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/94735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

@@ -1462,6 +1472,16 @@ inline APFloat maximum(const APFloat &A, const APFloat &B) { return A.isNegative() ? B : A; return A < B ? B : A; } +LLVM_READONLY kuhar wrote: also here https://github.com/llvm/llvm-project/pull/93841 ___

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

@@ -1449,6 +1449,16 @@ inline APFloat minimum(const APFloat &A, const APFloat &B) { return A.isNegative() ? A : B; return B < A ? B : A; } +LLVM_READONLY kuhar wrote: Please add and an empty line before this function and document its semantics. https:/

[clang] [llvm] [APFloat] Add APFloat support for FP4 data type (PR #95392)

@@ -6907,6 +7028,42 @@ TEST(APFloatTest, ConvertE2M3FToE3M2F) { EXPECT_EQ(status, APFloat::opInexact); } +TEST(APFloatTest, ConvertDoubleToE2M1F) { + bool losesInfo; kuhar wrote: It's an output parameter in `.convert`, so shouldn't matter either way? http

[clang] [llvm] [AArch64] Add support for Qualcomm Oryon processor (PR #91022)

https://github.com/kuhar updated https://github.com/llvm/llvm-project/pull/91022 >From 8aebe46d7fdd15f02a9716718f53b03056ef0d19 Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Fri, 3 May 2024 22:01:58 + Subject: [PATCH 1/3] [AArch64] Add support for Qualcomm Oryon processor --- clang/test/Dr

[clang] [flang] [llvm] [mlir] [ADT] Deprecate DenseMap::getOrInsertDefault (PR #107040)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/107040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [lld] [llvm] Use StringRef::operator== instead of StringRef::equals (NFC) (PR #91864)

https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/91864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >