[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi planned changes to this revision. Budovi added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17868 + FormatStyle Style = getLLVMStyle(); + Style.AccessModifierOffset = 4; + Style.AllowShortEnumsOnASingleLine = false; Budovi wrote: >

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 320818. Budovi added a comment. Updated the tests after checking the issues were not caused by the patch and they are reported / fixed. Rebased the changes to the newest version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94661/new/ https://revi

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi planned changes to this revision. Budovi added a comment. In D94661#2537356 , @HazardyKnusperkeks wrote: > You need to supply a full diff (with context). > Please also add it to the release notes. Oh sorry, forgot about the context lines. Will try

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 321392. Budovi added a comment. Changes: - Added release notes - Changed the documentation (tried to make it more clear in response to the confusion about the added option) Hopefully there is a full context in the patch this time. CHANGES SINCE LAST ACTION

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class``, ``struct``, ``union``) Budovi wrote: > curdeius wrote: > > curdeius wrote: > > > The

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi planned changes to this revision. Budovi added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19056 +TEST_F(FormatTest, IndentAccessModifiers) { + FormatStyle Style = getLLVMStyle(); + Style.AllowShortEnumsOnASingleLine = false; curde

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 321724. Budovi added a comment. Changes: - Added a unit test with a different `IndentWidth` - Removed a unit test that contained a class nested in function; didn't add much IMHO - Added brief comments about potentially non-obvious behaviour to some tests CH

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 322645. Budovi added a comment. Changes: - Fixed comments Thanks @curdeius for pointing out the issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94661/new/ https://reviews.llvm.org/D94661 Files: clang/docs/ClangFormatStyleOptions.rst clan

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added a comment. In D94661#2553843 , @curdeius wrote: > LGTM. But let other folks a few days to chime in. Especially > @mydeveloperday's input would be valuable here as he already attempted to > implement this. Sure, no problem. Thanks for your i

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi created this revision. Budovi added reviewers: MyDeveloperDay, rsmith. Budovi added a project: clang-format. Budovi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for coding styles that make a separate indentation level

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added a comment. In D94661#2497744 , @HazardyKnusperkeks wrote: > I would add a test where you have a member before the first access modifier. The very first unit test has no modifiers, the third one has a member before a modifier in the nested c

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class``, ``struct``, ``union``) curdeius wrote: > curdeius wrote: > > The name `IndentAccessM