[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:981 + + // Metadata needs to be padded out to an even word size. + size_t MetadataSize = Metadata.size(); scott.linder wrote: > stephenpeckham wrote: > > There's no requirement to pad th

[PATCH] D153600: Implement -frecord-command-line for XCOFF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbd0d123d3aa: Implement -frecord-command-line for XCOFF (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. Sorry for the late response @jansvoboda11, when `lookupModuleFile` is called, the file `build/tools/clang/test/Index/Core/Output/index-with-module.m.tmp.mcp/A03A61VI43WA/ModA-21USRMHJNU3PG.pcm` doesn't exist. So it seems there's some issue with the creation of the fil

[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

Jake-Egan created this revision. Herald added a project: All. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159213 Files: clang/unittests/Interpreter/CodeComple

[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86337beca2e6: [AIX][ClangRepl] Disable new tests on AIX (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

Jake-Egan added a comment. Hi, this new test fails on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

Jake-Egan added a comment. Thanks for addressing this. Unfortunately the test is still failing after the fix and a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/6170/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

Jake-Egan accepted this revision. Jake-Egan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145600/new/ https://reviews.llvm.org/D145600 _

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan created this revision. Herald added subscribers: kbarton, hiraditya, nemanjai. Herald added a project: All. Jake-Egan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Jake-Egan added a comment. Hi, this fails on AIX. It looks like it still produces the `/tmp/lit-tmp-*/[ab]-*.json` format. Can you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/7429/steps/6/logs/FAIL__Clang__ftime-trace_cpp Repository: rG LLVM Github Monorepo CHANG

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. Hi, there's a test failure on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/8005/steps/6/logs/FAIL__Clang__index-with-module_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/

[PATCH] D117587: [ifs] Use a tmp file instead of -

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117587 Files: clang/test/InterfaceStubs/object.c Index: clang/test/InterfaceStu

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

Jake-Egan updated this revision to Diff 401254. Jake-Egan marked an inline comment as done. Jake-Egan added a comment. Removed the unncessary pipe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 Files:

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

Jake-Egan added inline comments. Comment at: clang/test/InterfaceStubs/object.c:2 // RUN: %clang_cc1 -fvisibility default -o - -emit-interface-stubs %s | FileCheck -check-prefix=CHECK-TAPI %s -// RUN: %clang -fvisibility=default -c -o - %s | llvm-nm - 2>&1 | FileCheck -check-p

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24fe96f469b: [ifs] Use a tmp file instead of "-" (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.or

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118152 Files: clang/test/ClangScanDeps/headerwithdirname.cpp clang/test/ClangSc

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/headerwithdirname.cpp:16 -// CHECK: headerwithdirname_input.o +// CHECK: headerwithdirname_input{{.*}}{{.o|.s}} // CHECK-NEXT: headerwithdirname_input.cpp jansvoboda11 wrote: > Why is `{{.*}

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

Jake-Egan updated this revision to Diff 403761. Jake-Egan added a comment. Updated patch to use a more accurate check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118152/new/ https://reviews.llvm.org/D118152 Files: clang/test/ClangScanDeps/hea

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

Jake-Egan updated this revision to Diff 403763. Jake-Egan added a comment. Fixed diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118152/new/ https://reviews.llvm.org/D118152 Files: clang/test/ClangScanDeps/headerwithdirname.cpp clang/test/

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

Jake-Egan accepted this revision. Jake-Egan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118477/new/ https://reviews.llvm.org/D118477

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f4f745668ec: [clang][deps] Adapt test to be compatible when the assembler is called by… (authored by Jake-Egan). Repository: rG LLVM Github Monor

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c shchenz wrote: > Jake-Egan wrote: > > shchenz wrote: > > > Do we still need this?

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Jake-Egan wrote: > > > shchenz wrote: > > >

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf52caf58b3: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support (authored by Jake-Egan). Repository: rG LLVM Github Mon

[PATCH] D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117315 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Analysis/cfref_PR2519.

[PATCH] D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f0977519d12: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 395724. Jake-Egan added a comment. Added `-fintegrated-as` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/anonymous-fields/tes

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir shchenz wrote: > Jake-Egan wrote: > > jsji wrote: > > > ther

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 395904. Jake-Egan added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/codegen-body/test.c clang/test/ClangSc

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c shchenz wrote: > Do we still need thi

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan created this revision. Herald added subscribers: ormris, pengfei, arphaman, steven_wu, hiraditya, emaste. Jake-Egan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan updated this revision to Diff 377306. Jake-Egan added a comment. Updated to preserve blank lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69/new/ https://reviews.llvm.org/D69 Files: clang/test/ClangScanDeps/modules-full-b

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan added a comment. In D69#3047761 , @shchenz wrote: > Thanks for working on this. > > Could you please help to rerun the affected cases after applying D97184 > ? That patch is approved and I will deliver > it

[PATCH] D111336: [AIX] Disable tests failing due to missing DWARF sections

Jake-Egan created this revision. Herald added a subscriber: arphaman. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111336 Files: clang/test/M

[PATCH] D111336: [AIX] Disable tests failing due to missing DWARF sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG8037481cb2d7: [AIX] Disable tests failing due to missing DWARF sections (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111336/new/ h

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan abandoned this revision. Jake-Egan added a comment. Abandoning this patch because D97184 is already committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69/new/ https://reviews.llvm.org/D69

[PATCH] D112390: [AIX][ZOS] Disable module tests due to lack of Objective-C support

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112390 Files: clang/test/Modules/ModuleDebugInfo.cpp clang/test/Modules/ModuleD

[PATCH] D112390: [AIX][ZOS] Disable module tests due to lack of Objective-C support

Jake-Egan updated this revision to Diff 381814. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add llvm/test/DebugInfo/X86/objc_direct.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D112390: [AIX][ZOS] Disable tests due to lack of Objective-C support

Jake-Egan updated this revision to Diff 381979. Jake-Egan added a comment. Fixed objc_direct.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112390/new/ https://reviews.llvm.org/D112390 Files: clang/test/Modules/ModuleDebugInfo.cpp clang/test

[PATCH] D108917: Define __powerpc and __PPC macros

Jake-Egan created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108917 Files: clang/lib/Bas

[PATCH] D109060: Disable LIT tests on AIX due to lack of Objective-C support

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109060 Files: clang/test/CodeGenObjC/2007-05-02-Strong.m clang/test/CodeGenObjC

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

Jake-Egan added a comment. In D109060#2976745 , @jsji wrote: > For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add > lit.local.cfg and add the unsupport there, no adding to every files in the > folder? These tests are a subset of th

[PATCH] D108917: [PowerPC] Define __powerpc and __PPC macros

Jake-Egan updated this revision to Diff 369932. Jake-Egan added a comment. Define for AIX only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://reviews.llvm.org/D108917 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Prepr

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

Jake-Egan updated this revision to Diff 369992. Jake-Egan added a comment. Add negative test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://reviews.llvm.org/D108917 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Preproce

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG37f23ea97fde: [AIX][PowerPC] Define __powerpc and __PPC macros (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://re

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

Jake-Egan updated this revision to Diff 371137. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Added lit.local.cfg and unsupported z/OS as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.ll

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan updated this revision to Diff 371165. Jake-Egan added a comment. Fixed ExtDebugInfo.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://reviews.llvm.org/D109060 Files: clang/test/CodeGenObjC/lit.local.cfg clang/test

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaratio

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109541 Files: clang/test/Modules/ExtDebugInfo.cpp Index: clang/test/Modules/Ext

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

Jake-Egan updated this revision to Diff 371908. Jake-Egan added a comment. Added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109541/new/ https://reviews.llvm.org/D109541 Files: clang/test/Modules/ExtDebugInfo.cpp Index: clang/test

<    1   2