[PATCH] D122519: [AIX] XFAIL test for lack of visibility support

Jake-Egan created this revision. Herald added a project: All. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122519 Files: clang/test/OpenMP/target_update_messag

[PATCH] D122519: [AIX] XFAIL test for lack of visibility support

Jake-Egan updated this revision to Diff 418369. Jake-Egan added a comment. Updated the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/ https://reviews.llvm.org/D122519 Files: clang/test/OpenMP/target_update_messages.cpp Inde

[PATCH] D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5a9b5cc1265: [NFC][tests][AIX] XFAIL test for lack of visibility support (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

Jake-Egan added a comment. Hi, this new test is failing on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/2544/steps/6/logs/FAIL__Clang__objc_property_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130581/new

[PATCH] D130689: [LLVM] Update C++ standard to 17

Jake-Egan added a comment. There is a failure on the AIX bot also: 152.827 [4302/10/270] Linking CXX executable bin/llvm-tblgen FAILED: bin/llvm-tblgen : && /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r -mcmodel=large -fPIC -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b52e9bac207: [AIX] Define __LONGDOUBLE64 macro (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105477/new/ https://reviews.llvm.org/

[PATCH] D121709: [NFC][AIX] Disable precompiled module file test on AIX

Jake-Egan created this revision. Herald added a project: All. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121709 Files: clang/test/ClangScanDeps/modules-no-un

[PATCH] D121709: [NFC][AIX] Disable precompiled module file test on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1873d395d57: [NFC][AIX] Disable precompiled module file test on AIX (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121709/new/ http

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

Jake-Egan added a comment. Hi, unfortunately there's a build failure on AIX: https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://revi

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

Jake-Egan added a comment. Hi, we also have a failure on AIX with test-suite `call to undeclared library function '%0' with type %1; ISO C99 and later` https://lab.llvm.org/buildbot/#/builders/214/builds/825/steps/9/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

Jake-Egan added a comment. @aaron.ballman Here are all the errors. Thanks! MultiSource/Applications/d/write_ctables.c:600:6: error: call to undeclared library function 'strncasecmp' with type 'int (const char *, const char *, unsigned long)'; ISO C99 and later do not support implicit function

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Jake-Egan added a comment. Hi, this broke a test on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/903/steps/6/logs/FAIL__Clang__pch-with-module_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Jake-Egan added a comment. Thanks @sammccall, the test is passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250 ___ cfe-commits mailing list cfe-commits@

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

Jake-Egan added a comment. 4 of the tests fail on AIX also: https://lab.llvm.org/buildbot/#/builders/214/builds/1207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123273/new/ https://reviews.llvm.org/D123273 __

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

Jake-Egan added a comment. Hi, this patch causes a test failure on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/1221/steps/6/logs/FAIL__Clang__noinline_cu Could you please make a fix or revert if it takes too long? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan created this revision. Jake-Egan added reviewers: cebowleratibm, jasonliu, sfertile, daltenty, DiggerLin, hubert.reinterpretcast. Herald added subscribers: jeroen.dobbelaere, nemanjai. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribe

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan added a comment. In D102724#2768663 , @stevewan wrote: > Might be a dumb question, but I see this is a revert to rGb116ded > , do we > also want to revert the changes added t

[PATCH] D102807: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan created this revision. Herald added a subscriber: jeroen.dobbelaere. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit b116ded57da3530e661f871f4191c59cd9e091cd

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan updated this revision to Diff 346560. Jake-Egan added a comment. Added the changes jasonliu asked for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 Files: clang/lib/Driver/ToolChains/Clang.

[PATCH] D102807: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan abandoned this revision. Jake-Egan added a comment. Duplicate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102807/new/ https://reviews.llvm.org/D102807 ___ cfe-commits mailing list cfe-commit

[PATCH] D103587: Add AIX predefined macros

Jake-Egan created this revision. Herald added subscribers: jfb, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103587 Files: clang/lib/Basic/T

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45a738363ee3: Increase expected line number for ExtDebugInfo.cpp (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan updated this revision to Diff 372946. Jake-Egan added a comment. Revert last ExtDebugInfo.cpp change because https://reviews.llvm.org/rG45a738363ee39754a0e93d9f779bda2cad83fa18 has been committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan updated this revision to Diff 372984. Jake-Egan added a comment. Added missing tests: clang/test/Modules/ModuleDebugInfoDwoId.cpp clang/test/PCH/externally-retained.m clang/test/PCH/pending-ids.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

This revision was automatically updated to reflect the committed changes. Closed by commit rG22f01cd4fc5d: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349557. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Removed __THW_PPC__ and moved tests to init-ppc.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.ll

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349564. Jake-Egan marked an inline comment as done. Jake-Egan added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files: clang/lib/Bas

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349638. Jake-Egan added a comment. Set macros for C11 and higher. Add negative test for pre C11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files: clang/lib/

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349854. Jake-Egan marked 3 inline comments as done. Jake-Egan added a comment. Use LangStandard::isC11() and one C99 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D1

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349855. Jake-Egan added a comment. Use LangStandard::isC11() and one C99 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files: clang/lib/Basic/Targets/OSTa

[PATCH] D103587: [AIX] Transfer __TOS_AIX__ predefined macro

Jake-Egan updated this revision to Diff 349913. Jake-Egan added a comment. Use this patch to target only __TOS_AIX__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files: clang/lib/Basic/Targets/OSTar

[PATCH] D103707: Add STDC macros

Jake-Egan created this revision. Herald added subscribers: jfb, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103707 Files: clang/lib/Basic/T

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

Jake-Egan updated this revision to Diff 350392. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Prune positive tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103707/new/ https://reviews.llvm.org/D103707 Files: cla

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

Jake-Egan updated this revision to Diff 350400. Jake-Egan added a comment. Add C17 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103707/new/ https://reviews.llvm.org/D103707 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/Preproces

[PATCH] D103707: [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros

Jake-Egan updated this revision to Diff 350406. Jake-Egan added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103707/new/ https://reviews.llvm.org/D103707 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/Preproc

[PATCH] D107241: Define __THW_BIG_ENDIAN__ macro

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107241 Files: clang/lib/Basic/Target

[PATCH] D107242: Define __HOS_AIX__ macro

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107242 Files: clang/lib/Basic/Target

[PATCH] D107243: Define __THW_PPC__ macro

Jake-Egan created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107243 Files: clang/lib/Bas

[PATCH] D107244: Define _ARCH_PPC64 macro for 32-bit

Jake-Egan created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107244 Files: clang/lib/Bas

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

Jake-Egan updated this revision to Diff 364330. Jake-Egan added a comment. Add comment. clang-format suggests a second indent, but I think this is correct because the comment is addressing the else clause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

Jake-Egan updated this revision to Diff 364342. Jake-Egan added a comment. Merge else and if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Preproce

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

Jake-Egan updated this revision to Diff 364685. Jake-Egan added a comment. Only define if AIX is the target and host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D107242 Files: clang/lib/Basic/Targets/PPC.c

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

Jake-Egan updated this revision to Diff 364766. Jake-Egan added a comment. Updated the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Prepro

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

Jake-Egan updated this revision to Diff 364779. Jake-Egan added a comment. Use a temp rather than a local var. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D107242 Files: clang/lib/Basic/Targets/PPC.cpp cl

[PATCH] D107241: [AIX] Define __THW_BIG_ENDIAN__ macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG420e1d4cf45d: [AIX] Define __THW_BIG_ENDIAN__ macro (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107241/new/ https://reviews.llvm.

[PATCH] D107243: [AIX] Define __THW_PPC__ macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3189dd205a58: [AIX] Define __THW_PPC__ macro (authored by Jake-Egan). Changed prior to commit: https://reviews.llvm.org/D107243?vs=363354&id=36478

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG869d07ee88a4: [AIX] Define __HOS_AIX__ macro (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D10

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

This revision was automatically updated to reflect the committed changes. Closed by commit rG41bcfe81742e: [AIX] Define _ARCH_PPC64 macro for 32-bit (authored by Jake-Egan). Changed prior to commit: https://reviews.llvm.org/D107244?vs=364766&id=364793#toc Repository: rG LLVM Github Monorepo

[PATCH] D107825: Define __HOS_AIX__ only for AIX target

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107825 Files: clang/lib/Basic/Target

[PATCH] D107825: [AIX] Define __HOS_AIX__ macro only for AIX target

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b39fa3e2815: [AIX] Define __HOS_AIX__ macro only for AIX target (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107825/new/ https://

[PATCH] D105185: Add _AIX73 macro

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105185 Files: clang/lib/Basic/Target

[PATCH] D105185: [AIX] Add _AIX73 version macro

Jake-Egan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); xgupta wrote: > Seems this line need formatting? I originally had it matching the format of th

[PATCH] D105185: [AIX] Add _AIX73 version macro

Jake-Egan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); xgupta wrote: > Jake-Egan wrote: > > xgupta wrote: > > > Seems this line need formatting? > >

[PATCH] D105185: [AIX] Add _AIX73 version macro

Jake-Egan updated this revision to Diff 355613. Jake-Egan added a comment. Fixed formatting to be consistent with the other macro definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105185/new/ https://reviews.llvm.org/D105185 Files: clan

[PATCH] D105477: Define __LONGDOUBLE64 macro

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105477 Files: clang/lib/Basic/Target

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

Jake-Egan updated this revision to Diff 357399. Jake-Egan added a comment. Add control by -mlong-double-64 option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105477/new/ https://reviews.llvm.org/D105477 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D112390: [AIX][ZOS] Disable tests due to lack of Objective-C support

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ff1bcab970a: [AIX][ZOS] Disable tests due to lack of Objective-C support (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112390/new/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan created this revision. Herald added subscribers: ormris, lxfind, pengfei, arphaman, steven_wu, hiraditya. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384220. Jake-Egan added a comment. Fix llvm/test/DebugInfo/omit-empty.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/anonymous-fie

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384521. Jake-Egan added a comment. Updated patch to XFAIL only on 64-bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/anonymous-fie

[PATCH] D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113428 Files: clang/test/Sema/wchar.c Index: clang/test/Sema/wchar.c ==

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 385830. Jake-Egan added a comment. Add `LLVM :: DebugInfo/attr-btf_type_tag.ll` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/anonymo

[PATCH] D113614: Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

Jake-Egan accepted this revision. Jake-Egan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113614/new/ https://reviews.llvm.org/D113614 _

[PATCH] D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

This revision was automatically updated to reflect the committed changes. Closed by commit rG9303c7da3967: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. In D113049#3140160 , @jsji wrote: > Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? If 64-bit XCOFF object files will be supported in the future, I think it makes more sense to use `XFAIL` because these te

[PATCH] D114381: [AIX] Disable unsupported offloading gpu tests

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114381 Files: clang/test/Driver/clang-offload-bundler-asserts-on.c clang/test/D

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389196. Jake-Egan added a comment. Thanks for the review. I updated the patch to use lit.cfg.py to filter tests that use obj options. For tests that don't use the option or has an individual folder, I changed them to UNSUPPORTED instead of XFAIL. Reposit

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir jsji wrote: > there is no `fmodule-format=obj` here, why are we failing here? > They have the same erro

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389849. Jake-Egan added a comment. Removed some tests already disabled by D114481 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D11304

[PATCH] D114381: [AIX] Disable unsupported offloading gpu tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG0796869e4e1e: [AIX] Disable unsupported offloading gpu tests (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114381/new/ https://revi

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

Jake-Egan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114484/new/ https://reviews.llvm.org/D114484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. Hi, this test is failing on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/5242/steps/6/logs/FAIL__Clang__pr59765-modules-global-ctor-dtor_cppm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. In D140867#4038388 , @ChuanqiXu wrote: > In D140867#4036239 , @Jake-Egan > wrote: > >> Hi, this test is failing on AIX, could you take a look please? >> https://lab.llvm.org/buildbot/#

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. > Would you like to take a double look? Yes, it still fails on the bot and on my local machine. I've added an XFAIL to the test for now just to get the AIX bot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140867/

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. In D140867#4042405 , @ChuanqiXu wrote: > In D140867#4042351 , @Jake-Egan > wrote: > >>> Would you like to take a double look? >> >> Yes, it still fails on the bot and on my local machin

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

Jake-Egan added a comment. Getting a build failure on AIX, could you take a look please? /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/lib/Driver/Driver.cpp:5715:37: error: lambda capture 'C' is not used [-Werror,-Wunused-lambda-capture] auto IsHIPRDCInCompi

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

Jake-Egan added a comment. Hi, this new test fails on AIX. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142484/new/ htt

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

Jake-Egan added a comment. In D142484#4079909 , @jhuber6 wrote: > In D142484#4079869 , @Jake-Egan > wrote: > >> Hi, this new test fails on AIX. Could you take a look? >> https://lab.llvm.org/buildbot/#/builders/2

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

Jake-Egan added a comment. Hi, this change causes a failure on AIX. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/5502/steps/6/logs/FAIL__Clang__annotate-comments-objc_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1425

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

Jake-Egan added a comment. Thank you for looking into the failure. Fortunately the test is passing on the AIX bot now and locally for me - it looks like a clean build fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://revi

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

Jake-Egan added a comment. Hi, this new test fails on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm Could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https:

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

Jake-Egan added a comment. In D137058#4057424 , @ChuanqiXu wrote: > In D137058#4056647 , @Jake-Egan > wrote: > >> Hi, this new test fails on AIX >> https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

Jake-Egan added a comment. Thanks for taking a look. I agree someone on AIX should investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 ___ cfe-commits

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

Jake-Egan added a comment. Hi, it seems on AIX the target and arch options are ignored, so we don't get the expected output for this test. Any ideas about the course of action we should take? https://lab.llvm.org/buildbot/#/builders/214/builds/1785/steps/6/logs/FAIL__Clang__compilation_database_

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

Jake-Egan added a comment. Hi, these tests fail on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/1489 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

Jake-Egan added a comment. @arphaman Thanks for the quick action. The tests pass on a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/1493, so that's probably why there was trouble reproducing. I think we could revert 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

Jake-Egan added a comment. Hi, this caused `arm-float-abi-lto.c` to fail on AIX. The failure went away for a few builds, then came back. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/1625/steps/6/logs/FAIL__Clang__arm-float-abi-lto_c Repository: rG LLVM Github Mo

[PATCH] D125847: LTO: Add option to initialize with opaque/non-opaque pointer types

Jake-Egan added a comment. In D125847#3554706 , @MatzeB wrote: > In D125847#3554569 , @Jake-Egan > wrote: > >> Hi, this caused `arm-float-abi-lto.c` to fail on AIX. The failure went away >> for a few builds, the

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. @jansvoboda11 Thanks for taking care of the other tests. I'm not sure how this could be reproduced not on AIX. I'll have to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/new/ https://reviews.llvm.org/

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. @jansvoboda11 Actually, we could give you access to an AIX machine to debug this. Would that work for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/new/ https://reviews.llvm.org/D151938 _

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536795. Jake-Egan added a comment. Thanks for the review @scott.linder. I applied the changes you requested with some differences. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driv

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan marked 6 inline comments as done. Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1022 + if (PaddingSize) { +assert(PaddedSize - Index == WordSize); +std::array LastWord = {0}; I changed the assert that you requested

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:986 + + // If there's no metadata, the length is 0. + if (MetadataSize == 0) { Handled the 0 length case here. CHANGES SINCE LAST ACTION h

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536890. Jake-Egan added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeGen/AsmPrinter.h llvm/include/ll

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536920. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Thanks for the review @stephenpeckham, I updated the patch with the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llv

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537156. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Updated to use both a newline and null byte to separate command lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Fi

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537160. Jake-Egan added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeGen/AsmPrinter.h llvm/include/ll

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537377. Jake-Egan added a comment. Rerun CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeG

[PATCH] D143241: [Clang] Reset FP options before function instantiations

Jake-Egan added a comment. Hi, the following assertion is getting tripped on AIX: Assertion failed: *FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && "Expected a default pragma float_control value", file /scratch/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/c

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537572. Jake-Egan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/ll

  1   2   >