[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91373/new/ https://reviews.llvm.org/D91373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman created this revision. jacobdweightman added a reviewer: ABataev. jacobdweightman added a project: OpenMP. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jacobdweightman requested review of this revision. Herald added a reviewer: jdoerfert. H

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17141 + Visit(ACO->getTrueExpr()->IgnoreParenImpCasts()) || + Visit(ACO->getFalseExpr()->IgnoreParenImpCasts()); + } It looks like this short-circuits and the fa

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91373/new/ https://reviews.llvm.org/D91373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16869 +// Allow results of method calls to be mapped. +if (isa(ME->getMemberDecl())) { + RelevantExpr = ME; ABataev wrote: > I don't think it should always return `true`

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman updated this revision to Diff 309056. jacobdweightman added a comment. I separated the handling of `ConditionalOperator`s and `BinaryConditionalOperator`s in order to eliminate handling of `OpaqueValueExpression`s in general, and asserted that the OVE's `SourceExpr` is not null.