[PATCH] D48829: [NEON] Fix support for vrndi_f32(), vrndiq_f32() and vrndns_f32() intrinsics

kosarev added a comment. Ping. https://reviews.llvm.org/D48829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40176: [CodeGen] Collect information about sizes of accesses and access types for TBAA

kosarev updated this revision to Diff 124084. kosarev added a comment. Rebased. https://reviews.llvm.org/D40176 Files: lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/CodeGenTBAA.cpp lib/CodeGen/CodeGenTBAA.h Index: lib/CodeGen/CodeGenTBA

[PATCH] D40176: [CodeGen] Collect information about sizes of accesses and access types for TBAA

This revision was automatically updated to reflect the committed changes. Closed by commit rL319012: [CodeGen] Collect information about sizes of accesses and access types for TBAA (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D40176?vs=124084&id=124332#toc Repositor

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev updated this revision to Diff 124726. kosarev added a comment. - Added tests with nested unions. - Rebased. https://reviews.llvm.org/D39455 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/CodeGenTBAA.cpp lib/CodeGen/CodeGenTBAA.h test/CodeGen/tbaa-union.c

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev added a comment. Thanks Hal. Will commit it tomorrow. https://reviews.llvm.org/D39455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

This revision was automatically updated to reflect the committed changes. Closed by commit rL319413: [CodeGen] Add initial support for union members in TBAA (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39455?vs=124726&id=124883#toc Repository: rL LLVM https://re

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev added a comment. Responded here: https://bugs.llvm.org/show_bug.cgi?id=26603 Repository: rL LLVM https://reviews.llvm.org/D39455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev created this revision. Herald added subscribers: mattd, gchakrabarti, pmatos, asb, asavonic, wenlei, kerbowa, pengfei, Jim, asbirlea, thopre, rupprecht, george.burgess.iv, kbarton, hiraditya, jgravelle-google, sbc100, jvesely, nemanjai, dylanmckay, dschuff, jholewinski. Herald added a re

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. A work in progress. Contains changes that we likely want to see addressed separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. In D125604#3514983 , @jhenderson wrote: > Are the TODO cases where the test fails if changing them? Yes, this and where the fix is not perfectly obvious. Comment at: llvm/test/FileCheck/missspelled-directive.

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 429997. kosarev added a comment. Herald added subscribers: ThomasRaoux, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, mravishankar, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb,

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 430322. kosarev added a comment. Herald added a reviewer: bollu. Add Polly fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604 Files: clang/test/CodeGen/cmse-cle

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added subscribers: chill, momchil.velikov, az, alex-t, keith.walker.arm, plotfi, aivchenk, zer0, awanpand, levivic, zlei. kosarev added a comment. Tagging more people in hope to add visibility. Comment at: clang/test/CodeGen/cmse-clear-return.c:235 // CHECK-BE-NOPT-NE

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 430392. kosarev added a comment. Herald added a project: Flang. Added Flang fixes and rebased. Thanks Simon for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.l

[PATCH] D126191: [Clang][CodeGen] Fix the cmse-clear-return.c test.

kosarev created this revision. Herald added a project: All. kosarev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Caught with D125604 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D126191: [Clang][CodeGen] Fix the cmse-clear-return.c test.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe4eaf10eef7: [Clang][CodeGen] Fix the cmse-clear-return.c test. (authored by kosarev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126191/new/ https://re

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 431979. kosarev added a comment. Rebased on top of fixes for non-trivial cases. Going to submit this tomorrow, if no objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.or

[PATCH] D125604: [FileCheck] Catch missspelled directives.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad1d60c3befd: [FileCheck] Catch missspelled directives. (authored by kosarev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. Committing this revealed some more failures, fixed in rG8894c05b0d351f998b1836542ba791247394bd12 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/n

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

kosarev added a comment. @Prabhuk This reproduces with my setup as well. Did you try building with `-DBUILD_SHARED_LIBS=ON`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 __

[PATCH] D44616: Update existed CodeGen TBAA tests

kosarev added a comment. Looks fine to me. Repository: rC Clang https://reviews.llvm.org/D44616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

kosarev created this revision. kosarev added reviewers: az, sbaranga, t.p.northover. kosarev added a project: clang. Herald added subscribers: javed.absar, rengolin. https://reviews.llvm.org/D45483 Files: include/clang/Basic/arm_neon.td test/CodeGen/aarch64-neon-2velem.c Index: test/CodeGen

[PATCH] D45515: [NEON] Support vrndns_f32 intrinsic

kosarev created this revision. kosarev added reviewers: t.p.northover, rengolin, SjoerdMeijer. kosarev added a project: clang. Herald added a subscriber: javed.absar. https://reviews.llvm.org/D45515 Files: include/clang/Basic/arm_neon.td lib/CodeGen/CGBuiltin.cpp test/CodeGen/arm-neon-direc

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC329814: [NEON] Support vfma_n and vfms_n intrinsics (authored by kosarev, committed by ). Repository: rL LLVM https://reviews.llvm.org/D45483 Files: include/clang/Basic/arm_neon.td test/CodeGen/aa

[PATCH] D45483: [NEON] Support vfma_n and vfms_n intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL329814: [NEON] Support vfma_n and vfms_n intrinsics (authored by kosarev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45483?vs=141828&id=1

[PATCH] D39138: [CodeGen] Generate TBAA info for 'this' pointers

kosarev abandoned this revision. kosarev added a comment. OK, thanks. Repository: rL LLVM https://reviews.llvm.org/D39138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev added a comment. I suspect this is supposed to be in this diff: In https://reviews.llvm.org/D38796#906887, @rjmccall wrote: > I think probably the best solution is to track may-alias-ness explicitly in > the TBAAAccessInfo instead of relying in the frontend on being able to > distingui

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev added a comment. Yes, I don't like it too when it comes to comparing pointers to metadata nodes in an attempt to figure out what kind of access we are dealing with. What concerns me is that there may be other kinds of TBAA descriptors that are neither ordinary nor may-alias ones. For ex

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

kosarev updated this revision to Diff 120428. kosarev added a comment. - Referencee's renamed to pointee's. - EmitLoadOfReference() and EmitLoadOfReferenceLValue() reworked to take reference lvalues. https://reviews.llvm.org/D39177 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp l

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

kosarev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1041 +else + BaseLV = CGF.EmitLoadOfReferenceLValue(BaseLV); BaseTy = BaseTy->getPointeeType(); Oh-oh, it looks I do something not functionally equivalent here. Sorry, will

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

kosarev updated this revision to Diff 120654. kosarev added a comment. - Fixed the type of the reference lvalue in loadToBegin(). John, can you please review the fix? Thanks. https://reviews.llvm.org/D39177 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGOpenMPRuntim

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev updated this revision to Diff 120675. kosarev added a comment. Reworked to distinct may-alias accesses from ordinary ones with an explicit 'kind' field. https://reviews.llvm.org/D39008 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjCRuntime.cpp lib/CodeGen/CGOpenMPRuntime.cpp l

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

This revision was automatically updated to reflect the committed changes. Closed by commit rL316896: [CodeGen] Generate TBAA info for reference loads (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39177?vs=120654&id=120800#toc Repository: rL LLVM https://reviews.l

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev updated this revision to Diff 120828. kosarev added a comment. - Fixed comparing and hashing of TBAA access descriptors. - Rebased on top of https://reviews.llvm.org/D39177. Thanks John! https://reviews.llvm.org/D39008 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjCRuntime.cpp l

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

This revision was automatically updated to reflect the committed changes. Closed by commit rL316988: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39008?vs=120828&id=120958#toc Repository: rL LLVM https

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev created this revision. kosarev added a project: clang. The basic idea behind this patch is that since in strict aliasing mode all accesses to union members require their outermost enclosing union objects to be specified explicitly, then for a couple given accesses to union members of the

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev added a comment. Colleagues, please let me know if there are any concerns about this patch. It was specifically designed to not cause any substantial changes, but I may be missing something important. Thanks. Repository: rL LLVM https://reviews.llvm.org/D39455 ___

[PATCH] D39953: [CodeGen] Do not lookup for cached TBAA metadata nodes twice

kosarev created this revision. kosarev added a project: clang. Repository: rL LLVM https://reviews.llvm.org/D39953 Files: lib/CodeGen/CodeGenTBAA.cpp Index: lib/CodeGen/CodeGenTBAA.cpp === --- lib/CodeGen/CodeGenTBAA.cpp +++ li

[PATCH] D39955: [Driver] Add command-line flags for the new TBAA metadata format

kosarev created this revision. kosarev added a project: clang. This patch starts a series of changes to add support for the new TBAA metadata format proposed in this llvm-dev thread: http://lists.llvm.org/pipermail/llvm-dev/2017-November/118748.html Repository: rL LLVM https://reviews.llvm.

[PATCH] D39955: [Driver] Add command-line flags for the new TBAA metadata format

kosarev added a comment. Adding a (temporary) flag for the new format would help with updating tests that depend on the shape of TBAA metadata. There are lots of them and I guess some change frequently so we may want to address this in a few patches. That would also reduce the pressure on those

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

kosarev added a comment. Thanks John. Hal, do you see any problems with this patch? Repository: rL LLVM https://reviews.llvm.org/D39455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D39953: [CodeGen] Do not lookup for cached TBAA metadata nodes twice

kosarev added a comment. Indeed, DenseMap invalidates iterators on insertion. But then even the "technically correct" part of these changes make things more fragile while my original concern was reliability and not performance. I particularly don't like the repeating cache assignments. What if

[PATCH] D39955: [Driver] Add a cc1 flag for the new TBAA metadata format

kosarev updated this revision to Diff 123320. kosarev retitled this revision from "[Driver] Add command-line flags for the new TBAA metadata format" to "[Driver] Add a cc1 flag for the new TBAA metadata format". kosarev added a comment. Removed the clang command-line flag for the new format. h

[PATCH] D40176: [CodeGen] Collect information about sizes of accesses and access types for TBAA

kosarev created this revision. kosarev added a project: clang. The information about access and type sizes is necessary for producing TBAA metadata in the new size-aware format. With this patch, https://reviews.llvm.org/D39955 and https://reviews.llvm.org/D39956 in place we should be able to ch

[PATCH] D39955: [Driver] Add a cc1 flag for the new TBAA metadata format

This revision was automatically updated to reflect the committed changes. Closed by commit rL318644: [Driver] Add a cc1 flag for the new TBAA metadata format (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39955?vs=123320&id=123555#toc Repository: rL LLVM https://r

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

kosarev updated this revision to Diff 123563. kosarev retitled this revision from "[CodeGen] Do not lookup for cached TBAA metadata nodes twice" to "[CodeGen] Generate TBAA type descriptors in a more reliable manner". kosarev edited the summary of this revision. kosarev added a comment. Reworked

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

kosarev added a comment. In https://reviews.llvm.org/D39953#929144, @rjmccall wrote: > I think there might be some cases that intentionally don't cache their normal > result, though, so it might be harder than you think. My understanding is that conceptually every canonical type has a single

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

This revision was automatically updated to reflect the committed changes. Closed by commit rL318752: [CodeGen] Generate TBAA type descriptors in a more reliable manner (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39953?vs=123563&id=123754#toc Repository: rL LLVM

[PATCH] D40176: [CodeGen] Collect information about sizes of accesses and access types for TBAA

kosarev added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2426 llvm::StoreInst *Store = Builder.CreateStore(VTableAddressPoint, VTableField); - CGM.DecorateInstructionWithTBAA(Store, CGM.getTBAAVTablePtrAccessInfo()); + TBAAAccessInfo TBAAInfo = CGM.getTBAAVTablePt

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

kosarev updated this revision to Diff 130599. kosarev added a comment. - Supported propagation of TBAA info for aggregate transfers. - Added tests on copying of `may_alias` aggregates. https://reviews.llvm.org/D41539 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGCla

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev created this revision. kosarev added reviewers: rjmccall, hfinkel. kosarev added a project: clang. Herald added a subscriber: llvm-commits. This patch does two things. First, it fixes creating TBAA access descriptors for may_alias-marked access types. Currently, for such types we generate

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

kosarev updated this revision to Diff 131257. kosarev added a comment. The copying functions changed to take LValues. It seems Address-taking versions are not very useful so we don't bother with overloading. https://reviews.llvm.org/D41539 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL323421: [CodeGen] Decorate aggregate accesses with TBAA tags (authored by kosarev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41539?vs=13

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

This revision was automatically updated to reflect the committed changes. Closed by commit rC323421: [CodeGen] Decorate aggregate accesses with TBAA tags (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D41539?vs=131257&id=131434#toc Repository: rC Clan

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev added inline comments. Comment at: lib/CodeGen/CodeGenTBAA.h:67 /* BaseType= */ nullptr, /* AccessType= */ nullptr, - /* Offset= */ 0, /* Size= */ 0); + /* Offset= */ 0, /* Size= */ UINT64_MAX);

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev added a comment. Hal, will you please take a look? Repository: rL LLVM https://reviews.llvm.org/D42366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2