[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang-c/Index.h:5220 +CINDEX_LINKAGE CXString +clang_getCompletionCorrection(CXCompletionString completion_string, + unsigned correction_index, ilya-biryukov wrote: > I'm a bit vary abo

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 145664. yvvan added a comment. Address comments and provide diff with full context https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/C

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan added a comment. The idea was to ignore everything including notes and remarks so that only errors from system headers are still collected. Changing consumer might be a possible way to go as well but it requires changing (or wrapping) all consumers that we need to be affected. The advanta

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan added a comment. But this one misses a way to set this flag for everything except libclang. We can probably change that (Nikolai is in vacation till the end of summer so it's probably my part now) and add some tests outside of Index for it (probably Frontend) Repository: rC Clang htt

[PATCH] D48314: [Frontend] Cache preamble-related data

yvvan added a comment. @ilya-biryukov Sorry. I didn't have time to post comments here. The usecase that we have is a supportive translation unit for code completion. Probably you use something similar in clangd not to wait for the TU to be reparsed after a change? The gain from this change is bo

[PATCH] D49010: YAML output for index-while-building

yvvan created this revision. yvvan added a reviewer: nathawes. Herald added subscribers: ioeric, ilya-biryukov. Should be compatible with the current index format accepted by clangd https://reviews.llvm.org/D49010 Files: include/clang/Index/IndexRecordReader.h include/clang/Index/IndexRecor

[PATCH] D49063: [libclang] Add support for ObjCObjectType

yvvan added inline comments. Comment at: include/clang-c/Index.h:35 #define CINDEX_VERSION_MAJOR 0 #define CINDEX_VERSION_MINOR 49 Please, increment the minor version (you are adding new functions) Comment at: include/clang-c/Index.h:3644 +

[PATCH] D49010: YAML output for index-while-building

yvvan updated this revision to Diff 155331. https://reviews.llvm.org/D49010 Files: include/clang/Index/IndexRecordReader.h include/clang/Index/IndexRecordWriter.h include/indexstore/IndexStoreCXX.h include/indexstore/indexstore.h lib/Index/ClangIndexRecordWriter.cpp lib/Index/IndexRec

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan added a comment. @DmitryPolukhin Sorry, I didn't have time recently. Thanks a lot for taking care! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/ https://reviews.llvm.org/D63482 ___ cfe-commits mailin

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

yvvan added a comment. I'm not a big objC expert here. The idea looks fine to me and won't affect my workflow. So let's take this patch if nobody comments against it here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.ll

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan added a comment. @mgehre From your comment it seems that `clang-apply-replacements` handles the YAML wrong and does not make the proper conversion back from "\n\n" to "\n" Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/ https://reviews.llvm.org/D63

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan added a comment. @mgehre I think we need to adjust `denormalize(const IO &)` method here to convert \n back properly. It seems I missed it in my patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/ https://reviews.llvm.org/D63482 _

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan added inline comments. Comment at: tools/libclang/CIndex.cpp:6445 + struct PostChildrenAction { + CXCursor cursor; + enum Action { Invalid, Ignore, Postpone } action; 4 spaces instead of 2 Comment at: tools/libclang/CIndex.cpp:

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan added inline comments. Comment at: tools/libclang/CIndex.cpp:6888 + const SourceLocation fixedEnd = + RefNameRange.getEnd().getLocWithOffset(-1); + RefNameRange = SourceRange(RefNameRange.getBegin(), fixedEnd); nik wrote: > yvvan wrote: >

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification, Functi

[PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

yvvan added a comment. Can we still have it in 5.0? Repository: rL LLVM https://reviews.llvm.org/D40746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

yvvan added a comment. With this change we don't pass "LocInfo" directly and it seems to break the locations when calling "getCXXOperatorNameRange" for this DeclRefExpr later on. Please fix it. You can introduce another "Create" static method for DeclRefExpr that accepts LocInfo and passes it t

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

yvvan added a comment. In D129973#3688329 , @SimplyDanny wrote: > In D129973#3684940 , @yvvan wrote: > >> With this change we don't pass "LocInfo" directly and it seems to break the >> locations when calling "ge

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan updated this revision to Diff 108620. yvvan added a comment. Provide a workaround without regression https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp === --- lib/AST/ExprCons

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan added a comment. Ok, i will make safer solution... https://reviews.llvm.org/D34873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan updated this revision to Diff 108878. yvvan marked 2 inline comments as done. yvvan added a comment. Make safe solution without regression https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp ==

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan added a comment. ping. Do you think this is ok now? https://reviews.llvm.org/D34873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. one more Ping. this is quite a useful fix that does not cost much https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. In https://reviews.llvm.org/D35355#831845, @klimek wrote: > Sorry for missing this - can you add a test? I think I can :) Will add it next week. https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan created this revision. https://bugs.llvm.org/show_bug.cgi?id=33904 Happens when static function is accessed via the class variable. That leads to incorrect overloads number because the variable is considered as the first argument. struct Bar { static void foo(); static void foo(int);

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan updated this revision to Diff 109968. yvvan added a comment. Add unit-test for the case fixed in this review https://reviews.llvm.org/D35355 Files: lib/Frontend/ASTUnit.cpp lib/Parse/ParseTemplate.cpp test/Index/code-completion.cpp Index: test/Index/code-completion.cpp ===

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan updated this revision to Diff 109980. yvvan added a comment. Yes, I missed to include one file in this diff where it's used https://reviews.llvm.org/D36390 Files: include/clang/Sema/Sema.h lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaOverload.cpp test/Index/complete-call.cpp Index:

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. I've just found a regression in my change. in case I have std::string(/*complete here*/) I need to investigate that case because I thought it's covered by !isa(FD) ... https://reviews.llvm.org/D36390 ___ cfe-commits mailing

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. Do you mean the testcase that runs only for windows with ms-extensions flag and msvc includes? I don't know if clang has that kind of tests. Does it? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. Please check that one https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Ping... https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. And if you just meant how to reproduce: You need to parse and reparse standard header (my current one is C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\memory). I can provide the options and a command line that I have if you can't reproduce it with defau

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. But I don't know the source of that issue, I only know how to fix it because I caught that one in debugger and added a check to prevent it. How can I write testcase for such fix? https://reviews.llvm.org/D36458 ___ cfe-commit

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Can someone help me to commit it to the proper branch? (I don't have permissions) https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan updated this revision to Diff 110978. yvvan added a comment. I have minimized the crash case and added simple test for it. https://reviews.llvm.org/D36458 Files: lib/Parse/Parser.cpp test/Index/std-begin-error.cpp Index: test/Index/std-begin-error.cpp ===

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan abandoned this revision. yvvan added a comment. In https://reviews.llvm.org/D34873#841624, @rnk wrote: > This shouldn't be necessary after https://reviews.llvm.org/rL310905. https://reviews.llvm.org/D34873 ___ cfe-commits mailing list cfe-co

[PATCH] D35200: Don't use mmap on Windows

yvvan added a comment. The files might also be removed. I checked that with qtcreator from git. Switching to the different branch started reparse of some files. When I frequently switched branches back and forth I got lock issues. With mmap turned off this did not happen. https://reviews.llvm.

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6342 +&& !isa(FD)) { + Args = Args.slice(1); +} nik wrote: > bkramer wrote: > > assert that FD is a static method. > Just stumbled here because I was looking into

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan updated this revision to Diff 111647. yvvan marked 5 inline comments as done. yvvan added a comment. Review comments + solved https://bugs.llvm.org/show_bug.cgi?id=34207 issue. I've also added the extra test for that issue https://reviews.llvm.org/D36390 Files: include/clang/Sema/Sema.h

[PATCH] D74564: libclang: Add static build support for Windows

yvvan added a comment. Please, upload patches with context (-U). Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif Is it different from just leaving CINDEX

[PATCH] D74564: libclang: Add static build support for Windows

yvvan accepted this revision. yvvan added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif cr

[PATCH] D44426: Fix llvm + clang build with Intel compiler

yvvan added a comment. In https://reviews.llvm.org/D44426#1042162, @mibintc wrote: > I added some inline comments. You are using the Intel 18.0 compiler on > Windows - what version of Visual Studio is in the environment? Yes, I'm using 18.0 Comment at: include/llvm-c/Target

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:565 + /// \brief For this completion result correction is required. + Optional Corr = None; + ilya-biryukov wrote: > Having a string replacement without an actual range to replac

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:565 + /// \brief For this completion result correction is required. + Optional Corr = None; + yvvan wrote: > ilya-biryukov wrote: > > Having a string replacement without an actua

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. one more ping... https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. @bkramer Not yet, it would be good to have one though :) https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification, Functi

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Recheck please the latest diff https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan abandoned this revision. yvvan added a comment. Can't reproduce an error anymore https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34680: Fix clang-cl build -fprofile-instr-use flag

yvvan created this revision. Reproduced while building llvm with clang-cl. I have trained profdata file. When I tried to use it I got crash complaining of nullptr casted inside visitor. https://reviews.llvm.org/D34680 Files: lib/CodeGen/CodeGenPGO.cpp Index: lib/CodeGen/CodeGenPGO.cpp

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

yvvan added a comment. F3487082: llvm.profdata Profdata which causes crash https://reviews.llvm.org/D34680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793573, @klimek wrote: > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > Do not evaluate numbers. > > Check for != "=" is needed not to mess with invalid default arguments or > > their types (without it I get "const Bar& b

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793594, @klimek wrote: > In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > > > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > > > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > > > > > Do not evalu

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan created this revision. With that patch applied my 32-bit libclang.dll built with mingw does not crash anymore unit tests are not affected by that change https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp ===

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

yvvan added a comment. In https://reviews.llvm.org/D34680#794135, @vsk wrote: > Do you know which function clang was processing when it crashed? That would > help us find a test case. I have a trace: #0 0x7ff6942b777c HandleAbort d:\code\llvm_copy\lib\support\windows\signals.inc:405:0 #1

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 105045. yvvan added a comment. Add tests, append tests with default values. Move all default value handling to GetDefaultValueString https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp test/Index/code-

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Ping :) It's quite likely ok now because covered with tests. Check please. https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35200: Don't use mmap on Windows

yvvan created this revision. Memory mapping does not make llvm faster (at least I don't see any difference). It also allows llvm not to lock files which is sometimes quite important. https://reviews.llvm.org/D35200 Files: lib/Support/MemoryBuffer.cpp Index: lib/Support/MemoryBuffer.cpp

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 105976. yvvan added a comment. Add comments why it's needed to add '=' to default value in some cases https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp test/Index/code-completion.cpp test/Index/comp

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Ping! Comments are added :) https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35200: Don't use mmap on Windows

yvvan added a comment. What do you think about that change? https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 106170. yvvan added a comment. Add more checks into GetDefaultValueString to make it safe https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp test/Index/code-completion.cpp test/Index/complete-optiona

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan created this revision. When we have enabled cache for global completions we did not have diagnostics for Bar and could not complete Ba as in provided code example. template struct Foo { T member; }; template using Bar = Foo; int main() { Ba } https://reviews.llvm.org/D35355 Files

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Ping https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. So do we wait until the '=' case is more clear? This change should not break anything if it's fixed in either direction (if '=' will be provided always or never) https://reviews.llvm.org/D33644 ___ cfe-commits mailing list c

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 107077. yvvan added a comment. Add TODO about '=' check https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp test/Index/code-completion.cpp test/Index/complete-optional-params.cpp Index: test/Index/co

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan added a comment. The same alignment in other places works fine. i don't know the source of that issue. Should be somewhere in gcc(mingw) but it's not my focus. So this is a workaround that we can make (probably only for mingw builds) https://reviews.llvm.org/D34873

[PATCH] D42099: [libclang] Add missing CINDEX_LINKAGE

yvvan added a comment. I have mentioned there the original number (https://reviews.llvm.org/D39903) in the commit message but it's also not mentioned in the log there. Repository: rC Clang https://reviews.llvm.org/D42099 ___ cfe-commits mailing

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 130384. yvvan added a comment. Rebased. Applies for current master. Also ping again... https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h lib/Frontend/ASTU

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. One more Ping! https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Ping!!! https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 4 inline comments as done. yvvan added a comment. @ilya-biryukov Thanks a lot for you comments and for the provided code replacement. I'm checking now how it works and will continue addressing other comments. https://reviews.llvm.org/D41537 __

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 132146. yvvan added a comment. Use https://reviews.llvm.org/D42474 code. Add missing parts and tests for errors and fixits. https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Cod

<    1   2   3