ismailp accepted this revision.
ismailp added a comment.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D23898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp created this revision.
ismailp added a reviewer: rsmith.
ismailp added a subscriber: cfe-commits.
C++1z 6.4.1/p2:
If the if statement is of the form if constexpr, the value of the
condition shall be a contextually converted constant expression of type
bool [...]
C++1z 5.20/p4:
[...] A
ismailp updated this revision to Diff 70561.
ismailp added a comment.
- Added more tests
https://reviews.llvm.org/D24158
Files:
lib/Sema/SemaOverload.cpp
test/CodeGenCXX/cxx1z-constexpr-if.cpp
Index: test/CodeGenCXX/cxx1z-constexpr-if.cpp
===
ismailp added a comment.
Thank you for reviewing.
Sure, I'll try to look into those conversions as well.
Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:2
@@ -1,2 +1,3 @@
// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - | FileCheck %s
--implicit-check-not=should_not_be_use
Author: ismailp
Date: Wed Sep 7 13:24:54 2016
New Revision: 280838
URL: http://llvm.org/viewvc/llvm-project?rev=280838&view=rev
Log:
Try contextually converting condition of constexpr if to Boolean value
Summary:
C++1z 6.4.1/p2:
If the if statement is of the form if constexpr, the value of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280838: Try contextually converting condition of constexpr
if to Boolean value (authored by ismailp).
Changed prior to commit:
https://reviews.llvm.org/D24158?vs=70561&id=70577#toc
Repository:
rL LLV
ismailp added inline comments.
Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:2
@@ -1,2 +1,3 @@
// RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - | FileCheck %s
--implicit-check-not=should_not_be_used
+// RUN: %clang_cc1 -std=c++1z %s -DCHECK_CONVERSION -verify %s
-
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp added a comment.
I don't have ubigraph installed either. The purpose of the test isn't to check
as to whether we can generate a conforming/sensible ubigraph output, but to
ensure that this tiny patch works and clang doesn't crash. So, I'd keep it. But
if you are worried about other/unkn
ismailp updated this revision to Diff 35141.
ismailp added a comment.
- Added a new test file instead of adding '-analyzer-viz-egraph-ubigraph' to an
existing test.
http://reviews.llvm.org/D12119
Files:
lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
test/Analysis/ubigraph-viz.cpp
Index:
Author: ismailp
Date: Fri Sep 18 16:54:47 2015
New Revision: 248050
URL: http://llvm.org/viewvc/llvm-project?rev=248050&view=rev
Log:
Analyzer: Fix a crasher in UbigraphViz
Summary:
Name `Out` refers to the parameter. It is moved into the member `Out`
in ctor-init. Dereferencing null pointer will
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248050: Analyzer: Fix a crasher in UbigraphViz (authored by
ismailp).
Changed prior to commit:
http://reviews.llvm.org/D12119?vs=35141&id=35142#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12119
ismailp added a comment.
Thank you for reviewing!
Repository:
rL LLVM
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp added a reviewer: majnemer.
ismailp marked an inline comment as done.
ismailp added a comment.
Ping!
http://reviews.llvm.org/D9898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp added a comment.
Sorry, that's a typo. It is 24170.
http://reviews.llvm.org/D12482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp updated this revision to Diff 35384.
ismailp added a comment.
Addressed comments.
http://reviews.llvm.org/D12482
Files:
lib/StaticAnalyzer/Core/Environment.cpp
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/StaticAnalyzer/Core/SValBuilder.cpp
test/Analysis/dtor.cpp
Index: test/Anal
ismailp marked an inline comment as done.
ismailp added a comment.
Thanks for reviewing.
http://reviews.llvm.org/D12482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ismailp
Date: Tue Sep 22 14:33:15 2015
New Revision: 248314
URL: http://llvm.org/viewvc/llvm-project?rev=248314&view=rev
Log:
Analyzer: Teach analyzer how to handle TypeTraitExpr
Summary:
`TypeTraitExpr`s are not supported by the ExprEngine today. Analyzer
creates a sink, and aborts the b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248314: Analyzer: Teach analyzer how to handle TypeTraitExpr
(authored by ismailp).
Changed prior to commit:
http://reviews.llvm.org/D12482?vs=35384&id=35403#toc
Repository:
rL LLVM
http://reviews.l
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp updated this revision to Diff 36123.
ismailp added a comment.
- Don't try to calculate field offset for Objective-C instance variables
- Added test for Objective-C instance variables
- Added a non-null pointer in test
http://reviews.llvm.org/D12251
Files:
lib/StaticAnalyzer/Core/Store
ismailp marked 3 inline comments as done.
Comment at: test/Analysis/array-struct-region.cpp:128
@@ +127,3 @@
+#if __cplusplus
+ clang_analyzer_eval((void *)&PFONew->secondField != (void *)&PFONew); //
expected-warning{{TRUE}}
+#endif
I might be missing something
ismailp created this revision.
ismailp added reviewers: zaks.anna, krememek.
ismailp added a subscriber: cfe-commits.
Name `Out` refers to the parameter. It is moved into the member `Out`
in ctor-init. Dereferencing null pointer will crash clang, if user
passes '-analyzer-viz-egraph-ubigraph' argu
ismailp added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 +748,3 @@
assert (Src != Dst && "Self-edges are not allowed.");
Is Ubigraph generator actively maintained? If I run tests with
'-analyzer-viz-egraph-u
ismailp updated this revision to Diff 32745.
ismailp added a comment.
- Renamed `Out` parameter to `Stm`.
- Removed assertion that checks whether an ExplodedNode has an edge to itself.
- Added '-analyzer-viz-egraph-ubigraph' to an analyzer invocation in a test.
http://reviews.llvm.org/D12119
Fi
ismailp created this revision.
ismailp added reviewers: krememek, zaks.anna.
ismailp added a subscriber: cfe-commits.
`StoreManager::getLValueFieldOrIvar` should return loc as
base + field-offset, instead of just base.
http://reviews.llvm.org/D12251
Files:
lib/StaticAnalyzer/Core/Store.cpp
t
ismailp updated this revision to Diff 32903.
ismailp added a comment.
- Change parameter name to `OutStream`.
http://reviews.llvm.org/D12119
Files:
lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
test/Analysis/cfg.cpp
Index: test/Analysis/cfg.cpp
==
ismailp added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 @@
-
- assert (Src != Dst && "Self-edges are not allowed.");
-
krememek wrote:
> Did you look at the test case that causes this assertion to fail? I think i
ismailp created this revision.
ismailp added reviewers: zaks.anna, dcoughlin, krememek.
ismailp added a subscriber: cfe-commits.
`TypeTraitExpr`s are not supported by the ExprEngine today. Analyzer
creates a sink, and aborts the block. Therefore, certain bugs that
involve type traits intrinsics ca
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp updated this revision to Diff 34082.
ismailp added a comment.
- Rolled back to the first version of patch, where only parameter `Out` is
renamed to `OutStream`
- Use a different test that doesn't trigger the self-loop assertion.
http://reviews.llvm.org/D12119
Files:
lib/StaticAnalyze
ismailp added a comment.
Thank you for the feedback! I have added the test in a C file, so we can get
the first part of the patch in -- between lines 778-780.
I think self-loop is a different problem, and that requires its own patch. I'll
see what I can do about self-loop, if someone else isn't
ismailp added a comment.
Ping! It seems like this patch was forgotten. This fixes PR24730, which is
reported recently.
http://reviews.llvm.org/D9898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: ismailp
Date: Mon Oct 26 14:20:24 2015
New Revision: 251335
URL: http://llvm.org/viewvc/llvm-project?rev=251335&view=rev
Log:
MismatchingNewDeleteDetector uses incorrect field, and finds no initializer
Summary:
In `MismatchingNewDeleteDetector::analyzeInClassInitializer`, if
`Field`'s ini
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251335: MismatchingNewDeleteDetector uses incorrect field,
and finds no initializer (authored by ismailp).
Changed prior to commit:
http://reviews.llvm.org/D9898?vs=26271&id=38449#toc
Repository:
rL
Hi,
this patch addresses a crash-on-valid on 3.7. Could you please merge
this to 3.7 branch?
Ismail
On Mon, Oct 26, 2015 at 8:20 PM, Ismail Pazarbasi via cfe-commits
wrote:
> Author: ismailp
> Date: Mon Oct 26 14:20:24 2015
> New Revision: 251335
>
> URL: http://llvm.org/view
Thanks!
On Fri, Nov 6, 2015 at 12:44 PM, Tom Stellard wrote:
> tstellarAMD accepted this commit.
> tstellarAMD added a comment.
>
> r252290
>
>
> Users:
> ismailp (Author)
> rsmith (Auditor)
> 3.7-release (Auditor)
> cfe-commits (Auditor)
> tstellarAMD (Auditor)
>
> http://reviews.llvm.
ismailp added a subscriber: ismailp.
ismailp added a comment.
Thanks!
Users:
ismailp (Author)
rsmith (Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
http://reviews.llvm.org/rL251335
___
cfe-commits mailing list
39 matches
Mail list logo
