[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus updated this revision to Diff 278411. walrus added a comment. Simplify code according to suggestions in code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83855/new/ https://reviews.llvm.org/D83855 Files: clang/lib/AST/StmtPrinter.

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus updated this revision to Diff 278412. walrus added a comment. Remove unused struct definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83855/new/ https://reviews.llvm.org/D83855 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/a

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus marked an inline comment as done. walrus added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2011 + Expr *Init = D->getInit(); + if (D->getInitStyle() == VarDecl::CallInit && !isa(Init)) +OS << "("; kadircet wrote: > walrus w

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus updated this revision to Diff 278420. walrus added a comment. Simplify if..else statement, add braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83855/new/ https://reviews.llvm.org/D83855 Files: clang/lib/AST/StmtPrinter.cpp clang/te

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus marked 2 inline comments as done. walrus added a comment. In D83855#2155303 , @kadircet wrote: > thanks, lgtm! Thank you much for the review! I do not have commit access. Could you please commit the changes on my behalf? Ilya Golovenko Reposit

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

walrus created this revision. Herald added subscribers: cfe-commits, kbobyrev, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The fix improves handling of Windows UNC paths to align with Appendix E. Nonstandard Syntax Variations of RFC 8089. Before

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. This is an attempt to improve handling of Windows UNC paths in clangd. Any feedback is appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84150/new/ https://reviews.llvm.org/D84150 ___

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko updated this revision to Diff 279224. ilya-golovenko added a comment. Consistent naming: Name => Path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84150/new/ https://reviews.llvm.org/D84150 Files: clang-tools-extra/clangd/URI.cpp

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko updated this revision to Diff 279233. ilya-golovenko added a comment. Consistent naming: hasDriveLetter => isWindowsPath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84150/new/ https://reviews.llvm.org/D84150 Files: clang-tools-e

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, kbobyrev, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The fix improves handling of Windows UNC paths to align with Appendix E. Nonstandard Syntax Variations of RFC 8089

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko updated this revision to Diff 279271. ilya-golovenko marked an inline comment as done. ilya-golovenko added a comment. Address code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84172/new/ https://reviews.llvm.org/D8

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko marked 2 inline comments as done. ilya-golovenko added inline comments. Comment at: clang-tools-extra/clangd/URI.cpp:29 +bool isWindowsPath(llvm::StringRef Path) { + return Path.size() > 1 && llvm::isAlpha(Path[0]) && Path[1] == ':'; sammccall w

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2162284 , @sammccall wrote: > Thanks for doing this! And sorry about the shaky windows support... > > (There are potentially other lurking issues due to filenames being used as > keys internally, particularly case

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2162736 , @sammccall wrote: > Thanks! Do you have commit access, or should I land this for you? No, I don't have commit access. Could you please commit on my behalf? Ilya Golovenko And thanks again for the rev

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. @sammccall sorry for bothering you, could you please land this for me? Ilya Golovenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84172/new/ https://reviews.llvm.org/D84172

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a subscriber: walrus. ilya-golovenko added a comment. @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account... By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

walrus added a comment. In D84172#2166496 , @kbobyrev wrote: > In D84172#2166448 , @ilya-golovenko > wrote: > > > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus > > is my not-used-anymo

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2166496 , @kbobyrev wrote: > In D84172#2166448 , @ilya-golovenko > wrote: > > > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus > > is my not-us

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ilya-golovenko requested review of this revision. It is necessary to traverse children of unnamed declaration contexts to get symbols which are curren

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 281542. ilya-golovenko added a comment. Trigger new build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files: clang-tools-extra/clangd/FindSymbols.cpp cla

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:200 auto *ND = llvm::dyn_cast(D); -if (!ND) +if (!ND) { + // Traverse children of unnamed contexts, e.g. extern "C". kadircet wrote: > this will result in

[PATCH] D83855: [clang] fix printing of lambdas with capture expressions

walrus created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83855 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/ast-printer-lambda.cpp Index: clang/test/AST/ast-printer-lambda.cpp

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

walrus marked an inline comment as done. walrus added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2011 + Expr *Init = D->getInit(); + if (D->getInitStyle() == VarDecl::CallInit && !isa(Init)) +OS << "("; kadircet wrote: > what abo

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 282197. ilya-golovenko added a comment. Changes afte code review, add test for export context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files: clang-tool

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko added a comment. @kadircet I decided to add `OnlyChildren` to `enum VisitKind` instead of making a `VisitKindSet` - this helped to minimize the changes in `shouldVisit()`. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 282198. ilya-golovenko added a comment. Remove invalid comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files: clang-tools-extra/clangd/FindSymbols.cpp

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 282236. ilya-golovenko added a comment. Simplify logic in traverseDecl method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files: clang-tools-extra/clangd/F

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko added a comment. In D84839#2189120 , @kadircet wrote: > thanks, lgtm! > > let me know if i should land this for you Thank you much for the review. I don't have commit access so could you please land it for me: Ilya Golovenko Repository:

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ilya-golovenko requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Incorrect definition is shown in tooltip when hove

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

ilya-golovenko added reviewers: kadircet, sammccall. ilya-golovenko added a comment. I'm not quite sure my fix is the best way to fix the issue, so any advices are appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85253/new/ https://revie

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

ilya-golovenko added a comment. I agree the fix is not correct. I will check how it currently works with clangd built from master branch. I'm not quite sure there should be no tooltip for a `#define`. Such tooltip is not really useful, but at the same time clangd shows tooltips for function de

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

ilya-golovenko added a comment. It is also possible to force MSVC to treat a certain source code files as UTF-8 by adding the following pragma to the beginning of the file: #ifdef _MSVC_VER #pragma execution_character_set("utf-8"); #endif Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D92484: [clangd] Relations should not be accounted when computing backing storage size

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ilya-golovenko requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D92484: [clangd] Relation slabs should not be accounted when computing backing storage size

ilya-golovenko added a comment. In D92484#2430851 , @sammccall wrote: > Can you give a little context? Why not? It seems `Relations` should be not taken into account because they don't reference a backing storage. Only `SymStorage` and `RefsStorage` are

[PATCH] D92484: [clangd] Relation slabs should not be accounted when computing backing storage size

ilya-golovenko added a comment. In D92484#2430985 , @sammccall wrote: > Thanks, you're right. There's no "payload" memory here, and > MemIndex::estimateMemoryUsage should already be accounting for all the memory > used. > > (Sorry, it's been a while sinc

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ilya-golovenko requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Google test matcher DeclKind uses NamedDecl::getDeclKindNam

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

ilya-golovenko added a comment. I don't have commit access could you please commit it on my behalf? Ilya Golovenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90384/new/ https://reviews.llvm.org/D90384 __

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ilya-golovenko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko updated this revision to Diff 316877. ilya-golovenko added a comment. Update existing test and remove redundant one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94753/new/ https://reviews.llvm.org/D94753 Files: clang-tools-extra/

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko added a comment. @kadircet Thank you for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94753/new/ https://reviews.llvm.org/D94753 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko added a comment. In D94753#2500535 , @kadircet wrote: > btw, do you have commit access or should i land this for you ? (if so please > provide your email) I've got commit access some time ago. Thanks again! Repository: rG LLVM Github M

[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cc221b99bec: [clangd] exclude symbols from document outline which do not originate from the… (authored by ilya-golovenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie