[clang] e702bdb - [Syntax] Build SimpleDeclaration node that groups multiple declarators

2019-11-29 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-29T11:39:45+01:00 New Revision: e702bdb8598fcb4224f465569e7692a155c3eb3e URL: https://github.com/llvm/llvm-project/commit/e702bdb8598fcb4224f465569e7692a155c3eb3e DIFF: https://github.com/llvm/llvm-project/commit/e702bdb8598fcb4224f465569e7692a155c3eb3e.diff

[clang] 242649c - [Syntax] Show input code on tests failures. NFC

2019-12-05 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-05T16:25:35+01:00 New Revision: 242649c17c5b11bcc788b6f69bd3eed44cfd3d79 URL: https://github.com/llvm/llvm-project/commit/242649c17c5b11bcc788b6f69bd3eed44cfd3d79 DIFF: https://github.com/llvm/llvm-project/commit/242649c17c5b11bcc788b6f69bd3eed44cfd3d79.diff

[clang-tools-extra] b63c35e - [clangd] Simplify code using findName. NFC

2019-12-10 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-10T10:22:43+01:00 New Revision: b63c35ebf76ca0ac89405aeadee2b98a0e91e05e URL: https://github.com/llvm/llvm-project/commit/b63c35ebf76ca0ac89405aeadee2b98a0e91e05e DIFF: https://github.com/llvm/llvm-project/commit/b63c35ebf76ca0ac89405aeadee2b98a0e91e05e.diff

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

2019-12-10 Thread Ilya Biryukov via cfe-commits
Ah, some older gcc versions can't handle raw string literals inside macro arguments. +Haojian Wu , could you fix this? On Tue, Dec 10, 2019 at 12:22 PM Yvan Roux wrote: > Hi Haojian, > > AArch64 bots are broken after this commit, logs are available here: > > > http://lab.llvm.org:8011/builders/c

[clang] f7c8ace - [CodeComplete] Fix a crash in preferred type and signature help

2019-12-11 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-11T09:43:28+01:00 New Revision: f7c8ace4a52acecff7cd6ab61cbeaf677da1dd86 URL: https://github.com/llvm/llvm-project/commit/f7c8ace4a52acecff7cd6ab61cbeaf677da1dd86 DIFF: https://github.com/llvm/llvm-project/commit/f7c8ace4a52acecff7cd6ab61cbeaf677da1dd86.diff

[clang] be14a22 - [Syntax] Build nodes for simple cases of top level declarations

2019-12-11 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-12T08:04:22+01:00 New Revision: be14a22b47e5c61ff36e4183dcb4f8b138466157 URL: https://github.com/llvm/llvm-project/commit/be14a22b47e5c61ff36e4183dcb4f8b138466157 DIFF: https://github.com/llvm/llvm-project/commit/be14a22b47e5c61ff36e4183dcb4f8b138466157.diff

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

2019-12-12 Thread Ilya Biryukov via cfe-commits
Will fix right away, sorry for the delay. On Thu, Dec 12, 2019 at 12:42 PM Yvan Roux wrote: > On Tue, 10 Dec 2019 at 10:24, Ilya Biryukov wrote: > > > > Ah, some older gcc versions can't handle raw string literals inside > macro arguments. > > +Haojian Wu, could you fix this? > > When do you pl

[clang] 7d77898 - [Tooling] Move raw string literal out of a macro call. NFC

2019-12-12 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-12T10:53:20+01:00 New Revision: 7d7789899f4d4684dac51f265a47b049db4d09f2 URL: https://github.com/llvm/llvm-project/commit/7d7789899f4d4684dac51f265a47b049db4d09f2 DIFF: https://github.com/llvm/llvm-project/commit/7d7789899f4d4684dac51f265a47b049db4d09f2.diff

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

2019-12-12 Thread Ilya Biryukov via cfe-commits
Should be fixed in 7d7789899f4. On Thu, Dec 12, 2019 at 12:50 PM Ilya Biryukov wrote: > Will fix right away, sorry for the delay. > > On Thu, Dec 12, 2019 at 12:42 PM Yvan Roux wrote: > >> On Tue, 10 Dec 2019 at 10:24, Ilya Biryukov wrote: >> > >> > Ah, some older gcc versions can't handle raw

[clang] 1ad1504 - [Syntax] Allow to mutate syntax trees

2019-12-18 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-18T12:19:03+01:00 New Revision: 1ad15046dcf6ff8bafc4a1ea13f214f8d6ba7de6 URL: https://github.com/llvm/llvm-project/commit/1ad15046dcf6ff8bafc4a1ea13f214f8d6ba7de6 DIFF: https://github.com/llvm/llvm-project/commit/1ad15046dcf6ff8bafc4a1ea13f214f8d6ba7de6.diff

[clang] 038f538 - [Syntax] Uppercase the first letter of the test name. NFC

2019-12-18 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-18T12:20:30+01:00 New Revision: 038f53882e7cc25da0a71018d1c7f9b4706675c2 URL: https://github.com/llvm/llvm-project/commit/038f53882e7cc25da0a71018d1c7f9b4706675c2 DIFF: https://github.com/llvm/llvm-project/commit/038f53882e7cc25da0a71018d1c7f9b4706675c2.diff

[clang] c1bbefe - [Syntax] Use a hash table to search for tokens by their location

2019-12-18 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-18T12:24:00+01:00 New Revision: c1bbefef9d36e84e469513374ef404b9e354b262 URL: https://github.com/llvm/llvm-project/commit/c1bbefef9d36e84e469513374ef404b9e354b262 DIFF: https://github.com/llvm/llvm-project/commit/c1bbefef9d36e84e469513374ef404b9e354b262.diff

[clang-tools-extra] 14e1100 - [clangd] Fix crash in hover

2019-12-27 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-27T09:15:15+01:00 New Revision: 14e11005d1a6ac1fecb230c470e9011d6956b8e4 URL: https://github.com/llvm/llvm-project/commit/14e11005d1a6ac1fecb230c470e9011d6956b8e4 DIFF: https://github.com/llvm/llvm-project/commit/14e11005d1a6ac1fecb230c470e9011d6956b8e4.diff

[clang-tools-extra] e2d9f4e - [clangd] Reformat `HoverTests.cpp` NFC

2019-12-27 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-12-27T09:35:46+01:00 New Revision: e2d9f4e6a284992388a82df388e36f6491b9ec66 URL: https://github.com/llvm/llvm-project/commit/e2d9f4e6a284992388a82df388e36f6491b9ec66 DIFF: https://github.com/llvm/llvm-project/commit/e2d9f4e6a284992388a82df388e36f6491b9ec66.diff

[clang-tools-extra] r328302 - [clangd] Remove 'static' from a function inside anonymous ns. NFC

2018-03-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Mar 23 03:39:15 2018 New Revision: 328302 URL: http://llvm.org/viewvc/llvm-project?rev=328302&view=rev Log: [clangd] Remove 'static' from a function inside anonymous ns. NFC Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp Modified: clang-tools-e

r317676 - Moved QualTypeNames.h from Tooling to AST.

2017-11-08 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Nov 8 02:39:03 2017 New Revision: 317676 URL: http://llvm.org/viewvc/llvm-project?rev=317676&view=rev Log: Moved QualTypeNames.h from Tooling to AST. Summary: For code reuse in SemaCodeComplete. Note that the tests for QualTypeNames are still in Tooling as they use To

r317677 - Avoid printing some redundant name qualifiers in completion

2017-11-08 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Nov 8 02:39:09 2017 New Revision: 317677 URL: http://llvm.org/viewvc/llvm-project?rev=317677&view=rev Log: Avoid printing some redundant name qualifiers in completion Summary: Adjusted PrintingPolicy inside code completion to avoid printing some redundant name qualifi

r317687 - Workaround reverse-iteration buildbot breakages. Filed PR35244.

2017-11-08 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Nov 8 05:05:52 2017 New Revision: 317687 URL: http://llvm.org/viewvc/llvm-project?rev=317687&view=rev Log: Workaround reverse-iteration buildbot breakages. Filed PR35244. Clang's completion output is non-deterministic, causing test failures with turned on LLVM_REVERSE

[clang-tools-extra] r318317 - [clangd] clang-format the source code. NFC.

2017-11-15 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Nov 15 10:04:56 2017 New Revision: 318317 URL: http://llvm.org/viewvc/llvm-project?rev=318317&view=rev Log: [clangd] clang-format the source code. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-tools-extra/trunk/clangd/ClangdServer.cpp

r318411 - Allow to store precompiled preambles in memory.

2017-11-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Nov 16 08:25:01 2017 New Revision: 318411 URL: http://llvm.org/viewvc/llvm-project?rev=318411&view=rev Log: Allow to store precompiled preambles in memory. Summary: These preambles are built by ASTUnit and clangd. Previously, preambles were always stored on disk. In-m

[clang-tools-extra] r318412 - [clangd] Use in-memory preambles in clangd.

2017-11-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Nov 16 08:25:18 2017 New Revision: 318412 URL: http://llvm.org/viewvc/llvm-project?rev=318412&view=rev Log: [clangd] Use in-memory preambles in clangd. Reviewers: klimek, bkramer, sammccall Reviewed By: sammccall Subscribers: cfe-commits Differential Revision: https

r318514 - Use llvm-config.h instead of config.h

2017-11-17 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Nov 17 02:09:02 2017 New Revision: 318514 URL: http://llvm.org/viewvc/llvm-project?rev=318514&view=rev Log: Use llvm-config.h instead of config.h To fix standalone builds broken by r318411 (config.h is private to llvm). Modified: cfe/trunk/lib/Frontend/Precompiled

[clang-tools-extra] r318544 - [clangd] Release the old preamble before building a new one.

2017-11-17 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Nov 17 11:05:56 2017 New Revision: 318544 URL: http://llvm.org/viewvc/llvm-project?rev=318544&view=rev Log: [clangd] Release the old preamble before building a new one. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clang

[clang] 4361ba7 - Revert "[Coroutines] Fix premature conversion of return object"

2023-03-17 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-03-17T17:01:43+01:00 New Revision: 4361ba791cd6ab6e41fca4df3fd337da0c116132 URL: https://github.com/llvm/llvm-project/commit/4361ba791cd6ab6e41fca4df3fd337da0c116132 DIFF: https://github.com/llvm/llvm-project/commit/4361ba791cd6ab6e41fca4df3fd337da0c116132.diff

[clang] 282cae0 - [Sema] Fix crash on __fp16 parameters in template instantiations

2023-03-21 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-03-21T14:06:46+01:00 New Revision: 282cae0b9a602267ad7ef622f770066491332a11 URL: https://github.com/llvm/llvm-project/commit/282cae0b9a602267ad7ef622f770066491332a11 DIFF: https://github.com/llvm/llvm-project/commit/282cae0b9a602267ad7ef622f770066491332a11.diff

[clang] f27b77e - [Sema] Populate declarations inside TypeLocs for some invalid types

2023-04-06 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-04-06T19:02:41+02:00 New Revision: f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d URL: https://github.com/llvm/llvm-project/commit/f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d DIFF: https://github.com/llvm/llvm-project/commit/f27b77e5c59a1a907fa45eeb5f2e279a5c8bd17d.diff

[clang] 629170f - [Sema] Lambdas are not part of immediate context for deduction

2023-05-09 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-05-09T12:06:33+02:00 New Revision: 629170fe452f4849c89fc289d6e2cf5f08534342 URL: https://github.com/llvm/llvm-project/commit/629170fe452f4849c89fc289d6e2cf5f08534342 DIFF: https://github.com/llvm/llvm-project/commit/629170fe452f4849c89fc289d6e2cf5f08534342.diff

[clang] ccf7191 - [Modules] Do not rewrite existing decls when deserializing class fields

2023-04-18 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-04-18T12:40:39+02:00 New Revision: ccf7191719375cac15da5a3eb406e1efa602b096 URL: https://github.com/llvm/llvm-project/commit/ccf7191719375cac15da5a3eb406e1efa602b096 DIFF: https://github.com/llvm/llvm-project/commit/ccf7191719375cac15da5a3eb406e1efa602b096.diff

[clang] 67b298f - Reland [Modules] Remove unnecessary check when generating name lookup table in ASTWriter

2023-04-18 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-04-18T12:40:39+02:00 New Revision: 67b298f6d82e0b4bb648ac0dabe895e816a77ef1 URL: https://github.com/llvm/llvm-project/commit/67b298f6d82e0b4bb648ac0dabe895e816a77ef1 DIFF: https://github.com/llvm/llvm-project/commit/67b298f6d82e0b4bb648ac0dabe895e816a77ef1.diff

[clang] 5ea1580 - Revert "Reland [Modules] Remove unnecessary check when generating name lookup table in ASTWriter"

2023-04-21 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-04-21T14:08:18+02:00 New Revision: 5ea158077ec9ca50857ede5cbb0b27c61663fd55 URL: https://github.com/llvm/llvm-project/commit/5ea158077ec9ca50857ede5cbb0b27c61663fd55 DIFF: https://github.com/llvm/llvm-project/commit/5ea158077ec9ca50857ede5cbb0b27c61663fd55.diff

[clang-tools-extra] c9b3250 - [clangd] Allow to build Clangd without decision forest

2022-12-07 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2022-12-07T13:52:22+01:00 New Revision: c9b325088d14a816b101857eecd1042335aad4e0 URL: https://github.com/llvm/llvm-project/commit/c9b325088d14a816b101857eecd1042335aad4e0 DIFF: https://github.com/llvm/llvm-project/commit/c9b325088d14a816b101857eecd1042335aad4e0.diff

[clang-tools-extra] cdfce10 - [clangd] Fix a typo in -ranking-model documentation. NFC

2022-12-07 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2022-12-07T13:53:14+01:00 New Revision: cdfce10b28b158d2dcfeed289213eda1ad64f236 URL: https://github.com/llvm/llvm-project/commit/cdfce10b28b158d2dcfeed289213eda1ad64f236 DIFF: https://github.com/llvm/llvm-project/commit/cdfce10b28b158d2dcfeed289213eda1ad64f236.diff

[clang-tools-extra] edd5d77 - [clangd] NFC. Add a newline at the end of the file

2022-12-09 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2022-12-09T12:31:50+01:00 New Revision: edd5d777e981ab6a4952c14c35f3ead330c4a761 URL: https://github.com/llvm/llvm-project/commit/edd5d777e981ab6a4952c14c35f3ead330c4a761 DIFF: https://github.com/llvm/llvm-project/commit/edd5d777e981ab6a4952c14c35f3ead330c4a761.diff

[clang-tools-extra] r306530 - [clangd] Allow to override resource dir in ClangdServer.

2017-06-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jun 28 03:34:50 2017 New Revision: 306530 URL: http://llvm.org/viewvc/llvm-project?rev=306530&view=rev Log: [clangd] Allow to override resource dir in ClangdServer. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: klimek, cfe-commits Tags: #clan

r306549 - Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

2017-06-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jun 28 08:06:34 2017 New Revision: 306549 URL: http://llvm.org/viewvc/llvm-project?rev=306549&view=rev Log: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation. Summary: It used to always call into the RealFileSystem before. Reviewers: bkramer, krasimir, k

[clang-tools-extra] r306652 - [clangd] Added a test, checking that gcc install is searched via VFS.

2017-06-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jun 29 01:43:51 2017 New Revision: 306652 URL: http://llvm.org/viewvc/llvm-project?rev=306652&view=rev Log: [clangd] Added a test, checking that gcc install is searched via VFS. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: klimek, cfe-commits

[clang-tools-extra] r306656 - [clangd] Run a test, searching for gcc install, only on Unix.

2017-06-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jun 29 02:22:32 2017 New Revision: 306656 URL: http://llvm.org/viewvc/llvm-project?rev=306656&view=rev Log: [clangd] Run a test, searching for gcc install, only on Unix. This should fix windows buildbots. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTe

[clang-tools-extra] r306705 - [clangd] Check failure of Lexer::getRawToken in GoToDeclaration.

2017-06-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jun 29 10:11:32 2017 New Revision: 306705 URL: http://llvm.org/viewvc/llvm-project?rev=306705&view=rev Log: [clangd] Check failure of Lexer::getRawToken in GoToDeclaration. There was an access to unitialized memory because it wasn't checked. Modified: clang-tools-

[clang-tools-extra] r307025 - [clangd] Add -ffreestanding on VFS tests.

2017-07-03 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jul 3 07:46:03 2017 New Revision: 307025 URL: http://llvm.org/viewvc/llvm-project?rev=307025&view=rev Log: [clangd] Add -ffreestanding on VFS tests. Summary: They don't provide proper gcc installations and may fail on implicit include. Reviewers: klimek, krasimir, b

r308016 - [index] Added a method indexTopLevelDecls to run indexing on a list of Decls.

2017-07-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 14 03:47:45 2017 New Revision: 308016 URL: http://llvm.org/viewvc/llvm-project?rev=308016&view=rev Log: [index] Added a method indexTopLevelDecls to run indexing on a list of Decls. Summary: We need it in clangd for refactoring that replaces ASTUnit with manual AST

[clang-tools-extra] r308721 - [clangd] Specified --gcc-toolchain explicitly in VFS test.

2017-07-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 21 01:20:47 2017 New Revision: 308721 URL: http://llvm.org/viewvc/llvm-project?rev=308721&view=rev Log: [clangd] Specified --gcc-toolchain explicitly in VFS test. In order to avoid platform-specific configuration quirks. (Possible fix for https://bugs.llvm.org/show

r308722 - Fixed failing assert in code completion.

2017-07-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 21 02:24:00 2017 New Revision: 308722 URL: http://llvm.org/viewvc/llvm-project?rev=308722&view=rev Log: Fixed failing assert in code completion. Summary: The code was accessing uninstantiated default argument. This resulted in failing assertion at ParmVarDecl::getD

[clang-tools-extra] r308738 - [clangd] Replace ASTUnit with manual AST management.

2017-07-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 21 06:29:29 2017 New Revision: 308738 URL: http://llvm.org/viewvc/llvm-project?rev=308738&view=rev Log: [clangd] Replace ASTUnit with manual AST management. Summary: This refactoring does not aim to introduce any significant changes to the behaviour of clangd to ke

Re: [clang-tools-extra] r308738 - [clangd] Replace ASTUnit with manual AST management.

2017-07-25 Thread Ilya Biryukov via cfe-commits
ot; > textDocument":{"uri":"file:///main.cpp"},"position":{"line": > 4,"character":10}}} > > --> {"jsonrpc":"2.0","id":1,"result":[{"uri": "file:///main.cpp", > &quo

[clang-tools-extra] r308959 - [clangd] Workaround Windows test failures.

2017-07-25 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jul 25 02:31:51 2017 New Revision: 308959 URL: http://llvm.org/viewvc/llvm-project?rev=308959&view=rev Log: [clangd] Workaround Windows test failures. To properly fix this, Unix-specific paths should not be used when running tests on Windows. Modified: clang-tools

[clang-tools-extra] r309295 - [clangd] Don't reverse priorities of completion items.

2017-07-27 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jul 27 10:43:07 2017 New Revision: 309295 URL: http://llvm.org/viewvc/llvm-project?rev=309295&view=rev Log: [clangd] Don't reverse priorities of completion items. Summary: Current algorithm incorrectly provides completion results in a reverse order. Reviewers: krasim

[clang-tools-extra] r322637 - [clangd] Don't crash on LSP calls for non-added files

2018-01-17 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jan 17 04:30:24 2018 New Revision: 322637 URL: http://llvm.org/viewvc/llvm-project?rev=322637&view=rev Log: [clangd] Don't crash on LSP calls for non-added files Summary: We will return errors for non-added files for now. Another alternative for clangd would be to read

r322853 - [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

2018-01-18 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jan 18 07:16:53 2018 New Revision: 322853 URL: http://llvm.org/viewvc/llvm-project?rev=322853&view=rev Log: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse Summary: The new method 'OverridePreamble' allows to override the preamble of any source fil

[clang-tools-extra] r322854 - [clangd] Always use preamble (even stale) for code completion

2018-01-18 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jan 18 07:17:00 2018 New Revision: 322854 URL: http://llvm.org/viewvc/llvm-project?rev=322854&view=rev Log: [clangd] Always use preamble (even stale) for code completion Summary: This improves performance of code completion, because we avoid stating the files from the

r323133 - [CodeComplete] Fix completion in the middle of idents in macro calls

2018-01-22 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jan 22 09:18:28 2018 New Revision: 323133 URL: http://llvm.org/viewvc/llvm-project?rev=323133&view=rev Log: [CodeComplete] Fix completion in the middle of idents in macro calls Summary: This patch removes IdentifierInfo from completion token after remembering the ident

r323195 - [Tooling] Added a VFS parameter to ClangTool

2018-01-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jan 23 04:30:02 2018 New Revision: 323195 URL: http://llvm.org/viewvc/llvm-project?rev=323195&view=rev Log: [Tooling] Added a VFS parameter to ClangTool Summary: The parameter overrides the underlying vfs used by ClangTool for filesystem operations. Patch by Vladimir

[clang-tools-extra] r323196 - [clang-tidy] Add -vfsoverlay flag

2018-01-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jan 23 04:31:06 2018 New Revision: 323196 URL: http://llvm.org/viewvc/llvm-project?rev=323196&view=rev Log: [clang-tidy] Add -vfsoverlay flag Summary: It allows to remap and override files and directories on disk when running clang-tidy. The intended use case for the f

[clang-tools-extra] r323204 - [clangd] Simplify code handling compile commands

2018-01-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Jan 23 07:07:52 2018 New Revision: 323204 URL: http://llvm.org/viewvc/llvm-project?rev=323204&view=rev Log: [clangd] Simplify code handling compile commands Summary: CppFile can now change compilation arguments during rebuild. This allows simplifying code that manages

[clang-tools-extra] r323420 - [clangd] Moved caching of compile commands to ClangdServer

2018-01-25 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jan 25 06:19:21 2018 New Revision: 323420 URL: http://llvm.org/viewvc/llvm-project?rev=323420&view=rev Log: [clangd] Moved caching of compile commands to ClangdServer Summary: It allows to get rid of CppFile::getLastCommand and simplify the code in the upcoming threadi

[clang-tools-extra] r323423 - [clangd] Added forgotten files

2018-01-25 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jan 25 06:29:29 2018 New Revision: 323423 URL: http://llvm.org/viewvc/llvm-project?rev=323423&view=rev Log: [clangd] Added forgotten files Added: clang-tools-extra/trunk/clangd/CompileArgsCache.cpp clang-tools-extra/trunk/clangd/CompileArgsCache.h Added: clang

[clang-tools-extra] r323424 - [clangd] Fixed the file comment of new file. NFC

2018-01-25 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jan 25 06:30:46 2018 New Revision: 323424 URL: http://llvm.org/viewvc/llvm-project?rev=323424&view=rev Log: [clangd] Fixed the file comment of new file. NFC Modified: clang-tools-extra/trunk/clangd/CompileArgsCache.cpp Modified: clang-tools-extra/trunk/clangd/Comp

[clang-tools-extra] r323425 - [clangd] Provide a helper to report estimated memory usage per-file

2018-01-25 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Jan 25 06:32:21 2018 New Revision: 323425 URL: http://llvm.org/viewvc/llvm-project?rev=323425&view=rev Log: [clangd] Provide a helper to report estimated memory usage per-file Reviewers: sammccall, ioeric, hokein Reviewed By: ioeric Subscribers: klimek, cfe-commits,

[clang-tools-extra] r323652 - [clangd] Fixed null deference on invalid compile commands.

2018-01-29 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jan 29 06:30:28 2018 New Revision: 323652 URL: http://llvm.org/viewvc/llvm-project?rev=323652&view=rev Log: [clangd] Fixed null deference on invalid compile commands. Code building the AST expected that construction of CompilerInstance always succeeds. This is not the

[clang-tools-extra] r323851 - [clangd] Refactored threading in ClangdServer

2018-01-31 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jan 31 00:51:16 2018 New Revision: 323851 URL: http://llvm.org/viewvc/llvm-project?rev=323851&view=rev Log: [clangd] Refactored threading in ClangdServer Summary: We now provide an abstraction of Scheduler that abstracts threading and resource management in ClangdServe

[clang-tools-extra] r323859 - [clangd] Attempt to fix compilation breakage with MSVC.

2018-01-31 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jan 31 01:50:21 2018 New Revision: 323859 URL: http://llvm.org/viewvc/llvm-project?rev=323859&view=rev Log: [clangd] Attempt to fix compilation breakage with MSVC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clangd/C

[clang-tools-extra] r323863 - [clangd] Second attempt to fix MSVC compilation breakage.

2018-01-31 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Jan 31 03:26:43 2018 New Revision: 323863 URL: http://llvm.org/viewvc/llvm-project?rev=323863&view=rev Log: [clangd] Second attempt to fix MSVC compilation breakage. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clangd

[clang-tools-extra] r323992 - [clangd] Log dropped diagnostics.

2018-02-01 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Feb 1 11:06:45 2018 New Revision: 323992 URL: http://llvm.org/viewvc/llvm-project?rev=323992&view=rev Log: [clangd] Log dropped diagnostics. Summary: clangd drops diagnostics coming outside the main file, but it is still useful to see that something went wrong in the

r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

2018-02-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Feb 2 00:40:08 2018 New Revision: 324062 URL: http://llvm.org/viewvc/llvm-project?rev=324062&view=rev Log: [Sema] Add implicit members even for invalid CXXRecordDecls Summary: It should be safe, since other code paths are already generating implicit members even in in

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Ilya Biryukov via cfe-commits
In a single translation unit, yes. In multiple translation units that aren't linked together it's totally fine (may actually refer to different entities). On Fri, Feb 2, 2018 at 1:04 PM Sam McCall wrote: > Yeah this is just a bug in clang's pprinter. I'll fix it. > > If you give multiple C++ na

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Ilya Biryukov via cfe-commits
Exactly. We should make sure we *don't* treat them as the same symbol. But I would expect there USRs to be the same and that's what we use to deduplicate. On Fri, Feb 2, 2018 at 1:45 PM Sam McCall wrote: > Right. And multiple TUs that *are* linked together would be fine too. > But in that case

Re: [PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

2018-02-02 Thread Ilya Biryukov via cfe-commits
At least now we know they might cause problems. Thanks for digging into this. On Fri, Feb 2, 2018 at 1:53 PM Sam McCall wrote: > My intuition was that the USRs would be different, that linkage would > either be included or not included from the USR, but it wouldn't affect > whether the namespac

Re: r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

2018-02-05 Thread Ilya Biryukov via cfe-commits
st.github.com/EricWF/588a361030edeaebbbc1155b8347cab0 > > On Fri, Feb 2, 2018 at 1:40 AM, Ilya Biryukov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ibiryukov >> Date: Fri Feb 2 00:40:08 2018 >> New Revision: 324062 >> >> URL: http://llvm.org/viewvc/llv

[clang-tools-extra] r303063 - Test commit(changed comment)

2017-05-15 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 15 08:50:46 2017 New Revision: 303063 URL: http://llvm.org/viewvc/llvm-project?rev=303063&view=rev Log: Test commit(changed comment) Modified: clang-tools-extra/trunk/clangd/ASTManager.h Modified: clang-tools-extra/trunk/clangd/ASTManager.h URL: http://llvm.o

[clang-tools-extra] r303067 - [ClangD] Refactor clangd into separate components

2017-05-15 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 15 09:17:35 2017 New Revision: 303067 URL: http://llvm.org/viewvc/llvm-project?rev=303067&view=rev Log: [ClangD] Refactor clangd into separate components Summary: Major refactoring to split LSP implementation, Clang API calls and threading(mostly synchronization)

[clang-tools-extra] r303151 - Restored r303067 and fixed failing test.

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 04:38:59 2017 New Revision: 303151 URL: http://llvm.org/viewvc/llvm-project?rev=303151&view=rev Log: Restored r303067 and fixed failing test. Summary: This commit restores r303067(reverted by r303094) and fixes the 'formatting.test' failure. The failure is due

[clang-tools-extra] r303154 - Fixing compilation failures on buildbots.

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 05:06:20 2017 New Revision: 303154 URL: http://llvm.org/viewvc/llvm-project?rev=303154&view=rev Log: Fixing compilation failures on buildbots. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/DraftStore.cpp cla

[clang-tools-extra] r303173 - [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 09:40:30 2017 New Revision: 303173 URL: http://llvm.org/viewvc/llvm-project?rev=303173&view=rev Log: [clangd] Refactor ProtocolHandlers to decouple them from ClangdLSPServer Summary: A refactoring to decouple ProtocolHandlers and Language Server input parsing lo

[clang-tools-extra] r303177 - Added missing includes in clangd to fix the build.

2017-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 16 10:23:55 2017 New Revision: 303177 URL: http://llvm.org/viewvc/llvm-project?rev=303177&view=rev Log: Added missing includes in clangd to fix the build. This commit should fix buildbot failures. Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp

[clang-tools-extra] r303616 - [clangd] Split clangd into library+executable (mainly for unit tests).

2017-05-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 23 03:12:45 2017 New Revision: 303616 URL: http://llvm.org/viewvc/llvm-project?rev=303616&view=rev Log: [clangd] Split clangd into library+executable (mainly for unit tests). Summary: This commit itself doesn't add any unit tests, but one that does will follow shor

r303630 - Allow to use vfs::FileSystem for file accesses inside ASTUnit.

2017-05-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 23 06:37:52 2017 New Revision: 303630 URL: http://llvm.org/viewvc/llvm-project?rev=303630&view=rev Log: Allow to use vfs::FileSystem for file accesses inside ASTUnit. Reviewers: bkramer, krasimir, arphaman, akyrtzi Reviewed By: bkramer Subscribers: klimek, cfe-co

[clang-tools-extra] r303634 - [clangd] Replaced WorkerRequest with std::function...

2017-05-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 23 08:42:59 2017 New Revision: 303634 URL: http://llvm.org/viewvc/llvm-project?rev=303634&view=rev Log: [clangd] Replaced WorkerRequest with std::function... Summary: And implemented a helper function to dump an AST of a file for testing/debugging purposes. Review

[clang-tools-extra] r303636 - [clangd] Added a missing dependency on clangdAST to fix the build

2017-05-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue May 23 08:59:37 2017 New Revision: 303636 URL: http://llvm.org/viewvc/llvm-project?rev=303636&view=rev Log: [clangd] Added a missing dependency on clangdAST to fix the build Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-02-21 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Sorry for losing track of the discussion here. What is the current status here? Should we run another round of testing? Also, I see proposals to land the new behaviour under a flag and have it off by default. If that does not add a lot of complexity, that would definitely

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-07-01 Thread Ilya Biryukov via cfe-commits
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-04 Thread Ilya Biryukov via cfe-commits
@@ -1419,6 +1419,28 @@ is not specified. }]; } +def ExplicitInitDocs : Documentation { + let Category = DocCatField; + let Content = [{ +The ``clang::explicit_init`` attribute indicates that the field must be +initialized explicitly by the caller when the class is construc

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-04 Thread Ilya Biryukov via cfe-commits
@@ -1472,3 +1472,25 @@ template struct Outer { }; }; Outer::Inner outerinner; + +void aggregate() { + struct B { +[[clang::explicit_init]] int f1; + }; + + struct S : B { // expected-warning {{uninitialized}} +int f2; +int f3 [[clang::explicit_init]]; + }; + +

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in templat… (PR #106730)

2024-09-04 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/106730 >From a46885df62ff64f355abb010f778d84309acd10f Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Fri, 23 Aug 2024 17:27:26 +0200 Subject: [PATCH 1/3] [Clang] Add __type_list_dedup builtin to deduplicate

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in templat… (PR #106730)

2024-09-04 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/106730 >From a46885df62ff64f355abb010f778d84309acd10f Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Fri, 23 Aug 2024 17:27:26 +0200 Subject: [PATCH 1/3] [Clang] Add __type_list_dedup builtin to deduplicate

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in templat… (PR #106730)

2024-09-04 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov ready_for_review https://github.com/llvm/llvm-project/pull/106730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-04 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/106730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-04 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/106730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-04 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/106730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-04 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: I still need to add code that preserves source locations for template arguments and tests for it, but otherwise this is ready for review and I would like to get some initial feedback. The RFC did not get any comments so far, but also happy to discuss the general design th

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-09-06 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: @ChuanqiXu9 thanks for taking a look! Makes sense to give others a chance to chime in, I will wait for more comments. https://github.com/llvm/llvm-project/pull/88893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-09-06 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > To better understand the motivation, I have two questions: > > * Why do you give Clang module maps describing modules that are already > described in PCM files? Unless the module map describes some other top-level > module that's yet to be built, the information it provi

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/102040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: I think there are some good parallel disscussions happening in the RFC, but despite their outcomes, we could probably update the PR to capture current behavior in those interesting cases. I left a few comments along those lines, PTAL. https://githu

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
@@ -1472,3 +1472,25 @@ template struct Outer { }; }; Outer::Inner outerinner; + +void aggregate() { ilya-biryukov wrote: Could we add examples from @AaronBallman's [RFC comment](https://discourse.llvm.org/t/rfc-add-clang-attribute-to-ensure-that-fields-are-

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-09-09 Thread Ilya Biryukov via cfe-commits
@@ -2133,6 +2142,18 @@ void CXXRecordDecl::completeDefinition(CXXFinalOverriderMap *FinalOverriders) { for (conversion_iterator I = conversion_begin(), E = conversion_end(); I != E; ++I) I.setAccess((*I)->getAccess()); + + ASTContext &Context = getASTContext(); +

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-10 Thread Ilya Biryukov via cfe-commits
@@ -309,7 +309,10 @@ enum BuiltinTemplateKind : int { BTK__make_integer_seq, /// This names the __type_pack_element BuiltinTemplateDecl. - BTK__type_pack_element + BTK__type_pack_element, + + /// This names the __type_list_dedup BuiltinTemplateDecl. + BTK__type_list_de

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-10 Thread Ilya Biryukov via cfe-commits
@@ -309,7 +309,10 @@ enum BuiltinTemplateKind : int { BTK__make_integer_seq, /// This names the __type_pack_element BuiltinTemplateDecl. - BTK__type_pack_element + BTK__type_pack_element, + + /// This names the __type_list_dedup BuiltinTemplateDecl. + BTK__type_list_de

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-10 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/106730 >From a46885df62ff64f355abb010f778d84309acd10f Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Fri, 23 Aug 2024 17:27:26 +0200 Subject: [PATCH 1/5] [Clang] Add __type_list_dedup builtin to deduplicate

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-10 Thread Ilya Biryukov via cfe-commits
@@ -38,9 +40,11 @@ #include "clang/Sema/Template.h" #include "clang/Sema/TemplateDeduction.h" #include "llvm/ADT/BitVector.h" +#include "llvm/ADT/DenseSet.h" #include "llvm/ADT/SmallBitVector.h" #include "llvm/ADT/SmallString.h" #include "llvm/ADT/StringExtras.h" +#include "

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: Sorry for not looking closer yet, but could we get a test case? It would make it much easier to review this change. https://github.com/llvm/llvm-project/pull/108197 ___ cfe-commits mailing list cfe-commits@li

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Other than the test, the idea of the change does seem correct, here's the relevant comment from `Sema.h`: ```cpp /// The current index into pack expansion arguments that will be /// used for substitution of parameter packs. /// /// The pack expansion index will be -1 to indi

<    3   4   5   6   7   8   9   10   11   12   >