[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
@@ -11220,6 +11220,11 @@ class Sema final { VarDecl *buildCoroutinePromise(SourceLocation Loc); void CheckCompletedCoroutineBody(FunctionDecl *FD, Stmt *&Body); + // Heuristically tells if the function is get_return_object by matching ilya-biryukov wrote:

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
@@ -15841,13 +15841,24 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) { << FixItHint::CreateInsertion(P.first, "self->"); } +bool Sema::IsGetReturnObject(const FunctionDecl *FD) { + return isa(FD) && FD->param_empty() && ilya-biryukov wrote:

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-17 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Thanks for the patch! https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-18 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: We saw some failures internally with this patch: - ` "'absl::AnyInvocable' has different definitions in different modules;". ` Probably related to the template arguments stability you mention. - `"No type named 'MemberType' in 'some_object::Traits'"`. I suspect that's e

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-19 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-19 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov requested changes to this pull request. https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-19 Thread Ilya Biryukov via cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-19 Thread Ilya Biryukov via cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-20 Thread Ilya Biryukov via cfe-commits
@@ -37,6 +37,25 @@ These changes are ones which we think may surprise users when upgrading to Clang |release| because of the opportunity they pose for disruption to existing code bases. +- Fix a bug in reversed argument for templated operators. + This breaks code in C++20 wh

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-20 Thread Ilya Biryukov via cfe-commits
@@ -10085,10 +10085,14 @@ getImplicitObjectParamType(ASTContext &Context, const FunctionDecl *F) { return M->getFunctionObjectParameterReferenceType(); } -static bool haveSameParameterTypes(ASTContext &Context, const FunctionDecl *F1, +static bool allowAmbiguityWithSelf(AST

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-20 Thread Ilya Biryukov via cfe-commits
@@ -37,6 +37,25 @@ These changes are ones which we think may surprise users when upgrading to Clang |release| because of the opportunity they pose for disruption to existing code bases. +- Fix a bug in reversed argument for templated operators. + This breaks code in C++20 wh

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-20 Thread Ilya Biryukov via cfe-commits
@@ -7688,7 +7688,7 @@ bool Sema::CheckNonDependentConversions( QualType ParamType = ParamTypes[I + Offset]; if (!ParamType->isDependentType()) { unsigned ConvIdx = PO == OverloadCandidateParamOrder::Reversed - ? 0 +

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-20 Thread Ilya Biryukov via cfe-commits
@@ -7688,7 +7688,7 @@ bool Sema::CheckNonDependentConversions( QualType ParamType = ParamTypes[I + Offset]; if (!ParamType->isDependentType()) { unsigned ConvIdx = PO == OverloadCandidateParamOrder::Reversed - ? 0 +

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-20 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. The change looks good, I believe the comments about potentially redundant checks and naming of the function could be addressed in a follow-up. https://github.com/llvm/llvm-project/pull/69595 ___

[clang] [clang] Handle templated operators with reversed arguments (PR #69595)

2023-10-20 Thread Ilya Biryukov via cfe-commits
@@ -10085,10 +10085,14 @@ getImplicitObjectParamType(ASTContext &Context, const FunctionDecl *F) { return M->getFunctionObjectParameterReferenceType(); } -static bool haveSameParameterTypes(ASTContext &Context, const FunctionDecl *F1, +static bool allowAmbiguityWithSelf(AST

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-23 Thread Ilya Biryukov via cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-23 Thread Ilya Biryukov via cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-23 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Oh, one last thing! @usx95 maybe add a test for the visibility check? Various tests with modules (search for files with the `.cppm` extension in the tests) should give a good starting point. https://github.com/llvm/llvm-project/pull/68922 ___

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov created https://github.com/llvm/llvm-project/pull/69908 `createExpansionLocImpl` has an assert that checks if we ran out of source locations. We have observed this happening on real code and in release builds the assertion does not fire and the compiler just ke

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
@@ -356,6 +356,8 @@ def err_file_modified : Error< "file '%0' modified since it was first processed">, DefaultFatal; def err_file_too_large : Error< "sorry, unsupported: file '%0' is too large for Clang to process">; +def err_expansions_too_large : Error< i

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/69908 >From 6b73e1fbbad1a485ce6266dbd8d3c499956b859a Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Thu, 19 Oct 2023 17:50:38 +0200 Subject: [PATCH 1/2] [SourceManager] Report an error and crash on source lo

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
@@ -663,10 +663,13 @@ SourceManager::createExpansionLocImpl(const ExpansionInfo &Info, return SourceLocation::getMacroLoc(LoadedOffset); } LocalSLocEntryTable.push_back(SLocEntry::get(NextLocalOffset, Info)); - // FIXME: Produce a proper diagnostic for this case. - a

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/69908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/69908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] febf5c9 - [Sema] Change order of displayed overloads in diagnostics

2023-10-23 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-10-23T12:59:59+02:00 New Revision: febf5c97bba7910e796041c9518fce01f31ae826 URL: https://github.com/llvm/llvm-project/commit/febf5c97bba7910e796041c9518fce01f31ae826 DIFF: https://github.com/llvm/llvm-project/commit/febf5c97bba7910e796041c9518fce01f31ae826.diff

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
@@ -663,10 +663,15 @@ SourceManager::createExpansionLocImpl(const ExpansionInfo &Info, return SourceLocation::getMacroLoc(LoadedOffset); } LocalSLocEntryTable.push_back(SLocEntry::get(NextLocalOffset, Info)); - // FIXME: Produce a proper diagnostic for this case. - a

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
@@ -356,6 +356,8 @@ def err_file_modified : Error< "file '%0' modified since it was first processed">, DefaultFatal; def err_file_too_large : Error< "sorry, unsupported: file '%0' is too large for Clang to process">; +def err_expansions_too_large : Error< i

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/69908 >From 6b73e1fbbad1a485ce6266dbd8d3c499956b859a Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Thu, 19 Oct 2023 17:50:38 +0200 Subject: [PATCH 1/4] [SourceManager] Report an error and crash on source lo

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
@@ -663,10 +663,15 @@ SourceManager::createExpansionLocImpl(const ExpansionInfo &Info, return SourceLocation::getMacroLoc(LoadedOffset); } LocalSLocEntryTable.push_back(SLocEntry::get(NextLocalOffset, Info)); - // FIXME: Produce a proper diagnostic for this case. - a

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/69908 >From 6b73e1fbbad1a485ce6266dbd8d3c499956b859a Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Thu, 19 Oct 2023 17:50:38 +0200 Subject: [PATCH 1/5] [SourceManager] Report an error and crash on source lo

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/69908 >From 8767d9b2cbe699d8b160140bf168eca0f82f1c64 Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Thu, 19 Oct 2023 17:50:38 +0200 Subject: [PATCH 1/5] [SourceManager] Report an error and crash on source lo

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: I will land this, but happy to follow up if Aaron or anyone else will have comments. https://github.com/llvm/llvm-project/pull/69908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [Clang] Report an error and crash on source location exhaustion in macros (PR #69908)

2023-10-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov closed https://github.com/llvm/llvm-project/pull/69908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r370033 - [Driver] Add an option for createInvocationFromCommandLine to recover on errors

2019-08-27 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 27 03:02:18 2019 New Revision: 370033 URL: http://llvm.org/viewvc/llvm-project?rev=370033&view=rev Log: [Driver] Add an option for createInvocationFromCommandLine to recover on errors Summary: Previously, it would always return nullptr on any error. This change add

[clang-tools-extra] r370033 - [Driver] Add an option for createInvocationFromCommandLine to recover on errors

2019-08-27 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 27 03:02:18 2019 New Revision: 370033 URL: http://llvm.org/viewvc/llvm-project?rev=370033&view=rev Log: [Driver] Add an option for createInvocationFromCommandLine to recover on errors Summary: Previously, it would always return nullptr on any error. This change add

[clang-tools-extra] r370177 - [clangd] Surface errors from command-line parsing

2019-08-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 28 02:24:55 2019 New Revision: 370177 URL: http://llvm.org/viewvc/llvm-project?rev=370177&view=rev Log: [clangd] Surface errors from command-line parsing Summary: Those errors are exposed at the first character of a file, for a lack of a better place. Previously,

[clang-tools-extra] r370758 - [clangd] Fix a data race in test code

2019-09-03 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Sep 3 06:56:03 2019 New Revision: 370758 URL: http://llvm.org/viewvc/llvm-project?rev=370758&view=rev Log: [clangd] Fix a data race in test code Found by TSan, thanks bkramer for pointing this out. Modified: clang-tools-extra/trunk/clangd/unittests/TUSchedulerTes

r370908 - [Driver] Use shared singleton instance of DriverOptTable

2019-09-04 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Sep 4 07:26:28 2019 New Revision: 370908 URL: http://llvm.org/viewvc/llvm-project?rev=370908&view=rev Log: [Driver] Use shared singleton instance of DriverOptTable Summary: This significantly reduces the time required to run clangd tests, by ~10%. Should also have an

[clang-tools-extra] r370908 - [Driver] Use shared singleton instance of DriverOptTable

2019-09-04 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Sep 4 07:26:28 2019 New Revision: 370908 URL: http://llvm.org/viewvc/llvm-project?rev=370908&view=rev Log: [Driver] Use shared singleton instance of DriverOptTable Summary: This significantly reduces the time required to run clangd tests, by ~10%. Should also have an

r371032 - [Sema] Refactor LookupVisibleDecls. NFC

2019-09-05 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Sep 5 01:59:06 2019 New Revision: 371032 URL: http://llvm.org/viewvc/llvm-project?rev=371032&view=rev Log: [Sema] Refactor LookupVisibleDecls. NFC Summary: We accumulated some configuration parameters for LookupVisibleDecls that are being passed unchanged to recursive

[clang-tools-extra] r371081 - [clangd] Initialize int field to zero. NFC

2019-09-05 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Sep 5 08:30:05 2019 New Revision: 371081 URL: http://llvm.org/viewvc/llvm-project?rev=371081&view=rev Log: [clangd] Initialize int field to zero. NFC To make sure we do not have uninitialized values and undefined behavior. Modified: clang-tools-extra/trunk/clangd

[clang-tools-extra] r371373 - [clangd] Improve output of semantic highlighting tests in case of failures

2019-09-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Sep 9 01:47:05 2019 New Revision: 371373 URL: http://llvm.org/viewvc/llvm-project?rev=371373&view=rev Log: [clangd] Improve output of semantic highlighting tests in case of failures Summary: Instead of matching lists of highlightings, we annotate input code with resul

[clang-tools-extra] r371375 - [clangd] Replace HighlightingKind::NumKinds with LastKind. NFC

2019-09-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Sep 9 01:57:17 2019 New Revision: 371375 URL: http://llvm.org/viewvc/llvm-project?rev=371375&view=rev Log: [clangd] Replace HighlightingKind::NumKinds with LastKind. NFC Summary: The latter simplifies the client code by avoiding the need to handle it as a separate cas

[clang-tools-extra] r371379 - [clangd] Highlight typedefs to template parameters as template parameters

2019-09-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Sep 9 02:37:17 2019 New Revision: 371379 URL: http://llvm.org/viewvc/llvm-project?rev=371379&view=rev Log: [clangd] Highlight typedefs to template parameters as template parameters Summary: Template parameters were handled outside `addType`, this led to lack of highl

[clang-tools-extra] r371402 - [clangd] Add a new highlighting kind for typedefs

2019-09-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Sep 9 07:33:10 2019 New Revision: 371402 URL: http://llvm.org/viewvc/llvm-project?rev=371402&view=rev Log: [clangd] Add a new highlighting kind for typedefs Summary: We still attempt to highlight them as underlying types, but fallback to the generic 'typedef' highligh

[clang-tools-extra] r371408 - [clangd] Use pre-populated mappings for standard symbols

2019-09-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Sep 9 08:32:51 2019 New Revision: 371408 URL: http://llvm.org/viewvc/llvm-project?rev=371408&view=rev Log: [clangd] Use pre-populated mappings for standard symbols Summary: This takes ~5% of time when running clangd unit tests. To achieve this, move mapping of system

[clang-tools-extra] r371422 - [clangd] Attempt to fix failing Windows buildbots.

2019-09-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Sep 9 10:03:49 2019 New Revision: 371422 URL: http://llvm.org/viewvc/llvm-project?rev=371422&view=rev Log: [clangd] Attempt to fix failing Windows buildbots. The assertion is failing on Windows, probably because path separator is different. For the failure see: http

[clang-tools-extra] r309378 - [clangd] Workaround for a test failure on Windows.

2017-07-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Jul 28 05:25:51 2017 New Revision: 309378 URL: http://llvm.org/viewvc/llvm-project?rev=309378&view=rev Log: [clangd] Workaround for a test failure on Windows. Previous workaround (r308959) didn't account for a case when system drive letter is not 'C:'. Modified: c

[clang-tools-extra] r309550 - [clangd] Add ':' to completion trigger characters.

2017-07-31 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jul 31 02:27:52 2017 New Revision: 309550 URL: http://llvm.org/viewvc/llvm-project?rev=309550&view=rev Log: [clangd] Add ':' to completion trigger characters. Summary: Without it we don't get completion requests from VSCode after nested name qualifiers (e.g. after 'std

[clang-tools-extra] r309585 - [clangd] Allow to get vfs::FileSystem used inside codeComplete.

2017-07-31 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Jul 31 10:09:29 2017 New Revision: 309585 URL: http://llvm.org/viewvc/llvm-project?rev=309585&view=rev Log: [clangd] Allow to get vfs::FileSystem used inside codeComplete. Summary: This is useful for managing lifetime of VFS-based caches. Reviewers: bkramer, krasimir

[clang-tools-extra] r309696 - [clangd] Rewrote AST and Preamble management.

2017-08-01 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 1 08:51:38 2017 New Revision: 309696 URL: http://llvm.org/viewvc/llvm-project?rev=309696&view=rev Log: [clangd] Rewrote AST and Preamble management. Summary: The new implementation allows code completion that never waits for AST. Reviewers: bkramer, krasimir, kli

[clang-tools-extra] r309705 - [clangd] Fixed MSVC compilation failures.

2017-08-01 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 1 10:17:37 2017 New Revision: 309705 URL: http://llvm.org/viewvc/llvm-project?rev=309705&view=rev Log: [clangd] Fixed MSVC compilation failures. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h URL:

[clang-tools-extra] r309720 - [clangd] Fix more MSVC compilation failures.

2017-08-01 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 1 11:27:58 2017 New Revision: 309720 URL: http://llvm.org/viewvc/llvm-project?rev=309720&view=rev Log: [clangd] Fix more MSVC compilation failures. It turns out MSVC does not allow non-copyable classes in std::future and std::promise template arguments. Modified:

r309795 - Use VFS operations in FileManager::makeAbsolutePath.

2017-08-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 2 00:25:24 2017 New Revision: 309795 URL: http://llvm.org/viewvc/llvm-project?rev=309795&view=rev Log: Use VFS operations in FileManager::makeAbsolutePath. Summary: It used to call into llvm::sys::fs::make_absolute. Reviewers: akyrtzi, erikjv, bkramer, krasimir,

[clang-tools-extra] r309800 - [clangd] Capitalized descriptions of clangd options. NFC.

2017-08-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 2 01:53:48 2017 New Revision: 309800 URL: http://llvm.org/viewvc/llvm-project?rev=309800&view=rev Log: [clangd] Capitalized descriptions of clangd options. NFC. To follow the style of other options shown on `clangd -help`. Modified: clang-tools-extra/trunk/cl

[clang-tools-extra] r309801 - [clangd] Run clang-format on all clangd sources. NFC.

2017-08-02 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 2 02:08:39 2017 New Revision: 309801 URL: http://llvm.org/viewvc/llvm-project?rev=309801&view=rev Log: [clangd] Run clang-format on all clangd sources. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-tools-extra/trunk/clangd/ClangdL

Re: [clang-tools-extra] r308721 - [clangd] Specified --gcc-toolchain explicitly in VFS test.

2017-08-03 Thread Ilya Biryukov via cfe-commits
uot; in CDB.ExtraClangFlags will fix. > How do you think? > > > On Fri, Jul 21, 2017 at 5:21 PM Ilya Biryukov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ibiryukov >> Date: Fri Jul 21 01:20:47 2017 >> New Revision: 308721 >>

[clang-tools-extra] r310470 - [clangd] Fixed a bug in make_tagged.

2017-08-09 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed Aug 9 05:55:13 2017 New Revision: 310470 URL: http://llvm.org/viewvc/llvm-project?rev=310470&view=rev Log: [clangd] Fixed a bug in make_tagged. It accidentally std::move'd from Value parameter if it deduced to an l-value ref. Modified: clang-tools-extra/trunk/cla

r310618 - Fixed a race condition in PrecompiledPreamble.

2017-08-10 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Aug 10 09:10:40 2017 New Revision: 310618 URL: http://llvm.org/viewvc/llvm-project?rev=310618&view=rev Log: Fixed a race condition in PrecompiledPreamble. Summary: Two PrecompiledPreambles, used in parallel on separate threads, could be writing preamble to the same tem

[clang-tools-extra] r310818 - [clangd] Fixed a data race.

2017-08-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 14 01:17:24 2017 New Revision: 310818 URL: http://llvm.org/viewvc/llvm-project?rev=310818&view=rev Log: [clangd] Fixed a data race. Summary: Calling addDocument after removeDocument could have resulted in an invalid program state (AST and Preamble for the valid doc

[clang-tools-extra] r310819 - [clangd] Check if CompileCommand has changed on forceReparse.

2017-08-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 14 01:37:32 2017 New Revision: 310819 URL: http://llvm.org/viewvc/llvm-project?rev=310819&view=rev Log: [clangd] Check if CompileCommand has changed on forceReparse. Reviewers: krasimir, bkramer, klimek Reviewed By: klimek Subscribers: cfe-commits Differential R

[clang-tools-extra] r310821 - [clangd] Use multiple working threads in clangd.

2017-08-14 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 14 01:45:47 2017 New Revision: 310821 URL: http://llvm.org/viewvc/llvm-project?rev=310821&view=rev Log: [clangd] Use multiple working threads in clangd. Reviewers: bkramer, krasimir, klimek Reviewed By: klimek Subscribers: arphaman, cfe-commits Differential Revi

r311330 - Fixed a crash on replaying Preamble's PP conditional stack.

2017-08-21 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon Aug 21 05:03:08 2017 New Revision: 311330 URL: http://llvm.org/viewvc/llvm-project?rev=311330&view=rev Log: Fixed a crash on replaying Preamble's PP conditional stack. Summary: The crash occurs when the first token after a preamble is a macro expansion. Fixed by moving

[clang-tools-extra] r311436 - [clangd] Updated ClangdServer comments. NFC.

2017-08-22 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Aug 22 02:16:46 2017 New Revision: 311436 URL: http://llvm.org/viewvc/llvm-project?rev=311436&view=rev Log: [clangd] Updated ClangdServer comments. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.h Modified: clang-tools-extra/trunk/clangd/ClangdServer.h

[clang] 04f627f - [Syntax] Build spanning SimpleDecalration for classes, structs, etc

2020-01-03 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2020-01-03T12:33:11+01:00 New Revision: 04f627f6b9aeda924a83e75d281ab27a546d3515 URL: https://github.com/llvm/llvm-project/commit/04f627f6b9aeda924a83e75d281ab27a546d3515 DIFF: https://github.com/llvm/llvm-project/commit/04f627f6b9aeda924a83e75d281ab27a546d3515.diff

[clang] 759c904 - [Syntax] Update comment, remove stale FIXME. NFC

2020-01-09 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2020-01-10T08:15:18+01:00 New Revision: 759c90456d418ffe69e1a2b4bcea2792491a6b5a URL: https://github.com/llvm/llvm-project/commit/759c90456d418ffe69e1a2b4bcea2792491a6b5a DIFF: https://github.com/llvm/llvm-project/commit/759c90456d418ffe69e1a2b4bcea2792491a6b5a.diff

[clang] 57a51b6 - [CodeComplete] Suggest 'return nullptr' in functions returning pointers

2020-01-10 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2020-01-10T13:28:13+01:00 New Revision: 57a51b689e7b99c694a028104b0b5a69b80fd002 URL: https://github.com/llvm/llvm-project/commit/57a51b689e7b99c694a028104b0b5a69b80fd002 DIFF: https://github.com/llvm/llvm-project/commit/57a51b689e7b99c694a028104b0b5a69b80fd002.diff

[clang] 3b929fe - [Syntax] Assert invariants on tree structure and fix a bug in mutations

2020-01-14 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2020-01-14T16:31:08+01:00 New Revision: 3b929fe7763570fc1d4a4691a53257a4a0b7760e URL: https://github.com/llvm/llvm-project/commit/3b929fe7763570fc1d4a4691a53257a4a0b7760e DIFF: https://github.com/llvm/llvm-project/commit/3b929fe7763570fc1d4a4691a53257a4a0b7760e.diff

[clang] 07a4101 - [Syntax] Mark synthesized nodes as modifiable

2020-01-14 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2020-01-14T16:41:09+01:00 New Revision: 07a41018e9d27f67f7b4295eb7e00e0345c0aacf URL: https://github.com/llvm/llvm-project/commit/07a41018e9d27f67f7b4295eb7e00e0345c0aacf DIFF: https://github.com/llvm/llvm-project/commit/07a41018e9d27f67f7b4295eb7e00e0345c0aacf.diff

[clang] 013c07f - [Syntax] Unset IsOriginal flag on nodes removed from the tree

2020-01-14 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2020-01-14T17:00:33+01:00 New Revision: 013c07f697886649b068cd97127e528b4fe7c03e URL: https://github.com/llvm/llvm-project/commit/013c07f697886649b068cd97127e528b4fe7c03e DIFF: https://github.com/llvm/llvm-project/commit/013c07f697886649b068cd97127e528b4fe7c03e.diff

[clang] fba88ad - [Sema] Always perform ADL when searching for transormed operators in C++20

2022-08-12 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2022-08-12T16:07:02+02:00 New Revision: fba88adc8961fc8b8d7dece7bfecbfc31c652aff URL: https://github.com/llvm/llvm-project/commit/fba88adc8961fc8b8d7dece7bfecbfc31c652aff DIFF: https://github.com/llvm/llvm-project/commit/fba88adc8961fc8b8d7dece7bfecbfc31c652aff.diff

[clang] 7aa3270 - [clang] Add cxx scope if needed for requires clause.

2022-08-26 Thread Ilya Biryukov via cfe-commits
Author: Luke Nihlen Date: 2022-08-26T10:15:54+02:00 New Revision: 7aa3270622f495ce1209aeca83a3b216889ccab4 URL: https://github.com/llvm/llvm-project/commit/7aa3270622f495ce1209aeca83a3b216889ccab4 DIFF: https://github.com/llvm/llvm-project/commit/7aa3270622f495ce1209aeca83a3b216889ccab4.diff L

[clang] 5fef4c6 - [clang] NFC. Small tweak to release notes

2022-08-26 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2022-08-26T10:17:44+02:00 New Revision: 5fef4c6d397cbf9d6a41d42299b55b0cfddc7d12 URL: https://github.com/llvm/llvm-project/commit/5fef4c6d397cbf9d6a41d42299b55b0cfddc7d12 DIFF: https://github.com/llvm/llvm-project/commit/5fef4c6d397cbf9d6a41d42299b55b0cfddc7d12.diff

[clang-tools-extra] 453c287 - [include-cleaner] Add dependency to fix build with shared libraries

2022-11-09 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2022-11-09T18:31:14+01:00 New Revision: 453c2879cb2ad6c46267ef8f39f0274aed69d9ee URL: https://github.com/llvm/llvm-project/commit/453c2879cb2ad6c46267ef8f39f0274aed69d9ee DIFF: https://github.com/llvm/llvm-project/commit/453c2879cb2ad6c46267ef8f39f0274aed69d9ee.diff

[clang] 342e649 - [Sema] Fix assertion failure when instantiating requires expression

2022-06-23 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2022-06-23T16:20:30+02:00 New Revision: 342e64979afe0b3859462397c4a8abba6faa9de0 URL: https://github.com/llvm/llvm-project/commit/342e64979afe0b3859462397c4a8abba6faa9de0 DIFF: https://github.com/llvm/llvm-project/commit/342e64979afe0b3859462397c4a8abba6faa9de0.diff

[clang-tools-extra] afbe3ae - [clangd] Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

2022-06-09 Thread Ilya Biryukov via cfe-commits
Author: Paul Pluzhnikov Date: 2022-06-09T12:18:39+02:00 New Revision: afbe3aed4986300ee2cdbb5c0303bee172c2731b URL: https://github.com/llvm/llvm-project/commit/afbe3aed4986300ee2cdbb5c0303bee172c2731b DIFF: https://github.com/llvm/llvm-project/commit/afbe3aed4986300ee2cdbb5c0303bee172c2731b.dif

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

2023-09-25 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov created https://github.com/llvm/llvm-project/pull/67307 By ensuring the base is only visited once. This avoids infinite recursion and expontential running times in some corner cases. See the added tests for examples. Apart from the cases that caused infinite r

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

2023-09-25 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/67307 >From bd300e3bf41df7cc90e4d4acf5e46da9847be46a Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Mon, 25 Sep 2023 11:46:03 +0200 Subject: [PATCH 1/2] [ASTMatchers] Fix classIsDerivedFrom for recusrive case

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

2023-09-25 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov closed https://github.com/llvm/llvm-project/pull/67307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] d703dcd - [AST] Fix crash in evaluation of OpaqueExpr in Clangd

2023-08-28 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2023-08-28T17:10:44+02:00 New Revision: d703dcdfb08dbd591589a12e0ca0852c5fd30a72 URL: https://github.com/llvm/llvm-project/commit/d703dcdfb08dbd591589a12e0ca0852c5fd30a72 DIFF: https://github.com/llvm/llvm-project/commit/d703dcdfb08dbd591589a12e0ca0852c5fd30a72.diff

[clang-tools-extra] db335d0 - [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr

2022-11-25 Thread Ilya Biryukov via cfe-commits
Author: Jens Massberg Date: 2022-11-25T15:45:37+01:00 New Revision: db335d02a5e7d98c24f7006e42129856ba1cd695 URL: https://github.com/llvm/llvm-project/commit/db335d02a5e7d98c24f7006e42129856ba1cd695 DIFF: https://github.com/llvm/llvm-project/commit/db335d02a5e7d98c24f7006e42129856ba1cd695.diff

[clang-tools-extra] 733777a - [clangd] Fix namespace aliases in findExplicitReferences

2019-10-31 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-10-31T13:35:25+01:00 New Revision: 733777a81662c40960e9298bb59da8c39a14f8d5 URL: https://github.com/llvm/llvm-project/commit/733777a81662c40960e9298bb59da8c39a14f8d5 DIFF: https://github.com/llvm/llvm-project/commit/733777a81662c40960e9298bb59da8c39a14f8d5.diff

[clang] 9ba1661 - [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

2019-11-04 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-04T17:07:53+01:00 New Revision: 9ba16615fa07c586965b1fa2dc6e88f13fe8031d URL: https://github.com/llvm/llvm-project/commit/9ba16615fa07c586965b1fa2dc6e88f13fe8031d DIFF: https://github.com/llvm/llvm-project/commit/9ba16615fa07c586965b1fa2dc6e88f13fe8031d.diff

[clang-tools-extra] 87e0cb4 - [clangd] Implement semantic highlightings via findExplicitReferences

2019-11-05 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-05T19:15:24+01:00 New Revision: 87e0cb4f1ad299c87c3e26676a9b31b3caf58921 URL: https://github.com/llvm/llvm-project/commit/87e0cb4f1ad299c87c3e26676a9b31b3caf58921 DIFF: https://github.com/llvm/llvm-project/commit/87e0cb4f1ad299c87c3e26676a9b31b3caf58921.diff

[clang] 96065cf - [Syntax] Silence "unused function" warning in no-assert builds. NFC

2019-11-07 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-07T09:37:25+01:00 New Revision: 96065cf79ff76d5fd4fdaeb2fb2650074b3e0e51 URL: https://github.com/llvm/llvm-project/commit/96065cf79ff76d5fd4fdaeb2fb2650074b3e0e51 DIFF: https://github.com/llvm/llvm-project/commit/96065cf79ff76d5fd4fdaeb2fb2650074b3e0e51.diff

[clang-tools-extra] 0019684 - [clangd] Set RetainCommentsFromSystemHeaders to true

2019-11-07 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-07T09:54:20+01:00 New Revision: 0019684900491f517f3b08b4fa92740b69a8cc0f URL: https://github.com/llvm/llvm-project/commit/0019684900491f517f3b08b4fa92740b69a8cc0f DIFF: https://github.com/llvm/llvm-project/commit/0019684900491f517f3b08b4fa92740b69a8cc0f.diff

[clang-tools-extra] dec8d8d - [clangd] Add unit tests for comments in system headers

2019-11-07 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-07T10:24:27+01:00 New Revision: dec8d8d3f205268712a928d106ff2e6f799f7a9b URL: https://github.com/llvm/llvm-project/commit/dec8d8d3f205268712a928d106ff2e6f799f7a9b DIFF: https://github.com/llvm/llvm-project/commit/dec8d8d3f205268712a928d106ff2e6f799f7a9b.diff

[clang-tools-extra] b4f46a9 - [clangd] Fixes colon escaping on Windows

2019-11-11 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-11T09:21:25+01:00 New Revision: b4f46a9bb42972e663f8b7b4d15e4c8ed3fecef4 URL: https://github.com/llvm/llvm-project/commit/b4f46a9bb42972e663f8b7b4d15e4c8ed3fecef4 DIFF: https://github.com/llvm/llvm-project/commit/b4f46a9bb42972e663f8b7b4d15e4c8ed3fecef4.diff

[clang-tools-extra] 5a9547b - [clangd] Simplify the code in Index::refs

2019-11-14 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-14T14:43:29+01:00 New Revision: 5a9547b007090cf9c082ac84490310ee26d8b338 URL: https://github.com/llvm/llvm-project/commit/5a9547b007090cf9c082ac84490310ee26d8b338 DIFF: https://github.com/llvm/llvm-project/commit/5a9547b007090cf9c082ac84490310ee26d8b338.diff

[clang-tools-extra] b5135a8 - [clangd] Fix a crash in expected types

2019-11-20 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-20T16:40:28+01:00 New Revision: b5135a86e04761577494c70e7c0057136cc90b5b URL: https://github.com/llvm/llvm-project/commit/b5135a86e04761577494c70e7c0057136cc90b5b DIFF: https://github.com/llvm/llvm-project/commit/b5135a86e04761577494c70e7c0057136cc90b5b.diff

[clang-tools-extra] 339502c - [clangd] Reland b5135a86e0476: Fix a crash in expected types

2019-11-21 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-21T09:46:40+01:00 New Revision: 339502cc8abb375e3dc8b5d3e9ef35c2541ccbbd URL: https://github.com/llvm/llvm-project/commit/339502cc8abb375e3dc8b5d3e9ef35c2541ccbbd DIFF: https://github.com/llvm/llvm-project/commit/339502cc8abb375e3dc8b5d3e9ef35c2541ccbbd.diff

[clang] ba6f906 - [Driver] Use VFS to check if sanitizer blacklists exist

2019-11-21 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-21T11:00:30+01:00 New Revision: ba6f906854263375cff3257d22d241a8a259cf77 URL: https://github.com/llvm/llvm-project/commit/ba6f906854263375cff3257d22d241a8a259cf77 DIFF: https://github.com/llvm/llvm-project/commit/ba6f906854263375cff3257d22d241a8a259cf77.diff

[clang] 9f3fdb0 - Revert "[Driver] Use VFS to check if sanitizer blacklists exist"

2019-11-21 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-21T11:31:14+01:00 New Revision: 9f3fdb0d7fab73083e354768eb5808597474e1b8 URL: https://github.com/llvm/llvm-project/commit/9f3fdb0d7fab73083e354768eb5808597474e1b8 DIFF: https://github.com/llvm/llvm-project/commit/9f3fdb0d7fab73083e354768eb5808597474e1b8.diff

[clang] aa981c1 - Reland 9f3fdb0d7fab: [Driver] Use VFS to check if sanitizer blacklists exist

2019-11-21 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-21T11:56:09+01:00 New Revision: aa981c1802d7353c777e399f2568e5a0e12dea21 URL: https://github.com/llvm/llvm-project/commit/aa981c1802d7353c777e399f2568e5a0e12dea21 DIFF: https://github.com/llvm/llvm-project/commit/aa981c1802d7353c777e399f2568e5a0e12dea21.diff

[clang] 2e298a6 - [Driver] Fix a shadowing warning. NFC

2019-11-21 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-21T12:21:20+01:00 New Revision: 2e298a6a51065a25240d15872cb350e0761ea04d URL: https://github.com/llvm/llvm-project/commit/2e298a6a51065a25240d15872cb350e0761ea04d DIFF: https://github.com/llvm/llvm-project/commit/2e298a6a51065a25240d15872cb350e0761ea04d.diff

[clang] def65bb - [Syntax] Remove unused parameter from `TreeBuilder::markChildToken`. NFC

2019-11-29 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-29T09:45:06+01:00 New Revision: def65bb4f5bc87588fa6f849225397c21dcefb2b URL: https://github.com/llvm/llvm-project/commit/def65bb4f5bc87588fa6f849225397c21dcefb2b DIFF: https://github.com/llvm/llvm-project/commit/def65bb4f5bc87588fa6f849225397c21dcefb2b.diff

[clang] 302cb3b - [Syntax] Add a comment explaining the pointer keys in std::map. NFC

2019-11-29 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-29T09:49:24+01:00 New Revision: 302cb3bc3d7220e09f5dced64ddfdda33b9c49f9 URL: https://github.com/llvm/llvm-project/commit/302cb3bc3d7220e09f5dced64ddfdda33b9c49f9 DIFF: https://github.com/llvm/llvm-project/commit/302cb3bc3d7220e09f5dced64ddfdda33b9c49f9.diff

[clang] 4b24ab1 - [AST] Remove unused and undefined `TypeLoc::IgnoreMacroDefinitions` function. NFC

2019-11-29 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2019-11-29T11:21:07+01:00 New Revision: 4b24ab181aef58c6e2001e630331385648db3c08 URL: https://github.com/llvm/llvm-project/commit/4b24ab181aef58c6e2001e630331385648db3c08 DIFF: https://github.com/llvm/llvm-project/commit/4b24ab181aef58c6e2001e630331385648db3c08.diff

<    2   3   4   5   6   7   8   9   10   11   >