.llvm.org/D56446 should fix this.
>>>>>>
>>>>>> On Tue, Jan 8, 2019 at 5:12 PM Nico Weber
>>>>>> wrote:
>>>>>>
>>>>>>> It looks like clang now looks for libc++ headers
>>>>>>> in -
Author: ibiryukov
Date: Tue Jan 29 07:52:05 2019
New Revision: 352509
URL: http://llvm.org/viewvc/llvm-project?rev=352509&view=rev
Log:
[clangd] Make -clang-tidy-checks a non-hidden command-line arg
Summary:
This looks like a useful user-facing configuration parameter,
which should be discoverabl
Author: ibiryukov
Date: Tue Jan 29 07:57:14 2019
New Revision: 352510
URL: http://llvm.org/viewvc/llvm-project?rev=352510&view=rev
Log:
[clangd] Attempt to fix failing buildbots after r352494
For failures see:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/38501/steps/build-
Author: ibiryukov
Date: Tue Jan 29 08:04:39 2019
New Revision: 352511
URL: http://llvm.org/viewvc/llvm-project?rev=352511&view=rev
Log:
[clangd] Remove extra ';' to fix -Wpedantic warning. NFC
Modified:
clang-tools-extra/trunk/clangd/refactor/Tweak.cpp
Modified: clang-tools-extra/trunk/clang
d is identical.
>
> Attaching logs with gcc and clang.
>
> Any idea what the problem is?
>
> Regards,
> Mikael
>
> On 1/29/19 3:17 PM, Ilya Biryukov via cfe-commits wrote:
> > Author: ibiryukov
> > Date: Tue Jan 29 06:17:36 2019
> > New Revision: 352494
&
Author: ibiryukov
Date: Wed Jan 30 01:39:01 2019
New Revision: 352612
URL: http://llvm.org/viewvc/llvm-project?rev=352612&view=rev
Log:
[clangd] Fix a use after move
Introduced in r352494.
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
Modified: clang-tools-extra/trunk/clangd/
fore this patch the output from gcc and clang built clangd is identical.
>>
>> Attaching logs with gcc and clang.
>>
>> Any idea what the problem is?
>>
>> Regards,
>> Mikael
>>
>> On 1/29/19 3:17 PM, Ilya Biryukov via cfe-commits wrote:
>> >
Author: ibiryukov
Date: Wed Jan 30 06:24:17 2019
New Revision: 352624
URL: http://llvm.org/viewvc/llvm-project?rev=352624&view=rev
Log:
[clangd] Drop fixes if replying with tweaks resulted in an error
This should not happen in normal operation, as it implies that the diagnostics
with some availab
Author: ibiryukov
Date: Thu Jan 31 12:20:32 2019
New Revision: 352788
URL: http://llvm.org/viewvc/llvm-project?rev=352788&view=rev
Log:
[CodeComplete] Propagate preferred types through parser in more cases
Preferred types are used by code completion for ranking. This commit
considerably increases
Author: ibiryukov
Date: Thu Jan 31 13:30:05 2019
New Revision: 352796
URL: http://llvm.org/viewvc/llvm-project?rev=352796&view=rev
Log:
[clangd] A code action to swap branches of an if statement
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: llvm-commits, mgorny, ioeric, MaskRay, jkor
Author: ibiryukov
Date: Fri Nov 2 03:50:26 2018
New Revision: 345963
URL: http://llvm.org/viewvc/llvm-project?rev=345963&view=rev
Log:
Revert "Fix regression in behavior of clang -x c++-header -fmodule-name=XXX"
This reverts commit r345803 and r345915 (a follow-up fix to r345803).
Reason: r3458
Should be fixed in r346123.
+Kadir Çetinkaya who authored the fix.
On Fri, Nov 2, 2018 at 7:38 PM Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Also one of your resent commits added another broken test to the builder:
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86
Author: ibiryukov
Date: Wed Nov 7 02:02:31 2018
New Revision: 346301
URL: http://llvm.org/viewvc/llvm-project?rev=346301&view=rev
Log:
[CodeComplete] Do not complete self-initializations
Summary:
Removes references to initialized variable from the following completions:
int x = ^;
Handles
Author: ibiryukov
Date: Mon Nov 12 05:55:55 2018
New Revision: 346652
URL: http://llvm.org/viewvc/llvm-project?rev=346652&view=rev
Log:
Make clang-based tools find libc++ on MacOS
Summary:
When they read compiler args from compile_commands.json.
This change allows to run clang-based tools, like c
Author: ibiryukov
Date: Mon Nov 12 05:56:09 2018
New Revision: 346653
URL: http://llvm.org/viewvc/llvm-project?rev=346653&view=rev
Log:
Add a test checking clang-tidy can find libc++ on Mac
Reviewers: sammccall, arphaman, EricWF
Reviewed By: sammccall
Subscribers: christof, cfe-commits
Differe
Will take a look, thanks for the revert.
On Mon, Nov 12, 2018 at 6:13 PM Jonas Devlieghere via Phabricator <
revi...@reviews.llvm.org> wrote:
> JDevlieghere added a comment.
>
> I reverted this because it broke the LLDB bots on GreenDragon:
> http://green.lab.llvm.org/green/view/LLDB/
>
>
> Repos
Author: ibiryukov
Date: Thu Nov 22 07:39:54 2018
New Revision: 347468
URL: http://llvm.org/viewvc/llvm-project?rev=347468&view=rev
Log:
[clangd] Cleanup: make diagnostics callbacks from TUScheduler non-racy
Summary:
Previously, removeDoc followed by an addDoc to TUScheduler resulted in
racy diagn
Author: ibiryukov
Date: Thu Nov 22 08:20:12 2018
New Revision: 347472
URL: http://llvm.org/viewvc/llvm-project?rev=347472&view=rev
Log:
[clangd] Cleanup error consumption code. NFC
- Remove reimplementations of llvm::consumeError.
- Simplify test code by using EXPECT_ERROR where it fits.
Modifie
Author: ibiryukov
Date: Thu Nov 22 09:27:08 2018
New Revision: 347474
URL: http://llvm.org/viewvc/llvm-project?rev=347474&view=rev
Log:
[clangd] Cleanup: make the diags callback global in TUScheduler
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: javed.absar, ioeric, MaskRay, jkorous,
Author: ibiryukov
Date: Fri Nov 23 07:21:19 2018
New Revision: 347498
URL: http://llvm.org/viewvc/llvm-project?rev=347498&view=rev
Log:
[clangd] Add support for hierarchical documentSymbol
Reviewers: ioeric, sammccall, simark
Reviewed By: sammccall
Subscribers: MaskRay, jkorous, arphaman, kadir
Author: ibiryukov
Date: Mon Nov 26 01:57:41 2018
New Revision: 347539
URL: http://llvm.org/viewvc/llvm-project?rev=347539&view=rev
Log:
[clangd] Cleanup after landing documentSymbol. NFC
- fix compile error on older gcc in Protocol.cpp,
- remove redundant 'llvm::' qualifiers from Protocol.cpp,
-
/ninja/1.8.2/SLED11-64/bin/ninja -j1 -C
> build-all all) failed: child exited with value 1
>
>
> A couple of the build bots fail the same way, see e.g:
>
>
>
> http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/5512/steps/build%20stage%201/logs/stdio
>
Author: ibiryukov
Date: Mon Nov 26 07:24:48 2018
New Revision: 347558
URL: http://llvm.org/viewvc/llvm-project?rev=347558&view=rev
Log:
[Index] Expose USR generation for types
Summary: Used in clangd.
Reviewers: sammccall, ioeric
Reviewed By: sammccall
Subscribers: kadircet, cfe-commits
Diffe
Author: ibiryukov
Date: Mon Nov 26 07:25:20 2018
New Revision: 347559
URL: http://llvm.org/viewvc/llvm-project?rev=347559&view=rev
Log:
[clangd] Initial implementation of expected types
Summary:
Provides facilities to model the C++ conversion rules without the AST.
The introduced representation c
Author: ibiryukov
Date: Mon Nov 26 07:29:14 2018
New Revision: 347560
URL: http://llvm.org/viewvc/llvm-project?rev=347560&view=rev
Log:
[clangd] Collect and store expected types in the index
Summary:
And add a hidden option to control whether the types are collected.
For experiments, will be remo
Author: ibiryukov
Date: Mon Nov 26 07:38:01 2018
New Revision: 347562
URL: http://llvm.org/viewvc/llvm-project?rev=347562&view=rev
Log:
[clangd] Add type boosting in code completion
Reviewers: sammccall, ioeric
Reviewed By: sammccall
Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commit
Author: ibiryukov
Date: Mon Nov 26 07:52:16 2018
New Revision: 347563
URL: http://llvm.org/viewvc/llvm-project?rev=347563&view=rev
Log:
[clangd] Fix use-after-free with expected types in indexing
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: clang-tools-extra/t
Author: ibiryukov
Date: Mon Nov 26 07:58:29 2018
New Revision: 347566
URL: http://llvm.org/viewvc/llvm-project?rev=347566&view=rev
Log:
[clangd] Fix compilation of IndexBenchmark
Modified:
clang-tools-extra/trunk/clangd/benchmarks/IndexBenchmark.cpp
Modified: clang-tools-extra/trunk/clangd/b
Author: ibiryukov
Date: Mon Nov 26 09:05:13 2018
New Revision: 347574
URL: http://llvm.org/viewvc/llvm-project?rev=347574&view=rev
Log:
[clangd] Do not drop diagnostics from macros
if they still end up being in the main file.
Modified:
clang-tools-extra/trunk/clangd/Diagnostics.cpp
clang
Author: ibiryukov
Date: Wed Nov 28 06:43:26 2018
New Revision: 347760
URL: http://llvm.org/viewvc/llvm-project?rev=347760&view=rev
Log:
[clang-tidy] Added a test -export-fixes with relative paths.
Summary: A test for D51864.
Reviewers: ioeric, steveire
Reviewed By: steveire
Subscribers: xazax.
I don't have a Windows machine, but I tried it on the VM and couldn't come
up with a combination of flags that breaks it.
Which is weird because the linked stackoverflow question mentions Windows
locks all files on mmap, but that's not what I was seeing.
I'll repeat the experiment.
On Wed, Nov 2
On Thu, Nov 29, 2018 at 4:06 PM Zachary Turner wrote:
> If this is to go in (which I think is still not clear), it definitely
> should be limited to clangd. Not using mapped files is an order of
> magnitude performance regression for many use cases.
>
Absolutely, we have to make sure this does no
Author: ibiryukov
Date: Mon Dec 3 03:26:35 2018
New Revision: 348123
URL: http://llvm.org/viewvc/llvm-project?rev=348123&view=rev
Log:
[clang] Do not read from 'test/SemaCXX/Inputs' inside 'test/AST'
Our integrate relies on test inputs being taken from the same diretory as the
test itself.
Adde
Author: ibiryukov
Date: Mon Dec 3 03:28:17 2018
New Revision: 348124
URL: http://llvm.org/viewvc/llvm-project?rev=348124&view=rev
Log:
[Analysis] Properly prepare test env in test/Analysis/undef-call.c
The test expectes the '%T/ctudir' to be present, but does not create it.
Modified:
cfe/tr
Author: ibiryukov
Date: Mon Dec 3 03:34:08 2018
New Revision: 348125
URL: http://llvm.org/viewvc/llvm-project?rev=348125&view=rev
Log:
[Analyzer] Actually check for -model-path being a directory
The original patch (r348038) clearly contained a typo and checked
for '-ctu-dir' twice.
Modified:
Hi Kristóf,
There is clearly a typo in checking for -ctu-dir and -model-path being a
directory. Instead of checking -model-path, the code was checking for
-ctu-dir twice.
Landed a fix in r348125.
On Fri, Nov 30, 2018 at 10:27 PM Kristof Umann via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
Author: ibiryukov
Date: Mon Dec 3 05:29:17 2018
New Revision: 348135
URL: http://llvm.org/viewvc/llvm-project?rev=348135&view=rev
Log:
[CodeComplete] Cleanup access checking in code completion
Summary: Also fixes a crash (see the added 'accessibility-crash.cpp' test).
Reviewers: ioeric, kadirce
Author: ibiryukov
Date: Mon Dec 3 07:21:49 2018
New Revision: 348147
URL: http://llvm.org/viewvc/llvm-project?rev=348147&view=rev
Log:
[clangd] Avoid memory-mapping files on Windows
Summary:
Memory-mapping files on Windows leads to them being locked and prevents
editors from saving changes to th
No worries, this was easy to fix.
It's impossible to catch those in advance, we miss things like that all the
time.
On Mon, Dec 3, 2018 at 1:19 PM Aaron Ballman wrote:
> On Mon, Dec 3, 2018 at 6:29 AM Ilya Biryukov via cfe-commits
> wrote:
> >
> > Author: ibiryukov
>
Author: ibiryukov
Date: Tue Dec 4 08:30:45 2018
New Revision: 348280
URL: http://llvm.org/viewvc/llvm-project?rev=348280&view=rev
Log:
Revert "Avoid emitting redundant or unusable directories in DIFile metadata
entries."
This reverts commit r348154 and follow-up commits r348211 and r3248213.
Re
Hi!
I had to revert the fix (r348203) in r348280 as this broke our integrate.
Also reverted the original change to avoid having compiler-rt in a broken
state.
Sorry for the inconvenience, see the r348203 thread for more details.
On Tue, Dec 4, 2018 at 12:14 AM Adrian Prantl via cfe-commits <
cfe-
Author: ibiryukov
Date: Wed Dec 5 06:24:14 2018
New Revision: 348365
URL: http://llvm.org/viewvc/llvm-project?rev=348365&view=rev
Log:
Move detection of libc++ include dirs to Driver on MacOS
Summary:
The intention is to make the tools replaying compilations from
'compile_commands.json'
(clang-
Author: ibiryukov
Date: Wed Dec 5 06:24:14 2018
New Revision: 348365
URL: http://llvm.org/viewvc/llvm-project?rev=348365&view=rev
Log:
Move detection of libc++ include dirs to Driver on MacOS
Summary:
The intention is to make the tools replaying compilations from
'compile_commands.json'
(clang-
Author: ibiryukov
Date: Wed Dec 5 09:38:39 2018
New Revision: 348387
URL: http://llvm.org/viewvc/llvm-project?rev=348387&view=rev
Log:
[CodeComplete] Fix a crash in access checks of inner classes
Summary: The crash was introduced in r348135.
Reviewers: kadircet
Reviewed By: kadircet
Subscribe
Just noticed this. Really sorry that I submitted the broken version (made
the rename at the last minute) and many thanks for fixing this!
On Mon, Dec 3, 2018 at 9:01 PM Zachary Turner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: zturner
> Date: Mon Dec 3 11:59:00 2018
> New Rev
Author: ibiryukov
Date: Wed Dec 5 10:32:05 2018
New Revision: 348394
URL: http://llvm.org/viewvc/llvm-project?rev=348394&view=rev
Log:
Mention changes to libc++ include dir lookup in release notes.
Summary: The change itself landed as r348365, see the comment for more details.
Reviewers: arpham
Author: ibiryukov
Date: Thu Dec 6 07:14:11 2018
New Revision: 348490
URL: http://llvm.org/viewvc/llvm-project?rev=348490&view=rev
Log:
[clangd] Remove the test that sometimes deadlocks
Will figure out how to properly rewrite it and recommit.
Modified:
clang-tools-extra/trunk/unittests/clang
Author: ibiryukov
Date: Fri Dec 7 05:17:52 2018
New Revision: 348590
URL: http://llvm.org/viewvc/llvm-project?rev=348590&view=rev
Log:
[CodeComplete] Fix assertion failure
Summary:
...that fires when running completion inside an argument of
UnresolvedMemberExpr (see the added test).
The asserti
Slightly offtopic.
It would be nice to add a way to collect quality during actual completion
sessions, rather than simulated ones.
I'm thinking about clients sending a message to the server mentioning the
completion item user ended up selecting in a completion list (would require
an LSP extension)
Author: ibiryukov
Date: Tue Feb 26 03:01:50 2019
New Revision: 354864
URL: http://llvm.org/viewvc/llvm-project?rev=354864&view=rev
Log:
[CodeComplete] Propagate preferred type for function arguments in more cases
Summary:
See the added test for some new cases.
This change also removes special cod
Author: ibiryukov
Date: Wed Feb 27 02:16:03 2019
New Revision: 354957
URL: http://llvm.org/viewvc/llvm-project?rev=354957&view=rev
Log:
[clangd] Set thread priority on Windows
Reviewers: kadircet, gribozavr
Reviewed By: kadircet, gribozavr
Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-co
Author: ibiryukov
Date: Fri Mar 15 07:00:49 2019
New Revision: 356261
URL: http://llvm.org/viewvc/llvm-project?rev=356261&view=rev
Log:
[clangd] Tune the fuzzy-matching algorithm
Summary:
To reduce the gap between prefix and initialism matches.
The motivation is producing better scoring in one p
Author: ibiryukov
Date: Fri Mar 15 07:30:07 2019
New Revision: 356264
URL: http://llvm.org/viewvc/llvm-project?rev=356264&view=rev
Log:
[clangd] Remove includes of "gmock-matchers.h". NFC
For consistency with most of the test code.
Modified:
clang-tools-extra/trunk/unittests/clangd/ExpectedT
Author: ibiryukov
Date: Fri Mar 22 04:01:13 2019
New Revision: 356743
URL: http://llvm.org/viewvc/llvm-project?rev=356743&view=rev
Log:
[Tooling] Avoid working-dir races in AllTUsToolExecutor
Reviewers: ioeric
Reviewed By: ioeric
Subscribers: jdoerfert, cfe-commits
Tags: #clang
Differential R
Author: ibiryukov
Date: Mon Mar 25 03:15:11 2019
New Revision: 356880
URL: http://llvm.org/viewvc/llvm-project?rev=356880&view=rev
Log:
[clangd] Send empty diagnostics when a file is closed
Summary:
The LSP clients cannot know clangd will not send diagnostic updates
for closed files, so we send t
Author: ibiryukov
Date: Mon Mar 25 09:18:56 2019
New Revision: 356916
URL: http://llvm.org/viewvc/llvm-project?rev=356916&view=rev
Log:
[clangd] Add .cu files to VSCode extension
Summary:
clangd should be able to handle those with a proper compilation
database. However, users using 'nvcc' might s
Thanks for fixing this!
On Mon, Apr 1, 2019 at 11:14 PM Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon Apr 1 14:16:17 2019
> New Revision: 357429
>
> URL: http://llvm.org/viewvc/llvm-project?rev=357429&view=rev
> Log:
> Fix clangd unittest _WIN32 ifd
Author: ibiryukov
Date: Tue Apr 2 01:24:37 2019
New Revision: 357454
URL: http://llvm.org/viewvc/llvm-project?rev=357454&view=rev
Log:
[clangd] Use capacity() instead of size() in RefSlab::bytes()
Patch by Nathan Ridge.
Reviewers: gribozavr
Reviewed By: gribozavr
Subscribers: ilya-biryukov, i
Author: ibiryukov
Date: Wed Apr 3 00:18:43 2019
New Revision: 357561
URL: http://llvm.org/viewvc/llvm-project?rev=357561&view=rev
Log:
[clangd] Return clangd::TextEdit in ClangdServer::rename. NFC
Summary:
Instead of tooling::Replacement. To avoid the need to have contents of
the file at the cal
Replies inline.
On Thu, Apr 11, 2019 at 7:59 PM Sam McCall wrote:
> Thanks - I think there's quite a lot of background missing here:
>
Indeed, here are clarifications.
> what/who is this for,
>
Building the index for clangd without actually running clangd it seems
useful, e.g. for cases when yo
Author: ibiryukov
Date: Mon Apr 15 07:43:50 2019
New Revision: 358414
URL: http://llvm.org/viewvc/llvm-project?rev=358414&view=rev
Log:
Revert r358337: "[CommandLineParser] Add DefaultOption flag"
The change causes test failures under asan. Reverting to unbreak our
integrate.
Modified:
cfe/t
Hi Richard,
This seems to break libc++, found while doing an integrate. The errors are:
In file included from valarray:4:
.../include/c++/v1/valarray:1062:60: error: explicit instantiation
declaration of 'valarray<_Tp>' with internal linkage
_LIBCPP_EXTERN_TEMPLATE(_LIBCPP_FUNC_VIS valarray::vala
Author: ibiryukov
Date: Wed Apr 24 01:50:24 2019
New Revision: 359076
URL: http://llvm.org/viewvc/llvm-project?rev=359076&view=rev
Log:
Revert r359048: C++ DR2387: a variable template declared wthi
The change breaks libc++ with the follwing error:
In file included from valarray:4:
.../include/c+
Reverted in r359076.
On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov wrote:
> Hi Richard,
>
> This seems to break libc++, found while doing an integrate. The errors are:
>
> In file included from valarray:4:
> .../include/c++/v1/valarray:1062:60: error: explicit instantiation
> declaration of 'va
Author: ibiryukov
Date: Thu Apr 25 03:08:31 2019
New Revision: 359179
URL: http://llvm.org/viewvc/llvm-project?rev=359179&view=rev
Log:
[Testing] Move clangd::Annotations to llvm testing support
Summary:
Annotations allow writing nice-looking unit test code when one needs
access to locations from
Author: ibiryukov
Date: Thu Apr 25 03:08:31 2019
New Revision: 359179
URL: http://llvm.org/viewvc/llvm-project?rev=359179&view=rev
Log:
[Testing] Move clangd::Annotations to llvm testing support
Summary:
Annotations allow writing nice-looking unit test code when one needs
access to locations from
Author: ibiryukov
Date: Fri Apr 26 02:36:22 2019
New Revision: 359291
URL: http://llvm.org/viewvc/llvm-project?rev=359291&view=rev
Log:
[clangd] Remove unused ClangdServer::dynamicIndex(). NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.h
Modified: clang-tools-extra/trunk/clangd/Cl
Author: ibiryukov
Date: Fri May 3 01:03:21 2019
New Revision: 359866
URL: http://llvm.org/viewvc/llvm-project?rev=359866&view=rev
Log:
[clangd] Minor code style cleanups in Protocol.h. NFC
- Remove a parameter name that was misspelled (OS used for non-stream
parameter)
- Declare operator == (T
Author: ibiryukov
Date: Mon May 6 03:08:47 2019
New Revision: 360026
URL: http://llvm.org/viewvc/llvm-project?rev=360026&view=rev
Log:
[clangd] Qualify uses of ::testing everywhere. NFC
Add an initial '::' qualifier to all usages of 'testing' namespace that
did not have one.
The goal is to make
Author: ibiryukov
Date: Mon May 6 06:18:00 2019
New Revision: 360042
URL: http://llvm.org/viewvc/llvm-project?rev=360042&view=rev
Log:
[CodeComplete] Add a trailing semicolons to some pattern completions
Summary:
Where semicolon is required in any case. Here's a list of completions
that now have
Author: ibiryukov
Date: Mon May 6 07:56:24 2019
New Revision: 360048
URL: http://llvm.org/viewvc/llvm-project?rev=360048&view=rev
Log:
[CodeComplete] Update python tests after r360042
Modified:
cfe/trunk/bindings/python/tests/cindex/test_code_completion.py
Modified: cfe/trunk/bindings/pytho
Author: ibiryukov
Date: Tue May 7 07:18:18 2019
New Revision: 360151
URL: http://llvm.org/viewvc/llvm-project?rev=360151&view=rev
Log:
[clangd] Introduce intermediate representation of formatted text
Summary: That can render to markdown or plain text. Used for findHover requests.
Reviewers: mal
Author: ibiryukov
Date: Wed May 8 01:52:18 2019
New Revision: 360231
URL: http://llvm.org/viewvc/llvm-project?rev=360231&view=rev
Log:
[clang-tidy] Do not show incorrect fix in modernize-make-unique
Summary:
The case when initialize_list hides behind an implicit case was not
handled before.
Rev
Author: ibiryukov
Date: Thu May 9 05:04:07 2019
New Revision: 360332
URL: http://llvm.org/viewvc/llvm-project?rev=360332&view=rev
Log:
[clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
Summary:
To unify the way we create threads in clangd.
This should simplify landing D50993
Author: ibiryukov
Date: Thu May 9 05:21:28 2019
New Revision: 360336
URL: http://llvm.org/viewvc/llvm-project?rev=360336&view=rev
Log:
[clangd] Fix a TSAN warning in TUSchedulerTests
Modified:
clang-tools-extra/trunk/clangd/unittests/TUSchedulerTests.cpp
Modified: clang-tools-extra/trunk/cl
Author: ibiryukov
Date: Mon Sep 17 00:46:20 2018
New Revision: 342363
URL: http://llvm.org/viewvc/llvm-project?rev=342363&view=rev
Log:
[clang-Format] Fix indentation of member call after block
Summary:
before patch:
> echo "test() {([]() -> {int b = 32;return 3;}).as("");});" | clang-format
> -
Why would we want to serialize the origin?
We only serialize and deserialize for the static index, it does not seem to
be useful to serialize origin in that scenario.
Am I missing something?
On Fri, Sep 21, 2018 at 3:06 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: i
Eric Liu schrieb am Di., 25. Sep. 2018, 01:22:
> On Tue, Sep 25, 2018 at 6:34 AM Ilya Biryukov
> wrote:
>
>> Why would we want to serialize the origin?
>>
> We only serialize and deserialize for the static index, it does not seem
>> to be useful to serialize origin in that scenario.
>>
> We seri
Author: ibiryukov
Date: Tue Sep 25 22:45:31 2018
New Revision: 343066
URL: http://llvm.org/viewvc/llvm-project?rev=343066&view=rev
Log:
[clangd] Handle template args for disabled function arg snippets
Reviewers: kadircet, ioeric, sammccall
Reviewed By: kadircet
Subscribers: MaskRay, jkorous, ar
Author: ibiryukov
Date: Tue Sep 25 22:48:29 2018
New Revision: 343067
URL: http://llvm.org/viewvc/llvm-project?rev=343067&view=rev
Log:
[clangd] Fix crash if pending computations were active on exit
Summary:
Make sure JSONRPCDispatcher outlives the worker threads, they access
its fields to remove
> The downside is probably that all symbols in yaml would have the same
origin, which is a bit redundant but doesn't seem to matter much.
All my comments boil down to this one, but the argument is not only
redundant - it does not make sense design-wise to store an origin in the
serialized static in
Author: ibiryukov
Date: Fri Feb 1 03:20:13 2019
New Revision: 352862
URL: http://llvm.org/viewvc/llvm-project?rev=352862&view=rev
Log:
Disable tidy checks with too many hits
Summary:
Some tidy checks have too many hits in the codebase, making it hard to spot
other results from clang-tidy, theref
Author: ibiryukov
Date: Wed Feb 6 05:47:49 2019
New Revision: 353295
URL: http://llvm.org/viewvc/llvm-project?rev=353295&view=rev
Log:
[clangd] Enable clangd on Objective-C in VSCode
Summary: Thanks to Andreas Ostermeyer for raising this on the mailing list.
Reviewers: hokein
Reviewed By: hoke
Author: ibiryukov
Date: Wed Feb 6 05:53:24 2019
New Revision: 353296
URL: http://llvm.org/viewvc/llvm-project?rev=353296&view=rev
Log:
[clangd] Update dev dependencies of clangd-vscode
Summary:
The version bumps are a result of running `npm audit`, which found
3 security issues in previous versi
Author: ibiryukov
Date: Tue Feb 12 06:21:44 2019
New Revision: 353840
URL: http://llvm.org/viewvc/llvm-project?rev=353840&view=rev
Log:
[Sema] Fix a crash in access checking for deduction guides
Summary: See the added test for a repro.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: c
Author: ibiryukov
Date: Tue Feb 19 08:50:37 2019
New Revision: 354349
URL: http://llvm.org/viewvc/llvm-project?rev=354349&view=rev
Log:
[clangd] Add an option in the code to not display number of fixes
Summary:
Only to the APIs, which are used by our embedders.
We do not plan to add a user-facing
Author: ibiryukov
Date: Wed Feb 20 04:31:44 2019
New Revision: 354456
URL: http://llvm.org/viewvc/llvm-project?rev=354456&view=rev
Log:
[clangd] Fix a typo. NFC
The documentation for -index-file mentioned clang-index instead of
clangd-indexer.
Modified:
clang-tools-extra/trunk/clangd/tool/Cl
Author: ibiryukov
Date: Wed Feb 20 11:08:06 2019
New Revision: 354505
URL: http://llvm.org/viewvc/llvm-project?rev=354505&view=rev
Log:
[clangd] Store index in '.clangd/index' instead of '.clangd-index'
Summary: To take up the .clangd folder for other potential uses in the future.
Reviewers: kad
Author: ibiryukov
Date: Wed Feb 20 11:26:39 2019
New Revision: 354507
URL: http://llvm.org/viewvc/llvm-project?rev=354507&view=rev
Log:
[clangd] Fix a crash in Selection
Summary:
The assertion checking that a range of a node is a token range does
not hold in case of "split" tokens, e.g. between t
Author: ibiryukov
Date: Mon Sep 4 05:28:15 2017
New Revision: 312483
URL: http://llvm.org/viewvc/llvm-project?rev=312483&view=rev
Log:
clangd: Tolerate additional headers
Summary:
The language server protocol specified 2 headers (Content-Length and
Content-Type), but does not specify their sequ
Author: ibiryukov
Date: Fri Sep 8 06:36:38 2017
New Revision: 312788
URL: http://llvm.org/viewvc/llvm-project?rev=312788&view=rev
Log:
Fixed a crash in code completion.
Summary: The crash occured when FunctionDecl was parsed with an initializer.
Reviewers: bkramer, klimek, francisco.lopes
Revi
Author: ibiryukov
Date: Tue Sep 12 01:35:57 2017
New Revision: 313014
URL: http://llvm.org/viewvc/llvm-project?rev=313014&view=rev
Log:
Fix recording preamble's conditional stack in skipped PP branches.
Summary:
This fixes PR34547.
`Lexer::LexEndOfFile` handles recording of ConditionalStack for
p
Author: ibiryukov
Date: Tue Sep 12 06:57:14 2017
New Revision: 313029
URL: http://llvm.org/viewvc/llvm-project?rev=313029&view=rev
Log:
[clangd] Add support for snippet completions
Enhances CompletionItemsCollector in such a way that snippet
completions can be presented to the client. Enable snip
Author: ibiryukov
Date: Wed Sep 20 00:24:15 2017
New Revision: 313730
URL: http://llvm.org/viewvc/llvm-project?rev=313730&view=rev
Log:
[clangd] Introduced Logger interface.
Summary: This fixes a bunch of logging-related FIXMEs.
Reviewers: bkramer, krasimir, malaperle
Reviewed By: malaperle
Su
Author: ibiryukov
Date: Wed Sep 20 03:46:58 2017
New Revision: 313749
URL: http://llvm.org/viewvc/llvm-project?rev=313749&view=rev
Log:
[clangd] Run clang-format on ClangdUnit.cpp. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdUni
Author: ibiryukov
Date: Wed Sep 20 05:58:55 2017
New Revision: 313754
URL: http://llvm.org/viewvc/llvm-project?rev=313754&view=rev
Log:
[clangd] Serialize onDiagnosticsReady callbacks for the same file.
Summary:
Calls to onDiagnosticsReady were done concurrently before. This sometimes
led to olde
Author: ibiryukov
Date: Wed Sep 20 08:09:14 2017
New Revision: 313759
URL: http://llvm.org/viewvc/llvm-project?rev=313759&view=rev
Log:
[clangd] Put inacessible items to the end of completion list.
Reviewers: bkramer, krasimir
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Differential
like the sanitizers are
> reporting anything suspicious. Do you by any chance know what went wrong?
> If it will turn out to be a macOS only thing it might make sense to XFAIL
> formatting.test until the issue is resolved.
>
> Thanks,
> Alex
>
> On 20 September 2017 at 13:58,
Author: ibiryukov
Date: Wed Sep 20 12:32:06 2017
New Revision: 313801
URL: http://llvm.org/viewvc/llvm-project?rev=313801&view=rev
Log:
[clangd] Fixed crash on MacOS.
Caused by invalid order of members in ClangdServer.
DiagnosticsMutex was used after destruction.
Modified:
clang-tools-extra/
be a macOS only thing it might make sense to XFAIL
>> formatting.test until the issue is resolved.
>>
>> Thanks,
>> Alex
>>
>> On 20 September 2017 at 13:58, Ilya Biryukov via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author
201 - 300 of 1434 matches
Mail list logo
