Author: ibiryukov
Date: Fri Feb 9 05:51:57 2018
New Revision: 324732
URL: http://llvm.org/viewvc/llvm-project?rev=324732&view=rev
Log:
[clangd] Fix crash when CompilerInvocation can't be created.
Summary:
This can happen if the CompileCommand provided by compilation database
is malformed.
Revie
Author: ibiryukov
Date: Fri Feb 9 07:11:07 2018
New Revision: 324736
URL: http://llvm.org/viewvc/llvm-project?rev=324736&view=rev
Log:
[clangd] Fix crash in tests in debug mode.
Caused by the lack of checking of an Expected value in the previous
commit.
Modified:
clang-tools-extra/trunk/uni
Author: ibiryukov
Date: Mon Feb 12 03:37:28 2018
New Revision: 324883
URL: http://llvm.org/viewvc/llvm-project?rev=324883&view=rev
Log:
[clangd] Remove codeComplete that returns std::future<>
Summary:
It was deprecated and callback version and is used everywhere.
Only changes to the testing code
Author: ibiryukov
Date: Mon Feb 12 04:48:51 2018
New Revision: 324888
URL: http://llvm.org/viewvc/llvm-project?rev=324888&view=rev
Log:
[clangd] Log all ignored diagnostics.
Summary:
To aid debugging failures and crashes.
Only part of ignored diagnostics was logged before, now we log all of
them.
Author: ibiryukov
Date: Tue Feb 13 09:08:13 2018
New Revision: 325021
URL: http://llvm.org/viewvc/llvm-project?rev=325021&view=rev
Log:
[clangd] Remove the RealFS layer from test VFS. NFC.
It was required before because preambles could only be created on
disk. All tests use in-memory preambles no
Author: ibiryukov
Date: Tue Feb 13 09:15:06 2018
New Revision: 325024
URL: http://llvm.org/viewvc/llvm-project?rev=325024&view=rev
Log:
[clangd] Log if CWD could not be changed. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-extra/trunk/clangd/CodeComplete.cpp
M
Author: ibiryukov
Date: Tue Feb 13 09:47:16 2018
New Revision: 325029
URL: http://llvm.org/viewvc/llvm-project?rev=325029&view=rev
Log:
[clangd] Fixed findDefinitions to always return absolute paths.
Relative paths could be returned in some cases, e.g. when relative
path is used in compilation ar
Personally, I'm not a big fan of environment variables. There are harder to
discover than command-line flags and I still have to change editor config
often to switch between different builds of clangd.
I know it may sound weird, but maybe we could have both the flag and the
environment variables? (
Author: ibiryukov
Date: Wed Feb 14 02:52:04 2018
New Revision: 325113
URL: http://llvm.org/viewvc/llvm-project?rev=325113&view=rev
Log:
[clangd] Explicitly initialize all primitive fields in Protocol.h
Summary:
Some of the existing structs had primimtive fields that were
not explicitly initialize
Author: ibiryukov
Date: Wed Feb 14 07:19:20 2018
New Revision: 325132
URL: http://llvm.org/viewvc/llvm-project?rev=325132&view=rev
Log:
[clangd] Fix data race in ClangdThreadingTest.StressTest
Prior to this patch, same instance of VFS was shared for concurrent
processing of the files in ClangdThr
On Thu, Feb 15, 2018 at 8:29 AM Sam McCall wrote:
> On Wed, Feb 14, 2018 at 10:45 AM Ilya Biryukov
> wrote:
>
>> Personally, I'm not a big fan of environment variables. There are harder
>> to discover than command-line flags and I still have to change editor
>> config often to switch between dif
Author: ibiryukov
Date: Thu Feb 15 05:15:47 2018
New Revision: 325233
URL: http://llvm.org/viewvc/llvm-project?rev=325233&view=rev
Log:
[clangd] Make functions of ClangdServer callback-based
Summary:
As a consequence, all LSP operations are now handled asynchronously,
i.e. they never block the ma
Author: ibiryukov
Date: Thu Feb 15 06:32:57 2018
New Revision: 325242
URL: http://llvm.org/viewvc/llvm-project?rev=325242&view=rev
Log:
[clangd] Enable snippet completion based on client capabilities.
Summary: And remove -enable-snippets flag.
Reviewers: hokein, ioeric, sammccall
Reviewed By: i
Author: ibiryukov
Date: Thu Feb 15 07:41:49 2018
New Revision: 325254
URL: http://llvm.org/viewvc/llvm-project?rev=325254&view=rev
Log:
[clangd] Fixed compilation with MVSC.
Modified:
clang-tools-extra/trunk/unittests/clangd/SyncAPI.cpp
Modified: clang-tools-extra/trunk/unittests/clangd/Sync
Sorry about that, fixed in r325254.
I keep hitting this MSVC compilation error all the time.
On Thu, Feb 15, 2018 at 4:26 PM Carlos Alberto Enciso via Phabricator <
revi...@reviews.llvm.org> wrote:
> CarlosAlbertoEnciso added a comment.
>
> Hi,
>
> It seems that your submission broke the Windows
Author: ibiryukov
Date: Thu Feb 15 08:24:34 2018
New Revision: 325260
URL: http://llvm.org/viewvc/llvm-project?rev=325260&view=rev
Log:
[clangd] Create trace::Span when running ASTCallback
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/Clangd
Author: ibiryukov
Date: Fri Feb 16 04:20:47 2018
New Revision: 325337
URL: http://llvm.org/viewvc/llvm-project?rev=325337&view=rev
Log:
[clangd] Assert path is absolute when assigning to URIForFile.
Summary:
The assertion will point directly to misbehaving code, so that
debugging related problems
Author: ibiryukov
Date: Mon Feb 19 03:15:33 2018
New Revision: 325486
URL: http://llvm.org/viewvc/llvm-project?rev=325486&view=rev
Log:
[clangd] Mark non-changing fields of CppFile as const. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.h
Modified: clang-tools-extra/trunk/clangd/Cl
Author: ibiryukov
Date: Mon Feb 19 04:35:33 2018
New Revision: 325490
URL: http://llvm.org/viewvc/llvm-project?rev=325490&view=rev
Log:
[CodeComplete] Add a helper to print CodeCompletionContext::Kind
Summary: Will be used in clangd. See D43377.
Reviewers: sammccall
Reviewed By: sammccall
Subs
Author: ibiryukov
Date: Mon Feb 19 04:35:57 2018
New Revision: 325491
URL: http://llvm.org/viewvc/llvm-project?rev=325491&view=rev
Log:
[clangd] Attach more information about Sema completion to traces
Reviewers: hokein, ioeric, sammccall
Reviewed By: sammccall
Subscribers: klimek, cfe-commits,
Author: ibiryukov
Date: Mon Feb 19 05:53:49 2018
New Revision: 325496
URL: http://llvm.org/viewvc/llvm-project?rev=325496&view=rev
Log:
[CodeComplete] Avoid name clashes of 'Kind' inside CodeCompletionContext. NFC
CodeCompletionContext had declarations of field and enum inside, both named
'Kind'
Author: ibiryukov
Date: Mon Feb 19 10:18:49 2018
New Revision: 325522
URL: http://llvm.org/viewvc/llvm-project?rev=325522&view=rev
Log:
[clangd] Do not reuse preamble if compile args changed
Reviewers: hokein, ioeric, sammccall, simark
Reviewed By: simark
Subscribers: klimek, jkorous-apple, cfe
Author: ibiryukov
Date: Mon Feb 26 04:06:05 2018
New Revision: 326083
URL: http://llvm.org/viewvc/llvm-project?rev=326083&view=rev
Log:
Explicitly initialize ForceEnableInt128 to avoid UB
This fixes an uninitialized value read found by msan.
Modified:
cfe/trunk/include/clang/Basic/TargetOpti
a testcase?
>
> On Tue, May 23, 2017 at 4:37 AM, Ilya Biryukov via cfe-commits
> wrote:
> > Author: ibiryukov
> > Date: Tue May 23 06:37:52 2017
> > New Revision: 303630
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=303630&view=rev
> > Lo
Author: ibiryukov
Date: Fri May 26 07:26:51 2017
New Revision: 303977
URL: http://llvm.org/viewvc/llvm-project?rev=303977&view=rev
Log:
[clangd] Allow to use vfs::FileSystem for file accesses.
Summary:
Custom vfs::FileSystem is currently used for unit tests.
This revision depends on https://revie
Author: ibiryukov
Date: Fri May 26 09:34:34 2017
New Revision: 303993
URL: http://llvm.org/viewvc/llvm-project?rev=303993&view=rev
Log:
[clangd] Attempt to fix tests failing on Windows
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
Modified: clang-tools-extra/trunk/unitte
Author: ibiryukov
Date: Tue May 30 10:11:02 2017
New Revision: 304214
URL: http://llvm.org/viewvc/llvm-project?rev=304214&view=rev
Log:
[clangd] Mark results of clangd requests with a tag provided by the
FileSystemProvider.
Summary:
This allows an implementation of FileSystemProvider that can tr
Author: ibiryukov
Date: Tue Jun 13 03:24:48 2017
New Revision: 305279
URL: http://llvm.org/viewvc/llvm-project?rev=305279&view=rev
Log:
[clangd] Use 'std::string' for VFSTag instead of 'int'
Reviewers: krasimir
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Tags: #clang-tools-extra
Di
Author: ibiryukov
Date: Tue Jun 13 03:32:27 2017
New Revision: 305280
URL: http://llvm.org/viewvc/llvm-project?rev=305280&view=rev
Log:
[clangd] Allow to override contents of the file during completion.
Reviewers: krasimir
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Differential Rev
Author: ibiryukov
Date: Tue Jun 13 05:01:11 2017
New Revision: 305283
URL: http://llvm.org/viewvc/llvm-project?rev=305283&view=rev
Log:
Revert "[clangd] Allow to override contents of the file during completion."
This caused buildbots failures, reverting until we'll find out what's
wrong.
Modifie
Author: ibiryukov
Date: Tue Jun 13 09:15:56 2017
New Revision: 305291
URL: http://llvm.org/viewvc/llvm-project?rev=305291&view=rev
Log:
[clangd] Allow to override contents of the file during completion.
Summary:
This is a reapplied r305280 with a fix to the crash found by build bots
(StringRef to
Author: ibiryukov
Date: Tue Jun 13 10:59:43 2017
New Revision: 305298
URL: http://llvm.org/viewvc/llvm-project?rev=305298&view=rev
Log:
[clangd] Store references instead of unique_ptrs in ClangdServer.
Summary:
ClangdServer owned objects passed to it in constructor for no good reason.
Lots of stu
Author: ibiryukov
Date: Tue Jun 13 11:02:27 2017
New Revision: 305299
URL: http://llvm.org/viewvc/llvm-project?rev=305299&view=rev
Log:
[clangd] A comment for ClangdServer's constructor. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.h
Modified: clang-tools-extra/trunk/clangd/Cla
Author: ibiryukov
Date: Wed Jun 14 04:46:44 2017
New Revision: 305376
URL: http://llvm.org/viewvc/llvm-project?rev=305376&view=rev
Log:
[clangd] Add a filename parameter to FileSystemProvider.
Reviewers: krasimir
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Tags: #clang-tools-extra
Author: ibiryukov
Date: Wed Jun 21 05:24:58 2017
New Revision: 305890
URL: http://llvm.org/viewvc/llvm-project?rev=305890&view=rev
Log:
Moved code hanlding precompiled preamble out of the ASTUnit.
Reviewers: bkramer, krasimir, arphaman, akyrtzi, klimek
Reviewed By: klimek
Subscribers: mgorny, k
Author: ibiryukov
Date: Wed Jun 21 07:34:27 2017
New Revision: 305902
URL: http://llvm.org/viewvc/llvm-project?rev=305902&view=rev
Log:
Fixed compiler warnings after r305890.
Should fix buildbots that pass -Werror.
Modified:
cfe/trunk/lib/Frontend/ASTUnit.cpp
Modified: cfe/trunk/lib/Fronten
Author: ibiryukov
Date: Thu Dec 14 05:00:33 2017
New Revision: 320696
URL: http://llvm.org/viewvc/llvm-project?rev=320696&view=rev
Log:
[Frontend] Treat function with skipped body as definition
Summary:
This fixes an invalid warning about missing definition of a function when
parsing with SkipFun
Author: ibiryukov
Date: Thu Dec 14 06:51:17 2017
New Revision: 320702
URL: http://llvm.org/viewvc/llvm-project?rev=320702&view=rev
Log:
Renamed test file to use proper naming convention
Also changed the order of CHECK statements.
CHEKC-NOT must come before CHECK in skipped-function-bodies.cpp
Ad
Author: ibiryukov
Date: Thu Dec 14 07:04:59 2017
New Revision: 320706
URL: http://llvm.org/viewvc/llvm-project?rev=320706&view=rev
Log:
[clangd] Implemented tracing using Context
Reviewers: sammccall, ioeric, hokein
Reviewed By: sammccall
Subscribers: klimek, luckygeck, cfe-commits
Differentia
Author: ibiryukov
Date: Thu Dec 14 07:33:38 2017
New Revision: 320708
URL: http://llvm.org/viewvc/llvm-project?rev=320708&view=rev
Log:
[clangd] Changed tracing interfaces
Summary:
EventTracer interface now contains two methods:
- spanEvent for events that have duration,
- instant for events that
Author: ibiryukov
Date: Fri Dec 15 03:27:51 2017
New Revision: 320804
URL: http://llvm.org/viewvc/llvm-project?rev=320804&view=rev
Log:
[clang] Add PPCallbacks list to preprocessor when building a preacompiled
preamble.
Summary:
Revision D38639 needs this commit in order to properly make open
de
ther int types.
>
> On Wed, Dec 13, 2017 at 7:43 AM Ilya Biryukov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ibiryukov
>> Date: Wed Dec 13 07:42:59 2017
>> New Revision: 320591
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=32
Author: ibiryukov
Date: Wed Dec 20 06:06:05 2017
New Revision: 321173
URL: http://llvm.org/viewvc/llvm-project?rev=321173&view=rev
Log:
[clangd] Made UniqueFunction's bool conversion explicit
Modified:
clang-tools-extra/trunk/clangd/Function.h
Modified: clang-tools-extra/trunk/clangd/Functio
Author: ibiryukov
Date: Wed Dec 20 06:32:38 2017
New Revision: 321174
URL: http://llvm.org/viewvc/llvm-project?rev=321174&view=rev
Log:
[Frontend] Handle skipped bodies in template instantiations
Summary:
- Fixed an assert in Sema::InstantiateFunctionDefinition and added
support for instantiati
Author: ibiryukov
Date: Wed Dec 20 08:48:56 2017
New Revision: 321189
URL: http://llvm.org/viewvc/llvm-project?rev=321189&view=rev
Log:
[clang] Add BeforeExecute method to PrecompiledPreamble
Summary: Adds BeforeExecute method to PrecompiledPreamble to be called
before Execute(). This method can
Author: ibiryukov
Date: Thu Dec 21 06:04:39 2017
New Revision: 321266
URL: http://llvm.org/viewvc/llvm-project?rev=321266&view=rev
Log:
Added helper to get size of PrecompiledPreamble
Modified:
cfe/trunk/include/clang/Frontend/PrecompiledPreamble.h
cfe/trunk/lib/Frontend/PrecompiledPreamb
Author: ibiryukov
Date: Thu Dec 21 06:05:28 2017
New Revision: 321267
URL: http://llvm.org/viewvc/llvm-project?rev=321267&view=rev
Log:
[clangd] Log more info about preambles
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp
URL:
Author: ibiryukov
Date: Thu Dec 28 05:05:46 2017
New Revision: 321520
URL: http://llvm.org/viewvc/llvm-project?rev=321520&view=rev
Log:
[Frontend] Correctly handle instantiating ctors with skipped bodies
Summary:
Previsouly clang tried instantiating member initializers even if ctor
body was skipp
Author: ibiryukov
Date: Thu Dec 28 05:10:15 2017
New Revision: 321521
URL: http://llvm.org/viewvc/llvm-project?rev=321521&view=rev
Log:
[clangd] Skip function bodies when building the preamble
Summary: To make building preambles faster and keep them smaller.
Reviewers: sammccall
Reviewed By: sa
Author: ibiryukov
Date: Fri Dec 29 06:59:22 2017
New Revision: 321554
URL: http://llvm.org/viewvc/llvm-project?rev=321554&view=rev
Log:
[clangd] Properly set filterText for index-based completion items
It was previously set to an identifier that the user typed, leading to
surprising behavior in V
Author: ibiryukov
Date: Fri Jan 5 05:36:55 2018
New Revision: 321867
URL: http://llvm.org/viewvc/llvm-project?rev=321867&view=rev
Log:
[clangd] Fix memory leak in code completion
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeComplete.
Author: ibiryukov
Date: Tue Jan 9 06:39:27 2018
New Revision: 322080
URL: http://llvm.org/viewvc/llvm-project?rev=322080&view=rev
Log:
[clangd] Fix a bug in asynchronous code completion
A StringRef that goes out of scope was copied and used in a handler
running on a separate thread.
We didn't ca
Author: ibiryukov
Date: Wed Jan 10 05:51:09 2018
New Revision: 322185
URL: http://llvm.org/viewvc/llvm-project?rev=322185&view=rev
Log:
[clangd] Remove duplicates from code completion
Summary:
This patch removes hidden items from code completion.
Items can be hidden, e.g., by other items in the c
Author: ibiryukov
Date: Wed Jan 10 09:59:27 2018
New Revision: 322199
URL: http://llvm.org/viewvc/llvm-project?rev=322199&view=rev
Log:
[clangd] Pass Context to onDiagnosticsReady callback
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: klimek, cfe-commits
Differential Revision: https
Author: ibiryukov
Date: Thu Mar 1 04:43:39 2018
New Revision: 326432
URL: http://llvm.org/viewvc/llvm-project?rev=326432&view=rev
Log:
Revert "[analyzer] Support for naive cross translation unit analysis"
Also revert "[analyzer] Fix a compiler warning"
This reverts commits r326323 and r326324.
I replied to a commit in the wrong thread (https://reviews.llvm.org/rL326323),
sorry.
Here are the important bits:
This change introduced the following cyclic dependency in the build system:
StaticAnalyzerCore -> CrossTU -> Frontend -> StaticAnalyzerCore.
I'm sorry, but I had to revert the commit
You're right. We have this extra dependency in our internal build files for
some reason and I missed that.
It's totally my fault.
Should I resubmit the patch that I reverted or you would rather do it
yourself?
On Thu, Mar 1, 2018 at 3:07 PM Gábor Horváth wrote:
>
>
> 2018. márc. 1. 14:58 ezt
Author: ibiryukov
Date: Thu Mar 1 06:54:16 2018
New Revision: 326439
URL: http://llvm.org/viewvc/llvm-project?rev=326439&view=rev
Log:
Resubmit [analyzer] Support for naive cross translation unit analysis
Originally submitted as r326323 and r326324.
Reverted in r326432.
Reverting the commit was
Resubmitted as r326439. Sorry for all the trouble.
We need to hack around the Analyses.def being required by Frontend, but it
would nice to remove this dependency upstream.
On Thu, Mar 1, 2018 at 3:34 PM Benjamin Kramer wrote:
> Frontend depends on StaticAnalyzerCore by
> including "clang/Stat
Author: ibiryukov
Date: Fri Mar 2 04:28:27 2018
New Revision: 326569
URL: http://llvm.org/viewvc/llvm-project?rev=326569&view=rev
Log:
[clang] Fix use-after-free on code completion
Summary:
Found by asan. Fiddling with code completion AST after
FrontendAction::Exceute can lead to errors.
Calling
Author: ibiryukov
Date: Fri Mar 2 10:23:41 2018
New Revision: 326598
URL: http://llvm.org/viewvc/llvm-project?rev=326598&view=rev
Log:
[clangd] Use higher timoout values in TUSchedulerTest::Debounce
Should unbreak windows buildbots.
Modified:
clang-tools-extra/trunk/unittests/clangd/TUSched
The TUSchedulerTest::Debounce breaks on Windows buildbots. Probably because
the timeouts of 50ms/10ms/40ms are too low to be scheduled properly.
Increased the timeouts in r326598 to 1s/200ms/2s, hopefully that would
unbreak the buildbots.
We could tweak them back to lower values that work on Monda
Author: ibiryukov
Date: Tue Mar 6 08:45:21 2018
New Revision: 326809
URL: http://llvm.org/viewvc/llvm-project?rev=326809&view=rev
Log:
[clangd] Don't end completion item labels with '::'
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
clang-tools-extra/trunk/test/clangd/protoco
Author: ibiryukov
Date: Fri Mar 9 06:43:29 2018
New Revision: 327134
URL: http://llvm.org/viewvc/llvm-project?rev=327134&view=rev
Log:
[SemaOverload] Fixed crash on code completion
Summary:
The relevant failing assertion message is:
../tools/clang/lib/Sema/SemaInit.cpp:8411: PerformCopyInitializ
Author: ibiryukov
Date: Mon Mar 12 08:28:22 2018
New Revision: 327282
URL: http://llvm.org/viewvc/llvm-project?rev=327282&view=rev
Log:
[clangd] Revamp handling of diagnostics.
Summary:
The new implementation attaches notes to diagnostic message and shows
the original diagnostics in the message o
Author: ibiryukov
Date: Wed Mar 14 06:18:30 2018
New Revision: 327504
URL: http://llvm.org/viewvc/llvm-project?rev=327504&view=rev
Log:
[Sema] Pop function scope when instantiating a func with skipped body
Summary:
By calling ActOnFinishFunctionBody(). Previously we were only calling
ActOnSkipped
Author: ibiryukov
Date: Wed Mar 14 10:08:41 2018
New Revision: 327532
URL: http://llvm.org/viewvc/llvm-project?rev=327532&view=rev
Log:
[clangd] Remove forceReparse, add a flag to addDocument instead
Summary: To make the removal of DraftMgr from ClangdServer easier (D44408).
Reviewers: sammccall
Author: ibiryukov
Date: Wed Mar 14 10:46:52 2018
New Revision: 327537
URL: http://llvm.org/viewvc/llvm-project?rev=327537&view=rev
Log:
[clangd] Don't expose vfs in TUScheduler::runWithPreamble.
Summary:
It was previously an easy way to concurrently access a mutable vfs,
which is a recipe for dis
Author: ibiryukov
Date: Wed Mar 14 10:49:19 2018
New Revision: 327539
URL: http://llvm.org/viewvc/llvm-project?rev=327539&view=rev
Log:
[clangd] Fix indentation in the comment. NFC
Modified:
clang-tools-extra/trunk/clangd/TUScheduler.h
Modified: clang-tools-extra/trunk/clangd/TUScheduler.h
U
Author: ibiryukov
Date: Fri Mar 16 08:23:44 2018
New Revision: 327717
URL: http://llvm.org/viewvc/llvm-project?rev=327717&view=rev
Log:
[clangd] Handle multiple callbacks from Sema's completion
Summary:
When parser backtracks, we might receive multiple code completion
callbacks.
Previously we had
Author: ibiryukov
Date: Mon Mar 19 07:20:25 2018
New Revision: 327852
URL: http://llvm.org/viewvc/llvm-project?rev=327852&view=rev
Log:
Updated a usage of createTemporaryFile that does not expect file to be created.
Summary:
This fixes a usage of createTemporaryFile in clang repo after
a change i
Author: ibiryukov
Date: Tue Mar 20 07:39:12 2018
New Revision: 327984
URL: http://llvm.org/viewvc/llvm-project?rev=327984&view=rev
Log:
Backport changes from llvm/.clang_tidy to clang/.clang_tidy configs
Summary: LLVM .clang_tidy seems to be more up-to-date.
Reviewers: alexfh, simark
Reviewed B
Author: ibiryukov
Date: Wed May 30 03:43:00 2018
New Revision: 333528
URL: http://llvm.org/viewvc/llvm-project?rev=333528&view=rev
Log:
[clangd] Enable parsing of non-doxygen comments in global-symbol-builder
Reviewers: ioeric, sammccall
Reviewed By: ioeric
Subscribers: klimek, MaskRay, jkorous
Author: ibiryukov
Date: Wed May 30 05:41:19 2018
New Revision: 333537
URL: http://llvm.org/viewvc/llvm-project?rev=333537&view=rev
Log:
[clangd] clang-format the source code. NFC
Modified:
clang-tools-extra/trunk/clangd/AST.h
clang-tools-extra/trunk/clangd/Quality.h
clang-tools-extra/
Author: ibiryukov
Date: Wed May 30 05:50:48 2018
New Revision: 333538
URL: http://llvm.org/viewvc/llvm-project?rev=333538&view=rev
Log:
[Sema] Don't skip function bodies with 'auto' without trailing return type
Summary:
Skipping them was clearly not intentional. It's impossible to
guarantee corre
Author: ibiryukov
Date: Wed May 30 07:21:31 2018
New Revision: 333548
URL: http://llvm.org/viewvc/llvm-project?rev=333548&view=rev
Log:
[clangd] Add forgotten include guard to TestFS.h. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/TestFS.h
Modified: clang-tools-extra/trunk/unittest
Author: ibiryukov
Date: Fri Jun 1 02:49:53 2018
New Revision: 333735
URL: http://llvm.org/viewvc/llvm-project?rev=333735&view=rev
Log:
[CodeComplete] Add a few extra tests for r333538. NFC
From a follow-up discussion in D44480.
New tests check that function bodies are not skipped:
- In presence
Author: ibiryukov
Date: Fri Jun 1 03:08:43 2018
New Revision: 333737
URL: http://llvm.org/viewvc/llvm-project?rev=333737&view=rev
Log:
[clangd] Keep only a limited number of idle ASTs in memory
Summary:
After this commit, clangd will only keep the last 3 accessed ASTs in
memory. Preambles for ea
Author: ibiryukov
Date: Fri Jun 1 05:03:16 2018
New Revision: 333742
URL: http://llvm.org/viewvc/llvm-project?rev=333742&view=rev
Log:
[clangd] Attempt the fix the buildbots after r333737
Modified:
clang-tools-extra/trunk/clangd/TUScheduler.cpp
Modified: clang-tools-extra/trunk/clangd/TUSch
This broke buildbots. Sorry about that.
r333742 should fix them.
On Fri, Jun 1, 2018 at 12:12 PM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Fri Jun 1 03:08:43 2018
> New Revision: 333737
>
> URL: http://llvm.org/viewvc/ll
Author: ibiryukov
Date: Fri Jun 1 07:44:57 2018
New Revision: 333758
URL: http://llvm.org/viewvc/llvm-project?rev=333758&view=rev
Log:
[clangd] Compute better estimates for memory usage of the AST
Also fix the return value of IdleASTs::getUsedBytes().
It was 'bool' instead of 'size_t' *facepalm*
Author: ibiryukov
Date: Mon Jun 4 07:50:59 2018
New Revision: 333906
URL: http://llvm.org/viewvc/llvm-project?rev=333906&view=rev
Log:
[clangd] Boost scores for decls from current file in completion
Summary: This should, arguably, give better ranking.
Reviewers: ioeric, sammccall
Reviewed By:
Author: ibiryukov
Date: Wed Jun 6 01:50:12 2018
New Revision: 334073
URL: http://llvm.org/viewvc/llvm-project?rev=334073&view=rev
Log:
Change test to output 'pcm' to the temp dir, not the source dir
Modified:
cfe/trunk/test/SemaCXX/anonymous-union-export.cpp
Modified: cfe/trunk/test/SemaCXX
Author: ibiryukov
Date: Tue Jun 12 04:56:21 2018
New Revision: 334495
URL: http://llvm.org/viewvc/llvm-project?rev=334495&view=rev
Log:
[clangd] Trace time the operations wait on Semaphore.
The Semaphore is currently used to limit the number of concurrently
running tasks. Tracing the wait times w
Author: ibiryukov
Date: Wed Jun 13 02:20:41 2018
New Revision: 334585
URL: http://llvm.org/viewvc/llvm-project?rev=334585&view=rev
Log:
[clangd] Move caching of compile args out of ClangdServer.
Summary:
Caching is now handled by ClangdLSPServer and hidden behind the
GlobalCompilationDatabase int
Author: ibiryukov
Date: Fri Jun 15 01:31:17 2018
New Revision: 334807
URL: http://llvm.org/viewvc/llvm-project?rev=334807&view=rev
Log:
[clangd] Do not report comments that only have special chars.
Summary:
Like the following:
// ---
// ===
// ***
It does not cover all the case
Author: ibiryukov
Date: Wed Oct 24 01:29:24 2018
New Revision: 345122
URL: http://llvm.org/viewvc/llvm-project?rev=345122&view=rev
Log:
[Sema] Do not show unused parameter warnings when body is skipped
Summary: Without the function body, we cannot determine is parameter was used.
Reviewers: ioer
Author: ibiryukov
Date: Wed Oct 24 02:00:30 2018
New Revision: 345125
URL: http://llvm.org/viewvc/llvm-project?rev=345125&view=rev
Log:
[clangd] Fix a link in documentation. NFC
Modified:
clang-tools-extra/trunk/docs/clangd.rst
Modified: clang-tools-extra/trunk/docs/clangd.rst
URL:
http://l
Author: ibiryukov
Date: Wed Oct 24 02:47:24 2018
New Revision: 345126
URL: http://llvm.org/viewvc/llvm-project?rev=345126&view=rev
Log:
[clangd] Remove outdated comment-out code. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.h
Modified: clang-tools-extra/trunk/clangd/ClangdLSP
Author: ibiryukov
Date: Wed Oct 24 03:09:34 2018
New Revision: 345128
URL: http://llvm.org/viewvc/llvm-project?rev=345128&view=rev
Log:
[clangd] Simplify auto hover
Summary:
Use helper from clang. Also fixes some weird corner cases, e.g.
auto (*foo)() = bar;
Reviewers: kadircet, hokein
Revi
Author: ibiryukov
Date: Wed Jan 16 05:18:59 2019
New Revision: 351334
URL: http://llvm.org/viewvc/llvm-project?rev=351334&view=rev
Log:
Set '-target' flag in the test checking the MacOS include dir
To fix a buildbot failure on PS4, see
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-
Author: ibiryukov
Date: Fri Jan 18 09:04:26 2019
New Revision: 351563
URL: http://llvm.org/viewvc/llvm-project?rev=351563&view=rev
Log:
[clangd] Make background index less chatty
Summary:
It is producing too much input in non-verbose mode,
i.e. a message per indexed file
Reviewers: sammccall, ka
Author: ibiryukov
Date: Wed Jan 23 02:35:12 2019
New Revision: 351941
URL: http://llvm.org/viewvc/llvm-project?rev=351941&view=rev
Log:
[clangd] Fix crash due to ObjCPropertyDecl
With ObjCPropertyDecl, ASTNode.OrigD can be a ObjCPropertyImplDecl
which is not a NamedDecl, leading to a crash since
Author: ibiryukov
Date: Wed Jan 23 03:32:07 2019
New Revision: 351943
URL: http://llvm.org/viewvc/llvm-project?rev=351943&view=rev
Log:
[clangd] Workaround a test failure after r351941
This should fix failing buildbots.
Modified:
clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.
Author: ibiryukov
Date: Thu Jan 24 02:41:43 2019
New Revision: 352040
URL: http://llvm.org/viewvc/llvm-project?rev=352040&view=rev
Log:
[CodeComplete] [clangd] Fix crash on ValueDecl with a null type
Reviewers: kadircet
Reviewed By: kadircet
Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-
Author: ibiryukov
Date: Thu Jan 24 02:41:43 2019
New Revision: 352040
URL: http://llvm.org/viewvc/llvm-project?rev=352040&view=rev
Log:
[CodeComplete] [clangd] Fix crash on ValueDecl with a null type
Reviewers: kadircet
Reviewed By: kadircet
Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-
+Hans Wennborg , could you please merge this fix into
the release branch?
On Thu, Jan 24, 2019 at 1:41 PM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Thu Jan 24 02:41:43 2019
> New Revision: 352040
>
> URL: http://llvm.or
bc++ headers in -internal-isystem
>>>>>> Release+Asserts/bin/include/c++/v1 , compared to -internal-isystem
>>>>>> Release+Asserts/include/c++/v1. `make install` puts the libc++ headers in
>>>>>> Release+Asserts/include, the ol
Author: ibiryukov
Date: Tue Jan 29 06:17:36 2019
New Revision: 352494
URL: http://llvm.org/viewvc/llvm-project?rev=352494&view=rev
Log:
[clangd] Interfaces for writing code tweaks
Summary:
The code tweaks are an implementation of mini-refactorings exposed
via the LSP code actions. They run in two
Author: ibiryukov
Date: Tue Jan 29 06:31:19 2019
New Revision: 352501
URL: http://llvm.org/viewvc/llvm-project?rev=352501&view=rev
Log:
[clangd] Unit test for sourceLocationInMainFile.
This should have been part of r352494, which added the corresponding
function. The unit test ended up as a separ
101 - 200 of 1465 matches
Mail list logo
