[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231234. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/Support/Comma

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231235. lh123 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CMake

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231242. lh123 marked an inline comment as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Suppor

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked 3 inline comments as done. lh123 added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:47 +class FileSystem; +IntrusiveRefCntPtr getRealFileSystem(); + kadircet wrote: > now that we are also pulling the the function, I think it i

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231349. lh123 marked 3 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Suppor

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231353. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/Support/Comma

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231357. lh123 marked 6 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tool

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231359. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CM

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231361. lh123 added a comment. Sorry, upload the wrong patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231362. lh123 added a comment. fix bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CMa

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231377. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/Support/Comma

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231381. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/Support/Comma

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231384. lh123 added a comment. fixes no matching constructor for initialization of `llvm::StringError`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/incl

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231390. lh123 marked 6 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Suppor

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231393. lh123 marked 5 inline comments as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tool

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231395. lh123 marked an inline comment as done. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Suppor

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8");

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked 3 inline comments as done. lh123 added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8");

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231510. lh123 marked an inline comment as done. lh123 added a comment. fix typo: "Could not convert UTF16 To UTF8" -> "Could not convert UTF16 to UTF8" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ htt

[PATCH] D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json

lh123 added a comment. In D70222#1763553 , @kadircet wrote: > Thanks a lot for working on this patch, LGTM! > > again please make sure the changes are clang-formatted. I'm sure the code has been formatted. > Do you have commit access? I don't have comm

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 created this revision. lh123 added reviewers: kadircet, sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. `vector::assign` will cause UB at here. fixes: https://github.com/clangd/clangd/issues/223 Repository: rG LLVM Githu

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 added a comment. @sammccall Could you commit this, I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 ___ cfe-commits mailing lis

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 updated this revision to Diff 232771. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 Files: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp Index: clang/lib/Tooling/ExpandResponseFiles

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 updated this revision to Diff 232770. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71172/new/ https://reviews.llvm.org/D71172 Files: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp I

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1271 OS << " = " << *P.Default; + if (P.Type && P.Type->AKA) +OS << llvm::formatv(" (aka {0})", *P.Type->AKA); sammccall wrote: > kadircet wrote: > > sammccall wrote: > > > Hmm,

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. sammccall wrote: > One question is wh

[PATCH] D115108: [clangd] Print type for VarTemplateDecl in hover.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51dc466642c5: [clangd] Print type for VarTemplateDecl in hover. (authored by lh123). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115108/new/ https://revie

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1271 OS << " = " << *P.Default; + if (P.Type && P.Type->AKA) +OS << llvm::formatv(" (aka {0})", *P.Type->AKA); lh123 wrote: > sammccall wrote: > > kadircet wrote: > > > sammccal

[PATCH] D114522: [clangd] Add desugared type to hover

This revision was automatically updated to reflect the committed changes. lh123 marked 2 inline comments as done. Closed by commit rGec64d10340da: [clangd] Add desugared type to hover (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114522?vs=391545&id=392640#toc Reposit

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

This revision was automatically updated to reflect the committed changes. lh123 marked 3 inline comments as done. Closed by commit rG6fe577b1c1e4: [clangd] Make a.k.a printing configurable. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114665?vs=391546&id=392648#toc R

[PATCH] D115107: [clang][clangd] Desugar array type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53219009aaeb: [clang][clangd] Desugar array type. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D115107?vs=391884&id=393110#toc Repository: rG LLVM Github Monorepo CHANGES S

<    1   2