[PATCH] D28050: [Clang][Driver] Clean up Clang::ConstructJob a little bit, NFC

2017-01-30 Thread Hongbin Zheng via Phabricator via cfe-commits
etherzhhb added a comment. In https://reviews.llvm.org/D28050#660715, @ahatanak wrote: > I think this patch is an improvement, but Clang::ConstructJob is still one > giant function. > > Do you have ideas to improve readability of this function or plans to further > reduce its size? I am tryin

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

2018-01-17 Thread Hongbin Zheng via Phabricator via cfe-commits
etherzhhb created this revision. etherzhhb added reviewers: aaron.ballman, echristo. Herald added a subscriber: cfe-commits. Simple change to use Use enum instead of magic number in handleX86ForceAlignArgPointerAttr. No functional change Repository: rC Clang https://reviews.llvm.org/D42227

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

2018-01-18 Thread Hongbin Zheng via Phabricator via cfe-commits
etherzhhb added a comment. Thanks, I will commit tonight. If you want this patch before that, you could commit it for me. Repository: rC Clang https://reviews.llvm.org/D42227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l