inouehrs added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1133
+ HadExtra) ||
+ HadExtra || Major != 10 || Minor >= 100 || Micro >= 100)
+return MacOSSDKVersion;
What these magic numbers mean (especially
inouehrs created this revision.
This patch enables `-fomit-frame-pointer` option by default for PowerPC if -O1
or above optimization level is specified.
GCC already enables this option by default for -O1 or above in all of ppc32,
ppc64 and ppc64le.
This option gives some performance improvements
inouehrs updated this revision to Diff 87821.
inouehrs added a comment.
Thank you for the comment.
I added regression tests for PPC in test/Driver/frame-pointer.c as for other
platforms.
https://reviews.llvm.org/D29750
Files:
lib/Driver/Tools.cpp
test/Driver/frame-pointer.c
Index: test/D
inouehrs added inline comments.
Comment at: test/CodeGen/builtins-ppc-error.c:23
+void testXXPERMDI(void) {
+ int index = 5;
+ vec_xxpermdi(vsi); //expected-error {{too few arguments to function call,
expected at least 3, have 1}}
I am not sure we can assure t
inouehrs added inline comments.
Comment at: test/CodeGen/builtins-ppc-error.c:23
+void testXXPERMDI(void) {
+ int index = 5;
+ vec_xxpermdi(vsi); //expected-error {{too few arguments to function call,
expected at least 3, have 1}}
jtony wrote:
> inouehrs wrote